GNU bug report logs - #78645
[PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.

Previous Next

To reply to this bug, email your comments to 78645 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.
Date: Fri, 30 May 2025 23:15:57 +0200

* gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.

[source]: Update URL.
[arguments] <#:phases> {makeinfo}: Remove install-file.

Change-Id: I6ce7709c5925bae4ebe4a5feefb6f138e62193df
---
 gnu/packages/emacs-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1006d5ee1d..197b3c83f6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -42119,7 +42119,7 @@ (define-public emacs-ivy-avy
 (define-public emacs-vertico
   (package
     (name "emacs-vertico")
-    (version "2.0")
+    (version "2.2")
     (source
      (origin
        (method git-fetch)
@@ -42128,7 +42128,7 @@ (define-public emacs-vertico
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0qgw0mhfrjylhyznjmjf7wqs5p3xvdv0lq19pql54plbnr6fspqk"))))
+        (base32 "15zf0kj12an9dmdi55ghpkxj053bqzm50fwlhpga4sjzx7qmv5q8"))))
     (build-system emacs-build-system)
     (arguments
      (list
@@ -42142,15 +42142,13 @@ (define-public emacs-vertico
                 (for-each (lambda (f)
                             (rename-file f (basename f)))
                           el-files))))
-          (add-after 'install 'makeinfo
+          (add-after 'move-source-files 'makeinfo
             (lambda _
               (invoke "emacs"
                       "--batch"
                       "--eval=(require 'ox-texinfo)"
                       "--eval=(find-file \"README.org\")"
-                      "--eval=(org-texinfo-export-to-info)")
-              (install-file "vertico.info"
-                            (string-append #$output "/share/info")))))))
+                      "--eval=(org-texinfo-export-to-info)"))))))
     (native-inputs
      (list texinfo))
     (propagated-inputs

base-commit: e3b189854c957c9aa2a68d903d268fcf984d7c23
--
2.49.0

Message #8 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>, 78645 <at> debbugs.gnu.org
Cc: Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Trevor Richards <trev <at> trevdev.ca>, Andrew Tropin <andrew <at> trop.in>,
 Hilton Chain <hako <at> ultrarare.space>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#78645] [PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.
Date: Wed, 04 Jun 2025 20:46:20 +0200

Am Freitag, dem 30.05.2025 um 23:15 +0200 schrieb Cayetano Santos:
> * gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
> 
Gratuituous blank line?
> [source]: Update URL.
This appears to be missing.
> [arguments] <#:phases> {makeinfo}: Remove install-file.
Why, though?

Either way, you can shorten that to [#:phases]<makeinfo> imho.

Cheers

Message #11 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: liliana.prikler <at> gmail.com
Cc: ian <at> retrospec.tv, 78645 <at> debbugs.gnu.org, cox.katherine.e+guix <at> gmail.com,
 trev <at> trevdev.ca, csantosb <at> inventati.org, andrew <at> trop.in, hako <at> ultrarare.space,
 divya <at> subvertising.org
Subject: Re: [bug#78645] [PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.
Date: Fri, 06 Jun 2025 10:41:28 +0200

[Message part 1 (text/plain, inline)]

> > * gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
> >
> Gratuituous blank line?

Removed in v2.

> > [source]: Update URL.
> This appears to be missing.

Removed in v2.

> > [arguments] <#:phases> {makeinfo}: Remove install-file.

> Why, though?

To my understanding, there is no need to, as the build-system takes care of.

> Either way, you can shorten that to [#:phases]<makeinfo> imho.

Let me know if this is mandatory of a personal preference, as I feel
like some will reply to v2 arguing that [arguments] are missing ...

C.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78645 <at> debbugs.gnu.org
Cc: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH emacs-team v2] gnu: emacs-vertico: Update to 2.2.
Date: Fri,  6 Jun 2025 10:42:42 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
[arguments]<#:phases>{makeinfo}: Remove install-file.

Change-Id: I6ce7709c5925bae4ebe4a5feefb6f138e62193df
---
 gnu/packages/emacs-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5f285d0761..1820429cf7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -42316,7 +42316,7 @@ (define-public emacs-ivy-avy
 (define-public emacs-vertico
   (package
     (name "emacs-vertico")
-    (version "2.0")
+    (version "2.2")
     (source
      (origin
        (method git-fetch)
@@ -42325,7 +42325,7 @@ (define-public emacs-vertico
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0qgw0mhfrjylhyznjmjf7wqs5p3xvdv0lq19pql54plbnr6fspqk"))))
+        (base32 "15zf0kj12an9dmdi55ghpkxj053bqzm50fwlhpga4sjzx7qmv5q8"))))
     (build-system emacs-build-system)
     (arguments
      (list
@@ -42339,15 +42339,13 @@ (define-public emacs-vertico
                 (for-each (lambda (f)
                             (rename-file f (basename f)))
                           el-files))))
-          (add-after 'install 'makeinfo
+          (add-after 'move-source-files 'makeinfo
             (lambda _
               (invoke "emacs"
                       "--batch"
                       "--eval=(require 'ox-texinfo)"
                       "--eval=(find-file \"README.org\")"
-                      "--eval=(org-texinfo-export-to-info)")
-              (install-file "vertico.info"
-                            (string-append #$output "/share/info")))))))
+                      "--eval=(org-texinfo-export-to-info)"))))))
     (native-inputs
      (list texinfo))
     (propagated-inputs

base-commit: 60e332adae600e230efb76e4027b764e3ae2c7dc
-- 
2.49.0

Message #17 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78645 <at> debbugs.gnu.org, ian <at> retrospec.tv, cox.katherine.e+guix <at> gmail.com,
 trev <at> trevdev.ca, andrew <at> trop.in, hako <at> ultrarare.space, divya <at> subvertising.org
Subject: Re: [bug#78645] [PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.
Date: Sat, 07 Jun 2025 00:10:28 +0200

Am Freitag, dem 06.06.2025 um 10:41 +0200 schrieb Cayetano Santos:
> > Either way, you can shorten that to [#:phases]<makeinfo> imho.
> 
> Let me know if this is mandatory of a personal preference, as I feel
> like some will reply to v2 arguing that [arguments] are missing ...
While this is a personal opinion and style – and ChangeLog style does
vary quite a bit in Guix commits, as it is not too strictly enforced –
there are a number of contributors with a similar style.  Both Ian Eure
and Hilton Chain are members of emacs-team, who can be shown by a quick
'git log --grep' to use '[#:phases]'.

The idea behind this is that four levels of nesting is already the
maximum with the brackets we have and for keyword arguments it's clear
that those belong to arguments.  Particularly, when no other argument
is changed, it doesn't make much sense to spell out <arguments>.

Cheers

Message #20 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78645 <at> debbugs.gnu.org
Cc: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Subject: [PATCH emacs-team v3] gnu: emacs-vertico: Update to 2.2.
Date: Mon,  9 Jun 2025 11:58:13 +0200

From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-vertico): Update to 2.2.
<#:phases>{makeinfo}: Remove install-file.

Change-Id: I6ce7709c5925bae4ebe4a5feefb6f138e62193df
---
 gnu/packages/emacs-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cc23eaa4bc..fca2871a81 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -42316,7 +42316,7 @@ (define-public emacs-ivy-avy
 (define-public emacs-vertico
   (package
     (name "emacs-vertico")
-    (version "2.0")
+    (version "2.2")
     (source
      (origin
        (method git-fetch)
@@ -42325,7 +42325,7 @@ (define-public emacs-vertico
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0qgw0mhfrjylhyznjmjf7wqs5p3xvdv0lq19pql54plbnr6fspqk"))))
+        (base32 "15zf0kj12an9dmdi55ghpkxj053bqzm50fwlhpga4sjzx7qmv5q8"))))
     (build-system emacs-build-system)
     (arguments
      (list
@@ -42339,15 +42339,13 @@ (define-public emacs-vertico
                 (for-each (lambda (f)
                             (rename-file f (basename f)))
                           el-files))))
-          (add-after 'install 'makeinfo
+          (add-after 'move-source-files 'makeinfo
             (lambda _
               (invoke "emacs"
                       "--batch"
                       "--eval=(require 'ox-texinfo)"
                       "--eval=(find-file \"README.org\")"
-                      "--eval=(org-texinfo-export-to-info)")
-              (install-file "vertico.info"
-                            (string-append #$output "/share/info")))))))
+                      "--eval=(org-texinfo-export-to-info)"))))))
     (native-inputs
      (list texinfo))
     (propagated-inputs

base-commit: 03ce76718c41b32d174713c945d269d6fcdd8bf1
-- 
2.49.0

Message #23 received at 78645 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: liliana.prikler <at> gmail.com
Cc: ian <at> retrospec.tv, 78645 <at> debbugs.gnu.org, cox.katherine.e+guix <at> gmail.com,
 trev <at> trevdev.ca, csantosb <at> inventati.org, andrew <at> trop.in, hako <at> ultrarare.space,
 divya <at> subvertising.org
Subject: Re: [bug#78645] [PATCH emacs-team] gnu: emacs-vertico: Update to 2.2.
Date: Mon, 09 Jun 2025 12:05:41 +0200

[Message part 1 (text/plain, inline)]

> The idea behind this is that four levels of nesting is already the
> maximum with the brackets we have and for keyword arguments it's clear
> that those belong to arguments.  Particularly, when no other argument
> is changed, it doesn't make much sense to spell out <arguments>.

Thanks for the explanation, fixed in v3.

Let me just point out that, as a random contributor and for light
changes, changelogs appear way more sophisticated that changes
themselves, specially when they seem kind of redundant with the changes.

Anyway, I’ll do my best to comply with the above in following patches.

C.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.