GNU bug report logs - #78630
31.0.50; feature/igc: Redundant tracing in fix_window

Previous Next

Package: emacs;

Reported by: Helmut Eller <eller.helmut <at> gmail.com>

Date: Thu, 29 May 2025 16:44:01 UTC

Severity: normal

Found in version 31.0.50

To reply to this bug, email your comments to 78630 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#78630; Package emacs. (Thu, 29 May 2025 16:44:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Helmut Eller <eller.helmut <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 29 May 2025 16:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Helmut Eller <eller.helmut <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; feature/igc: Redundant tracing in fix_window
Date: Thu, 29 May 2025 18:42:51 +0200

In the fix_window function:

  static mps_res_t
  fix_window (mps_ss_t ss, struct window *w)
  {
    MPS_SCAN_BEGIN (ss)
    {
      IGC_FIX_CALL_FN (ss, struct Lisp_Vector, w, fix_vectorlike);
      if (w->current_matrix && !w->current_matrix->pool)
        IGC_FIX_CALL (ss, fix_glyph_matrix (ss, w->current_matrix));
      if (w->desired_matrix && !w->desired_matrix->pool)
        IGC_FIX_CALL (ss, fix_glyph_matrix (ss, w->desired_matrix));
      IGC_FIX12_OBJ (ss, &w->prev_buffers);
      IGC_FIX12_OBJ (ss, &w->next_buffers);
    }
    MPS_SCAN_END (ss);
    return MPS_RES_OK;
  }

tracing next_buffers/prev_buffers seems unnecessary as those two fields
should already be covered by fix_vectorlike.
This bug report was last modified 19 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.