GNU bug report logs - #78619
[PATCH] Add additional keybindings for flymake diagnostics modes

Previous Next

To reply to this bug, email your comments to 78619 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jake <jforst.mailman <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Spencer Baugh <sbaugh <at> janestreet.com>,
 Matthew Tromp <matthewktromp <at> gmail.com>
Subject: [PATCH] Add additional keybindings for flymake diagnostics modes
Date: Wed, 28 May 2025 11:20:34 +0000

[Message part 1 (text/plain, inline)]

Flymake diagnostic buffers have `next-error` support, but their
keymaps do not make use of it.  The attached patch by Matthew Tromp
makes `flymake-diagnostics-buffer-mode-map` and
`flymake-project-diagnostics-mode-map` more consistent with the other
`next-error` buffer keymaps, like those from occur, grep, and compile.

As discussed on emacs-devel:
https://mail.gnu.org/archive/html/emacs-devel/2025-05/msg00370.html

[0001-Add-additional-keybindings-for-flymake-diagnostics-m.patch (text/x-patch, attachment)]

Message #10 received at 78619-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jake <jforst.mailman <at> gmail.com>
Cc: 78619-done <at> debbugs.gnu.org, sbaugh <at> janestreet.com, matthewktromp <at> gmail.com
Subject: Re: bug#78619: [PATCH] Add additional keybindings for flymake
 diagnostics modes
Date: Sat, 31 May 2025 17:28:15 +0300

> Cc: Spencer Baugh <sbaugh <at> janestreet.com>,
>  Matthew Tromp <matthewktromp <at> gmail.com>
> From: Jake <jforst.mailman <at> gmail.com>
> Date: Wed, 28 May 2025 11:20:34 +0000
> 
> Flymake diagnostic buffers have `next-error` support, but their
> keymaps do not make use of it.  The attached patch by Matthew Tromp
> makes `flymake-diagnostics-buffer-mode-map` and
> `flymake-project-diagnostics-mode-map` more consistent with the other
> `next-error` buffer keymaps, like those from occur, grep, and compile.
> 
> As discussed on emacs-devel:
> https://mail.gnu.org/archive/html/emacs-devel/2025-05/msg00370.html

Thanks, installed on the master branch, and closing the bug.

Note that this exhausts the amount of contributed code we can accept
from Matthew Tromp without a copyright assignment.  If agree, I can
send the form to fill and the instructions, to start the assignment
paperwork.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.