From debbugs-submit-bounces@debbugs.gnu.org Wed May 28 07:03:19 2025 Received: (at submit) by debbugs.gnu.org; 28 May 2025 11:03:20 +0000 Received: from localhost ([127.0.0.1]:51357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKEZ5-0006Yv-A0 for submit@debbugs.gnu.org; Wed, 28 May 2025 07:03:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37376) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKEZ2-0006Ye-Cx for submit@debbugs.gnu.org; Wed, 28 May 2025 07:03:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKEYr-0002Rm-Gk for bug-gzip@gnu.org; Wed, 28 May 2025 07:03:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKEYo-0000Lc-UM for bug-gzip@gnu.org; Wed, 28 May 2025 07:03:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748430181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=tYgEf6SDMTYwWIM1qpx2cKpdenA2jh8D6oRYoJQ6Jw0=; b=hCpdjTwMyrSZmMe1a9tRuxcj+38UsV3l31pA45nLzDqHlpOUIj+xPiaVM7tWSp7HBdQnmS N+5deGYW9Nam6L4jHeOXY0aX/j8pju1v3oBHefElbnHKDNkD+WNXQp3pbUfi0EcrDvQP4m NPG4RJJIdsbrwQcSN1NbQbvex4ylmxg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-7MGgL4oROWS82_qqi4z6tA-1; Wed, 28 May 2025 07:01:40 -0400 X-MC-Unique: 7MGgL4oROWS82_qqi4z6tA-1 X-Mimecast-MFC-AGG-ID: 7MGgL4oROWS82_qqi4z6tA_1748430099 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-acb23361d73so81671866b.0 for ; Wed, 28 May 2025 04:01:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748430099; x=1749034899; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tYgEf6SDMTYwWIM1qpx2cKpdenA2jh8D6oRYoJQ6Jw0=; b=V+0tTt28wJJxL5wQQmkthsQpbBakxSoTcR6JrItiZxjXdWXTEi0XLszsYqrinTyGn0 djv6A7RpLW35QhHWGA9PnAZRUS8khwCR/aOXtKP5nArJgjZoO7zvkYdq62hIqyREiyWB cJ+hbW4Is/IEhiYt8gjuH9bisKc3JMNzdu+DMxtAonwq6iXeC3UZCVotIioMXQuNCQHR sOnYCUeQ+NzIep6bbyiw45WFyc1FLaWfgueIzptnFtRBij+vCJXmjT7cHSslJkrgGgGj mQhS5pnu3+uJUaE1SCxrJwsr66vMfmskNgg5VICEQ+aW/FQZ6S3BWJPMVL0qjfkZqbeG J3Yg== X-Gm-Message-State: AOJu0YzssK3f6XhjyaI/sZTX7ZkkE/HSt5cWle8KzAaJvmzMTkV7L+f7 nhUbI5amZaL0p9DA1gwOmDHq9w40wxYdPSZv+5WhDbE82lC+7jD8OCnvMCZJiXZ9omPXXZtip+O im4KkkQv8GrmXr+EduZ+7JlrD+AxpFGSI07UNTKCRuBy+BitIh1WLIbAEKyqKijqvHM7a/2hLT4 DDoJNrbtDMu9JbJHt0mlwB97wzRWav03fOuuY= X-Gm-Gg: ASbGncvmRz6j/yZ1XnAOKI3YZuEMnMLfeekTCl59o+QAH+mFCKPANmUm/39Ibs/VzvN SdBzzy2ThPkfzKEKbd+ozRlhgs6BskwZexqzEphd63g/2x85bQtUVjxaGOPiUF3ezI4ZuO7aph+ zvBY/VCBvBU8RwE1EeorS8FoaVYSA= X-Received: by 2002:a17:907:d93:b0:ad8:8b49:57d4 with SMTP id a640c23a62f3a-ad898a1a357mr422528966b.28.1748430098848; Wed, 28 May 2025 04:01:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbH5VGcDGds7VU5E+0agmFvMZKY9FljgMHOHJCafRIl9nKjfMns5cUkB7lrslCs/qh6BukUGir+y1DQi+jodc= X-Received: by 2002:a17:907:d93:b0:ad8:8b49:57d4 with SMTP id a640c23a62f3a-ad898a1a357mr422524566b.28.1748430098419; Wed, 28 May 2025 04:01:38 -0700 (PDT) MIME-Version: 1.0 From: Jakub Martisko Date: Wed, 28 May 2025 13:01:25 +0200 X-Gm-Features: AX0GCFuEAzLZqLWyE3-jugKaeyD0NNOL-85i6CcrGkABOYAHW_8U8isoXukWofU Message-ID: Subject: Gzip 1.14 build failure on s390x (undeclared errno in dfltcc.c) To: bug-gzip@gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J-C_wA71RLCpSpQS4yfAIZPZBhptK0Dj2br6-nvODGQ_1748430099 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ee679d0636301aff" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jamartis@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.907, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --000000000000ee679d0636301aff Content-Type: text/plain; charset="UTF-8" Hello, while rebasing the gzip in fedora I've encountered the build failure from the $SUBJ. A bit more info: - happens only when configured with the --enable-dfltcc - introduced by the [1] (the "errno" variable doesn't seem to be used outside of the scope of the patch) - build completes when the "--enable-dfltcc" is not used or when the [1] is reversed - The actual error (I can provide patch if needed): dfltcc.c:441:15: error: 'errno' undeclared (first use in this function) 441 | errno = 0; | ^~~~~ dfltcc.c:28:1: note: 'errno' is defined in header ''; this is probably fixable by adding '#include ' 27 | #include "gzip.h" +++ |+#include 28 | dfltcc.c:441:15: note: each undeclared identifier is reported only once for each function it appears in 441 | errno = 0; | ^~~~~ make[2]: *** [Makefile:2050: dfltcc.o] Error 1 [1]: https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?h=v1.14&id=23ddd95f3e152423fe0dfc96ff31d4130a65e8cf --000000000000ee679d0636301aff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

while rebasing the gz= ip in fedora I've encountered the build failure from the $SUBJ.
A bit more info:
- happens only when configured with the --ena= ble-dfltcc
- introduced=C2=A0 by the [1] (the "errno" v= ariable doesn't seem to be used outside of the scope of the patch)
- build completes when the "--enable-dfltcc" is not used or= when the [1] is reversed
- The actual error (I can provide patch= if needed):
dfltcc.c:441:15: error: 'errno' undecla=
red (first use in this function)
  441 |               errno =3D 0;
      |               ^~~~~
dfltcc.c:28:1: note: 'errno' is defined in header '<errno.h&=
gt;'; this is probably fixable by adding '#include <errno.h>&=
#39;
   27 | #include "gzip.h"
  +++ |+#include <errno.h>
   28 |=20
dfltcc.c:441:15: note: each undeclared identifier is reported only once for=
 each function it appears in
  441 |               errno =3D 0;
      |               ^~~~~
make[2]: *** [Makefile:2050: dfltcc.o] Error 1

--000000000000ee679d0636301aff-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 30 15:33:10 2025 Received: (at 78618-done) by debbugs.gnu.org; 30 May 2025 19:33:10 +0000 Received: from localhost ([127.0.0.1]:50886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uL5TW-0006Va-00 for submit@debbugs.gnu.org; Fri, 30 May 2025 15:33:10 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:48936) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uL5TS-0006Ur-U6 for 78618-done@debbugs.gnu.org; Fri, 30 May 2025 15:33:03 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 531653C0149D7; Fri, 30 May 2025 12:32:57 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id M_aiX3xJkHGw; Fri, 30 May 2025 12:32:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 2B7C13C0149E2; Fri, 30 May 2025 12:32:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 2B7C13C0149E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1748633577; bh=jmdsv/3/yIqEaa8WVS6xTHIpgddsmu8BytYZdRGtuDU=; h=Message-ID:Date:MIME-Version:To:From; b=JL/MCRB3kbAJEN8bF+o1grJ6fmX8EsYIlf13gS3QQm4c4QXN9mHAgWDiFP87AsUoh GewQxeHeajH28o2Az0+KEllG4eGIXvRj93KUUUyaGrXxKbmi7LET9dhrcDyC9USv+9 f2+dHGDBuaHUKl9tSu0UehGOTyz0qVpQ99S1+hR2Z2XRj47fwf0dV9tIDZYzEm3cz9 6T3ZL+8VeZJxgj1utTjKTeYKu9MPbm7Nz8xhM9+zlCttlUVxpTWefLUd6j2YUXJWDO w7cAO0cX9zUpzGsjLnUxMjaugcoYh4dT5wV0pQaq+Do3NUl24baq6Ls3Yq/OxILpAV Z//h2uWfLQ3kw== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id cwg1720MM746; Fri, 30 May 2025 12:32:57 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-143-215-226.fdr01.snmn.ca.ip.frontiernet.net [47.143.215.226]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 0D3DD3C0149D7; Fri, 30 May 2025 12:32:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------pU0ZW00nNebVjEOMcWPABAKX" Message-ID: Date: Fri, 30 May 2025 12:32:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#78618: Gzip 1.14 build failure on s390x (undeclared errno in dfltcc.c) To: Jakub Martisko References: Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78618-done Cc: 78618-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------pU0ZW00nNebVjEOMcWPABAKX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached slightly-different patch (different because it includes errno.h in same order as other files). --------------pU0ZW00nNebVjEOMcWPABAKX Content-Type: text/x-patch; charset=UTF-8; name="0001-gzip-fix-s390x-build-failure.patch" Content-Disposition: attachment; filename="0001-gzip-fix-s390x-build-failure.patch" Content-Transfer-Encoding: base64 RnJvbSBjNzZhZmZiNDU1MTYzMGZmNjYxYWMxYzFlZTk5MzUzYTE3ZWIxNmUxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDMwIE1heSAyMDI1IDEyOjMxOjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZ3ppcDogZml4IHMzOTB4IGJ1aWxkIGZhaWx1cmUKClByb2JsZW0gcmVwb3J0ZWQgYnkg SmFrdWIgTWFydGlza28gPGh0dHBzOi8vYnVncy5nbnUub3JnLzc4NjE4Pi4KKiBkZmx0Y2Mu YzogSW5jbHVkZSBlcnJuby5oLgotLS0KIGRmbHRjYy5jIHwgMSArCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9kZmx0Y2MuYyBiL2RmbHRjYy5jCmlu ZGV4IDlmODY1ODEuLjgzMDdhOTcgMTAwNjQ0Ci0tLSBhL2RmbHRjYy5jCisrKyBiL2RmbHRj Yy5jCkBAIC0xNyw2ICsxNyw3IEBACiAKICNpbmNsdWRlIDxjb25maWcuaD4KIAorI2luY2x1 ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAKICNpZmRlZiBIQVZFX1NZU19T RFRfSAotLSAKMi40OC4xCgo= --------------pU0ZW00nNebVjEOMcWPABAKX--