GNU bug report logs - #78601
[PATCH] Add tool-bar icons to package-menu-mode

Previous Next

To reply to this bug, email your comments to 78601 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add tool-bar icons to package-menu-mode
Date: Mon, 26 May 2025 21:01:34 -0600

Tags: patch


This add some new icons (made by myself) to the tool-bar for
`package-menu-mode'.
-- 
                                          - E.G via GNU Emacs and Org.

Message #8 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: 78601 <at> debbugs.gnu.org
Subject: [PATCH] Add tool-bar icons to package-menu-mode
Date: Mon, 26 May 2025 21:04:25 -0600

[0001-Add-tool-bar-icons-to-package-menu-mode-bug-78601.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #11 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 Philip Kaludercic <philipk <at> posteo.net>
Cc: 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sat, 31 May 2025 14:35:36 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Date: Mon, 26 May 2025 21:04:25 -0600

Thanks.

Would people please try this and report whether they like these new
icons?

Message #14 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: eg642616 <at> gmail.com, philipk <at> posteo.net
Cc: 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sat, 07 Jun 2025 12:00:14 +0300

Ping!  Would someone please try these icons and report?  I feel
uncomfortable installing new icons without some feedback from others.

> Cc: 78601 <at> debbugs.gnu.org
> Date: Sat, 31 May 2025 14:35:36 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> > Date: Mon, 26 May 2025 21:04:25 -0600
> 
> Thanks.
> 
> Would people please try this and report whether they like these new
> icons?
> 
> 
> 
> 

Message #17 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sat, 07 Jun 2025 21:52:52 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Ping!  Would someone please try these icons and report?  I feel
> uncomfortable installing new icons without some feedback from others.

I don't know what I should report back on, seeing as I don't use the
tool-bar myself, but I have added a screenshot in case it might help
anyone else evaluate the change.

[Screenshot From 2025-06-07 23-30-17.png (image/png, attachment)]

[Message part 3 (text/plain, inline)]

The only comment I can make on the UX is that I find it surprising that
the icons disappear in the *Help* buffer describing the package, but I
get that adding them in the right place and the right time is tricky...
It is just that the idea of invoking `package-browse-url' by selecting
the right line in the package-list buffer (without opening the *Help*
buffer), and then selecting the button in the tool-bar is not an
interaction that seems intuitive to me.

>> Cc: 78601 <at> debbugs.gnu.org
>> Date: Sat, 31 May 2025 14:35:36 +0300
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> 
>> > From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
>> > Date: Mon, 26 May 2025 21:04:25 -0600
>> 
>> Thanks.
>> 
>> Would people please try this and report whether they like these new
>> icons?
>> 
>> 
>> 
>> 

Message #20 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sat, 07 Jun 2025 20:36:09 -0600

Philip Kaludercic <philipk <at> posteo.net> writes:

> The only comment I can make on the UX is that I find it surprising that
> the icons disappear in the *Help* buffer describing the package

That is because the icons are meant to be used in `package-menu-mode`,
not in `help-mode` (like `package-menu-mode` menu-bar).

> It is just that the idea of invoking `package-browse-url' by selecting
> the right line in the package-list buffer (without opening the *Help*
> buffer), and then selecting the button in the tool-bar is not an
> interaction that seems intuitive to me.

But `package-menu-mode` menu-bar does the same, I don't see the
difference, in my experience, i find it better than first opening the
*Help* buffer and later selecting the package website.

-- 
                                          - E.G via GNU Emacs and Org.

Message #23 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 07:40:14 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
> Date: Sat, 07 Jun 2025 21:52:52 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Ping!  Would someone please try these icons and report?  I feel
> > uncomfortable installing new icons without some feedback from others.
> 
> I don't know what I should report back on

Whether the icons are visually appealing, I guess?

> seeing as I don't use the tool-bar myself, but I have added a
> screenshot in case it might help anyone else evaluate the change.

Thanks, I hope more people will provide their opinions.

Message #26 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Kristoffer Balintona <krisbalintona <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sat, 7 Jun 2025 22:20:02 -0700

On Sun, Jun 08 2025, Eli Zaretskii wrote:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
>> Date: Sat, 07 Jun 2025 21:52:52 +0000
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> > Ping!  Would someone please try these icons and report?  I feel
>> > uncomfortable installing new icons without some feedback from others.
>>
>> I don't know what I should report back on
>
> Whether the icons are visually appealing, I guess?
>
>> seeing as I don't use the tool-bar myself, but I have added a
>> screenshot in case it might help anyone else evaluate the change.
>
> Thanks, I hope more people will provide their opinions.

FWIW I think the icons look great and I don’t have a problem with them.
But I also rarely have strong preferences when it comes to these
matters.

-- 
Kind regards,
Kristoffer

Message #29 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 07:13:19 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
>> Date: Sat, 07 Jun 2025 21:52:52 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Ping!  Would someone please try these icons and report?  I feel
>> > uncomfortable installing new icons without some feedback from others.
>> 
>> I don't know what I should report back on
>
> Whether the icons are visually appealing, I guess?

I wouldn't object, because I do not use them, but if I couldn't disable
the tool-bar, I would (with apologies) not find them that appealing,
because a visual priority of mine is stylistic consistency, and these
icons wouldn't fit into the remaining design language GUI on my system(s).

>> seeing as I don't use the tool-bar myself, but I have added a
>> screenshot in case it might help anyone else evaluate the change.
>
> Thanks, I hope more people will provide their opinions.

FWIW I don't think there is any harm in adding the icons anyway.
Disregarding visual appeal, I think a slightly less subjective question
is would it help attract the attention of new users to useful operations
when they are dealing with packages, and I think that the answer here is
affirmative.

Message #32 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 07:42:18 +0000

Elijah Gabe Pérez <eg642616 <at> gmail.com> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> The only comment I can make on the UX is that I find it surprising that
>> the icons disappear in the *Help* buffer describing the package
>
> That is because the icons are meant to be used in `package-menu-mode`,
> not in `help-mode` (like `package-menu-mode` menu-bar).

I understand that, it is just that when I click on a package "link" and
the description gets opened up in a *Help* buffer, I would intuitively
expect the same operations to be retained, just instead of acting on the
package on the current line, they would act on the package in the
current buffer.

>> It is just that the idea of invoking `package-browse-url' by selecting
>> the right line in the package-list buffer (without opening the *Help*
>> buffer), and then selecting the button in the tool-bar is not an
>> interaction that seems intuitive to me.
>
> But `package-menu-mode` menu-bar does the same, I don't see the
> difference, in my experience, i find it better than first opening the
> *Help* buffer and later selecting the package website.

That is fair, I know that my take above is a personal preference, my
point was just to contextualise why the above behaviour confused me.

Message #35 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 11:10:15 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
> Date: Sun, 08 Jun 2025 07:13:19 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Philip Kaludercic <philipk <at> posteo.net>
> >> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
> >> Date: Sat, 07 Jun 2025 21:52:52 +0000
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> > Ping!  Would someone please try these icons and report?  I feel
> >> > uncomfortable installing new icons without some feedback from others.
> >> 
> >> I don't know what I should report back on
> >
> > Whether the icons are visually appealing, I guess?
> 
> I wouldn't object, because I do not use them, but if I couldn't disable
> the tool-bar, I would (with apologies) not find them that appealing,
> because a visual priority of mine is stylistic consistency, and these
> icons wouldn't fit into the remaining design language GUI on my system(s).

Can you elaborate on how these icons are inconsistent with the other
GUI on your system?  Which aspects are inconsistent.

> FWIW I don't think there is any harm in adding the icons anyway.
> Disregarding visual appeal, I think a slightly less subjective question
> is would it help attract the attention of new users to useful operations
> when they are dealing with packages, and I think that the answer here is
> affirmative.

I'd like to avoid the situation where adding the icons will cause a
flood of complaints about their appearance.

Message #38 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kristoffer Balintona <krisbalintona <at> gmail.com>
Cc: philipk <at> posteo.net, eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 11:23:13 +0300

> From: Kristoffer Balintona <krisbalintona <at> gmail.com>
> Date: Sat, 7 Jun 2025 22:20:02 -0700
> Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
> 
> On Sun, Jun 08 2025, Eli Zaretskii wrote:
> 
> >> From: Philip Kaludercic <philipk <at> posteo.net>
> >> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
> >> Date: Sat, 07 Jun 2025 21:52:52 +0000
> >>
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >>
> >> > Ping!  Would someone please try these icons and report?  I feel
> >> > uncomfortable installing new icons without some feedback from others.
> >>
> >> I don't know what I should report back on
> >
> > Whether the icons are visually appealing, I guess?
> >
> >> seeing as I don't use the tool-bar myself, but I have added a
> >> screenshot in case it might help anyone else evaluate the change.
> >
> > Thanks, I hope more people will provide their opinions.
> 
> FWIW I think the icons look great and I don’t have a problem with them.
> But I also rarely have strong preferences when it comes to these
> matters.

Thanks for the feedback.

Message #41 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 09:09:05 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
>> Date: Sun, 08 Jun 2025 07:13:19 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: Philip Kaludercic <philipk <at> posteo.net>
>> >> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
>> >> Date: Sat, 07 Jun 2025 21:52:52 +0000
>> >> 
>> >> Eli Zaretskii <eliz <at> gnu.org> writes:
>> >> 
>> >> > Ping!  Would someone please try these icons and report?  I feel
>> >> > uncomfortable installing new icons without some feedback from others.
>> >> 
>> >> I don't know what I should report back on
>> >
>> > Whether the icons are visually appealing, I guess?
>> 
>> I wouldn't object, because I do not use them, but if I couldn't disable
>> the tool-bar, I would (with apologies) not find them that appealing,
>> because a visual priority of mine is stylistic consistency, and these
>> icons wouldn't fit into the remaining design language GUI on my system(s).
>
> Can you elaborate on how these icons are inconsistent with the other
> GUI on your system?  Which aspects are inconsistent.

Just the design of the icons.  I use GNOME, and compare the previous
screenshot to this one of the file manager:

[Screenshot From 2025-06-08 10-51-24.png (image/png, attachment)]

[Message part 3 (text/plain, inline)]

As we are not using icons provided by the icon theme of the desktop
environment, which in my case should be
https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
mismatch that some people might find irritating, but that is nothing new
with Emacs.

>> FWIW I don't think there is any harm in adding the icons anyway.
>> Disregarding visual appeal, I think a slightly less subjective question
>> is would it help attract the attention of new users to useful operations
>> when they are dealing with packages, and I think that the answer here is
>> affirmative.
>
> I'd like to avoid the situation where adding the icons will cause a
> flood of complaints about their appearance.

Understandable, but unless we find some way to detect and use the right
icons on all the systems that Emacs supports, I feel that this is
inevitable.

Message #44 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 13:31:28 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
> Date: Sun, 08 Jun 2025 09:09:05 +0000
> 
> >> I wouldn't object, because I do not use them, but if I couldn't disable
> >> the tool-bar, I would (with apologies) not find them that appealing,
> >> because a visual priority of mine is stylistic consistency, and these
> >> icons wouldn't fit into the remaining design language GUI on my system(s).
> >
> > Can you elaborate on how these icons are inconsistent with the other
> > GUI on your system?  Which aspects are inconsistent.
> 
> Just the design of the icons.  I use GNOME, and compare the previous
> screenshot to this one of the file manager:

This shows just two icons, and doesn't show the proposed ones for our
tool bar near them, so it is hard to compare.  What aspects of the
icons did you have in mind that are different: the size, the color
scheme, something else?

> As we are not using icons provided by the icon theme of the desktop
> environment, which in my case should be
> https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
> mismatch that some people might find irritating, but that is nothing new
> with Emacs.

Are there icons in that theme that could serve the needs of
package-menu-mode?  If so, we could offer them as an alternative, when
that desktop is in use.

> >> FWIW I don't think there is any harm in adding the icons anyway.
> >> Disregarding visual appeal, I think a slightly less subjective question
> >> is would it help attract the attention of new users to useful operations
> >> when they are dealing with packages, and I think that the answer here is
> >> affirmative.
> >
> > I'd like to avoid the situation where adding the icons will cause a
> > flood of complaints about their appearance.
> 
> Understandable, but unless we find some way to detect and use the right
> icons on all the systems that Emacs supports, I feel that this is
> inevitable.

I don't think it's practical "to detect and use the right icons on all
the systems that Emacs supports".  As for complaints, some are
definitely inevitable, but the question is how many of them will come
in?

Message #47 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 10:46:26 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: eg642616 <at> gmail.com,  78601 <at> debbugs.gnu.org
>> Date: Sun, 08 Jun 2025 09:09:05 +0000
>> 
>> >> I wouldn't object, because I do not use them, but if I couldn't disable
>> >> the tool-bar, I would (with apologies) not find them that appealing,
>> >> because a visual priority of mine is stylistic consistency, and these
>> >> icons wouldn't fit into the remaining design language GUI on my system(s).
>> >
>> > Can you elaborate on how these icons are inconsistent with the other
>> > GUI on your system?  Which aspects are inconsistent.
>> 
>> Just the design of the icons.  I use GNOME, and compare the previous
>> screenshot to this one of the file manager:
>
> This shows just two icons, and doesn't show the proposed ones for our
> tool bar near them, so it is hard to compare.  What aspects of the
> icons did you have in mind that are different: the size, the color
> scheme, something else?

Mainly the color scheme and the shapes.  I don't think the size is
relevant, as that is something that depends on the context and usage of
the icons.  The icons currently being suggested appear acceptable in the
toolbar, but that might be different on screens with higher resolutions.

>> As we are not using icons provided by the icon theme of the desktop
>> environment, which in my case should be
>> https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
>> mismatch that some people might find irritating, but that is nothing new
>> with Emacs.
>
> Are there icons in that theme that could serve the needs of
> package-menu-mode?  If so, we could offer them as an alternative, when
> that desktop is in use.

It appears so, I was able to find something sensible for everything
besides "execute".

If we were to do this, I think it would be acceptable to use the Adwita
icons whenever Emacs is using GTK.

>> >> FWIW I don't think there is any harm in adding the icons anyway.
>> >> Disregarding visual appeal, I think a slightly less subjective question
>> >> is would it help attract the attention of new users to useful operations
>> >> when they are dealing with packages, and I think that the answer here is
>> >> affirmative.
>> >
>> > I'd like to avoid the situation where adding the icons will cause a
>> > flood of complaints about their appearance.
>> 
>> Understandable, but unless we find some way to detect and use the right
>> icons on all the systems that Emacs supports, I feel that this is
>> inevitable.
>
> I don't think it's practical "to detect and use the right icons on all
> the systems that Emacs supports".  As for complaints, some are
> definitely inevitable, but the question is how many of them will come
> in?

That I cannot say :)

Message #50 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Sun, 08 Jun 2025 17:37:18 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> As we are not using icons provided by the icon theme of the desktop
>> environment, which in my case should be
>> https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
>> mismatch that some people might find irritating, but that is nothing new
>> with Emacs.
>
> Are there icons in that theme that could serve the needs of
> package-menu-mode?  If so, we could offer them as an alternative, when
> that desktop is in use.

Another solution I can think of is to find a good GTK stock icon, add
their name to `x-gtk-stock-map` along with these new icons, so it stays
(mostly) consistent.

-- 
                                          - E.G via GNU Emacs and Org.

Message #53 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Mon, 09 Jun 2025 11:48:44 +0000

Elijah Gabe Pérez <eg642616 <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> As we are not using icons provided by the icon theme of the desktop
>>> environment, which in my case should be
>>> https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
>>> mismatch that some people might find irritating, but that is nothing new
>>> with Emacs.
>>
>> Are there icons in that theme that could serve the needs of
>> package-menu-mode?  If so, we could offer them as an alternative, when
>> that desktop is in use.
>
> Another solution I can think of is to find a good GTK stock icon, add
> their name to `x-gtk-stock-map` along with these new icons, so it stays
> (mostly) consistent.

I am not familiar with GTK as a developer, but if the toolkit already
provides some system to load pre-bundled icons, that sounds like the
preferable solution.

Message #56 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: eg642616 <at> gmail.com, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Mon, 09 Jun 2025 17:39:51 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  78601 <at> debbugs.gnu.org
> Date: Mon, 09 Jun 2025 11:48:44 +0000
> 
> Elijah Gabe Pérez <eg642616 <at> gmail.com> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >>> As we are not using icons provided by the icon theme of the desktop
> >>> environment, which in my case should be
> >>> https://gitlab.gnome.org/GNOME/adwaita-icon-theme, there is a visual
> >>> mismatch that some people might find irritating, but that is nothing new
> >>> with Emacs.
> >>
> >> Are there icons in that theme that could serve the needs of
> >> package-menu-mode?  If so, we could offer them as an alternative, when
> >> that desktop is in use.
> >
> > Another solution I can think of is to find a good GTK stock icon, add
> > their name to `x-gtk-stock-map` along with these new icons, so it stays
> > (mostly) consistent.
> 
> I am not familiar with GTK as a developer, but if the toolkit already
> provides some system to load pre-bundled icons, that sounds like the
> preferable solution.

Agreed.  Using platform icons is always preferable, at least as the
default.

Message #59 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Wed, 11 Jun 2025 20:00:10 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>

[...]

>> I am not familiar with GTK as a developer, but if the toolkit already
>> provides some system to load pre-bundled icons, that sounds like the
>> preferable solution.
>
> Agreed.  Using platform icons is always preferable, at least as the
> default.

I found a few icons that match these new ones.

This is what it looks like now:

[Captura desde 2025-06-11 19-28-31.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

I've tested it with breeze and WhiteSur icons, but it should work for
any (modern) icons theme.

I've already updated the patch (plus, I added a new icon).

[0001-Add-tool-bar-icons-to-package-menu-mode-bug-78601.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #62 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: philipk <at> posteo.net, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Thu, 12 Jun 2025 09:23:42 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: Philip Kaludercic <philipk <at> posteo.net>,  78601 <at> debbugs.gnu.org
> Date: Wed, 11 Jun 2025 20:00:10 -0600
> 
> >> I am not familiar with GTK as a developer, but if the toolkit already
> >> provides some system to load pre-bundled icons, that sounds like the
> >> preferable solution.
> >
> > Agreed.  Using platform icons is always preferable, at least as the
> > default.
> 
> I found a few icons that match these new ones.
> 
> This is what it looks like now:

Thanks.  Those icons seem to be black-and-white?  If so, are our
facilities for customizing these icons convenient enough to allow PGTK
users who want that to switch to our icons instead?

Btw, why should the GTK icons be only used by the PGTK build? cannot
the GTK build use them as well?

Message #65 received at 78601 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: philipk <at> posteo.net, 78601 <at> debbugs.gnu.org
Subject: Re: bug#78601: [PATCH] Add tool-bar icons to package-menu-mode
Date: Thu, 12 Jun 2025 18:21:04 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> This is what it looks like now:
>
> Thanks.  Those icons seem to be black-and-white?  If so, are our
> facilities for customizing these icons convenient enough to allow PGTK
> users who want that to switch to our icons instead?

The black-and-white icons is because it is using my current icon-theme,
the appearance depends from the icon-theme that system is using, so it
can look more colorful in others one.

This is how it looks without the gtk-cache icons:

[Captura desde 2025-06-12 17-58-13.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

> Btw, why should the GTK icons be only used by the PGTK build? cannot
> the GTK build use them as well?

Oops, i forgot add it to `x-win.el` too.

It should now be fixed:

[0001-Add-tool-bar-icons-to-package-menu-mode-bug-78601.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.