GNU bug report logs - #78596
30.1; recentf-open ought to use a completion table and category

Previous Next

Full log

View this message in rfc822 format

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 78596 <at> debbugs.gnu.org
Cc: eliz <at> gnu.org, me <at> eshelyaron.com, dpchiesa <at> hotmail.com
Subject: bug#78596: 30.1; recentf-open ought to use a completion table
Date: Sun, 08 Jun 2025 22:13:09 +0200

Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> Hi Daniel,
>
> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>> Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text
>> editors" <bug-gnu-emacs <at> gnu.org> writes:
>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>
>>>>> From: Eshel Yaron <me <at> eshelyaron.com>
>>>>> Cc: dino chiesa <dpchiesa <at> hotmail.com>,  78596 <at> debbugs.gnu.org
>>>>> Date: Sat, 07 Jun 2025 22:14:05 +0200
>>>>> 
>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>>> 
>>>>> >> From: dino chiesa <dpchiesa <at> hotmail.com>
>>>>> >> Date: Sun, 1 Jun 2025 00:32:26 +0000
>>>>> >> msip_labels: 
>>>>> >> 
>>>>> >> Thank you, 
>>>>> >> that will work nicely. 
>>>>> >
>>>>> > Thanks.
>>>>> >
>>>>> > Eshel, would you please therefore install your changes?
>>>>> 
>>>>> Sure, I've now pushed the change to recentf-open in commit b7560fb63dc.
>>>>> Should I also push the part that documents
>>>>> completion-table-with-metadata in the ELisp manual?
>>>>
>>>> Yes.  If what you say there is correct for Emacs 30 as well, please
>>>> install that part on the release branch.
>>>
>>> AFAICT completion-table-with-metadata was only added on master,
>>> so I pushed it to master in commit 4be63c85d2a.
>>
>> `completion-table-with-metadata' does not merge the metadata. The
>> function only adds metadata to a table without metadata, like a list of
>> strings.
>
> Oh my, right, I had another version of that function in mind.
> I've pushed a fix in 86eb733aef4, does that seem accurate?

Yes, thanks.

> Thanks,
>
> Eshel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.