GNU bug report logs - #78594
[PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify variable-use consistently

Previous Next

Full log

Message #16 received at 78594-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78594-done <at> debbugs.gnu.org
Subject: Re: bug#78594: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does
 not fontify variable-use consistently
Date: Sun, 1 Jun 2025 15:48:56 -0700

[Message part 1 (text/plain, inline)]

> On May 26, 2025, at 10:02 AM, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> Hey everyone!
> 
> I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.
> 
> Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.
> 
> Attached is a patch which seeks to remedy the situation. Let me know what you think :) 

Thanks Jostein, these are very nice improvements! I merged the patch to master.

Would be nice to include some screenshots to illustrate the changes visually. But your comment message is very informational, and I was able to make some screenshots myself to see the change (attached).

Also the commit message format is still not quite right, but I fixed it when pushing.

Yuan

[after.png (image/png, inline)]

[before.png (image/png, inline)]

[Message part 4 (text/plain, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.