GNU bug report logs - #78594
[PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify variable-use consistently

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78594: closed ([PATCH] 31.0.50; typescript-ts-mode &
 tsx-ts-mode does not fontify variable-use consistently)
Date: Sun, 01 Jun 2025 22:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 1 Jun 2025 15:48:56 -0700
with message-id <0B9CDA26-101D-4A07-8C7C-1AD250CCB831 <at> gmail.com>
and subject line Re: bug#78594: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify variable-use consistently
has caused the debbugs.gnu.org bug report #78594,
regarding [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify variable-use consistently
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78594: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78594
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does not fontify
 variable-use consistently
Date: Mon, 26 May 2025 19:02:04 +0200

[Message part 3 (text/plain, inline)]

Hey everyone!

I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.

Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.

Attached is a patch which seeks to remedy the situation. Let me know what you think :) 



—
Kind Regards
Jostein Kjønigsen

[Message part 4 (text/html, inline)]

[0001-typescrip-ts-mode.el-Fontificatiomn-improvements.patch (application/octet-stream, attachment)]

[Message part 6 (text/html, inline)]

[Message part 7 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78594-done <at> debbugs.gnu.org
Subject: Re: bug#78594: [PATCH] 31.0.50; typescript-ts-mode & tsx-ts-mode does
 not fontify variable-use consistently
Date: Sun, 1 Jun 2025 15:48:56 -0700

[Message part 8 (text/plain, inline)]

> On May 26, 2025, at 10:02 AM, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> Hey everyone!
> 
> I'm an avid user of typescript-ts-mode, and I'm also very interested in seeing expanded use of font-lock-variable-use-face in Emacs. IMO it really helps highlight key structural elements of the code.
> 
> Unfortunately typescript-ts-mode (and tsx-ts-mode) is not very good, nor consistent in highlighting variable use using these new faces.
> 
> Attached is a patch which seeks to remedy the situation. Let me know what you think :) 

Thanks Jostein, these are very nice improvements! I merged the patch to master.

Would be nice to include some screenshots to illustrate the changes visually. But your comment message is very informational, and I was able to make some screenshots myself to see the change (attached).

Also the commit message format is still not quite right, but I fixed it when pushing.

Yuan

[after.png (image/png, inline)]

[before.png (image/png, inline)]

[Message part 11 (text/plain, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.