From unknown Sat Jun 21 10:24:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78592 <78592@debbugs.gnu.org> To: bug#78592 <78592@debbugs.gnu.org> Subject: Status: 30.1; sh-mode variable sh-indent-comment does not work Reply-To: bug#78592 <78592@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:24:50 +0000 retitle 78592 30.1; sh-mode variable sh-indent-comment does not work reassign 78592 emacs submitter 78592 richard newton severity 78592 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 26 10:40:59 2025 Received: (at submit) by debbugs.gnu.org; 26 May 2025 14:40:59 +0000 Received: from localhost ([127.0.0.1]:57863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJZ0c-0007X3-59 for submit@debbugs.gnu.org; Mon, 26 May 2025 10:40:59 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46864) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJY4H-0002h5-TT for submit@debbugs.gnu.org; Mon, 26 May 2025 09:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJY4B-0000Lh-IF for bug-gnu-emacs@gnu.org; Mon, 26 May 2025 09:40:35 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJY48-0002p4-LA for bug-gnu-emacs@gnu.org; Mon, 26 May 2025 09:40:35 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-3081f72c271so1666642a91.0 for ; Mon, 26 May 2025 06:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748266830; x=1748871630; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8V5zd47caRTIw5DMWkmejDTI7pM6pVkFzoBYxehnRQg=; b=T88Rz5IPZ6btu713jVKBZBIhvQMokVio/5Eo3Mh6ZUaYqPr+yJfOs4qOEtePfyR1eZ FI30Q0TXXmJK//X7R6kTeDF0pXjcYnIKb7Ud8s0iFlGCaih8O1haUcWCto/0GZcf5rKw lA/gX2xQaqlqeXTQeH5nbHTQEDTKFTWqoPPJtnvvgFe9vJpb8zdVLO7CWWtGyU6YX7qg cG2LdRzDzDeqZzUWHVtVz4UbggiV42y6BkfF6zi0+oZSHguoGS0MlUTHkd24S2DJHv29 MWbnEIOOY7W9MPgX5J2GYBdeMe129sZ6Kj/O0I+C6/u7iyOnFAiw6IaoXS6orQ44cEQi uKZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748266830; x=1748871630; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8V5zd47caRTIw5DMWkmejDTI7pM6pVkFzoBYxehnRQg=; b=I3ajgWJEy/wmmnVB9d7Mr5LTesthaKfQrnBfcZZ2zjUaFZEOOrPIlAajtuitrhP2b7 KFLGkfpVwLyMSiJ08eYTJ1T3zd6xU+sdPGQQnXRlgagV+ZYUbUjsVuZjFIJJSiujeX0v ggXzJCcmc3+rLIOYjOtnag6Dic6BI0u4FkOgJVa6dnuHeLl2YaY2sD6obycW8Tj4/OAt EpEkc1xp7lkCCPVARmoJLRjWPeVxGaZ8qM12ouGGH3Kbf0b2mRbEMyYgDHxSetTDVqFh aZex5zm0wfAyUW6ZiffaG9zyaM9M7InkFjrjsHqqWA4s7FyXcJUisf/HkMI+h5k1Aci4 69UA== X-Gm-Message-State: AOJu0YzNODtp0b4Odj5sDw1nKReYNAEQIWBweYhMLlKdjnWQ2RuIr83a h272Og12aNs1n9VviA0yph6fmPh34hZpsnoSPU3nobAKGt6sbKK1AKlZWQHQgmPHP0C4bopheTl l72MQe0uIE8PgGQXEt9kFu8PaqsnwIiGlzdat X-Gm-Gg: ASbGncvZU7LrZNRq2U5IWHCazdmhnjb9QCx1mmFKEEbq8EIqggMuFbkLsPczqLPVvKa 55PIDXmJku4oklIq4GDC+kgOHhYHpfu47m+3gwsPF/BhHgCKOLoGjc8Jn+gIFnf2hbzI6lYIpHl lQK6HKjWOO9zjkiG7XgD5HO6GcXYHmEQAjwF6HfgZ48T13wR5zKsc5G2YS9mYUriHzKw== X-Google-Smtp-Source: AGHT+IEx7TOGy7rs+0PLFgh/Eko+LXJ/IQEI/l4KaQ5Xg66jO7Zt1sdl9FaTaZ4JnZDFoPvH/e6g8tgBvnc9VZFL53o= X-Received: by 2002:a17:90b:3f0d:b0:311:44f:d153 with SMTP id 98e67ed59e1d1-3111089e039mr13508711a91.25.1748266830346; Mon, 26 May 2025 06:40:30 -0700 (PDT) MIME-Version: 1.0 From: richard newton Date: Mon, 26 May 2025 15:40:19 +0200 X-Gm-Features: AX0GCFvMyssVP0hRtMnuaKvu2lYIyTQzSiX_n3o3SmD0ekL7KkpwTKZwlI0h3es Message-ID: Subject: 30.1; sh-mode variable sh-indent-comment does not work To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000653f2f06360a1787" Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richardn26@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: sh-mode variable sh-indent-comment does not work any more. Setting it to nil or a number does not seem to have any effect when indenting a comment in a shell script. Looking at sh-script.el it only seems to be referenced in sh-var-list Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (richardn26[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (richardn26[at]gmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 26 May 2025 10:40:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --000000000000653f2f06360a1787 Content-Type: text/plain; charset="UTF-8" sh-mode variable sh-indent-comment does not work any more. Setting it to nil or a number does not seem to have any effect when indenting a comment in a shell script. Looking at sh-script.el it only seems to be referenced in sh-var-list Should it be marked as obsolete (or deleted)? Should it be removed from sh-var-list The same also seems to apply to the sh-mode variables sh-first-lines-indent sh-indent-for-else In GNU Emacs 30.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) of 2025-03-30, modified by Debian built on sbuild System Description: Debian GNU/Linux 13 (trixie) Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/30.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/30.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/30.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/30.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-pgtk 'CFLAGS=-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/emacs-30.1+1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: server-mode: t which-function-mode: t global-cwarn-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums face-remap help-macro package-x package url-handlers emacs-news-mode noutline outline tabify man etags fileloop generator xref project view pcase shell pcomplete compare-w diff-mode track-changes yank-media mhtml-mode css-mode eww xdg url-queue shr pixel-fill kinsoku url-file svg xml mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr color js c-ts-common conf-mode rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu dom nxml-util nxml-enc xmltok debug backtrace cal-menu calendar cal-loaddefs jka-compr find-func gnutls network-stream puny nsm warnings easy-mmode cl-print rcirc parse-time iso8601 apropos time-date compile comint ansi-osc ansi-color ring comp-run shortdoc text-property-search comp-common erc format-spec erc-backend erc-networks erc-common erc-compat compat erc-loaddefs help-fns radix-tree rot13 disp-table epa-file epa derived epg rfc6068 epg-config browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source eieio eieio-core cl-macs password-cache json subr-x map url-vars mailcap cl-extra help-mode edmacro kmacro byte-opt gv bytecomp byte-compile thingatpt misearch multi-isearch mule-util display-line-numbers sh-script rx smie treesit executable dired-aux add-log server cl-seq which-func imenu cus-start dired dired-loaddefs cwarn cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 868468 161855) (symbols 48 23300 0) (strings 32 96041 7003) (string-bytes 1 4003228) (vectors 16 48843) (vector-slots 8 1448049 118949) (floats 8 313 9292) (intervals 56 80852 2722) (buffers 992 108)) --000000000000653f2f06360a1787 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
sh-mode variable sh-indent-comment does not work any more.= Setting it to nil or a number does not seem to have any effect when indent= ing a comment in a shell script.

Looking at sh-script.el it only see= ms to be referenced in sh-var-list

Should it be marked as obsolete (= or deleted)? Should it be removed from sh-var-list

The same also see= ms to apply to the sh-mode variables
sh-first-lines-indent
sh-indent-= for-else

In GNU Emacs 30.1 (build 2, x86_64-pc-linux-gnu, GTK+ Versi= on 3.24.49,
=C2=A0cairo version 1.18.4) of 2025-03-30, modified by Debia= n built on sbuild
System Description: Debian GNU/Linux 13 (trixie)
Configured using:
=C2=A0'configure --build x86_64-linux-gnu --pref= ix=3D/usr
=C2=A0--sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec<= br>=C2=A0--localstatedir=3D/var/lib --infodir=3D/usr/share/info
=C2=A0--= mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes
=C2=A0--enabl= e-locallisppath=3D/etc/emacs:/usr/local/share/emacs/30.1/site-lisp:/usr/loc= al/share/emacs/site-lisp:/usr/share/emacs/30.1/site-lisp:/usr/share/emacs/s= ite-lisp
=C2=A0--with-sound=3Dalsa --without-gconf --with-mailutils --bu= ild
=C2=A0x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib=C2=A0--libexecdir=3D/usr/libexec --localstatedir=3D/var/lib
=C2=A0--i= nfodir=3D/usr/share/info --mandir=3D/usr/share/man --with-libsystemd
=C2= =A0--with-pop=3Dyes
=C2=A0--enable-locallisppath=3D/etc/emacs:/usr/local= /share/emacs/30.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/ema= cs/30.1/site-lisp:/usr/share/emacs/site-lisp
=C2=A0--with-sound=3Dalsa -= -without-gconf --with-mailutils --with-pgtk
=C2=A0'CFLAGS=3D-g -O2 -= Werror=3Dimplicit-function-declaration
=C2=A0-ffile-prefix-map=3D/build/= reproducible-path/emacs-30.1+1=3D.
=C2=A0-fstack-protector-strong -fstac= k-clash-protection -Wformat
=C2=A0-Werror=3Dformat-security -fcf-protect= ion -Wall' 'CPPFLAGS=3D-Wdate-time
=C2=A0-D_FORTIFY_SOURCE=3D2&#= 39; LDFLAGS=3D-Wl,-z,relro'

Configured features:
ACL CAIRO DB= US FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF= LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPE= R PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS T= REE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
=C2=A0 value of= $LANG: en_GB.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major= mode: Fundamental

Minor modes in effect:
=C2=A0 server-mode: t=C2=A0 which-function-mode: t
=C2=A0 global-cwarn-mode: t
=C2=A0 gl= obal-eldoc-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-m= ode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 file-name-shadow-mode: t
= =C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 minib= uffer-regexp-mode: t
=C2=A0 column-number-mode: t
=C2=A0 line-number-= mode: t
=C2=A0 transient-mark-mode: t
=C2=A0 auto-composition-mode: t=
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
Load-path shadows:
None found.

Features:
(shadow sort mail-e= xtr emacsbug message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode ma= il-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc204= 5 ietf-drums face-remap help-macro package-x
package url-handlers emacs-= news-mode noutline outline tabify man etags
fileloop generator xref proj= ect view pcase shell pcomplete compare-w
diff-mode track-changes yank-me= dia mhtml-mode css-mode eww xdg url-queue
shr pixel-fill kinsoku url-fil= e svg xml mm-url gnus nnheader gnus-util
mail-utils range mm-util mail-p= rsvr color js c-ts-common conf-mode
rng-xsd xsd-regexp rng-cmpct rng-nxm= l rng-valid rng-loc rng-uri
rng-parse nxml-parse rng-match rng-dt rng-ut= il rng-pttrn nxml-ns
nxml-mode nxml-outln nxml-rap sgml-mode facemenu do= m nxml-util nxml-enc
xmltok debug backtrace cal-menu calendar cal-loadde= fs jka-compr
find-func gnutls network-stream puny nsm warnings easy-mmod= e cl-print
rcirc parse-time iso8601 apropos time-date compile comint ans= i-osc
ansi-color ring comp-run shortdoc text-property-search comp-common= erc
format-spec erc-backend erc-networks erc-common erc-compat compaterc-loaddefs help-fns radix-tree rot13 disp-table epa-file epa derivedepg rfc6068 epg-config browse-url url url-proxy url-privacy url-expand
= url-methods url-history url-cookie generate-lisp-file url-domsuf
url-uti= l url-parse auth-source eieio eieio-core cl-macs password-cache
json sub= r-x map url-vars mailcap cl-extra help-mode edmacro kmacro
byte-opt gv b= ytecomp byte-compile thingatpt misearch multi-isearch
mule-util display-= line-numbers sh-script rx smie treesit executable
dired-aux add-log serv= er cl-seq which-func imenu cus-start dired
dired-loaddefs cwarn cc-mode = cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars = cc-defs cus-edit pp cus-load icons
wid-edit cl-loaddefs cl-lib rmc iso-t= ransl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks li= sp-float-type elisp-mode mwheel
term/pgtk-win pgtk-win term/common-win t= ouch-screen pgtk-dnd tool-bar
dnd fontset image regexp-opt fringe tabula= ted-list replace newcomment
text-mode lisp-mode prog-mode register page = tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mo= use jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer= nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8= -lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese euc= jp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic india= n cyrillic chinese
composite emoji-zwj charscript charprop case-table ep= a-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button lo= addefs
theme-loaddefs faces cus-face macroexp files window text-properti= es
overlay sha1 md5 base64 format env code-pages mule custom widget keym= ap
hashtable-print-readable backquote threads dbusbind inotify
dynami= c-setting system-font-setting font-render-setting cairo gtk pgtk
lcms2 m= ulti-tty move-toolbar make-network-process native-compile emacs)

Mem= ory information:
((conses 16 868468 161855) (symbols 48 23300 0)
=C2= =A0 (strings 32 96041 7003) (string-bytes 1 4003228) (vectors 16 48843)
= =C2=A0 (vector-slots 8 1448049 118949) (floats 8 313 9292)
=C2=A0 (inter= vals 56 80852 2722) (buffers 992 108))
--000000000000653f2f06360a1787-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 05:11:20 2025 Received: (at 78592) by debbugs.gnu.org; 29 May 2025 09:11:20 +0000 Received: from localhost ([127.0.0.1]:33843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKZIF-0003bk-Ky for submit@debbugs.gnu.org; Thu, 29 May 2025 05:11:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47282) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKZID-0003bB-JC for 78592@debbugs.gnu.org; Thu, 29 May 2025 05:11:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKZI6-0000P1-Pg; Thu, 29 May 2025 05:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h9z1mlyO35hldQ1HrbBB4Ryvb/NHlLrkr9z9M+UhvJM=; b=bv0YpU+7yE9J M77oa9JMIxDLR3whxMasV3C6IJqPHoyJKMquD6Nq9+VOjog7JFOYPdknmnIutnfdeo+Rej4adYIry 8NRjRy+e6Wt2jwoY4gLArFNSFJ7saOYN0SJXg1x8Ax+y4sFvKNe+2ukjmyg8WH9fftVBToSFedCln OTmE8R9BRQY/n67mCOQgkSiEuEYVK+yYZiylJRLMiblPbnqWHKfuQaeFPWsZzzEqinijR+2/hxjfl YUuSJRfvDfZ60R8pPU1upG2CETgfIcv+FoWojuMLkorf5gFXv+AbWf8i8b1u+kDubrVyeGjcAf0IY hUKIRyw3H0lfEyugX8YpLw==; Date: Thu, 29 May 2025 12:11:04 +0300 Message-Id: <86plfrvl1z.fsf@gnu.org> From: Eli Zaretskii To: richard newton , Stefan Monnier In-Reply-To: (message from richard newton on Mon, 26 May 2025 15:40:19 +0200) Subject: Re: bug#78592: 30.1; sh-mode variable sh-indent-comment does not work References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78592 Cc: 78592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: richard newton > Date: Mon, 26 May 2025 15:40:19 +0200 > > sh-mode variable sh-indent-comment does not work any more. Setting it to nil or a number does not seem to > have any effect when indenting a comment in a shell script. > > Looking at sh-script.el it only seems to be referenced in sh-var-list > > Should it be marked as obsolete (or deleted)? Should it be removed from sh-var-list > > The same also seems to apply to the sh-mode variables > sh-first-lines-indent > sh-indent-for-else Stefan, this seems to be due to your cleanup of sh-script's indentation in commit f9504ffba2e2604338c243dd77c877bbb8162e4a Author: Stefan Monnier AuthorDate: Mon Feb 3 15:26:59 2020 -0500 Commit: Stefan Monnier CommitDate: Mon Feb 3 15:26:59 2020 -0500 * lisp/progmodes/sh-script.el: Remove old non-SMIE indentation code Are these variables really no-ops now? I don't see that in NEWS in any release of Emacs except this in NEWS.28: ** The old non-SMIE indentation of 'sh-mode' has been removed. What, if anything, can users do now to control indentation of comment lines in sh-mode? From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 17:20:28 2025 Received: (at 78592) by debbugs.gnu.org; 29 May 2025 21:20:28 +0000 Received: from localhost ([127.0.0.1]:39946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKkfr-0007hq-N9 for submit@debbugs.gnu.org; Thu, 29 May 2025 17:20:28 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33392) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKkfp-0007hX-9u for 78592@debbugs.gnu.org; Thu, 29 May 2025 17:20:25 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2E9744403A3; Thu, 29 May 2025 17:20:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1748553618; bh=eK0mvqKbiV6o8t/8yNPvQxzrzO3c553chaoVv4rtK5A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lVvqFM6Lt42HV7GHIxae9ocTYb8Piee300xduF8j7NAjyY8JwHpUJXbtkT8/maPwL ti2UVywVf80HaVEqUeu8RtiRI7Y/wRwAfhqqwZHWPalqCCy/x1aX8OUHE+Pnk2wh1t XS03/7fgmp7tJkRvvBTAqB0Nip+SjFLkOu3EuXnPsV/o9QqF0cvW8TTkmAlq17U76/ u3rdw4RGg7JLH6pPnF2xqsmPeVpwO8hue3NVjwaFWWbVOwP3Nsi3pPFVZjorzS2xCk GxVZSPMz0owNvY+CjXn12EZRBcRDvwx5d6gDpf6f2BIswd0WwhkYmGUFrwDivHtSCQ PYOBR+YxNU15w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 04D29441157; Thu, 29 May 2025 17:20:18 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E4B5D1204B4; Thu, 29 May 2025 17:20:17 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#78592: 30.1; sh-mode variable sh-indent-comment does not work In-Reply-To: <86plfrvl1z.fsf@gnu.org> Message-ID: References: <86plfrvl1z.fsf@gnu.org> Date: Thu, 29 May 2025 17:20:17 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.161 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78592 Cc: 78592@debbugs.gnu.org, richard newton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> sh-mode variable sh-indent-comment does not work any more. Setting it to >> nil or a number does not seem to >> have any effect when indenting a comment in a shell script. >> >> Looking at sh-script.el it only seems to be referenced in sh-var-list >> The same also seems to apply to the sh-mode variables >> sh-first-lines-indent >> sh-indent-for-else Indeed, these vars were not ported over to the new SMIE-based indentation code. >> Should it be marked as obsolete (or deleted)? Should it be removed from sh-var-list I think so, yes. > Stefan, this seems to be due to your cleanup of sh-script's > indentation in > > commit f9504ffba2e2604338c243dd77c877bbb8162e4a > Author: Stefan Monnier > AuthorDate: Mon Feb 3 15:26:59 2020 -0500 > Commit: Stefan Monnier > CommitDate: Mon Feb 3 15:26:59 2020 -0500 > > * lisp/progmodes/sh-script.el: Remove old non-SMIE indentation code > > Are these variables really no-ops now? Yes. > I don't see that in NEWS in any release of Emacs except this in > NEWS.28: They were already no-ops when using SMIE indentation before that change, so in a sense it is implied by "The old non-SMIE indentation of 'sh-mode' has been removed", but we should have removed those vars at the same time. I just hadn't noticed that nobody complained about the lack of support for those vars, so the new code was never adjusted to obey them. > ** The old non-SMIE indentation of 'sh-mode' has been removed. > > What, if anything, can users do now to control indentation of comment > lines in sh-mode? There's no easy/convenient way to do it. They have to add a new function on `smie-indent-function` that provides the indentation they want (or advise `smie-indent-comment`, or replace this function on that list with another one). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 31 08:11:38 2025 Received: (at 78592-done) by debbugs.gnu.org; 31 May 2025 12:11:38 +0000 Received: from localhost ([127.0.0.1]:56625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLL3p-0000xB-09 for submit@debbugs.gnu.org; Sat, 31 May 2025 08:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46034) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLL3i-0000vG-7e for 78592-done@debbugs.gnu.org; Sat, 31 May 2025 08:11:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLL3c-0003Ih-Ix; Sat, 31 May 2025 08:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vHxYbCFqWFBxWb2BGTDIcIvKxrvA7TSxnCxj7udjMa8=; b=X0woQRr1WxvX sMlQBeyvmbfg600dio0Soa8VCcukwIjEQLBNkDf2/dW5DiF5mJXZ2xn2YUZnNZvZ7yzS2DV2xqjEa D2zSYJV8J0i0aCLI1hpMYuE7mvUL+JTJMHHVC6R4tZ0aQNckx0QEgQ6xFlBMo0YPs5phFklBA0cXW IJH1oKsHGrfsbJiz7dNIOENeHHdww2cZ7VqrO5K4Z030R82FbiZuSSqogupBqbZJAvRH+J6XUqg3T eB34oo9DqPIWhOVkY4/4cqBie5xsRYrarkY9iP38dobmLLCcib77NBoNPZIEhFpl8/30EHl8NKkqe gXoNpSWEQuoMoySyJra8JA==; Date: Sat, 31 May 2025 15:11:21 +0300 Message-Id: <86zfetq8t2.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 29 May 2025 17:20:17 -0400) Subject: Re: bug#78592: 30.1; sh-mode variable sh-indent-comment does not work References: <86plfrvl1z.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78592-done Cc: 78592-done@debbugs.gnu.org, richardn26@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: richard newton , 78592@debbugs.gnu.org > Date: Thu, 29 May 2025 17:20:17 -0400 > > >> sh-mode variable sh-indent-comment does not work any more. Setting it to > >> nil or a number does not seem to > >> have any effect when indenting a comment in a shell script. > >> > >> Looking at sh-script.el it only seems to be referenced in sh-var-list > >> The same also seems to apply to the sh-mode variables > >> sh-first-lines-indent > >> sh-indent-for-else > > Indeed, these vars were not ported over to the new SMIE-based indentation code. > > >> Should it be marked as obsolete (or deleted)? Should it be removed from sh-var-list > > I think so, yes. > > > Stefan, this seems to be due to your cleanup of sh-script's > > indentation in > > > > commit f9504ffba2e2604338c243dd77c877bbb8162e4a > > Author: Stefan Monnier > > AuthorDate: Mon Feb 3 15:26:59 2020 -0500 > > Commit: Stefan Monnier > > CommitDate: Mon Feb 3 15:26:59 2020 -0500 > > > > * lisp/progmodes/sh-script.el: Remove old non-SMIE indentation code > > > > Are these variables really no-ops now? > > Yes. > > > I don't see that in NEWS in any release of Emacs except this in > > NEWS.28: > > They were already no-ops when using SMIE indentation before that change, > so in a sense it is implied by "The old non-SMIE indentation of > 'sh-mode' has been removed", but we should have removed those vars at > the same time. > > I just hadn't noticed that nobody complained about the lack of support > for those vars, so the new code was never adjusted to obey them. > > > ** The old non-SMIE indentation of 'sh-mode' has been removed. > > > > What, if anything, can users do now to control indentation of comment > > lines in sh-mode? > > There's no easy/convenient way to do it. > They have to add a new function on `smie-indent-function` that provides > the indentation they want (or advise `smie-indent-comment`, or replace > this function on that list with another one). OK, so I've now removed these variables, and I'm closing this bug.