GNU bug report logs - #78582
30.1; which-key-mode overwrites custom key bindings

Previous Next

Full log

Message #89 received at 78582 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: gerd.moellmann <at> gmail.com, murray.alex <at> gmail.com, luangruo <at> yahoo.com,
 monnier <at> iro.umontreal.ca, 78582 <at> debbugs.gnu.org
Subject: Re: bug#78582: 30.1; which-key-mode overwrites custom key bindings
Date: Mon, 02 Jun 2025 18:38:03 +0300

> From: Robert Pluim <rpluim <at> gmail.com>
> Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,
>   murray.alex <at> gmail.com,
>   luangruo <at> yahoo.com,  Eli Zaretskii <eliz <at> gnu.org>,  78582 <at> debbugs.gnu.org
> Date: Mon, 02 Jun 2025 16:26:50 +0200
> 
> >>>>> On Mon, 02 Jun 2025 10:11:16 -0400, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> said:
> 
>     Stefan> Maybe we should try and work harder to make such reloading more harmless
>     Stefan> (e.g. replace the `define-key/global-set-key`s with functions which do
>     Stefan> nothing if the key is already bound?), but it's an issue that affects
>     Stefan> only those people who hack on the code of the very Emacs they're
>     Stefan> running, so it's not super-high priority.
> 
> At least for kmacro.el, any reason we canʼt put those
> `global-set-key's in bindings.el?

It would make the maintenance a tad harder, because the bindings will
be in a different file.  I'd say that benefits are not worth the
downsides in this case.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.