Subject: Re: bug#78582: 30.1; which-key-mode overwrites custom key bindings

From: Eli Zaretskii <[email-masked]>
Date: Mon, 02 Jun 2025 18:38:03 +0300

> From: Robert Pluim <[email-masked]>
> Cc: Gerd Möllmann <[email-masked]>,
>   [email-masked],
>   [email-masked],  Eli Zaretskii <[email-masked]>,  [email-masked]
> Date: Mon, 02 Jun 2025 16:26:50 +0200
> 
> >>>>> On Mon, 02 Jun 2025 10:11:16 -0400, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <[email-masked]> said:
> 
>     Stefan> Maybe we should try and work harder to make such reloading more harmless
>     Stefan> (e.g. replace the `define-key/global-set-key`s with functions which do
>     Stefan> nothing if the key is already bound?), but it's an issue that affects
>     Stefan> only those people who hack on the code of the very Emacs they're
>     Stefan> running, so it's not super-high priority.
> 
> At least for kmacro.el, any reason we canʼt put those
> `global-set-key's in bindings.el?

It would make the maintenance a tad harder, because the bindings will
be in a different file.  I'd say that benefits are not worth the
downsides in this case.