From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 11:14:27 2025 Received: (at submit) by debbugs.gnu.org; 22 May 2025 15:14:27 +0000 Received: from localhost ([127.0.0.1]:35954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI7co-0001UN-LG for submit@debbugs.gnu.org; Thu, 22 May 2025 11:14:27 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53602) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI7cj-0001TM-A4 for submit@debbugs.gnu.org; Thu, 22 May 2025 11:14:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI7cT-0002XV-8c for bug-gnu-emacs@gnu.org; Thu, 22 May 2025 11:14:05 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uI7cR-0006vB-6l for bug-gnu-emacs@gnu.org; Thu, 22 May 2025 11:14:04 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so85828165e9.1 for ; Thu, 22 May 2025 08:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747926840; x=1748531640; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=6FPbOMqA5jhoJnNO2xKQGXQJ5DWcqoHVrdbzd88rimk=; b=ZHuvbVFtxXF/UMlqysxrXRCbdB8Uvla2BdaTIWF90+d1nxFupxyu7/sJQesuGTVLAg v5mJgLbNQvAwN49VaL2Ylw95SKEJGDPxFI+s1JStqsKNFaoAnh5g41F6NRZRaNM3upHJ 4ijadvwd7nxbwTjdUm+xq0tQ95gPYGR6Oi17wJGaeHABuelURQJrIMurLAmxTZjuo9DS SZ7Jq4jskHKdjOYtRuymgZWFZ1Xsfc7Qz6X2qxkiya0QzlAuDlnV+Ib1aMU9wEq+4HGJ tFfBXJxQZGvBM7AzU0TZ3W9l2Vec4jdH9T9QALHqsPnIlDqEIpTgOJxKgMwwjpd1MUQQ BRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747926840; x=1748531640; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6FPbOMqA5jhoJnNO2xKQGXQJ5DWcqoHVrdbzd88rimk=; b=bXIB6BhYdS/VF0lbtveG+Jsoy5G/vt+IS3EL++nw/e4VTcjSVW93MjEuI5R9ONB7ju JZXHkzXlXJe0Zu51brJuaHD9+TaqohhSUZmivsyjzEilWX0HzpI2nId9OQtURVaLzfao 0Mncl5CcR3JOnkUgeaQaq8oFsOym2G8H68lkjWRImjN+Oy4dpTsmkMxBTalM1VttdPfp ysXAZXTHSvf8UZzCHLE31hAtOerfQTeXSFi3+cjqBLxRVEtiPkmerFGvM8bUUGq7lhD9 yMk0TYK3y5jmeUwuMV3K2zfLP/+ajJz5bBs6yHw+JR8+3JFoaw736+0RZN2Bo1AFjGLe FIIg== X-Gm-Message-State: AOJu0YwoSrszMe6CkOLKKscrzTD8jc84jR7/NIYmIfUgJoyDHQVdoKF4 RnLZ52iLPJwzmjJMc+BaQMupTeFHeV6jHlx6Rk80S4ndrVd3nxOmqYA0v5a0vg== X-Gm-Gg: ASbGncua4fEbskPiQjoN/8PA6yHokSdonxSdg0PxZ38ZxqlV7aby3TaHpovc8NhJ/W+ j9TOzSabIP6YkpZWGY28/wv1EDlx9MmwapxCxOxTCRB3+Ifb8qpni6pOGopDGBKcSeqWnCx5CuS mRT6jLzHkknswpHFZUY9+APB1kW598k87O44uU4O9lsl5lzf5LfUI4jSaZ3kv/ATCC5eXlD0won Taljy2atMyKa8Bvbt0qhcueM+Ew9EQS1ODKkcCEZLVabQLt+aTi3BDJ83q3eVHnS+MA2CyqvGLe RTv5C63YyqQ95mBbf4Q79glETM17nJwa0mCMqq9WKL2wLx+aFLaUdSkPJHpR X-Google-Smtp-Source: AGHT+IGcjT2Ob9vJmZWS+S5e6uuqkB1OHdFqX09AWdkhVlaK7b7qN+F5NVcVaSu/Ytj/VBggdMMphQ== X-Received: by 2002:a05:600c:34c9:b0:43d:fa59:af97 with SMTP id 5b1f17b1804b1-442fd671d12mr226692485e9.32.1747926839272; Thu, 22 May 2025 08:13:59 -0700 (PDT) Received: from localhost ([84.79.192.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d3edcsm112255845e9.20.2025.05.22.08.13.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 08:13:58 -0700 (PDT) From: Roi Martin To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add baseline pass/fail tests for `ert-test-erts-file' X-Debbugs-Cc: Christian Ohler Date: Thu, 22 May 2025 17:13:54 +0200 Message-ID: <8734cwwudp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=jroi.martin@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch This patch adds tests to verify that the `ert-test-erts-file' function can detect both passing a failing test cases. This provides a baseline to test other erts features like test specifications (e.g. `Skip' or `Code'). It complements the tests introduced in Bug#76839, which tested a bug fix for `Skip'. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-baseline-pass-fail-tests-for-ert-test-erts-file.patch >From 1549198120051afaa1016627a1833d6497d4bc65 Mon Sep 17 00:00:00 2001 From: Roi Martin Date: Sun, 20 Apr 2025 08:05:56 +0200 Subject: [PATCH] Add baseline pass/fail tests for `ert-test-erts-file' * test/lisp/emacs-lisp/ert-tests.el (ert-test-erts-pass) (ert-test-erts-fail): Add tests to verify that the `ert-test-erts-file' function can detect both passing a failing test cases. * test/lisp/emacs-lisp/ert-resources/erts-fail.erts: * test/lisp/emacs-lisp/ert-resources/erts-pass.erts: Add test data. --- test/lisp/emacs-lisp/ert-resources/erts-fail.erts | 7 +++++++ test/lisp/emacs-lisp/ert-resources/erts-pass.erts | 7 +++++++ test/lisp/emacs-lisp/ert-tests.el | 11 +++++++++++ 3 files changed, 25 insertions(+) create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-fail.erts create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-pass.erts diff --git a/test/lisp/emacs-lisp/ert-resources/erts-fail.erts b/test/lisp/emacs-lisp/ert-resources/erts-fail.erts new file mode 100644 index 000000000000..12d73454f7b0 --- /dev/null +++ b/test/lisp/emacs-lisp/ert-resources/erts-fail.erts @@ -0,0 +1,7 @@ +Name: fail + +=-= +FOO +=-= +BAR +=-=-= diff --git a/test/lisp/emacs-lisp/ert-resources/erts-pass.erts b/test/lisp/emacs-lisp/ert-resources/erts-pass.erts new file mode 100644 index 000000000000..6f98150d4d9f --- /dev/null +++ b/test/lisp/emacs-lisp/ert-resources/erts-pass.erts @@ -0,0 +1,7 @@ +Name: pass + +=-= +FOO +=-= +FOO +=-=-= diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el index 467d01fed9d2..048ab931f501 100644 --- a/test/lisp/emacs-lisp/ert-tests.el +++ b/test/lisp/emacs-lisp/ert-tests.el @@ -1030,6 +1030,17 @@ ert-test-with-test-buffer-selected/buffer-name (ert-with-test-buffer (:name "foo" :selected t) (buffer-name))))) +(ert-deftest ert-test-erts-pass () + "Test that `ert-test-erts-file' reports test case passed." + (ert-test-erts-file (ert-resource-file "erts-pass.erts") + (lambda () ()))) + +(ert-deftest ert-test-erts-fail () + "Test that `ert-test-erts-file' reports test case failed." + (should-error (ert-test-erts-file (ert-resource-file "erts-fail.erts") + (lambda () ())) + :type 'ert-test-failed)) + (ert-deftest ert-test-erts-skip-one () "Test that Skip does not affect subsequent test cases (Bug#76839)." (should-error (ert-test-erts-file (ert-resource-file "erts-skip-one.erts") -- 2.49.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 06:09:43 2025 Received: (at 78552-done) by debbugs.gnu.org; 24 May 2025 10:09:43 +0000 Received: from localhost ([127.0.0.1]:57444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIlp1-000414-BG for submit@debbugs.gnu.org; Sat, 24 May 2025 06:09:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIlow-00040W-Jp for 78552-done@debbugs.gnu.org; Sat, 24 May 2025 06:09:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIloq-0007X7-O6; Sat, 24 May 2025 06:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2iHRLSslMspqOVsBdnw9R7U8aPXi/rVXbqfljSSEBNY=; b=o6mSXEgak4Fs kI2VdSZr+NYY7tyXtZPYNuPt6y8WeBMKRbrVSwd0NMcFuQmLPh9pyHeuG/skXrEu3nBFKXT4SGHN6 3NCsNIcRdCKkHUhznK7YuWPSqyNeQ0sVhyZ45807AA8JID+yauK8GdEqN1siFxuJV2WiJER6aBLcq ELMUDoeYCtkleWYpHkIeJej9397X3wXe5vb3rpzedkEsjuwMnxBGCWMcFPz7K+VpmOqN8+Y4cTORv 26KhmNdXtutV+sGEZA8w3WhuaO2l/t0QAZRGwPlTME0U56ksIjkY6zzRE4Q1Wf5EzZgZpV6La12wo H5p4rWyVP2PtdsZ/vy91YA==; Date: Sat, 24 May 2025 13:09:30 +0300 Message-Id: <86a5721fs5.fsf@gnu.org> From: Eli Zaretskii To: Roi Martin In-Reply-To: <8734cwwudp.fsf@gmail.com> (message from Roi Martin on Thu, 22 May 2025 17:13:54 +0200) Subject: Re: bug#78552: [PATCH] Add baseline pass/fail tests for `ert-test-erts-file' References: <8734cwwudp.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78552-done Cc: 78552-done@debbugs.gnu.org, ohler@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Christian Ohler > From: Roi Martin > Date: Thu, 22 May 2025 17:13:54 +0200 > > This patch adds tests to verify that the `ert-test-erts-file' function > can detect both passing a failing test cases. This provides a baseline > to test other erts features like test specifications (e.g. `Skip' or > `Code'). It complements the tests introduced in Bug#76839, which tested > a bug fix for `Skip'. Thanks, installed on the master branch, and closing the bug.