GNU bug report logs - #78530
31.0.50; [PATCH] eglot-code-action-suggestion doesn't call the callback function in the original buffer

Previous Next

Full log

Message #11 received at 78530 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: 78530 <at> debbugs.gnu.org
Subject: Re: bug#78530: 31.0.50; [PATCH] eglot-code-action-suggestion doesn't
 call the callback function in the original buffer
Date: Wed, 21 May 2025 22:48:15 -0700

> On May 21, 2025, at 4:20 AM, João Távora <joaotavora <at> gmail.com> wrote:
> 
> Good catch, good analysis and great commit message.
> 
> Just please rename the subject line of the commit message to
> start with "Eglot: " if you can.  Makes it easier to identify.  For example:
> 
> Eglot: always call ElDoc callbacks in correct buffer
> 
> Then add a reference to this bug#78530 and push at will.

Cool. And thanks for the commit title, I was struggling to come up with a good one :) I pushed the fix. But we should also think about fixing the root cause. For example, switching to the original buffer temporarily when running ‘eldoc-display-functions’, like what eglot documentation functions do already. WDYT?

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.