GNU bug report logs - #78525
[PATCH] test: Skip a test that fails without python enabled.

Previous Next

Package: automake-patches;

Reported by: Collin Funk <collin.funk1 <at> gmail.com>

Date: Wed, 21 May 2025 05:10:02 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78525: closed ([PATCH] test: Skip a test that fails without
 python enabled.)
Date: Wed, 21 May 2025 20:19:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 21 May 2025 14:18:35 -0600
with message-id <202505212018.54LKIZVk3194594 <at> freefriends.org>
and subject line Re: [bug#78525] [PATCH] test: Skip a test that fails without python enabled.
has caused the debbugs.gnu.org bug report #78525,
regarding [PATCH] test: Skip a test that fails without python enabled.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78525: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78525
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Collin Funk <collin.funk1 <at> gmail.com>
To: automake-patches <at> gnu.org
Subject: [PATCH] test: Skip a test that fails without python enabled.
Date: Tue, 20 May 2025 22:08:56 -0700
[Message part 3 (text/plain, inline)]
On a system without Python 't/py-compile-usage' fails with:

    + ./py-compile --help
    + cat stdout
    py-compile: Invalid python executable (according to -V): python
    py-compile: Python support disabled
    + test -s stderr
    + grep '^Usage: py-compile .' stdout
    + am_exit_trap 1
    + exit_status=1

This occurs after the following commit:

    commit 0ea7ef97493cd88da915d1936e04a6ace5c754d8
    Author: Karl Berry <karl <at> freefriends.org>
    Date:   Sun Feb 9 09:36:24 2025 -0800
    
        python: restore more compatible behavior for $PYTHON.
        
        For https://bugs.gnu.org/74434.
        
        * lib/py-compile: if $PYTHON -V does not include the
        string "python" (case-insensitive), consider the support
        intentionally disabled and exit successfully, unless PYTHON is set
        to false, in which case exit unsuccessfully. This is closer to
        the old behavior. Mention this in the help message.
        * t/py-compile-env.sh: add test for PYTHON=:.
        * NEWS: mention this. (And, en passant, add some past bug#s and
        clarify that only RCS/SCCS pattern rules were disabled, not all.)
    
Simple 1 line fix attached. :)

Collin

[0001-test-Skip-a-test-that-fails-without-python-enabled.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: collin.funk1 <at> gmail.com
Cc: 78525 <at> debbugs.gnu.org
Subject: Re: [bug#78525] [PATCH] test: Skip a test that fails without python
 enabled.
Date: Wed, 21 May 2025 14:18:35 -0600
    --- a/t/py-compile-usage.sh
    +++ b/t/py-compile-usage.sh
    @@ -17,6 +17,7 @@
     # Test 'py-compile --help', 'py-compile --version', and that 'py-compile'
     # correctly complains on wrong usage.

    +required=python

Installed and closing. Thanks Collin.

BTW, do you have any idea why the "From " line in your patch is dated
from 2001?
From 5f9001d17fa17088468b650a26a6f876dcdca161 Mon Sep 17 00:00:00 2001

Doesn't matter. Just seemed curious. --thanks, karl.


This bug report was last modified 25 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.