GNU bug report logs - #78520
31.0.50; Performance issue in dired+isearch with dired-isearch-filenames

Previous Next

Package: emacs;

Reported by: Ergus <spacibba <at> aol.com>

Date: Tue, 20 May 2025 23:34:02 UTC

Severity: normal

Tags: fixed

Found in version 31.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #86 received at 78520 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 78520 <at> debbugs.gnu.org, spacibba <at> aol.com
Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with
 dired-isearch-filenames
Date: Mon, 09 Jun 2025 05:14:31 +0200
Juri Linkov <juri <at> linkov.net> writes:

> > 1.  In `wdired-change-to-wdired-mode', we do this:
> >
> > | (when wdired-search-replace-filenames
> > |   (add-function :around (local 'isearch-search-fun-function)
> > |                 #'dired-isearch-search-filenames
> > |                 '((isearch-message-prefix . "filename ")))
> > |   (setq-local replace-search-function
> > |               (setq-local replace-re-search-function
> > |                           (funcall isearch-search-fun-function)))
> > |   ;; Original dired hook removes dired-isearch-search-filenames that
> > |   ;; is needed outside isearch for lazy-highlighting in query-replace.
> > |   (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t))
> >
> > Does that mean that after switching to wdired there is no way to switch
> > between filename-only and normal search and replace?
>
> Correct.
>
> > Is the behavior determined when switching to wdired, or can it still
> > be change while in wdired-mode?
>
> Since wdired is intended for editing filenames, we restrict
> search/replace to filenames only.

It's also possible to change permissions.  Anyway...


> > 2.  How was that - was it possible to control whether to search and
> > replace in the symlink targets?
>
> To search/replace in the symlink, 'dired-isearch-search-filenames'
> uses the text property 'dired-symlink-filename'.

Ah - right, that was it.  Thanks.


Michael.




This bug report was last modified 21 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.