GNU bug report logs - #78520
31.0.50; Performance issue in dired+isearch with dired-isearch-filenames

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 78520 <at> debbugs.gnu.org
Subject: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames
Date: Thu, 19 Jun 2025 09:59:09 +0300

>> `wdired-search-replace-filenames` is required anyway
>> since it also sets `replace-search-function`.
>
> Hmm - but we could also try to do this when query-replace is invoked.
> Similar to what we do when invoking isearch.
>
> Do we handle wdired differently only because of this problem?
>
> |  ;; Original dired hook removes dired-isearch-search-filenames that
> |  ;; is needed outside isearch for lazy-highlighting in query-replace.
> |  (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t)
>
> Maybe we could solve this in some other way?  Then, isearch and
> query-replace would just look whether filename only matching is enabled
> or not, and do the according setup when any of them is called by the
> user.

Could you try to remove all isearch-related code from wdired.el
and see how it reuses dired setup?  I tried, but query-replace
proposes to replace matches outside of filenames.  This is because
query-replace uses isearch functions, but dired-isearch-filenames-setup
is not called.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.