From debbugs-submit-bounces@debbugs.gnu.org Tue May 20 19:33:59 2025 Received: (at submit) by debbugs.gnu.org; 20 May 2025 23:34:00 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uHWT8-0005yQ-Dh for submit@debbugs.gnu.org; Tue, 20 May 2025 19:33:59 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59826) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uHWT4-0005xb-Ax for submit@debbugs.gnu.org; Tue, 20 May 2025 19:33:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHWSx-0003Ow-Qn for bug-gnu-emacs@gnu.org; Tue, 20 May 2025 19:33:47 -0400 Received: from sonic303-3.consmr.mail.bf2.yahoo.com ([74.6.131.42]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uHWSv-0001Do-6g for bug-gnu-emacs@gnu.org; Tue, 20 May 2025 19:33:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1747784023; bh=FDYBj3XPk41+cgOYT1WYK0CGTp7eX04rg+Edbf7Kvis=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=ZHUUW2PJbchtiVJm4B6J92u9nefJlNwFRas4JDbQfwcZcLzwi05Cqbazyy8CKOLrMjjV1mL0LsWpfPKU5ueUohu4lp/wF+fbhHyx6/APXYfNx0B/tHfAlR5mPsO7zE3yNa8u1k7uMCQFiFaMgNwisXdtwXtZjuI75u7zp+iMsOYZp2V6h4m6R+ETZ4DOfiegMDAOdOfFk0Z/yfJnnihsMVRFivYCT8GDodmxh1XL8YJWgqKEBPOIurxr5xBKNXY0h9Myuo7OGbF7lx26CretOCjX2tCvCANkJEqUBiD8LDTKruQ9HPW//DZP2iSCFiHYLlK769m4BPDn/2W9xmNRqA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1747784023; bh=pMC6eiW951xhvO3WG8hTtfXWjxHGQMvK+49gvckuF0x=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=E+6Nj7mNgPPgNseFpGg4LKuXXn1S2nxNOJQYyCKI2cDHwNFCEZSEjmo+n7WJsiIqY71wFQjLfwjR+c5ztzjC0IIiNVw891j9H8K7pRePdYFSvTDEnO+7ahvi+2xy9qGSxi3jXuHAAWO+Fum3LpqBGBykDPxGg0sLhCP3OZ+TIai743gIfbMHWSY8grZcGICjkAtAcU/UlzCBv2BWfXDneY+Ir6TJgg6dfGfHnwwbN5VgUIX99ainTGTrVxnXY3NGAH4uCzR5Ifl5sgMWbGCQmQRhiF3Jxi6eWMQu33Hk8XoGZeQqpBkxAENXr4nNmUnrfJhRQeTAV/slo24uhJScrQ== X-YMail-OSG: esSc5pQVM1nFzO6FzCtWpdj8Fzqj4sAKcuhEebYN5PG.KKQhyM0m4OP84yZvTMq 8KT.n1KsNIY2MZzb7A.BP8uitUU_UZbXQT5VGqOc_Fvu_6DlDnJ9uVxqzaIMaB8OB3vuW4rA3uaj c_1S52s5ubupdKHzAfwcw2clOMcyMLgUC8ZmRn_CWkHS1dXKiBBGLckPUNhJQhGoFqnxhTZ_etF0 D8LoF0hbSfOH7AUZ6aykuKndzibgDI6isv0fzB_lG7RZnUzG_NCWWJ_Ck0SyxKGLQ9UqKzrRLMjP gfVh2y4kmHYuHd9Eg2g7NPU3sXW7vS8LOdeDRKyDZYYHFcF2Zn2M6.kAOJJbpSCvt9iPOZmx2oyU XlBETzN3TEg7XeNkuioljljtG_xTJxWqNJwh5uXCBAse_zp_ATE0v09.P7V5.eRt1h0t0t2cDXGa POxvy2fXSaqVY3TJHFqGp.94ceUf357U1SDbBlzsMzGsxbhdguM_s58yeYBnew.xC7DOYDIiFqFB 2Zk2DXxKhuQczzuP372a8bkdvDUi_i7Y1XkxRfn1DKRvyzZMpYYbwlaCVl8lPjEFbNT_ZXXp.twE xPq.cw_ItDCot.SMvW3zBvGxZ3cx0Ta0RPkWAFI9MK6dJDjYrr1b8iMU.j2BRzOSpyATzAOlaTvw YvQib9AXAWXi2soJ5pGNoV94FeL.fSx6jL2UFrX71Fb75gplbLBwJiNW2eDbcpdqSxB3U5LfQ6_l HOGCuVkJnVBrVl9mgxgPWPBDSkbxh0Z39yyz2bR4BJr2wpNyy0Bt3nNVzziaiyGZagcEr0xXGNK3 Tmm9K9LCp5mzKj4HzyvolOfm.HvyxpMlz5zhHjtqgfdCo1KBnHmxyC9q14K2KlQdVqvYS41OxuC3 KXvp4G2peRgklItRVYIERvTDYF9OtwrjZEtCD8_iFYNRUCqnfPDz.e0_yYCGBN7ikdjttLQpvUVl 5aAIKti.bjkjoaXH.kLoHAgyztlDx21iFH82Ec.IFbdpEFl7j5Nmp_u22ghJFxp4_37gfhskMCrj 1yowfM5aHHuLjOLJNaimf.quGv4wffSMvgW9PaAMcLCs6cFARAidt7nUPjDnrC4Vs2LM0tovTKlC bXQ_a_CnMa9ieuUQ2vBJ._8uyK0oWM8ycNAYz74A1y5LTaJdbwfcoy2Oqrra2KjyNjnGNgtnfH13 O29YwYdqLplW6usR0woXnhUj.B2vIqYQ.mJeft66pWhtyq1JdDRfbBHLM6elQq2jECmXB1G8c.hy dOMRPQzVJNd.R3mhazWw5F3OPYmOURQt.we3GkQlUjIXmDror7P5cleNZVZvo6zFh3GiQ0Cxsf6. GJ38QPO9SKHnGbu1yfAjWeuGmVhml9AzZg7CXqG3_e_NDRs1SU2o2AsM.YDcrKjBXUE_.fXzYP_Q RiOijjdHVIbvMvDVjjOX17g2HvU74th.lmRVF9BBo8jfnhpQOde4Pmnrsd9PXXV.cPWdmt3uIRMK MkJCpRGhRofADhdWYlrsxFthE_1SQvJEYp4JnfPGukSUBiiCJEQA_.cQf6WdT.4ObLGv.XQKYphV Lz5O7sMbzr3ChkG5PuUgO_lYQBl8Y.Y0Rkl_qp_fNWbUN4.sgBjRWIVQnIDiKiyl5POemDL8PYML QVVfojG9oIffagJLCXlKNubYRme5xLHDAI7fVRodhzQ_F_dHb0nWmy63E9nSVSGR_BKRD.eEYWIN JL0RMcOQZShBv96pHU6dZFN46wBeujoLEoYJZxKqEb_yKh5rXVgE1GHOQnYXJ2OPNzGeHw242RFi KAaekdEIrqbaCVgbfWmqPG9BzMJuKKHHdsGbspge6itlp.kVbiZVgW7w1AGpV.xxcYvodFDQEeHF O105XVLjZbXInz7xVZ9VlUDo9qriOvHlSKd9s_q0EPHyK922gPbi4IEoJBx8PJuygA5UNcKBmoq0 pgkMh32lgB3BfU2UiJ9WKCqw7_BrN86b8IakOwoznbzwviDa3fRl_tPuGRClwtvYbArcLpu4cRVl ATRIEaLnAq5.LTbWkVkkvp0x8K7RvB9wHhrlncO1rD68If24nEcXuewCIxgDvxcz5LFbl2zodit6 DGdGmWyyTv3gX_MDpbao79vAtpay4Kp3Th3nsYPz5EWoZwIEg1YBE92ddTCXx0on7UAgW_znBil5 fmig.mnXJkl.6PDAuVa0mlUhHznYx_VCKczibjn_CnafqmKkcu1dF1s93dtrwb_7QhTke8dZDJyy cS7X.3r4- X-Sonic-MF: X-Sonic-ID: cb4e4c27-e075-478b-a99a-d46f838b989e Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.bf2.yahoo.com with HTTP; Tue, 20 May 2025 23:33:43 +0000 Received: by hermes--production-ir2-858bd4ff7b-rtzhj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 816f9d59139933589275dee86fed0968; Tue, 20 May 2025 23:33:39 +0000 (UTC) From: Ergus To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames X-Debbugs-Cc: Date: Wed, 21 May 2025 01:33:19 +0200 Message-ID: <87y0uqyi0w.fsf@aol.com> MIME-Version: 1.0 Content-Type: text/plain References: <87y0uqyi0w.fsf.ref@aol.com> X-Mailer: WebService/1.1.23840 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 13089 Received-SPF: pass client-ip=74.6.131.42; envelope-from=spacibba@aol.com; helo=sonic303-3.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi: I have been using dired and isearch in a directory with ~8000 files and emacs became totally non-responsive. It freezed with every letter for ~10 seconds. I checked my config and it seems that the problem is `dired-isearch-filenames`. Any non-nil value produces this issue. I ran with the profiler and it showed that all the time is going in `next-single-property-change` 86696 91% - command-execute 86696 91% - call-interactively 86695 91% - funcall-interactively 59531 62% - isearch-printing-char 59531 62% - isearch-process-search-char 59531 62% - isearch-process-search-string 59531 62% - isearch-search-and-update 45907 48% - isearch-update 45890 48% - isearch-lazy-highlight-new-loop 45890 48% - redisplay 45854 48% - timer-event-handler 45854 48% - apply 45854 48% - isearch-lazy-highlight-buffer-update 45853 48% - isearch-lazy-highlight-search 45852 48% - isearch-search-string 45852 48% - # 45852 48% - apply 45852 48% - search-within-boundaries 45778 48% - # 45726 48% - mapcar 45722 48% - # 45721 48% next-single-property-change 35 0% + seq-min 9 0% make-closure 6 0% delq 40 0% + # 2 0% + # 1 0% + isearch-filter-visible 36 0% redisplay_internal (C function) 14 0% + pos-visible-in-window-group-p 2 0% + isearch-message 1 0% + window-max-chars-per-line 13620 14% + isearch-search 4 0% + isearch-message 27143 28% - isearch-del-char 13624 14% - isearch-update 13624 14% - isearch-lazy-highlight-new-loop 13624 14% - redisplay 13622 14% - timer-event-handler 13622 14% - apply 13622 14% - isearch-lazy-highlight-buffer-update 13622 14% - isearch-lazy-highlight-search 13622 14% - isearch-search-string 13622 14% - # 13622 14% - apply 13622 14% - search-within-boundaries 13602 14% - # 13584 14% - mapcar 13581 14% - # 13578 14% next-single-property-change 10 0% + seq-min 4 0% make-closure 2 0% delq 13 0% + # 2 0% redisplay_internal (C function) 13519 14% - isearch-search 13519 14% - isearch-search-string 13519 14% - # 13519 14% - apply 13519 14% - search-within-boundaries 13498 14% - # 13486 14% - mapcar 13485 14% - # 13482 14% next-single-property-change 5 0% make-closure 3 0% + seq-min 2 0% delq 12 0% + # 11 0% + isearch-forward 6 0% + isearch-abort 3 0% + dired-next-line 1 0% + dired-previous-line 7498 7% - timer-event-handler 7498 7% - apply 6849 7% - isearch-lazy-highlight-buffer-update 6837 7% - isearch-lazy-highlight-search 6831 7% - isearch-search-string 6810 7% - # 6810 7% - apply 6810 7% - search-within-boundaries 6802 7% - # 6793 7% - mapcar 6793 7% - # 6792 7% next-single-property-change 3 0% + seq-min 3 0% delq 1 0% make-closure 5 0% + # 15 0% + # 1 0% char-table-p 1 0% + isearch-search-fun 2 0% + isearch-filter-visible 9 0% + isearch-filter-visible 1 0% + internal--before-save-selected-window 638 0% + isearch-lazy-highlight-start 5 0% + jit-lock-stealth-fontify 3 0% + show-paren-function 3 0% + jit-lock-context--update 362 0% + redisplay_internal (C function) 62 0% Automatic GC 8 0% + tooltip-hide 2 0% + winner-save-old-configurations 2 0% + undo-auto--add-boundary 0 0% ... In GNU Emacs 31.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) of 2025-05-19 built on RTX Repository revision: b499898a5e6e27ecacfb6a60b22a2289afc589dd Repository branch: project System Description: Arch Linux Configured using: 'configure --prefix=/home/ergo/.local/ --with-mailutils --with-pgtk --with-modules --with-cairo --with-harfbuzz --with-native-compilation=aot '--program-transform-name=s/^ctags$/ctags.emacs/'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Elisp/l Minor modes in effect: windmove-mode: t global-auto-revert-mode: t recentf-mode: t electric-pair-mode: t whitespace-mode: t flyspell-mode: t completion-preview-mode: t diff-hl-margin-local-mode: t diff-hl-margin-mode: t diff-hl-mode: t global-corfu-mode: t corfu-mode: t fancy-compilation-mode: t winner-mode: t project-multi-mode: t gtags-mode: t repeat-mode: t xterm-mouse-mode: t tty-tip-mode: t xclip-mode: t override-global-mode: t save-place-mode: t delete-selection-mode: t savehist-mode: t global-display-fill-column-indicator-mode: t display-fill-column-indicator-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t which-key-mode: t tooltip-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /mnt/casa/gits/emacs_clones/gtags-mode/gtags-mode hides /home/ergo/.config/emacs/elpa/gtags-mode-1.8.6/gtags-mode /home/ergo/.config/emacs/elpa/transient-20250516.1031/transient hides /home/ergo/.local/share/emacs/31.0.50/lisp/transient Features: (shadow sort mail-extr emacsbug lisp-mnt windmove jka-compr find-func cl-print dired-subtree dired-hacks-utils dired-aux dash help-fns radix-tree mc-edit-lines mc-hide-unmatched-lines-mode mc-mark-more sgml-mode facemenu dom mc-cycle-cursors multiple-cursors-core advice comp comp-cstr warnings rect autorevert filenotify recentf tree-widget ffap thingatpt misearch multi-isearch tramp-cache time-stamp tramp-sh tramp trampver tramp-integration tramp-message tramp-compat shell pcomplete parse-time iso8601 format-spec tramp-loaddefs vc-git elec-pair whitespace flyspell-correct flyspell ispell completion-preview diff-hl-margin diff-hl-dired diff-hl log-view log-edit message sendmail yank-media puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader add-log pcvs-util vc-dir ewoc vc vc-dispatcher diff-mode track-changes corfu fancy-compilation compile text-property-search comint ansi-osc ansi-color comp-run comp-common winner cus-edit pp cus-start cus-load wid-edit project-multi-mode gtags-mode files-x xref project ring term/tmux term/xterm xterm init rx repeat cape compat use-package-ensure package browse-url xdg url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core cl-macs icons password-cache json subr-x map url-vars use-package-diminish xt-mouse tty-tip xclip edmacro kmacro byte-opt use-package-bind-key bind-key cl-extra help-mode simple-16-theme saveplace delsel savehist easy-mmode display-fill-column-indicator display-line-numbers diminish which-key cl-seq use-package-core cl-loaddefs cl-lib bytecomp byte-compile gv disp-table info arduino-cli-mode-autoloads auctex-autoloads tex-site avy-zap-autoloads avy-autoloads benchmark-init-autoloads bufferlo-autoloads caml-autoloads cape-autoloads clang-format-autoloads cobol-mode-autoloads compile-multi-autoloads compiler-explorer-autoloads corfu-autoloads crdt-autoloads csv-mode-autoloads d-mode-autoloads dape-autoloads deadgrep-autoloads debbugs-autoloads diff-hl-autoloads diminish-autoloads dired-sidebar-autoloads dired-subtree-autoloads dired-hacks-utils-autoloads dumb-jump-autoloads e2ansi-autoloads eglot-booster-autoloads emamux-autoloads eshell-toggle-autoloads esup-autoloads evil-collection-autoloads annalist-autoloads evil-leader-autoloads evil-autoloads face-explorer-autoloads fancy-compilation-autoloads flx-autoloads flymake-nasm-autoloads flymake-quickdef-autoloads flyspell-correct-autoloads git-commit-ts-mode-autoloads git-modes-autoloads git-timemachine-autoloads gnuplot-autoloads goto-chg-autoloads groovy-mode-autoloads gtags-mode-autoloads haskell-mode-autoloads highlight-indent-guides-autoloads i3wm-config-mode-autoloads ibuffer-sidebar-autoloads iedit-autoloads imenu-list-autoloads julia-ts-mode-autoloads julia-mode-autoloads languagetool-autoloads lice-autoloads lorem-ipsum-autoloads lua-mode-autoloads magit-autoloads magit-section-autoloads llama-autoloads move-dup-autoloads multiple-cursors-autoloads mutt-mode-autoloads nasm-mode-autoloads neotree-autoloads nftables-mode-autoloads nginx-mode-autoloads notmuch-autoloads objed-autoloads phi-search-autoloads pkgbuild-mode-autoloads plz-autoloads popup-autoloads protobuf-ts-mode-autoloads scopeline-autoloads shell-command+-autoloads slime-autoloads macrostep-autoloads sphinx-mode-autoloads f-autoloads s-autoloads dash-autoloads spinner-autoloads ssh-config-mode-autoloads string-inflection-autoloads sudo-edit-autoloads systemd-autoloads tmux-mode-autoloads transient-autoloads urgrep-autoloads vdiff-autoloads hydra-autoloads lv-autoloads vterm-toggle-autoloads vterm-autoloads vundo-autoloads with-editor-autoloads xclip-autoloads yasnippet-snippets-autoloads yasnippet-autoloads early-init rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty move-toolbar make-network-process tty-child-frames native-compile emacs) Memory information: ((conses 16 348255 236056) (symbols 48 21674 0) (strings 32 85000 11286) (string-bytes 1 2720636) (vectors 16 38169) (vector-slots 8 1104566 168128) (floats 8 143 137) (intervals 56 14651 3188) (buffers 1064 19)) From debbugs-submit-bounces@debbugs.gnu.org Wed May 21 02:34:12 2025 Received: (at submit) by debbugs.gnu.org; 21 May 2025 06:34:12 +0000 Received: from localhost ([127.0.0.1]:43237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uHd1o-00049s-3D for submit@debbugs.gnu.org; Wed, 21 May 2025 02:34:12 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54256) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uHd1i-00048w-Sl for submit@debbugs.gnu.org; Wed, 21 May 2025 02:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHd1d-0005Cv-4h for bug-gnu-emacs@gnu.org; Wed, 21 May 2025 02:34:01 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHd1b-0001Ct-4O for bug-gnu-emacs@gnu.org; Wed, 21 May 2025 02:34:00 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B2FE843FD9; Wed, 21 May 2025 06:33:53 +0000 (UTC) From: Juri Linkov To: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87y0uqyi0w.fsf@aol.com> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> Date: Wed, 21 May 2025 09:20:43 +0300 Message-ID: <87jz6abiyg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfeejucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrgh X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Ergus , 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) > I have been using dired and isearch in a directory with ~8000 files and > emacs became totally non-responsive. It freezed with every letter for > ~10 seconds. > > I checked my config and it seems that the problem is > `dired-isearch-filenames`. Any non-nil value produces this issue. When you customize `dired-isearch-filenames` to non-nil, it uses `next-single-property-change` to restrict matches to filenames. > I ran with the profiler and it showed that all the time is going in > `next-single-property-change` You can make it twice as quick by removing the property 'dired-symlink-filename' from 'dired-isearch-search-filenames'. From debbugs-submit-bounces@debbugs.gnu.org Wed May 21 08:39:16 2025 Received: (at 78520) by debbugs.gnu.org; 21 May 2025 12:39:16 +0000 Received: from localhost ([127.0.0.1]:46968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uHij5-0006vk-Po for submit@debbugs.gnu.org; Wed, 21 May 2025 08:39:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uHij1-0006v6-Iz for 78520@debbugs.gnu.org; Wed, 21 May 2025 08:39:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHiiv-0002mP-Ul; Wed, 21 May 2025 08:39:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Q2e8UPGy4RlOY1qI+t1bfPMah8kQ2XMbDu0ydV8SB2c=; b=SusjlcsNtidm vJv9M+uj3EaIr8vUA8H4xScqfu5fZh65XuB6FgBFK7II5bRVtEcNr9Z/IUYIkqtVMnYoXrLx20ng8 NQ/Kir/Pvr/ml+WQXD/so1ck2IKIBHpUvZB3XLwBHwXqlGkXar5XRXR5hMo3B7u0n30rPGf+SDdIx ad5U00ULdYiRv0RyL5qXT74j001YMZwaKAAHNlJnl867zeEMQOssznT8UW9IyfIemD4MTRnRvUYWy YvIgZbz1A86hniioRw7QCw4wD8aPfp7Hm7PaPLf7kg1OjIus3rQSPQ6z9feMpAxDzHUV2g0DhgCLw MAcXo4nhdxanX7PB81PssA==; Date: Wed, 21 May 2025 15:38:59 +0300 Message-Id: <8634cy87fg.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87jz6abiyg.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 21 May 2025 09:20:43 +0300) Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: spacibba@aol.com > From: Juri Linkov > Date: Wed, 21 May 2025 09:20:43 +0300 > > > I have been using dired and isearch in a directory with ~8000 files and > > emacs became totally non-responsive. It freezed with every letter for > > ~10 seconds. > > > > I checked my config and it seems that the problem is > > `dired-isearch-filenames`. Any non-nil value produces this issue. > > When you customize `dired-isearch-filenames` to non-nil, it uses > `next-single-property-change` to restrict matches to filenames. I guess this could be slow in a buffer with a lot of properties? Would it be possible to speed this up by searching as usual, but then rejecting matches whose positions don't have the 'filename' property? Or was this tried and found to be not faster? From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 02:46:10 2025 Received: (at 78520) by debbugs.gnu.org; 22 May 2025 06:46:11 +0000 Received: from localhost ([127.0.0.1]:59068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uHzgt-0007My-WC for submit@debbugs.gnu.org; Thu, 22 May 2025 02:46:10 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:49027) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uHzgq-0007LN-2H for 78520@debbugs.gnu.org; Thu, 22 May 2025 02:46:04 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D567C438E7; Thu, 22 May 2025 06:45:56 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <8634cy87fg.fsf@gnu.org> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> Date: Thu, 22 May 2025 09:33:20 +0300 Message-ID: <87cyc1yxyy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdehvdekucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > I have been using dired and isearch in a directory with ~8000 files and >> > emacs became totally non-responsive. It freezed with every letter for >> > ~10 seconds. >> > >> > I checked my config and it seems that the problem is >> > `dired-isearch-filenames`. Any non-nil value produces this issue. >> >> When you customize `dired-isearch-filenames` to non-nil, it uses >> `next-single-property-change` to restrict matches to filenames. > > I guess this could be slow in a buffer with a lot of properties? In a Dired buffer the property 'dired-filename' is almost on every line. > Would it be possible to speed this up by searching as usual, but then > rejecting matches whose positions don't have the 'filename' property? > Or was this tried and found to be not faster? The currently implementation was intended to be quite fast, and indeed when I try it on a dir with thousands of files, isearch-lazy-highlight takes only 1 sec, even with thousands of matches. But apparently on slower hardware it's more slow. So unless someone wants to make an effort to optimize the implementation more, IMHO this could be closed. From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 03:41:37 2025 Received: (at 78520) by debbugs.gnu.org; 22 May 2025 07:41:37 +0000 Received: from localhost ([127.0.0.1]:59383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI0Ya-0002kN-By for submit@debbugs.gnu.org; Thu, 22 May 2025 03:41:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35200) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI0YW-0002k9-En for 78520@debbugs.gnu.org; Thu, 22 May 2025 03:41:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI0YP-0008VR-Hx; Thu, 22 May 2025 03:41:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y+SOp1TyaW83/Po3DB34PmCUx8+q82LKT6Eh6wJVaN4=; b=DQDBOeCnq3jv Vqn5Z2a3FPxxf7utBjNyca2x5l7T+Bn0tczCkE3XMDTKBOic7bxXGBPBl+hQPQEhOLUWaSIN4zy7A nowMe9JWWYOy7ViAaGxovJ/3GSjZkTHWlYNqBb0taMfbsf+g/ltHFltfh0WU36hywVPodJ+2VUYxQ 8PEKAnSGj2b2tl3hnisEQbrnnze6iv9htRHtSA59jL9kAse71yqDdtShmj983buNov/LnQMb1IiNa XaFisjqB7L8+RpSee3+91mBx+9srPPeU+kaZt/HS0Vd1B8CKW4WVUnoxMPcFmdBYFFQMM6iJe6Mm6 3tL/zlnxN0rfVLOJt/m+Ew==; Date: Thu, 22 May 2025 10:41:21 +0300 Message-Id: <86frgx6qji.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87cyc1yxyy.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 22 May 2025 09:33:20 +0300) Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 78520@debbugs.gnu.org, spacibba@aol.com > Date: Thu, 22 May 2025 09:33:20 +0300 > > >> When you customize `dired-isearch-filenames` to non-nil, it uses > >> `next-single-property-change` to restrict matches to filenames. > > > > I guess this could be slow in a buffer with a lot of properties? > > In a Dired buffer the property 'dired-filename' is almost on every line. > > > Would it be possible to speed this up by searching as usual, but then > > rejecting matches whose positions don't have the 'filename' property? > > Or was this tried and found to be not faster? > > The currently implementation was intended to be quite fast, > and indeed when I try it on a dir with thousands of files, > isearch-lazy-highlight takes only 1 sec, even with thousands of matches. > But apparently on slower hardware it's more slow. I have fast hardware, but C-s for a match near the end of a Dired buffer showing 5K files takes about 9 sec. This is in an unoptimized build; an optimized build still takes 2.25 sec. I'm not sure why you are talking about isearch-lazy-highlight, that's not what the original report is about. C-s is slow even if I turn off isearch-lazy-highlight, and the profile below in that case still points to next-single-property-change as the hot spot. > So unless someone wants to make an effort to optimize the > implementation more, IMHO this could be closed. Does isearch.el have some infrastructure for examining a match and rejecting it if it doesn't meet some criteria? If so, can you point me to that infrastructure? Here's the profile I collected after turning off isearch-lazy-highlight: 621 87% - ... 618 87% - isearch-search 618 87% - condition-case 618 87% - let 618 87% - while 618 87% - setq 618 87% - isearch-search-string 618 87% - let* 618 87% - save-excursion 618 87% - funcall 618 87% - # 618 87% - apply 618 87% - search-within-boundaries 618 87% - let* 618 87% - while 311 43% - setq 311 43% - funcall 311 43% - # 311 43% - let 311 43% - if 311 43% - mapcar 308 43% - # 308 43% next-single-property-change 3 0% - function 3 0% - cconv-make-interpreted-closure 2 0% cconv-fv 1 0% macroexpand-all 307 43% - if 303 42% - setq 302 42% - funcall 299 42% - # 299 42% - let 298 42% - if 298 42% - mapcar 289 40% - # 289 40% next-single-property-change 8 1% - function 8 1% - cconv-make-interpreted-closure 3 0% - macroexpand-all 3 0% - macroexp--expand-all 3 0% - macroexp--all-forms 2 0% - macroexp--expand-all 2 0% - # 2 0% - macroexp--all-forms 2 0% - macroexp--expand-all 2 0% macroexp-macroexpand 3 0% - cconv-fv 2 0% mapcar 1 0% - cconv-analyze-form 1 0% - cconv--analyze-function 1 0% - mapcar 1 0% # 3 0% - # 2 0% - let 1 0% - funcall 1 0% re-search-forward 1 0% cond 4 0% - if 3 0% - progn 3 0% - if 2 0% goto-char 2 0% - completion-try-completion 2 0% - completion--nth-completion 2 0% - seq-some 2 0% - seq-do 2 0% - mapc 2 0% - # 2 0% - # 2 0% - eval 2 0% - let 2 0% - funcall 2 0% - # 1 0% - completion-pcm-try-completion 1 0% - completion-pcm--find-all-completions 1 0% - completion-pcm--all-completions 1 0% - all-completions 1 0% - # 1 0% - complete-with-action 1 0% all-completions 1 0% - completion-basic-try-completion 1 0% - try-completion 1 0% - # 1 0% - complete-with-action 1 0% try-completion 1 0% - funcall-interactively 1 0% - isearch-printing-char 1 0% - let 1 0% - if 1 0% - isearch-process-search-char 1 0% - let* 1 0% - isearch-process-search-string 1 0% - isearch-search-and-update 1 0% - isearch-update 1 0% - if 1 0% - progn 1 0% - if 1 0% - let 1 0% - setq 1 0% - pos-visible-in-window-group-p 1 0% pos-visible-in-window-p 68 9% Automatic GC 14 1% - command-execute 14 1% - call-interactively 14 1% - byte-code 14 1% - read-extended-command 14 1% - read-extended-command-1 14 1% - completing-read 14 1% - completing-read-default 14 1% - read-from-minibuffer 2 0% redisplay_internal (C function) 6 0% redisplay_internal (C function) From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 13:17:39 2025 Received: (at 78520) by debbugs.gnu.org; 22 May 2025 17:17:39 +0000 Received: from localhost ([127.0.0.1]:36983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI9Y2-0003kq-49 for submit@debbugs.gnu.org; Thu, 22 May 2025 13:17:39 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:32985) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI9Xw-0003jL-HT for 78520@debbugs.gnu.org; Thu, 22 May 2025 13:17:33 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 00DAA43A57; Thu, 22 May 2025 17:17:24 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <86frgx6qji.fsf@gnu.org> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> Date: Thu, 22 May 2025 19:58:07 +0300 Message-ID: <87ldqo8u4s.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdeiheegucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> The currently implementation was intended to be quite fast, >> and indeed when I try it on a dir with thousands of files, >> isearch-lazy-highlight takes only 1 sec, even with thousands of matches. >> But apparently on slower hardware it's more slow. > > I have fast hardware, but C-s for a match near the end of a Dired > buffer showing 5K files takes about 9 sec. This is in an unoptimized > build; an optimized build still takes 2.25 sec. I see the same in an optimized build: ~2 sec until isearch-lazy-count shows the number of matches (~5000). > I'm not sure why you are talking about isearch-lazy-highlight, that's > not what the original report is about. C-s is slow even if I turn off > isearch-lazy-highlight, and the profile below in that case still > points to next-single-property-change as the hot spot. I see no delay when isearch-lazy-highlight is disabled. >> So unless someone wants to make an effort to optimize the >> implementation more, IMHO this could be closed. > > Does isearch.el have some infrastructure for examining a match and > rejecting it if it doesn't meet some criteria? If so, can you point > me to that infrastructure? Everything is in 'search-within-boundaries' where 'next-fun' is a lambda from 'isearch-search-fun-in-text-property' that uses 'next-single-property-change'. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 03:08:47 2025 Received: (at 78520) by debbugs.gnu.org; 23 May 2025 07:08:47 +0000 Received: from localhost ([127.0.0.1]:44543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIMWN-0005Mg-39 for submit@debbugs.gnu.org; Fri, 23 May 2025 03:08:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57004) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIMWL-0005MK-A0 for 78520@debbugs.gnu.org; Fri, 23 May 2025 03:08:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIMWD-0003W5-5w; Fri, 23 May 2025 03:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HLOHGQ6ARtIOvNP3+X9KbZMN9qVdPvMecJryNiwe7+o=; b=pRAehOGWOPb2 Yq3sKp6mCmwMdtYripv2V+3p8WA3R7nygTbhvqOJR4gCTcy5k990jqeIJYnX8GlIPLhzHWABHoiW3 jlrBtsNh2RUBkFTby5ejsMX+K0++vK4L+xqYV55a+32FEkdbIqrU6+euKtfQ3ZAAO0R3iLiBrpTj7 1c9u7Fq6o/UJbEEUHd2gEEbrtSLlFZDUdpSMeXxsYHcntfJcu7TVlZJsw0bxDnc7BtCIL24+3Uh1p ZySOJkHkrXNVtLz2+N4piGyvNkOqRAHQbftFgg3dJRKAITmj4+Xw+hrEUwY1/oh0gQeh/sKw5JyxB /mUtpkA3vDw44daPGufqVw==; Date: Fri, 23 May 2025 10:08:33 +0300 Message-Id: <861psf6bym.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87ldqo8u4s.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 22 May 2025 19:58:07 +0300) Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 78520@debbugs.gnu.org, spacibba@aol.com > Date: Thu, 22 May 2025 19:58:07 +0300 > > >> So unless someone wants to make an effort to optimize the > >> implementation more, IMHO this could be closed. > > > > Does isearch.el have some infrastructure for examining a match and > > rejecting it if it doesn't meet some criteria? If so, can you point > > me to that infrastructure? > > Everything is in 'search-within-boundaries' where 'next-fun' > is a lambda from 'isearch-search-fun-in-text-property' > that uses 'next-single-property-change'. Thanks, but what I meant was whether the "normal" search that searches the entire text has a facility to examine and reject potential matches. isearch-search-fun-in-text-property looks only inside text that has a specified property, and that's not what I meant. I meant this idea: > Would it be possible to speed this up by searching as usual, but then > rejecting matches whose positions don't have the 'filename' property? > Or was this tried and found to be not faster? Here, "searching as usual" means searching the entire buffer text, not just its chunks that have a specific property. Do we have such infrastructure in isearch.el? From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 14:28:09 2025 Received: (at 78520) by debbugs.gnu.org; 23 May 2025 18:28:09 +0000 Received: from localhost ([127.0.0.1]:50448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIX7o-0002Vp-LH for submit@debbugs.gnu.org; Fri, 23 May 2025 14:28:08 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:46909) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIX7m-0002V1-7l for 78520@debbugs.gnu.org; Fri, 23 May 2025 14:28:06 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id A84D81FCEF; Fri, 23 May 2025 18:27:58 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <861psf6bym.fsf@gnu.org> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> Date: Fri, 23 May 2025 21:19:27 +0300 Message-ID: <877c27tck1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdelheejucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> So unless someone wants to make an effort to optimize the >> >> implementation more, IMHO this could be closed. >> > >> > Does isearch.el have some infrastructure for examining a match and >> > rejecting it if it doesn't meet some criteria? If so, can you point >> > me to that infrastructure? >> >> Everything is in 'search-within-boundaries' where 'next-fun' >> is a lambda from 'isearch-search-fun-in-text-property' >> that uses 'next-single-property-change'. > > Thanks, but what I meant was whether the "normal" search that searches > the entire text has a facility to examine and reject potential > matches. isearch-search-fun-in-text-property looks only inside text > that has a specified property, and that's not what I meant. I meant > this idea: > >> Would it be possible to speed this up by searching as usual, but then >> rejecting matches whose positions don't have the 'filename' property? >> Or was this tried and found to be not faster? > > Here, "searching as usual" means searching the entire buffer text, not > just its chunks that have a specific property. > > Do we have such infrastructure in isearch.el? To search the entire buffer text is possible by leaving uncustomized the default value nil of 'dired-isearch-filenames'. Or do you mean adding a new value to 'dired-isearch-filenames' that will use 'isearch-filter-predicate' removed in the commit 935cc4279568? Then one value will use the current implementation with 'isearch-search-fun-function'. And a new value will use the faster implementation with 'isearch-filter-predicate'. But I have no idea how to explain this difference in documentation. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 17:07:58 2025 Received: (at 78520) by debbugs.gnu.org; 23 May 2025 21:07:58 +0000 Received: from localhost ([127.0.0.1]:51568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIZcU-0006gO-3f for submit@debbugs.gnu.org; Fri, 23 May 2025 17:07:58 -0400 Received: from mout.web.de ([212.227.15.3]:37657) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIZcR-0006fg-FE for 78520@debbugs.gnu.org; Fri, 23 May 2025 17:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1748034464; x=1748639264; i=michael_heerdegen@web.de; bh=vr4ldVj+6i8SXMVxqjpGrWZPf+czOvuWrteFoYScge0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=fGHPcKZ96v07iUPqdEu3Wj4AF2q2fiyAvTRC1w6kUs6ItaHj3VM9+KyIL7qbhRwc pxhfIbG06evsI7q1g5CIbmwsHaLO+wT3Vx7hh81gVSvIIB22DxwsAcq+qRI/4j2Ad oSvFOLhKjRRnWX+9VlAP+YyRnqJ688eDcZKbljA5T4Mzbr/bU4x/ro6VdqwAQMkT6 5xC+PCkkHcUOVZ7d+RShmamGG5+DZvjgtjBhNdpmhhPsTHl2ATfD9Iv4arnt30QIL cyorQPCnKCvEzo8B65w/QobpYBso36tKIXGCzqCwTPS5JpToD7QIDHm/S5QEeoKvE EL2GoxLjny9CZXj1ag== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1My6lX-1v8upL1NMt-016DTF; Fri, 23 May 2025 23:07:44 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <861psf6bym.fsf@gnu.org> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> Date: Fri, 23 May 2025 23:09:25 +0200 Message-ID: <87y0unxce2.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:AmZSdZ1msw7oJF4opXKX7I9OS2Kw3LtwFc95l5wItVWRsahAa+K xMqZJsyEXMW+82aoYhjkp042yevWXQ0KqGGsWnpnygJI019e6J4+MePxmXjWVab/YPJQKIX r80tzFy34rm05ov0kjTdqtoxcgsrxZ3vEVuOeqOcfLKBiJXQ+46fm1sY5U4yqAOJuu+w9Q2 +3tMSex+H0fCJW2PKFzuw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ip10Kh4t5rA=;hLF2BKj9tEvpPW+uQkbte6Az8Bz DH1OplILUXpSpJc/axMHdTHn+b3Iz2SUYCjXWe2NzLx4YZdC4Al4b4qZhMBQvzxpQCtbVUfZF 37xD4GALNDwqSrIs4jSWPZoF+qW59I6ibC/eiXoNYA6d763syjH2aQZ/L2zsj6H+PJ/XoXMwl BcL6eBcEHRsYm++vXb/PKVfJNVr/LOIlTEZDB4IHOFrnvZkxRp3e08S6OHsxlSOS0/J2L1YYv GdfIAnRe8CpZlfpZHjd9mXUhbE7nBi2/20Jx6Q+6ImMsTYKYfcG1URw5epV5MUxkHNcuWnsrF 4lB+igBrFjF6x40R12c9ornogaBjH7P4KhfW3HtT+UceHvITqvddRu6iHUJEBI/6e8kxr0M4w 4QxQCLSGcJJeBxEDzrv+C6Qsb+hFKmI8JRC6eDAHzctGFHIsfUuvipCd5/n2gWqL2zY7c+MLZ 0Z3mM3FpFbc4BVeskhYZmVSJcmw3fUU3Eo4LRXTvI0TRkK3lt1sDC2jgbjBOOcaCSDL9aS0fg a0bLSzJZ0O3CTUF8u4CeA4re56vyEA1+BzQgFy7WKkXyTdil+0y5mOmxcU3L6PV+iC66PvuBb hxPFP7Y8+/9MqNySU/WnHiUD7DkTEiocY06sopH1E1JBTuzCxBTX36b16H/xxuzAnAV76dPB0 DlRCBYZ8/8VF4HMHJxAphGyjiwr95XwSNRf3r+WpibkI+o1lOP7S4eNQxucO1byYCqE1Wu8hj QUaSWn1sx1wleWH0llPbIaifXFMvH+ur6rDBqou3XyKoowkgkwutsXsyFhpkalKuWOnxdwA5F 8JCybBCmsZThgKEIelcX9uRVmPY3SEASXVEMNu9bvExv/x50uGHrQYdkEwEZnT3RSwWUjfz7K jWffhJq2MvcBGEnoQs+UcyUedxRLK6dUGIgL48rSeSAFVXhtQ2HOxVSAo/q7879tLheSmtrmQ n9Mi2h1QghAvhVD0GSvSCWPJ+wNcjX374CRbO66niYiPRkZXQQmev8jBqb3RS6xB2w0rv4RvB ETPjh+EoQBMicREtCwK4xtIMy3lfKRRefjdkKCVzIjprnGtao8PBHjEBCDDIjbC+UQtaoG24X ftYp7FUNTEglCLl/3u3L9bpRrVTlCQ9FEGV5xnB3y7rhPlHyKQ1/Og4PCcqFSv3gpsoohX80Z SAgb/P2ae14aobjyx6rDD2l0guhZbkSPOPIOLylzhSFzhHwyh7PGPx6YMWq8maa86hgipo/a0 WJFVUaUcnF/wEzZ3+uI6PvLEuBNw1IzIt67YJjx0/AHQKQK7Ehep2bMk3hTFm0xMHXXPW6l5m lllGdgF0ZvD0d3u6unDn9D1v51yBe0mx0d8slSsrtRwDtqK6p8LOoTAKZKkoHl8nl4ijVykTF IaYlarx4fJDQLa4VvaDOxZ68UENmx57KBjelDUkkUDj6avikN1c0izvJUVwOjdLU0JtjHEF5/ z5mPlmI6mOMpLwtR2C3VD+60Mr+oBtddy1klQxfaCBMpOu7SEwIidpLYhWDBXHYSks29TiTHN bDD7aZp/CEy/60xjxyj+jmSrhh4A4fUwqPIJ2H2RzmWTcru2y7KWQEBRNvQA6HuaK4Sn6nW+r nF4ukoeETizFZWlB4jnaq4mV2smngxyVWTlYaEAFfUNAoE+H7IdcLHs1Px8rXncJoHNGMhM3F TLcQDw3uDcXnvvP6FTQ3S5HPLtRhdZ1j6prwb8Sji+7LG3SVQgXSyh0cLls8UEB/tVEQIl71T /Aik+SGBjsi86C653kx0bQb657wru8hyS9oTnKyhm3b0J34pcXtOsRQpcUxaQ+1icUYHI0ytj gWJ17Enw2Ug55yRzYitFsJ03SLr3RjHsdmTQ2yL8NyOCoBdH4/nlxaEQtZuO0/I0a1CqhSRZH n/PC3d+LtNQGrZwlx6wlCQl3aUVTQ+tN9voU4tWTpaOZA3UpRoXk2FPT+6UUtWmxBW5QJQE81 /vxRrIpwH0EhfNlmENgbrmmv65QB9ciWF5CioIAvuxYzACZ16HTHVBwz2+7f12yQs8OaxqClK CJSwNabViiTe7XHdvRELaXZ288l3qu5ApumIvr0Iy9iWlfs5NR3+j3hbRvpnJJv4V64mCO0nV rLt0pdoDCzi5mc5MS+InC1T3sZCFYmlqQbv2Tnv4PRzsZh0cXWm8BX8nASMpioDYVWD17ssTO +EQieNSdY0qMwNGDcM2Y0l1Pehgmh0A0TKbXVK1Vj5vWB19ezFCRuiKxFPmYhVCuLv/WVZ4a0 5iScFh+Od+VYsd1qwOYLhsSbHxzrTI2xlZnUo6wEfhscwKwL4kkZ82yrz9ffteeJwrB+sOx6f ddA6TarQqeFC9QWNub916FUBgTUKP8fhk6nrWM3PxmE8VCm9g2N1PIkUmEir6a+i51ZInCZVh TrI3MDvZ1Elc1RGeodb/80wWKywgf6O3KsxUUjodhm95OAtOro2e24yNICd/RM+sTt8A8Ji+/ Na3VzszSy1BoezObqOE/3qecfC1utWXhPhUqLfG7gfF4sZYFiVuVd6MbRBzDfPiu17fjoQQWq tetBwhwNC0kS6yScyUdItwTTUcMdzOKeUumfSHxeGepUOOxE6/CoE5t8PXjoZjvBrcMqf4zIK M0AzwTMh/gtakmAGBfBX0/T08o+PzZ1Uzig5vMotKzWsI7rX+EKK+V9ctECDv5Z1slLksMr/N 8BVB7lHpxz+w4qluDhPFOLSFKr48OFHKfGoTksJt8f1Cq8Kxg7uJ6JYVHSllNTdBtiyqKre2I a5TcmNidt0qSios5h7YIMTfov/BAvPhPnmBu0YxoQL+6OAHTYu3SR4fXUqmma9DIYqodyECXo bTMYb2+f8i5mB9nnLKMhEN1zgCf3S/q1RE9JAyOBRg7IpnGJdkU4LXHVbz2J57BmnlU0yeihk NgTrn4Sr4xbU4OnFP4CyjjgKkAjmehkNev5xiOZGOwneYLZ1GXjrDb+zfn32Pp2GKbkNn55yY ovSUpQAmzctRMdP7q6fVu7+VKRerDfmTO7vbPK0yMx3LCtEke9CnnleR8/hbqWKPfuKqVuVoW QiUmfSR4wgkjpazgHl9KGyZvKV0vAWJZE4xXF1xMSZ8SzS7L5c7F1T7Wd0lf3KrNLWR09kxC+ rbZPpxWVz745kGzLrJMnotoPy5P8Xt7m8K X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > > Would it be possible to speed this up by searching as usual, but then > > rejecting matches whose positions don't have the 'filename' property? > > Or was this tried and found to be not faster? IIRC (and understand correctly): It had been tried and was faster, but: we then had dismissed this idea. One reason was that we wanted to make ^ and $ match the beginning and end of the file names when using regexp file name isearch. There were other reasons - lazy highlight, I don't recall. There were a few problems, you find it somewhere. The decision was not taken lightly - the result was just not convincing, and the problems not fixable in a sensible way. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 21:41:58 2025 Received: (at 78520) by debbugs.gnu.org; 24 May 2025 01:41:59 +0000 Received: from localhost ([127.0.0.1]:53650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIdte-0003N9-7L for submit@debbugs.gnu.org; Fri, 23 May 2025 21:41:58 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:12160) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIdtT-0003MN-Oo for 78520@debbugs.gnu.org; Fri, 23 May 2025 21:41:48 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54O1VuIo014534; Sat, 24 May 2025 01:41:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=6wWCMasaD3DGJSInpekboiMB4jiy+WKwn0Gv7pBmy4I=; b= KRMEGh9cZzTxq9NeL+nCECnjqh2p4N7WNu4CHp7jEuNxju9iUaHoJFAfhYmlEdyh CWdjKO9GWclj0VJwEq5iPOEBGxkWMWBq9hZldalZ2rKWJIKfJ3Z17Sgu5fKATsQL sbgz7DF8rhXBJp3Q7ijs0eRiIpcssN/Z9zxpXkoxd4NZBkQAlfEqVPn08Mvt2eTX Mal/EoC7xzSUfcgaNuWWbpEETegts6JN0h4GKm1pZuezPCSO0F23mgXJ1wEWwUd6 Lkgjvz0S9u4wrVvJd2mSfCAD3i/DbGsaVVyEhOPISNyxggJlIyjdp8sfWpUkg3ml 0Xv3o2+RBjKdHIuchkTVQA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46u4hdr03y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 May 2025 01:41:44 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54O1Xikb024449; Sat, 24 May 2025 01:41:44 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10on2063.outbound.protection.outlook.com [40.107.93.63]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46u4j68411-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 May 2025 01:41:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vnP9mVCasiTMQ0nClqiZYJHWkW02EKlMQxQ7xOun57DvQwzMZ2dtYIDf5UFrN7vpqGvoG16e/YcSPHVkmelVEqokKqy80X64Yzwu9G5mz9UoKQ5xDwtresM/0aVxG0lmqf2PVStgWJD890IezzaX97PngNOysyN/cHVElZ7LN7dqkHfRjRmN/FvvdJrC4VVR4fGykbNucUXr5j2PHaILbX7SE4dUT0jZHccq/T6AQXFZlvRGpdEXfjV2Mgpocnq+ymJpAnUk2TIRuxZVErZ3MiBonGUYI7lkgX5yxiuOQiaWJ2OPG47z+MFMXxkbz2z9ZZBHhgMSdUV71iyPr2BH9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6wWCMasaD3DGJSInpekboiMB4jiy+WKwn0Gv7pBmy4I=; b=ZeJIuG/uFX5zOAfOgic15Rck3x8er5A98RoOnxa+vGoHRPRe2N343Sn9F33/K9Lr9WxLxaQHv43hW9hVHiHJ4IWkciU2hvrJnZZOM+DhMnU6CTADMC88SPL6sb3SMDc1mlC5Amr2rgNEoaSC1Zf/RBKdOYVT00lku0h6jMuI7ESYE2DUsbdUM6sH8rRgiGWK4zf+/6K2bWyM7rzrsmBhIt+j0XBhVvw1vrUAUnFRIwkYgb+2Rx2+7qx1EUW1ie9L3UNpV+cObP2T1zcH8TUtv19MDJCwbMw3ZyFShG7GOkXmvvAS3RkBCUkXGZqmpaVbJUNA1S9JwhvJVCVrFKuMNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wWCMasaD3DGJSInpekboiMB4jiy+WKwn0Gv7pBmy4I=; b=aC2iCt3eVcQOX5YGY0VuJJ1z5lP3uwfhcrh0dbrXc2EbNJnZT+ONcte+NolOCMyr4ZCjOr69PkK36SS3LCCDYN+3kg8zQlwAi6dYMpGe5Va8l9lL0Oeh4diSHftEwXng6YLIfKRhLAN1ztagV0ZFUA37mhuB3Ao074jgWmZrJ+Y= Received: from BLAPR10MB5219.namprd10.prod.outlook.com (2603:10b6:208:321::22) by IA1PR10MB7446.namprd10.prod.outlook.com (2603:10b6:208:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Sat, 24 May 2025 01:41:41 +0000 Received: from BLAPR10MB5219.namprd10.prod.outlook.com ([fe80::8179:21ba:b158:7d50]) by BLAPR10MB5219.namprd10.prod.outlook.com ([fe80::8179:21ba:b158:7d50%6]) with mapi id 15.20.8746.031; Sat, 24 May 2025 01:41:39 +0000 From: Drew Adams To: Michael Heerdegen , Eli Zaretskii Subject: RE: [External] : bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames Thread-Topic: [External] : bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames Thread-Index: AQHbzCbm3Dps1Wp8f0izF9N7GEi6hLPgu3vw Date: Sat, 24 May 2025 01:41:38 +0000 Message-ID: References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> In-Reply-To: <87y0unxce2.fsf@web.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5219:EE_|IA1PR10MB7446:EE_ x-ms-office365-filtering-correlation-id: fe2fc369-4348-4e6a-288f-08dd9a642097 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?F+QbRQDg9l824JUhf/Iz9uTfEfgt+1m91z08sOjp4dp7a/YBk5tKo1npa3bU?= =?us-ascii?Q?aoJp7xjweuXTwpPC25e6nBZLT5GU0JY9N/iWyPg4hog2Cr0Vf3oNSd67oEgU?= =?us-ascii?Q?pWnJ9N1lORhWRwPJVL48mdtPg7tPXLRVLZzrPIujX6npyAQ0xD+mm7IOEVb0?= =?us-ascii?Q?mrm7RpjeA3c6rx/hYmixFXUmBomxFaZEgxuGIE18qvDks63nAK/4JGqxFwiU?= =?us-ascii?Q?7ookAoDVOXtOKE5PokfyBJWN0hiwXCcw8Yeni4Bdar3dI16sXL/QE19YlNHN?= =?us-ascii?Q?y5TQgc3YmJhBPAEZOyn/4CTuzAUVENpWfNp8BCQ6ckoc9CDLQKmllMZW/TzW?= =?us-ascii?Q?b6YybpkseLGxNBfNXJQuj2ixCX8a8UXqIuGPUzU/ytgMmWVH8Q2tnqiWGrVZ?= =?us-ascii?Q?3xDyCRzLPoGyBkfhtnuLMQEIS0v0pNR1bTQSYNhWO6AxV+Gi67u8h/hXKN9o?= =?us-ascii?Q?Ht3CNS/ZfD6zcHYmBFOx2j1gDZVjVUugj240ss9AC9GXY8FMz+wt4H3J/2MY?= =?us-ascii?Q?8ja1yAT0LoWbgKc/HRW/Qgno/RJRj36t+F5/kd86rg+8/yLlAZTkHFfIoI12?= =?us-ascii?Q?UJmgaNUlJS0eR01gmU5asU3gRscDNKR624UzR2+JC83YRANOAQhxbY+yZEPL?= =?us-ascii?Q?xEAfTnZK2RKXR3qFjKicYW02LuYxroKdQKvAN9ixEL83QTAfdvHd70w4UOxV?= =?us-ascii?Q?rdMZLzs0DqnfdaPlKh/oaI2YVnh//mHnkpINWnhawUETo4Wp2H9LcIrIfhcJ?= =?us-ascii?Q?PPes1n8zFQziwcVmdeh3NZI3O1nuIwVNZ9q9+h4BxaJzTJfKrdFlohFy5xW2?= =?us-ascii?Q?jeRTgtllH6nrW/KGYQQlti2I4vOb/wfewpTpOOneOS1BBbnEeE6nQFUccYgQ?= =?us-ascii?Q?A2iL0YgQ4s2mfSP2efUWD+WUoMBrWXOW7dXV93hjXA+6a3BZNe8wx+Qjn7us?= =?us-ascii?Q?SqBYV3U/13yKwahnZgZV6h1ejo7qB9Z7/KjFuQ5Xu2d3EGiY1VATzSGIXPLN?= =?us-ascii?Q?6/PHVQordWgR1YHWB8Hrb+RFi/4bjJXLB4GhqVcdznJCNsOU73JmDnXlkCCG?= =?us-ascii?Q?MT7pxf8b5EbjZXjsr0jGgU18xDnsv6xiw1htDibbYQSe3LDQvqmdr28xLvGJ?= =?us-ascii?Q?eqUj3nDzhkzmAZbaK3D1lKyqHiA65WCLDHQZMrHV5FS3TLqLnhdQ43PC8KeX?= =?us-ascii?Q?OcWeS7x2pbIwgDHwz1sxwDSvk7FntqHeAhJN62raYek0RkkJ0dF+TsnvUKFs?= =?us-ascii?Q?2u2fCR29Mrtf0LODFWG87IJSdAZwSavb5CyU3KwzrHZgBl0qgt58nOya7rge?= =?us-ascii?Q?a09Ak/G2yComR7CA+O20NPbSKuno79mctoxofYIWUtbdJh2F4UCZkE1AUYNk?= =?us-ascii?Q?VUdnN/N0xxEROlbMeGIjy64dfKLYdOXmH/PmL6yy6ICyA3afJKDNlrb8ohsQ?= =?us-ascii?Q?qVs+/Lt+rZonnHz8qOwKYaYSVycJy7At20gTHMWjRkfVXXadbHUngJnEvf+X?= =?us-ascii?Q?VE0LqVCbIr4wcXg=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5219.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TSV5atNKKjDrC17KRc5KO5EB7Ts/0WFSlRAk0da2VA0EIxaUSRdu+BKmfoou?= =?us-ascii?Q?eSg1jKT0BpGguSIBh+cIScvB0r+tk+gqCmkpWwS6Wa+GDq/tHE1yeAPd6swo?= =?us-ascii?Q?y941Fy00wvUoKbYi+KBrzLiQYXLyoRqFJHHJM9aOMiH/oZv09EyDCAxqwvuD?= =?us-ascii?Q?CocvatPbhSdS5wQP+Y89/1giDG+wFlNCtXmpgMC8go6yHCr/JLBFbiJnt+uB?= =?us-ascii?Q?KKK1uYn0w/iQe+80fx7Jdxulavijp9/pmZYZcrfFudmOmSpEjUyOfOMYEbxX?= =?us-ascii?Q?CQ8VrYFGLgk9+1oXiOfvEMlFnFwPt4xno+R1JzLVofpurw1Ljt4SBCrHu9Ct?= =?us-ascii?Q?6Ees315iFQ5xhWtRf5g91iwaZxUvSjN6vhrDHL9Hcm8/uqfb1D1skViYoqID?= =?us-ascii?Q?UFBhT070DCa1lT6CLTkyEcvTm4Q5TdtPGa5CjmYQ7e9xI8E5XcPoQm+CWzUs?= =?us-ascii?Q?TOpNZAcAdCi+Ldx3VTDmrG3VBjLz2fex3S0G0tG9Ew7+73uoYSXsYmlrvrHq?= =?us-ascii?Q?ECyBkyEjNIodln/U3e7fheDHOS0263WurxcvMOjCcEdDaNAiw/YJWGoRLLWY?= =?us-ascii?Q?OhN1x1qDKJR3E8JngLSXqqPhQg2DKv4PysTDBy+P+/TaxVBth6TPGdVGcIAC?= =?us-ascii?Q?lGJXZqE+vkG0xBmmD3cmcDRldru+HeIhTNI6QRH/sn5BtSAgVGR24Crb5PoH?= =?us-ascii?Q?24wSTJgAABsz6HvtCeX77HvNEiq9Z1Urve5ac31fxekvyodw2WD2d/YgWjJY?= =?us-ascii?Q?HlN4/pR0FZE2+ENA33WrREOkpqch8vBVowE9t1dwR0p+RKx/q7MHBO9DcwnJ?= =?us-ascii?Q?XEx68dsIruwpwhElOfWXr5Lih/r32LHcjQi4S8HaO1x6WTMYqtzT4fvlrrDd?= =?us-ascii?Q?+Y9nH4SovIpnbmoW0jpe3PCy2JWohluq4PkFZcHYRWL1BBkZJUlWpBVOJ9fk?= =?us-ascii?Q?yJx41Ty8+pY7EwaTG1X1EWXVdR4qF8MYSU4KZ4JFJFQEsSWNvkqld6GA6ayZ?= =?us-ascii?Q?QPqfM8k+aXQXhg5fKsTnnE/0Sy4HXGeeHA5ZlpAyZ89Wkj8Wu07GTj+eX8hO?= =?us-ascii?Q?LuENTasWD6zqwH9t2Fypjiyyt1JPle1QzMYXYhwqjl/kuxMqNeIcBwsUQKGf?= =?us-ascii?Q?OJYmdAMCy3RfMs72gFY7M/l3mQ0K4GgnucwAmQFajARSpDeb+9vNDfSyDqrG?= =?us-ascii?Q?qOIxLqRSfe01FsdQhslVoeBiIV1Kh1WfUxFKPDCo8WizWf5Ks451ZCDn7W1Z?= =?us-ascii?Q?tFf/zksxeVixTGgb64lH7e20xF6KYIymLT+Iv1yhyW11bt6o7RjMNOcFI/Id?= =?us-ascii?Q?ejwzeDZ/R0JYLPdjMUM5LgyOK5Gk7WAYflM8hg1bqx+wOLUKHuX1ZsjRoiiG?= =?us-ascii?Q?rjH5Nw7x1UU0Q/bdrT8uvYdL7t5ZBXHeoRj2Emra1gXiexBL9NwZMjPFLnzr?= =?us-ascii?Q?5f7FT9p/5bs/hBNLqfItnxopeeTREEaWRsIMmrGqzGk7WGHnhMKyPaZUlgP+?= =?us-ascii?Q?1dFy74vACsYSLcn613eFB6jjScZUz5pbz9t1NnITdwykmatO5t8YZUaiIFSv?= =?us-ascii?Q?3i7YQR3Kud62jRyAzcORxZalOoBcgoKS7svYbW82?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QFfd9/UPF1G58wbc+kdN6i/XTZa98GRbnAk7u3uZst5Bmm6BnbCgf/r6MFLr/JQBEEHft8nxMNR/LPDh09WiVIbMfVpRWUqZq1VxA3tS8rJSDaIKuszlz3rnB0wEuaA3TO+6Q1mgJwXyV8EZR0aWKwPqwqM2XSnRcQq9ZHouYCrDFu1SYhFRSTFB79ECa9iopeur+8ndiLpoux/DJiqFsGKNQfQ2dgi0dlmV03qU6Z6a+1Me1/a6nx1EhOAOCgcSMhte8yHBGfbXmG+fQ3hPxNS8Ldmqs4vu9j7sNRAb9tKcoPKrZqHiiV+E9H6tc/V0qeiXz6nM9lRr5NvG3FUPmEOL54NdlRGamkr1n70iSePyI80KY0/BKQhIqXnXJ5nvODGJCRv8cHs20Ns0bEREwxUaQoWoPnpnd+vZQK6ki7wUUiYGTu3Zqa0eEy4hCBWRRGvZDjfUAA9TGdAWynERz/kWOAekJciAHhhn9McQyOtrbaTQFrWqZPZYkqvcfhKhBfVAt34hZTPWizUaCPTs4EBFsX/FyngY7LByA3r3BsAhQYxkhZgS/uOKbLblIEpCQW4GaMO83RxqWxHWm1wZqvpW3415yJyzUFfjP+UaxOQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5219.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe2fc369-4348-4e6a-288f-08dd9a642097 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2025 01:41:39.0640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kj11Cm8AjCd6WHu+5qhkUFfKq61HOFA79rtD0dfKB9nIqmwtiiqn902TPUzTSlEJzOtEk3Cmwh157I9BkDrGVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7446 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-24_01,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2505240014 X-Authority-Analysis: v=2.4 cv=FugF/3rq c=1 sm=1 tr=0 ts=683123d8 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=WeVmKNwRYAYrVBOFrVAA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13206 X-Proofpoint-ORIG-GUID: 4vhYtGXYKrZK2CFEVshwBOQhiZPW41vK X-Proofpoint-GUID: 4vhYtGXYKrZK2CFEVshwBOQhiZPW41vK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI0MDAxNSBTYWx0ZWRfX2UWwBpIuulmY eomJgrG+8o0e3myb09aZf611FKnOmJE4XyHpguwu8SC8cn578B3pQ0AI8t+T7Ow6ZWV7xniESLg HX7iBnXCwc0CF3u93wwN7WFIGnpblG+30EgK+dtpKGKXcJNXeyiSnHCiIlAra4Yft404lnsSDHI 2jdrrKoffWreKrhybE0XKNygEGX6ZweOUs1EoB7UoRCEyfTioifNIdXfvw4lN7nSDtZhuqPtEWt rHYZySEBx9tzboON7OUPwJ6av2sAR7u939mI51jJ1+TZjt8n4sVP1KH96ymoOfimwzDTsl/xLyE lWbYmK+WWwwkBrRYNieDq9HrMfVE4GSgWXF2l35yM2Gqd8VQMmSOOpznpW/L6He1atLWE/aBZnc o1i7r9r0l/wL0pPFrtWI+4d3I0gKnTZVUuT6xulN2qhvsJVCDmBrHKcAEJBhgvNhVgKxWNYW X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: "spacibba@aol.com" , "78520@debbugs.gnu.org" <78520@debbugs.gnu.org>, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > > Would it be possible to speed this up by searching as usual, but then > > > rejecting matches whose positions don't have the 'filename' property? > > > Or was this tried and found to be not faster? >=20 > IIRC (and understand correctly): It had been tried and was faster, but: > we then had dismissed this idea. One reason was that we wanted to make > ^ and $ match the beginning and end of the file names when using regexp > file name isearch. There were other reasons - lazy highlight, I don't > recall. There were a few problems, you find it somewhere. The decision > was not taken lightly - the result was just not convincing, and the > problems not fixable in a sensible way. Caveat: I rarely use `dired-isearch-filenames', and I've nothing to say about improving performance of that command. But wrt searching filenames in Dired it might sometimes be appropriate to divide the search space (listing(s) in the buffer), by using narrowings or `occur', before using `dired-isearch-filenames' (or even plain Isearch). From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 03:56:25 2025 Received: (at 78520) by debbugs.gnu.org; 24 May 2025 07:56:25 +0000 Received: from localhost ([127.0.0.1]:56391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIjk0-0007e1-RO for submit@debbugs.gnu.org; Sat, 24 May 2025 03:56:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38050) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIjjy-0007dZ-9P; Sat, 24 May 2025 03:56:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIjjr-0001EJ-M1; Sat, 24 May 2025 03:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mYkvTSmAxrD8D80dNsuoSYyy2LxeV7kCNh9l84yEeFI=; b=pzJQhFOOATtS wcGzJM28SXMULzoVtuhIT+oh5AdlROWESuK2J3NHxVpBgxueUkQvmX+/0mai23ZtXz1vIsirf/mhI C6b6f9cpF003e5NwHoLae/RRouIkzMgQycJgYhC9YPuNRD/DXcp9Ce/jWy05yJOYA3jg/OPGiLveM 33wdDbGs6xSZ1TA4KroUP0ncS8t+/+wEAMZ3aAV2Y4ao/WRzXatM3qM+Upim4Vo0OkFBo/NuQyAL1 0dI7i1bLd8toZO3BmwrBNe5KSIY00WCBP+nk+yDuvPRKQEODC+Nwzc5EjiMpZ7hokOotRhQ4p1ZXE ZH/BBEvcZFwUc+KqSkE8CA==; Date: Sat, 24 May 2025 10:56:13 +0300 Message-Id: <861pse4f36.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87y0unxce2.fsf@web.de> (message from Michael Heerdegen on Fri, 23 May 2025 23:09:25 +0200) Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 78520 wontfix close 78520 thanks > From: Michael Heerdegen > Cc: Juri Linkov , spacibba@aol.com, 78520@debbugs.gnu.org > Date: Fri, 23 May 2025 23:09:25 +0200 > > Eli Zaretskii writes: > > > > Would it be possible to speed this up by searching as usual, but then > > > rejecting matches whose positions don't have the 'filename' property? > > > Or was this tried and found to be not faster? > > IIRC (and understand correctly): It had been tried and was faster, but: > we then had dismissed this idea. One reason was that we wanted to make > ^ and $ match the beginning and end of the file names when using regexp > file name isearch. There were other reasons - lazy highlight, I don't > recall. There were a few problems, you find it somewhere. The decision > was not taken lightly - the result was just not convincing, and the > problems not fixable in a sensible way. Thanks. I guess this means users of this feature will have to live with the slowdown. I'm therefore closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 13:36:38 2025 Received: (at 78520) by debbugs.gnu.org; 24 May 2025 17:36:38 +0000 Received: from localhost ([127.0.0.1]:35031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIsnW-0003qn-30 for submit@debbugs.gnu.org; Sat, 24 May 2025 13:36:38 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:17000) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIsnT-0003qQ-HI for 78520@debbugs.gnu.org; Sat, 24 May 2025 13:36:36 -0400 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54OGZJXu009228; Sat, 24 May 2025 17:36:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=89s0eDSVaRDlvaNl5yqbu34MAPwYfjh4qFOJL8cHiQs=; b= ihiQYBLdPUG58iskY1MKnxa6FRphZUhqOt6m4YAMQod5ng2G0hKB7+gE80M+oPxI J1jepY5P8tq9C6Z1krmzetYxDLZRN21rHBUDJOsnqZyQGFSZv+8vHqTa//+io00K jy2uG7dIXWy85Yihus9C1AVUOqlaJoZWr0d/fylPtxJctXhq14Dak2GzA/CMhBmu MMPvUvT9SgnOhObV5s4KeCoii6VrOHlbtJrHqSBlgSobpWgiKO25v8+YuwKhMeIz vcigxgmEGGMuveFQVHLrrH0Cf2i3t/ZFWfUN3350tdI3GeUl14StuIZawfaRmYI3 fk8uV0es6c5mWGL0U3es/w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46ufm1r3xr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 May 2025 17:36:33 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54OCGTC9028359; Sat, 24 May 2025 17:36:32 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2075.outbound.protection.outlook.com [40.107.94.75]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46u4j6gtw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 May 2025 17:36:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QBAgNi8+6YLFHauW2WhcwPWfHi5f9pe9AtcZFiJvXAo3kH/ZEmEqWhCIkvuu53wbQQsO9S4gmjBScci4d/OWhtgqWUtWEDrsER0dhvCtmXTEMVSvT2jxuyLmPBBZE9lZgXgdIE2Lr5Qir2VgYkyZuWpNcZkjs8LLwbjnohy1Mhhqc8LNxHeK0OA/qwDvnna7OmE9I39pELUI9KCoW52/ZcUe3LajwY2Y5ZH1xHnFVJvnZ+FSBrFceqiKpFPc0JqKZMo1shvgNGbha8VQTYGsNjgfATFEJwFKbUVXYcDais/KahGsN04uUHmI/UU0XrUvci6DfsR1uM+LXdzaF3yqNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=89s0eDSVaRDlvaNl5yqbu34MAPwYfjh4qFOJL8cHiQs=; b=wOSX57huKYqpH4icH/rZ86+pfjmubWOCij8es9NGPMiO2xbE2jcUeRsUqMhJpOq6K3GCLktEglAh+qaod+EAXHtu+JSstdDvyABgDpv3lDi9J66qeu9CNn6HzekfKWHp7m7mXdR2wm8cqXikp5mEiL2f7gRyN4MzW6IfGERnks5Ybc+9ON0agL0pGCTh/9CgubOYiINa4BCNRU/CThFzDIX7v1Dz5aabyvCGLQSJIlAqdlpoNH/hZF518BQltXv6Ye/vdMLcWq6NfLzhF809/rnKq4ahsyKrh2vI8b334bZj6WrDTvwjfCFeQlg8lOki/3R6u4ep6soqkn78rpNqKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89s0eDSVaRDlvaNl5yqbu34MAPwYfjh4qFOJL8cHiQs=; b=PqJ8of4XPcIjSci3Lrw+VVWKEcsIFis8crJOtgBlj1pZwjukk7BpYtWkXFjW1XaoKrixING+2ED1dDfsg01n5jZ2Hy7baorrjFT48tQs9elkGjeNUs9F/dxNOGp1SlVITKesEE7YNwcPGRdbLOPGRaGk+zASeSdC0LWw8wDRzMU= Received: from BLAPR10MB5219.namprd10.prod.outlook.com (2603:10b6:208:321::22) by SA2PR10MB4425.namprd10.prod.outlook.com (2603:10b6:806:11b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Sat, 24 May 2025 17:36:29 +0000 Received: from BLAPR10MB5219.namprd10.prod.outlook.com ([fe80::8179:21ba:b158:7d50]) by BLAPR10MB5219.namprd10.prod.outlook.com ([fe80::8179:21ba:b158:7d50%6]) with mapi id 15.20.8746.031; Sat, 24 May 2025 17:36:28 +0000 From: Drew Adams To: Drew Adams , Michael Heerdegen , Eli Zaretskii Subject: RE: [External] : bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames Thread-Topic: [External] : bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames Thread-Index: AQHbzCbm3Dps1Wp8f0izF9N7GEi6hLPgu3vwgAFQSBA= Date: Sat, 24 May 2025 17:36:28 +0000 Message-ID: References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5219:EE_|SA2PR10MB4425:EE_ x-ms-office365-filtering-correlation-id: 7e07485d-b738-4f1d-f50f-08dd9ae983fa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?BRCEPJ5ma/s1cWLpT+8SqOWY5LQucQzT/DhzfKWRndB26hckfR4L+iRKr74i?= =?us-ascii?Q?/9Z/t8tJeQyyz/ZtUIuM0EWqkw5q5fZNUllaKlYe66Fi2ezXgANrp0vJhDT1?= =?us-ascii?Q?oPXHMM9jMJIhjbeF9UGZZ/PO+i2rOF4iNugsPiZDn9vb1xbc+aHhP9HIPPPu?= =?us-ascii?Q?FZl2919WmguK2IYFtVJKGJdPz4HFCJqIMyweEhkDWvTG+Q1RJQ4KYkWel81h?= =?us-ascii?Q?GFtfrxq+5VEQKqEjXR9oZAZ6tppopBpGpNcCNQJF8Ny/bzumkT8tjVG9qzaO?= =?us-ascii?Q?90zJ2Yuz1ZhtPY34bvoKssthNa5V1GXFvLD85pf7537ld49ZmLeP6oCCkpii?= =?us-ascii?Q?rZp9eL+xsdLfzegJX/o+943VpHxn+sdVSs9MKQW20wVD8LT9FRbl/oUXaSHn?= =?us-ascii?Q?b/1CrrkQBNP50hVnqZ1x/1XAzLKpzwNOuXNEtCS2D2yGNXUgml8JWd/8W15k?= =?us-ascii?Q?lapTklVQ0ULbbcCBngNUEZW/qM9vVxCailyroX6eXJAvnjageByrq7P/61Bp?= =?us-ascii?Q?ylv4+cTxcTDa+3WctkPTI7m928BXoMJO0QvANUomPt+cZ3Pxr0TYUXKtv+iQ?= =?us-ascii?Q?Pkm8xc773Rq0eHE+g5raSi30Bvu0gH6bQ/SeZXg2SLb7K0rjDAbnJI4nll9g?= =?us-ascii?Q?X+2HTdevlj+egscgO/dbBKnF0SBwNIBKsx5dLBcydBBfL8XMfi9CWu4+Xsvn?= =?us-ascii?Q?Bbec5GAJUezVrRUhhn4OS5E1aZbU3YRMCcAv6bHcbLj9hUjsI1ElAabspIMJ?= =?us-ascii?Q?jx7pZS1GXFIVC5W9d7ceEctf0oITaUGrUqNKK3kfH2NCnZaLSLFySe60euIT?= =?us-ascii?Q?f0izeyNLzPgqIvX3kkjHoH1hz42YJh1a9xHMuPYAw1qWthIG9hW6NEzb0sKp?= =?us-ascii?Q?gOl+6cMEwYj1jHtkY3JgcLLpsZm0gPSNHnwdcAnAwe1VDzhWMdEfD56qcfz4?= =?us-ascii?Q?iHXuim/GWmuPYKb6bamB3kYw+d+jis17tgMGXTM4eC/WcTVtZemFLf2SXXWZ?= =?us-ascii?Q?7dFGMSKQT6H5D4Hysu2NkpSBDHkAOmtFwrHPgehCOj4unymvKKPvSJhfpOGi?= =?us-ascii?Q?QTdiRY8e5iuqiGIaYxXCozAIul8vT4nQp5oeXVqdveG6NjhF7qxFCiWk0RNu?= =?us-ascii?Q?QYKfnDLO1F1JbuYnmJSeXSaoBNfKHe8C3LeURU9R/iVNKZ7wmM6sjV91GLql?= =?us-ascii?Q?E6gShKPyHFZ04EEumKXbbf7VqY+/1AgYUBUgeay/6q3/pkZAhwTc3GAJp97+?= =?us-ascii?Q?CfWxhvkaXYKW7+54euVlXsGec/MJiZkTzDy3fD2wVP+thj5RPNim+9zElT2z?= =?us-ascii?Q?auALEwWkB177iZXpJxypKSfai4EegPcpbAcjRdoPZuVGQs8bFJQiSv4paE05?= =?us-ascii?Q?OJy+uxwUon+kpcdi69o7aiNSXvACI4sTfIqkwQMOvki1yA0zg5BFk3zw8OqP?= =?us-ascii?Q?uHTm0Xj3hx3sRFA/5AZ39oyZ9zQy6RJ9O3tKzUbk+u7VkdIZvUjJ+7zWBssr?= =?us-ascii?Q?LEShxrJzedgz3/Q=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5219.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3/ceQ9bz1C2i5V5vEzSUpvtBzLMYXgj6f3SRchwgTbhm4WxBynk7O/HbRuad?= =?us-ascii?Q?xGr3iU93bJGZI7xO36STUqUL2/I7aseyXtGAuLGbBSxsjFjlgGDbZRdhpbxp?= =?us-ascii?Q?0qdMHoCAAIY4m2CLs5DFofPCaodtttRUADE7rUgtXN5qPmVFDYUG/F7R8XlE?= =?us-ascii?Q?+UyvFCq/q02RMPZS116hKSta3DhddkvN9R5k+qZR8amgQw4EDkz99MWJbCuR?= =?us-ascii?Q?5K/gsTL3qAHrR4kksMmEKB9zCO5q3zgcEcNsWwcnNxTu/CP0REAr2xTi7a2x?= =?us-ascii?Q?ZX4Mg77GiA4Vvz2d3pnOwzFnONtKAB9JohLHANhSx+NgSOqXVu5z3P0pxlIK?= =?us-ascii?Q?qPaf0VmbSGPHy2PKp7qZxlNpl2RWmO4cPjuMeOd8QWHeY/8vNKuR5WlbZKve?= =?us-ascii?Q?Gvqh2NaF7AEcld66ZRVgmPP3+qdn9w4iZdhRSBAF0hrG4abzbUY9Vkg3V+9y?= =?us-ascii?Q?XJW5y/RdcKfVah94/aoBKLhSZS9XYr9l4Ly0f6/ND3f9xsBgK5YVuUOxsu/T?= =?us-ascii?Q?dECTQl/Cyhv5tOljq0YwovePAuBz4QQj/NmBgiNrlpMIhGEJA/XMkwVugUnu?= =?us-ascii?Q?sfLE2cBG23frqtMCk8Bpm04DnlyWQOmb2g1EVuAiu9HBBnDU7DvAU7Qzbu2c?= =?us-ascii?Q?Wga4ARMeORrvPlqAKxXYWr7kOvBachsDYV0x+N8Ky/uBVQ1SQjG+dA45Skvz?= =?us-ascii?Q?/VuuUrqkCtMArAsexsIKugM5z0BuBEb0FmB0dvnJcVNcnFjj3o1exm6mkX+P?= =?us-ascii?Q?jKh2mkZ+JYoEQbruStqL6Aaif6hjZZTowJ6J5z2V2jthJ0YBpwGbsgFU/+lv?= =?us-ascii?Q?gdFqAcd165ACfDHgM1PBk4SFDMBoenEvOCyYuG98fK6Eoz48mMmdbSj8hpmc?= =?us-ascii?Q?7NDHxUr7vyVpvHXE8ntlfhIy8Oebhnhxxx6GEcpCYsl8LHh1Ww4q/qiVyMh1?= =?us-ascii?Q?/wXePMxF8c5a+6tUZYzpDfj8BgvSF7mSqHI2spxQJyjxz4S3namgkd3fbh/q?= =?us-ascii?Q?LVkn/F2erCNo7hHchv5j2uqkM4d8VH5BwVzLSYtlO/c3w4zwDl2vcXtwXC1F?= =?us-ascii?Q?+X0eai0F4bfg/6E5CgbkT28cxI9kq+h73wxxWLtKY0GoaiJBuoWM32BLNfVY?= =?us-ascii?Q?T2tdxlpMm1/OwzYKwAZbwqmQf/CCWC9DpRvd/61T9b8AKnuXTznyKEdoamf6?= =?us-ascii?Q?uYNvB5Jh6RsG33/mYpMjnpIMdahZn9fSMB69cUJ/ajqPEm6AuDY0yWRL81me?= =?us-ascii?Q?qeWma/QroyhlCPigWdlI21ML/jTC+1BQCdvYO1mPGV7ZL8wOgFFt5Bni26JC?= =?us-ascii?Q?rKZ9QRc5jccyXg1BIsAx8cEG408uH5XYpuWppi/KbXdN49tsADkl9C1nL5OI?= =?us-ascii?Q?0nIIz0fLWKHLaNUobRuepLcmbsG+1YCzKAPKrAcjbmagdhQagg0JjQhhSJr/?= =?us-ascii?Q?vD4B6E5Gr/UzamN71HiCYGMUxyvI/BL3sAptPWtQ97B6CpTCRy++2szaxWGB?= =?us-ascii?Q?eCLrXWX+4kO9NHxMU+mOmeFdhAM0s7cMYg4naxqFji056oXaDNx9obfggh/m?= =?us-ascii?Q?vXKTe9o8pJvnT9kLDnf1DpWSjgwJot4Z7Idk77zT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jed1eLStGECQHjZZPAfyis5mSe+qslur4rPS6Qg3rD/p9oYksWi1/P3UMvF7ufgcKgqkENmjrIohfhREf+lT9R77gUiXOQJRTa9P2QfPpv1y5aT8YnUoYz1uo0c0RPTmHq3O0Lubj1ejFYETENLZBn39pFwoH3ZhXsIMU1BKC72mxHuejr6Lb93WLuNoXf4BmY3BZWDyWC0RDowvv5gucAG43lavcVwn1y9CY9NIzGEOAQh3TWRbLR9oyZusCDrLJqKwg75/za/3kqXcW1EIhrDEXJkr81umI/kM85i77VwHrc44kwnsm22tK2+MRT7ybthe2fd12BiLLymgGe9O3/JFoL9OzROiaKMpZ/k2gCd26h5OKwiLWlUjZaiu6kFHCKGYdUibrr72Hpjd9lUzZs97s/WzYyJkGt4FzTicSuJRYeikCoRz/Hwessh28XYxLrBdBtJUNWDRgy4J28HQtRJPvDgoIC0U4vW2t9F8tMTTuL+NJ+fjPRm+IJmfC4s6fRarrs6vSfBf0jryoWoKWisDIwc/il6s6goiLr4iyXcfGLbya5qTez5d6Fpi4Bm+rqJn6WspFnNV4X1HbEQjfnT5p5aVPl0Vxxvd/ckwztw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5219.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e07485d-b738-4f1d-f50f-08dd9ae983fa X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2025 17:36:28.8375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u4cHc7WNqxiBf4ffVW5G9Y4tFu1Pw2BQTEmmIvq8GNHOh0npZysu95W+9NvafmIOdXTAd3ggZWoC+bZ/BJ2NNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4425 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-24_06,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxscore=0 mlxlogscore=887 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2505240161 X-Proofpoint-GUID: vrT0GUsmLX68f3M7fyVaC0zGxZqgCZ9D X-Proofpoint-ORIG-GUID: vrT0GUsmLX68f3M7fyVaC0zGxZqgCZ9D X-Authority-Analysis: v=2.4 cv=I8dlRMgg c=1 sm=1 tr=0 ts=683203a1 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=0U8fcYKysFeK0USn0EQA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI0MDE2MSBTYWx0ZWRfX87oOaHblgsW0 wtDwjKZtYYos8AzCEZcTGyQ3H0ItUY31OBd0QnAOyzFSUUwL4U6J1QZnLTtCuTPFCF8gPJYbwlm pUqublNpZhEByhazTyb9wmyfen3Y7QaNGKPgcYTWHcDeU1LewH/nSmv47oks8umihT0EvCeHWCa nerGlaF+HUn3S79RAoC7Y3VwKjp5Eljcm/OjToXlwJ9wi+5WDrSELogRWDGkRpUyS5kisQAnQ+W N/dO79ZLceDrlxbqUtqxDbVi3AdfpM6NwXMixDYJc2aCvjOCZ0V4q9qavo9a6dIlzdex7xc8css tz+sHH5z6QAGq6l5AgN9gpyL0hSun6wNLkiVzdxFr2ydlFUdZ5+0IXfSK/r0g++AIQgAoUaMBM0 eCNYy0f+GxZlW0zRY/SegN3t+hM/jOvHbmBNIHhM0mdewb8RW/MdMYxq6hAFB+Pfh5T1c+DJ X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: "spacibba@aol.com" , "78520@debbugs.gnu.org" <78520@debbugs.gnu.org>, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > But wrt searching filenames in Dired it might sometimes > be appropriate to divide the search space (listing(s) > in the buffer), by using narrowings or `occur', before > using `dired-isearch-filenames' (or even plain Isearch). Should have mentioned that another way to divide up the search space for separate searches is to use wildcards (*) to create subset Dired buffers. That can already do some of the filename=20 "searching". Mentioning these things (which may be obvious) for the OP, especially since the bug has now been closed. From debbugs-submit-bounces@debbugs.gnu.org Sun May 25 16:36:42 2025 Received: (at 78520) by debbugs.gnu.org; 25 May 2025 20:36:42 +0000 Received: from localhost ([127.0.0.1]:49067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJI5J-0003oW-U6 for submit@debbugs.gnu.org; Sun, 25 May 2025 16:36:42 -0400 Received: from mout.web.de ([217.72.192.78]:43177) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJI5H-0003oE-3M for 78520@debbugs.gnu.org; Sun, 25 May 2025 16:36:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1748205382; x=1748810182; i=michael_heerdegen@web.de; bh=XPQ2Qytce/KwPYJ+1kHLFDWdnxWJrCfEM+GXbF1ub3o=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=lz3MnHQ/SM8NM3tz5VjJPWjX8a7v4zwph5Hb/lCBZs2cMzPUX56IBkfqdvaEhuhT nSni+8g87+cjZZkv+R3/BR1B54KNio8/aMC+4THtrAq2W/XeX2SA+XkdgsRb7FbtP UeP68592enYsv1e6iZh7f3r/eYV48g8qOlvPQpVOl/n+EhSUP6Nus9tH3J/Zf5dB7 oHcNTmwr5JEmKDYHwWQJnLOEvXFIFyMDrCBXmHTcUWb+yfuCp8A1YF81BTeYwZa1n vrLbDpX//cvYdlP5mbhoQRU0L9uE7tp6Wdsk8F67VTu1u+evzRSwNnkWTJr6v/TDt 9sLcUsAxrUmsXtpufA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MGgJM-1u5UJg319O-00DZAW; Sun, 25 May 2025 22:36:22 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <861pse4f36.fsf@gnu.org> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> Date: Sun, 25 May 2025 22:38:03 +0200 Message-ID: <87frgs8lzo.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:VPmMx+aC1LBj0CTa9ELaq/czJbozMhSVSDSZ1JgJLHB3bZ4R7Jo LlQjeuB4Pk2Zn6Yby/7RA5hm6+zFBz8ui0IWMHbk4yvhzGMXn77a8f3iMoQ4hsiqeyNBSK2 iTzQt3Ks2d/sqn/hIyB7gfrotVwt696uq1Vb0KR5+bm9/Uva61VidmZdvWCakaToLR+FuCp 5n63/eD7rgawdCwX/Ug1g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rjnYWs+tYK4=;5vVDEIBL4bQUV/xKKgEJZ3V8Nbd c+h00Gd7bIyjjUqpjxil97GL8FjyBfO6A8+5Xx+3pIbxqqe6L1EMFW3dzZNcPmjN9NDo5u2/N ZXJRenYU6xoy0NwsaifvQHOb51nas+xJ0+dvqe5GuCe4zJeU7DtkpGAz/na6WyymR7ofvg0uu eopDWDCIpuUE+15gg9hF5KsbVZTrlJjwwmhsSuxrIJi6YhytuvTSBDeVJ8lN7DV2zHaMatOhS +w3V5W12fBvELsL6ftdxRpVA8ZMqkbLMHG5Vc0c9pqnIIqhRcZaAZ3/1v+8x4Sv2Rg2G4JFpi XYONJUv+yNnP+dGBAD0e64473Yvfd/st/xUezgsEC1kC5df/qC7XzoPJLMN0NYAM+htmzI7gi Dr/ofSl6/bhCspxS4DOfEP8qympemCcJUxMYnBlTzzu+xc9gjDCO8wN0bSqM2tncnyNtcDxHS WAtHCifEtDYlUzkG4kgy5MYOOyAMdbcqGWVzMVW8wmKeH7NBOT0/E/F/6XlaD8f/f16HvkaA8 fHYCLYBoKUeVVVjSbg/q5K0uC/8uIg4TqWXr4pDxrXKDL9QFI08x+wK5u8VrFbias1XICWUyy waRCFsEEnpap+Qa2DUWUfpJdFto2AxByLiRGQHwTjvmPekvlju6CO+lZKSOiVx3EGCNKrLj3M hXY+ziK6czNXnTJ/6kjzYUuSwoWz8YJsyrIlQZ+NdtkXhRm1F+15CBXTej1+yQPQY02IIB9Zt w9A6scJcmNZfQPaLvvaEiSSlWPqEnus/NejYtKZF8vzDQwDqDyoSr6BTPXH2npNJd/VkKU4Za iPfvLxb0toTmDS5u5cyX9L9PGsMt2C3tpSrHzPNUHhWLT8c3Fm4Mv0pyIzHjcFvPZzkO4N60h nMzMLR9eRRTpxA9YijebRwxuR61AKDlfBFUW0tjmLw7Z2nxZsCZRllqfP8ZB+e3hCXI3LMZVP zxiO12gw/ZXH4oF0jrB6AxAzqen6PGf/Rih8J/c57uR4r/9J6y8+jMfCWW/mAoAKVrqAqTTG5 N5Em3MqWj11r29DMQPzAv3VF9gBP/sR8rXo8O1pZ6paL2oLfUvAcie5Tblz6LrlA2zlBROpIT cVp5tFP31xKAY+Ol5WtihBAAlmCRSiltt7Kff5MYcKaCin4t7nuJDv27m1P4qtCl7Z/bIasJ2 m4Ueurv+afIsSbuwE6N6FzuxU41fyI74vsWgn28O8vao/Pwz9UDM0kBbp2wjLWzesmqV1qlZ+ 7muLty1DYwmZa+2opVPutrxXyNFU+HyBA382eN9dvSmuobCKsuu+gdkTszZ0Sd0TUUGgzLyda GKnXMaERKEZMrW2sFTN+dzyl4aMb2x1GvgX8tV5WFTImGaae0Fwj41mEpczLJC7UOgmCjqC5V T9dJvzpJxAUBGhRFS0v5WuQL43a9v//EGQx5sWeFVH986kGFN/yyzuHmg2L/nEg8a+vMLclYD YfT9/tg== X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 78520 Cc: spacibba@aol.com, 78520@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Eli Zaretskii writes: > Thanks. I guess this means users of this feature will have to live > with the slowdown. Probably. We could, of course, try to improve things a bit. I don't recall all cases where this slow kind of doing things is necessary. Do you, Juri? Maybe it would be possible to use a faster, but equivalent, algorithm when possible, e.g. whenever using a non-regexp filename search. I have been experimenting with this approach locally, but I don't know if I'm breaking any use cases. It might be worth trying at least - the performance in large buffers can be a pain. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 02:55:12 2025 Received: (at 78520) by debbugs.gnu.org; 27 May 2025 06:55:12 +0000 Received: from localhost ([127.0.0.1]:37139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJoDQ-0007xm-D8 for submit@debbugs.gnu.org; Tue, 27 May 2025 02:55:12 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:60141) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJoDN-0007s7-P6 for 78520@debbugs.gnu.org; Tue, 27 May 2025 02:55:10 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id AE1AF1FD55; Tue, 27 May 2025 06:55:02 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87frgs8lzo.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> Date: Tue, 27 May 2025 09:35:29 +0300 Message-ID: <87frgqa7ty.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdduleejudculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepjeekhedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks. I guess this means users of this feature will have to live >> with the slowdown. > > Probably. We could, of course, try to improve things a bit. > > I don't recall all cases where this slow kind of doing things is > necessary. Do you, Juri? > > Maybe it would be possible to use a faster, but equivalent, algorithm > when possible, e.g. whenever using a non-regexp filename search. I have > been experimenting with this approach locally, but I don't know if I'm > breaking any use cases. It might be worth trying at least - the > performance in large buffers can be a pain. Unfortunately, I don't remember if this slower implementation is required for non-regexp case. Maybe let's revert it for non-regexp. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 11:29:01 2025 Received: (at 78520) by debbugs.gnu.org; 27 May 2025 15:29:01 +0000 Received: from localhost ([127.0.0.1]:42593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJwEf-0008Ig-Dc for submit@debbugs.gnu.org; Tue, 27 May 2025 11:29:01 -0400 Received: from mout.web.de ([217.72.192.78]:42227) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJwEb-0008IM-UH for 78520@debbugs.gnu.org; Tue, 27 May 2025 11:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1748359724; x=1748964524; i=michael_heerdegen@web.de; bh=8ab2CTate0xGJS/jx6mXBw414ac9AkHBC378mdDErBM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=HBZ2WM/EGFC6levUpoUiJ+w4h16jZ3dT7ucRT9FBOspAn+Hwjn57LN9C9k0lVmJ1 7yV3QgQFa8Jz47hVOHCbjujK3LW/bnSPbYt/ZiSpQBj4+p4nXyud6XXaGT2BOAWDl sHkM+nMNoZXkrOP/AxBq8kYxeHrsOT+KO0QAdnLiRTNzWeSIhtfnVcG9wY1nn0pza 7U21GTZSIbH702HJLT4kzD1b3C04MZgnjAx+hQT9YlylpKjGFsshmvbe4h3sY9xKL +ac13X6h/jkBh74Hc7seg/kA16he4H3p/tMTGc3fxoTeBa86tvO6fnqMcTeEDbuto PcWxZoWbcNIAVGIMjg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MECGl-1u9nsU41Pp-00AWeH; Tue, 27 May 2025 17:28:44 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87frgqa7ty.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> Date: Tue, 27 May 2025 17:30:24 +0200 Message-ID: <87zfeydqb3.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:w9wxcvXznj5Z8wXQw0JFGrT0O0KWPd+91/D3J+9KXcAoxO09xXZ W1wJ8y9xv92o5jTq3KyaJfodvHw3q/oX1C3sGeeprMG+q0/NV3s2lLKWWjddVEBeO/QHOYO zGOZQW3kdVzC7RdJ5fCdrTEMrAcUXV6WsU9sRgya6XhtNEO9xzJxOcdxqzp7JXNKhGdBFOF PJoa5vGE6FsT2B/5T9DBA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C69dmTYkX8I=;2m0Q4UnXQoUvz9si2CJ+jUpxAnD s+SGZI8nVSPzGzoDlwPyRvrafiygKIpUCgysuo9Zj8AVEFNtpw48ulEyETGbkC7+lRlhveleM Tf0OM+ddW6Q5+PdTtetZwQEpriM3/HUC1d9m4dqiFRd2yqeat49cMpzE8mAU3PUP33m/5SlHR Ae30Tmv1m4O+COiYuPS/NI4WSPBa2ar5PbztwiSkIZaSzGaTbvdUlQuuVSBG4FHQpZw+rBQVw P3O51TxfvaQmCskDrKBOszszaEDhWQiy31yobQsrYjayZQyTY4FI/CPuoVlhfcTOtAs8Z+k8+ +FTo/X2LoN+eW/m09iiGz5Z23NOwOchrvtNmYpjyWpDfS9c6dXgZMZ54TB215fSfqJehv5mCa W8hOk61Tt1/lOLYVj9c0m87IHGV4cGPkqTR8ierGLHZnSyPTvK2Ln6Z6FnpjLDP4zarKH9wv6 0VBuY9iTKsofwFkI+whAoFN36HjrItgcNqBpCcmLvaBuOEuYDZ4c2ozc8TlViSpZu7Q87Gfs5 hjD8AuZ4Qqtf1SyL5nEquUPvFegpTMsGBFqdUOjvsaqqBfSrKuzQUubtSjLmGAPrCV9iA65eG WfbdUUJIimIv4L6LqlvMgRMb5GC3WI7SlsdvksDwnS1AQmmgF+8D46gyXGXSMC5HIzV8w8K+r l/28z5jJnWr6sSwB/bI+Rks0jKcf4AbIfPoHsmuvjMV94oAJqPIIJI3FP1cvB3f8A32iOa3mQ k8BXFXPiKnKtV3iTji8ewd7J+AutEip/dZwj0c85u6MEPfKzfn5x19LXJ7/GVWebnYsmGk/K4 spEvNPDJzaL+4g2snOMno9k1VvVQ5whZVoqVXI5rIKqX3Lb/AE1i53K9/KAEbASNqxEM1c/o2 B1t9/lVb0/ynhel+IJm6wxU/pHW8cm5cdsZplgpC/03VJXbAw79gRJV1kM8T9ZzaLmbcmsAT/ r2YdbzIT4YVLrljWprHw3kK/sK50xq+2M4VYmvlalLoOR/1/KAhVbQYIsW0ylLHv7rpSq9cvv FJ9l/lNWR2smHHKAVDEa/x0V9he45+Bk6b7Tg8d9k+69OfxY8SyxLfSsU3i5f3JlCpO6Q33Sc xXG7tLob9uaBakMhKEew1WfPevQZgGWlqH4yOl/1iwcp86o+rauJt8pWevIrhyHigTcNu48x+ Fdq/3JJ5cHsd18VSMvvuxJ4PNwxV68XVZwC+3DOZWlQH1XqURUWOIpuc7b0s8fwzTHjhUMcZh OqqXeEwdt2O+uVp2+j7a5pCOOb1SuVs/9GJR2WrkBby7+oxvgOXBPk1q44l05V+Lno6s84AjF kBtEBWQr7IHKVoZAqXBD57X0nXbjM0wUVrbtjZDTMhi1Ts6hKg/yoUBbLBsiZ9QDVK9XFAz3F iU8JOx3T9D6uvWHtUIJM1OzAcQockl7qza6M8D9AQhaGlOr6tAmoO/pIG7fmc5M9O0lszp2Lk PZ+Lwnq+GwmMOmNd6+BEeGRndJ8UISwY35V8E09/ydHDDNpsMR1LPmwnf57c9KJS/tE4KQxpg j8c27zLFGR7+eyKoamCQGRrMfjnbPlBlj6Tn52NyRlKkjUxrcD02t/8/t98fjuz1Ua95ETlFA FoKGPCR+wH5lCw1LoTc16iL0EwYnt+8cxyeMHeO7xh5pGGBdFMQ90VAmlx9uBJAgg1PQYu6+R vjrrKkuq/+pDGAHzJLRrKsm6S0Dy4mMPDFPQTOxhuMVCOqdBuBaR73g6dgBptXAUbtpQruk6p ZR5zeLTf8ltw9buF9nvYXWOywngxoUO21owGyqJLdDdn6bLTy3oI45xL3lkmfbHd26VkawYBj FpytLDjRPhW8RCUhHO1NLaL3eetwnRUwMd+qS/932IE+LGY+eshy3ZcPBEtKghHOP9qgMyeiG FIM4nv3Z7rnM+9yYv+04UF70+kZsITdNQpNmcnqKV9yUHg2no7Fs4QXgCTxVURfaLph/hmdMf JK2O3giqdbHU3mRGST/Ot5QtN7TnKk2kvJyJ3oPRxDPOklq/LJCd6r+f5BhkS9A2ZwhJvCfsS /myFAATO+j58UMFzb1jGL1YS8co+asjUVg5WC83tcmbjGnIjjd1Zv9X1Cs4K5c9efUalYIcPx DnWekNK7SJpwXP+JiEzHiBxI9GrGZP6UgBWMIWjF7o9T3ntoXp646pNGJsru8vtkdaTSWWOVf 6NgYz3hEh9F3Irc4KMhnLAY01Ld7Iuph6ef+SBbLTAtCEbstkH8+j5Fs/rVvZ0h3wsHhP5eo+ Srr53oSNCSEfXVEpYvJwY8mZtlI1RGhGq6v71Swxy1hFk/X9Iie5luWGpeE4tOe2QpWSWTNlo e2qIoBcs+f0gyIdPnpJV/OybaAgzZF+o971qbWUFWVJTYk5twrUXDEmy3H17/8N99FhuUvfYP fS8atGyWebpdMJxBHiyk+64I1quPYiHbxSOnH97I1KrIug+nQ0EKahO0GMSyQJ7eZ3Eyy41Np v5oUBC/0o+OCr4o85dbuf2lk934jxTtHPWqu8qtRVhtgrsnc9uGI9ZtzVW1frp4LQ1jtTC5/4 gMn3Mve15d+c4O1Z7EUT794feMD6R0kc33QfSkPPDY8uq15GmlvASwCFc3zO36oZBTsHnNBh/ aRuBRDST9yRxC4ADvGFY6NUpT08GC7mPxa3Q1sP6QlkAZzvvyGfs/9F4CnzeaV3Cv1ShJ7Xf/ HpN97/Yrt/Mpy2GcA95cjE6eYHWzl2NAc7mQWHOcIRYsV0j2EdP6kOEWyUlnQJi5gjLggUNUb eDsRnAMUysfHmVrG6uoI+AICtxaZSVoHVdASNBkzotSnUxdcfgQRjwht3Bk+VBpwueWjTwIie yMakhYIlUgU837waIIi4dl5Ovy9E0D/MawLP80LPsdIrrp3oCLgW+gYXep81/KEvTXBuoZBXC JibqWyqovZz5vZ/4cixRXFHBMGp8z5pTy3nfx9F+T/A8lQNCF6tTjZCNqr0Y+sXLCt5tJZwmZ Z0J2YNetiB0uQSfvJXm6mjBgLFM3FOIc8f5zyPCk00hqLFiMPvYsO6vGQtRjS1ZWbLIzc2Jgb MMer6BP7b51jB6ZSv3hP07Nh4BdERJTzg0mD2TCGn0fg4NrL+4FJeejU0rSlXLBvCiRzXePkt zVK0t65hmlvw4fuYA3flYmSF3tFCSwfMaYXLoUzemUvK6Y4alWO8p3JKtbRXbJcL+9YOZYxte Dugx8orSEFlSR3swy5YQ+OP1Fskz1NyGm+PSO4jWytMxjyAqNMFUqymw8zHnAACQ/nMCgNc1y wbnPs/IDjVWD2/V4OcTwX7VzSUJZfrhqRiw7LQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Unfortunately, I don't remember if this slower implementation is > required for non-regexp case. Maybe let's revert it for non-regexp. A big part of the discussion was in Bug#14013. I've read most of the discussion again but found no clue. So hopefully: no, not required. I'm now looking at `search-within-boundaries'. Do you think we could fall back to a more efficient algorithm even when `subregexp' is nil (that seems to work for me)? For reference, I had been using something like this: #+begin_src emacs-lisp (defun my-search-within-boundaries--before-while-ad (f search-fun get-fun next-fun string &optional bound noerror count) "Search more efficiently when possible." (cl-flet ((search-with-slow-algorithm () (funcall f search-fun get-fun next-fun string bound noerror count))) (if (and isearch-regexp ;; do we match the beginning or end of the line (a region)? (save-match-data (let ((subregexp (make-symbol "subregexp"))) (catch subregexp (let ((i 0)) (while (string-match "\\^\\|\\$" string i) (setq i (match-end 0)) (when (subregexp-context-p string (match-beginning 0)) ;; The ^/$ is not inside a char-range or escaped. (throw subregexp t)))))))) ;; we need to fall back to the slow procedure (search-with-slow-algorithm) (let ((old (point)) (search-result nil)) (unwind-protect (setq search-result (and (save-match-data (when (funcall (or search-fun (isearch-search-fun-default)) string bound 'noeror) (goto-char (if isearch-forward (match-beginning 0) (match-end 0))) t)) (search-with-slow-algorithm))) (unless search-result (goto-char old))))))) (advice-add 'search-within-boundaries :around #'my-search-within-boundaries--before-while-ad) #+end_src and didn't see any downside so far. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 14:10:39 2025 Received: (at 78520) by debbugs.gnu.org; 27 May 2025 18:10:39 +0000 Received: from localhost ([127.0.0.1]:43908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJyl4-0007ci-Ln for submit@debbugs.gnu.org; Tue, 27 May 2025 14:10:39 -0400 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:41115) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJyl1-0007c7-GM for 78520@debbugs.gnu.org; Tue, 27 May 2025 14:10:36 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D463B43A62; Tue, 27 May 2025 18:10:27 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87zfeydqb3.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> Date: Tue, 27 May 2025 20:59:03 +0300 Message-ID: <87h6162c9s.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvuddtieculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepjeekhedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I'm now looking at `search-within-boundaries'. Do you think we could > fall back to a more efficient algorithm even when `subregexp' is nil > (that seems to work for me)? So you propose the optimization that moves point to the next search match before fall back to old algorithm. I expected that optimization like this is needed. But it will take more time to adapt it into the current implementation. From debbugs-submit-bounces@debbugs.gnu.org Wed May 28 13:17:17 2025 Received: (at 78520) by debbugs.gnu.org; 28 May 2025 17:17:17 +0000 Received: from localhost ([127.0.0.1]:55904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKKOy-0008Vu-TC for submit@debbugs.gnu.org; Wed, 28 May 2025 13:17:17 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:51119) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKKOw-0008VT-Py; Wed, 28 May 2025 13:17:15 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id F291343A37; Wed, 28 May 2025 17:17:05 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87zfeydqb3.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> Date: Wed, 28 May 2025 20:15:56 +0300 Message-ID: <87iklk1ws3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfeekgeculddtuddrgeefvddrtddtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeehpdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhitghhrggvlhgphhgvvghruggvghgvnhesfigvsgdruggv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 78520 = fixed thanks >> Unfortunately, I don't remember if this slower implementation is >> required for non-regexp case. Maybe let's revert it for non-regexp. > > A big part of the discussion was in Bug#14013. I've read most of the > discussion again but found no clue. So hopefully: no, not required. > > I'm now looking at `search-within-boundaries'. Do you think we could > fall back to a more efficient algorithm even when `subregexp' is nil > (that seems to work for me)? Thanks for the idea of optimization. Now it's pushed to master. Please check if everything is correct. Also thanks Ergus for the request. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 01 19:08:49 2025 Received: (at 78520) by debbugs.gnu.org; 1 Jun 2025 23:08:50 +0000 Received: from localhost ([127.0.0.1]:43209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLrnN-0001Fu-GR for submit@debbugs.gnu.org; Sun, 01 Jun 2025 19:08:49 -0400 Received: from mout.web.de ([212.227.15.4]:37905) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLrnK-0001FN-D3 for 78520@debbugs.gnu.org; Sun, 01 Jun 2025 19:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1748819318; x=1749424118; i=michael_heerdegen@web.de; bh=ONnAdgkAp4N3hh2EkRFECRNdXeaZfn4hW76RMNEyLYo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=VCQeRQnB6psUZ5dk7l4gq68l7lbv4RldnENO7AeFlkh0ccSHyyeyWuoSwndIgSxS 3tDIuE3Tm2ZBkfJpdew9m21kSvxASkhrVFXmfbOuYicGxGbO1HbSOTSNED+I1yJKs wqLRb5j/o5Eq7GVZqL0K7QlBUwt4FgtMlhcx/HI7q4xj/rMA2qu/21ZEn9/mP7Nvv 6Gk4A0A5ZAAkhTtwMjTwWAOUo7f9734Ai1wvG75QcwnCdEUVfXKseZS7WE5EquFhs cqLZ6/NzIJ18cfWXJkwWGpdZiwv8FphqeeQIDBeQfHTlAhV3lOJT3Nvthfl8DZelL ldHHUtycVFCn4vEwNw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N8Epo-1uzH7N3wCu-00xBR1; Mon, 02 Jun 2025 01:08:38 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87iklk1ws3.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> Date: Mon, 02 Jun 2025 01:10:18 +0200 Message-ID: <87tt4zkqhx.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wGgloRkMNvuaRo67PJtKLXumewnTWpxR8TS8Juqp708lfiy7vq0 qsScvG0m0of9+vdpxNV5kSGAn8pX8k5quDunvtU5PMaCc0N1bgysaeardHJzFRnWCLGjg3e vxva4kuz1Qt5Y+xwpDt8HceD2O475UEmj9CahBGNjuHSjErS5fcAE5ovhnClCaHc7LKVNzQ xyuaXRfIwmK0Cctrk8wgA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:CK3i+KqTpeo=;pIX3NkTBH6Wy1x3CYL8qqnrwHXp 23hXmmxe2I9bbedw765PpJIENDEzXPym0Nj1AHBjUQWADb0p40mDzcEXUDaOEeLvtWpkt8NTH 1DBo5deUM8qnDfgw7ItalO323ilUCpB6NamyFk1ophiHalfHFm8xDGCTeIpMEngiIHi+4TCNa iLLM6SiyFTST+FRhc2Zqgf1aFwQIslWPTn6+CgRQInBY9VnUKX591mDE3WyFh3CVjhVaHUiEh bhWI3iI7wDH5uLgXZolm8EVUChV8KXFUPpQGlt+TouN2VZwVdEpMQE3xT5WKz2fFlueMSkg6m nK6s+uG4m6NfOtyRkXJ2EK+vRbhEU6ppa1/w5dr2sMU0/FWx7ePvNv7KRI3N3ufFznb44VFzX w13a95xnPvHpkLDfpHFGaTWLa2uyI+DtMXnwWQ935hdtKDc1hu07V0Jd9e1uPN8EdzSEeTuPI G52LjCiOCAMCfA6Lb3leXbJb/1frABYHvK2EQGbGEfhfBVYl2m4tm8pwiiwpNFK7iNbI/v+HY gMViQTZz5ooloRVkqYDm99eLgc+rajLUJXto6sTvy40BPgEdGpCyCt4Mu5ccLhG4M3eX2SR/f hiIsxhsyWeFVuMeYDqthT7hJ2yLKSTIiptibfXX+aD+x2/1Mm3QYd90QII4ZjIKBXozglY9VM 7JYtUXWFawHBOi4ncmfnahG19FgA2Wng+umTtMmQAAVRLXTvl/UAcFHJYpqNH5IEGblBe2AMT 4Pjao4SiCYZgFZKZkn4zbUwQbDv+dyx2r2F3vLvt3/bqq1VRdEbKyXt52RQjC9lFFwD80pBCV pK0taBeUwlXkfzLFW/T4ptbc0Cj0clRR0NTom/V9cqtvCAL5B6/XgOQ4C0yWEYDbiyAqliaN5 yFq6UG4nBiwJZrwLknFQ5MLntFfzEfpY2cYOjh1GcZkJw3zFKfdBkOpNTwAUsmq+zVS8W/FUY 7chUJBtk1Mai0zTEpxXJ6HAgkMDZiiMPB8jLwypNbMUtAYZhYQdfdF4EL0ZLoXUc1pUOjXTRy UqrA7T2Rad+gHjBbhEltXGRLbB5HmBBCxR5gIErduUjiUgDudeA/xHGyOPvRbrK2vFJHKHIUu 10JQ8DfqcqFcj9EukDViMo400a1w+G8mLlj5KlOaOJHbfIT5hy4rnZswEK/MLsAaNx7NXogav 4SVrEF3CXVoBVAe5uBcVRFcp+p4SwaAiMHxiqvT5cgFSM3OHUccODd1R10o1Hh+wvoVwoevVG PXLJ7tlRlBcq/ropQXTgctag2b9RJkjTGssR3dtid8FheBV5lHlhr9VCfJpaZvzvuvOn0h4fk I9dtv1TjGW9/ehwi+cfM6mpDBXIiz+6DPfAumBYoNXGVrOiij09w6L1c8lMYBFP2vieQmln8L Qi9FOezfafgAlhgvS4FIQ4ns+c2TALueWq2OEyngadJbd9D3v74wZVXowRzJeeLrytC2JIouc +8dOofBfNP3gVe2+BmiUlU6wfJNPJkzQmrd7cS4fMzm7ygFX7hJ9TjxQCmhNiQZPKLKTtc1W1 316+pdJgfZIhvIEiWGVIE/tMuJOleXFJPUpZbNPwTV2rVCSmjEWfb9DcnQb7LyMAlcdG6Pu1r b3G+QThb6UnfSi/88MoE2fAenDMGlKPecPtpDe6deuRYTqDI79bU+03bbr2yOCN8TYeUbyKVQ JFg6+SQz9IC8yaXffjVUR9mAcOxeN91Ef92/gwsr/TTu9/6xS9DFffdMsFrkfQzh1wVAjPh/0 n0xnoiQvkwrvfhuLZLRMm6z7nMnylX1vtA869+0KyDG39YmWC9bdzsYvMHwhSvMz5yVYBOzi4 aWHDTZ5Euu9sb/jG2BVaOR+005ck7Pj0yX38Uxp8IMyfccQ3KVlBckFVGsmOTASQD2/8SFsgM R6XBjT4e8EcXPXjix9LBifGld2cd+RjgrCSgamF4M4clgjOfEfiqH7M/l/HgZqv0CiVycRofA WTGT4dEj8oW/4guPMP7Gjqz5pITg8qDmyeNoYDjCs6Ha9QTV80D7/+l94s1rueg+c4u3CZoQ/ Cw7LUojjyonb1BteMVOUTYBrrRkcaxIi74WY11hptqW8j72Aez32rQovMO9yEleVM+vy1vkKB hIFFQEpSitp2DZ8yFt8aJQl4hIzDpBKJogZz3l14XuHyTN38nkpvf6hpC2Bog4XNg3LKNXEor Y6wXk3gli+XyxcBG7H4/SyxOlQeApnibVOJwLvIXRFtAWbwIrDehnXAMiNmbc6La2N3gOm200 Ds1Gboa4Cv5xupFUKTN/CEKFMrt6hgzmJ7+JYB0NiultMJlHS3JktONwal4iqcEg12WU4EnX4 x3M1iLYx7TJj0sknetwTZhjIpdVtmbKByBkXY8br89CSOWuS5qe28LFihr8W6tKRM2AtDB8PH W/Mw2iT8FPqsO3Ubm4JY11gkTIlwyF3J6ORYo4yhvU2ID0XXf3DGHLaepeQa1SxwxL1Nasqzi imheHKE2oN1RYwPCS+rvn/tR+fr5ojJRVGk5CwYM/ynuNIWkKTAnvYGvvea6JOrG3YEYdtVhE UkInDigwRprjVzUON4LqidvwDtepqCPD3aUEC0BjsUPwnAjuR9r8+ariprqtM+DOmshrIxkIa u5iUWPR8EREiC3HeZNRqtDAltdfUmHCNoiPI8HEyazIe6fxOh7I0Xhg3G9YAKYDNeve7FvAUk Z/Q71mkJpuYwpuojoWE4KC+cjMtJgcsFMQd4cid0jwmiwjmhpMrrZMRZrpkQgbw4rgYUA32N2 F9zF3Du6U9qjYI1kPh02wo1l3cy99vq6/eOiDxLIJhYRgBDf4GxePzuMrG0A1V6AkdXnxSp5B JhnZJ3yMi8pVXJI9niMpVhGTHYSGZhibgVmhE4rtuorEuj5xVi40+Iaze8sLVBaGNjDCJqVNu rTZjx7BWzyFi8GaVY4jLusJ2wXMMYYqwgFAHWzp8NBQ1LRlmg0d/ezAlFacyDzjWYAKt83SiL MBWViRUonMkPVXK30fxscD8GVX0voo/NKGHK10BJ7fpIHV5HC+FvFkNhWjtUTiy6dazEquN6r nZrCkaKeKKr8iLyzeEi2nXXLHI3LYxkr2VzO3VE9KsRDED1oxLAVESig9qstUWNlnbhzfjo7+ ZPdXgtkcVl4fu/XHcuHbZetiTv8uF8fR8prT9ZKV1sjp6SUry0omO3rs0yVQoiiroyDWtqJsQ AoPnl8tA5b1MSZX51d5fvu0VpiVPrMka2NLSkP8GJdfpVhopaoSbtH6aFX7lDg6ZlqznUNb0W i2bszRzq5zuWFeoH X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Thanks for the idea of optimization. Now it's pushed to master. > Please check if everything is correct. Thanks for the patch. I did not face errors so far but... is it now really faster than before? I tried M-s f C-s in a huge dired buffer in emacs -Q, and it was horribly slow. Slower than with the hack I had been using. I did not yet try to have a closer look at your code I must admit. Did you see a speed improvement? Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 03 12:46:17 2025 Received: (at 78520) by debbugs.gnu.org; 3 Jun 2025 16:46:17 +0000 Received: from localhost ([127.0.0.1]:40803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMUmH-0000nn-Fg for submit@debbugs.gnu.org; Tue, 03 Jun 2025 12:46:17 -0400 Received: from mslow3.mail.gandi.net ([217.70.178.249]:54441) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMUmE-0000nT-FD for 78520@debbugs.gnu.org; Tue, 03 Jun 2025 12:46:15 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by mslow3.mail.gandi.net (Postfix) with ESMTP id 2EEFF58277A for <78520@debbugs.gnu.org>; Tue, 3 Jun 2025 15:38:58 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id A92DB4390D; Tue, 3 Jun 2025 15:38:56 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87tt4zkqhx.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> Date: Tue, 03 Jun 2025 18:25:33 +0300 Message-ID: <87ikld7xc2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeiudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepjeekhedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvg X-GND-Sasl: juri@linkov.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I did not face errors so far but... is it now really faster than before? > I tried M-s f C-s in a huge dired buffer in emacs -Q, and it was > horribly slow. Slower than with the hack I had been using. I did not > yet try to have a closer look at your code I must admit. Did you see a > speed improvement? I'm using C-s in large Dired buffers all the time, and before the patch the search lags were too long (~2 sec on every match). But now with the patch the search is instantaneous even on very large Dired buffers. The search might be still slow only on one very rare case: when the search string also occurs outside of file names. For example, when the Dired contains permissions "-rw-r--r--", then searching for "r" or "rw" will be slow. Do we need more optimization for such rare cases? This is possible to do by adding the same code that you suggested not only before the 'while' loop, but also at the end of every iteration inside the 'while' loop. But this will overcomplicate the function 'search-within-boundaries'. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 03 21:43:16 2025 Received: (at 78520) by debbugs.gnu.org; 4 Jun 2025 01:43:16 +0000 Received: from localhost ([127.0.0.1]:44132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMd9w-0000hq-4h for submit@debbugs.gnu.org; Tue, 03 Jun 2025 21:43:16 -0400 Received: from mout.web.de ([212.227.15.4]:53867) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMd9t-0000h8-95 for 78520@debbugs.gnu.org; Tue, 03 Jun 2025 21:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749001383; x=1749606183; i=michael_heerdegen@web.de; bh=hd1ZAQaV+0u7h8VHUWFw46bOh6dms2y9KHkSMjqisps=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=meHvquf7nIWnh/twA5b8T/+vg9m6FgO4Os5sqR7ZPAmcJzVu6bV2g6EJd98Pjy52 cqu3MwutwxtaquJAcFBW3wH24eDf1guINWMCCdVY0/YJAvPiDT0v/k3neympa7Pfu ddaoF1SAM8wd5kb2DTojXrmF/ONXffVTwYv9EMzbDJULcA0/gCVAeMUjD32I9lv3T f06bxE4Ov7LrAAyfk2kGTsgVdZkduCToU/U8DWkpWtqz07z7wh+9Uht7wuXiUqcwB e2tjlP7DKO8GVCAcITjCgF2XEKI9dHugHpv80th28xb8qeDqAjcDp/EI2n2dqVm5L yg9E4C8GBNJNhCqKXQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MnX5F-1ulThy2IYn-00p0lB; Wed, 04 Jun 2025 03:43:03 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87ikld7xc2.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> Date: Wed, 04 Jun 2025 03:44:44 +0200 Message-ID: <87msaomgab.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:R2gWCxVjfctbriSChk0BsZ2e8AIn6INledRVBhHOdOgd409iMeq eylpneC2trEClUbUtAewAgC3uJ4K9BkcK1CIuG5brd/S4FsLj2T6anEgfTgsORqHwgzM/vb HmDaWpjBKBOQcM/4lQixHe4xoiWGkjNu/YaJF6mAoUajet4hSAe20GTD2KjIzRXDFBiPzbV XUzvgNDuP6Oxsi2EkpRSA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:KWk5JlFXxZA=;tsD2fI/ptvRVGMsbUpsdmupU3/J tcB/5yDKx/xkQ3UaFt2Q2W0NPRFCvq331gGhI81+qChcUkgqZYbvOvCguZTOaO/ZRnMNo3AN+ XL64mqr1S2Wgqf+qkEjo72YYz8o/a6qI2lMr2Jlr+RnJYg6gCkB+7IkKCtXCqKNoTZomvF9J0 Gleo4DHU1MNAFTuUE5cVH71KrgqU1cX8qMlZ8DM7RnQ1BP6BkrW6VNPbtkYL86yzwKD5jb9GK xfN1h08Pa7QofANOsBAyrvveUhZHjQLpzw7VgX87THvC6RdZ3X0Jc90Afxzw9a2KEnDRduXmt NGn3iJB4yNVdxaJUGtRZYbOlgF3p8q80biEeGjLblKOBgmH8sphLm7ts6SnsDHlPaMG833hRB PjjULYfVqnmgpli/vNuVnvtcETZbUH4iCyLcpjfEY/K/vTBpXB5EcAfn00GpWPIC6Ymqlaw9D nfs8Oxj640U+cYOEWYCxv7R7aH4oumfUNk/eAQrCRoOYU2E39m0nA+fP7QDLkKtsopAzwFpY+ wsu/MahR5Afme1F67m9GjlpNAi/FTwFHVAnajKsA9jRVz4FH5gHrkQ659WOLwbqyCz3RoiQF6 Vh2bW/EQwDzLlkzikwoRMFjSaY7jHEpA0jkEaJApFLpxjWP1pOnB4QBrUGb9itLpa1fs6fsES 9IWw8eVEb0H9SXy5gjhZvWXe7XFLuRz2JPQ+HaUmS17rX5pWA8HmT8jm2w2DCyw3TQcHpHOQ/ aiymxx8Wa+GL1vW7zzBgo5smhj9DkwE+S7UH6OlEUzZkXROKIHiP7EM0emU3egiBUynjSLVed rWIS4h7GM/v4f5n++yzlIkyB9CXSnETdgiLODb0D7HGn9e7qsThKu9tACgdM01ICyXx3zhtIX yQoWv5/+v4fGPSrCMQtD9MwyUxkeZCrfSXmlfHXbSkEKVLMjd4fmfhPw4hI+SAd54cMrMuJke 6gdn24ME3+P7AWS8CUYy68P5ZTG5C33k1m2PosIeBRIkQFDTBU0T0Py5B+WIao/7JTTCO8rjb HZt7cxViFGDh4TyDqVHzzXJxv+4NxfIQAGrokTnXPenN5W8yN6n6w5P+PgCy5q8tfe98InA3Q KwcCqzc346IMWSuX1CX1jaLK4HZhyzMgBAURqpiFr/eZpkBuDW1+0AJ/uXUkcOJvbDP5WjGxt FbCGX1KBHJNlPTTgQrnUDkw53+FalMEefdpC0y1WmF1HlwiQ9LCKwGTI0d4gi2Qvnco7C5D88 EGnTVC7OIzvlAIovdeHhkWnbU9FBqhVpzaBNyiXCEoRINH0eiSKajR5n9d5lcaUuz605q2xgD 49bV7g82CWSjXs2rKjxWUQ9hFQ9lvAzYp8zWo7J5o2ExfQL8piDxvh5AvK/NOUi/P6sb+7433 cL3Yq0Eeg/NZ9voefNORwC3x0lGTuQjDEiT7HYqjKh7py91wEVbARGTXVh2Mj+G6fK1Tqc9TJ vQbCfnDqQGg1x8iHQCWpvywmll30MUb5mOsC278EZpAjZRw239UlVs6onyH8feWArFXtER1pH b9JMAtvNAQJh+wSrHR9KQHI+pQROhrAZEpTagYvdO1STraqZOQV0Px0v7c5r6A1k9Sn36Mjgc gTx0cGO2qyP2QI3Y6cmQqK0u6hS54FA5ji7FpS7BjKaTFv0McLHnUyL0izFTmMNS6YG+z1sh/ eLiJyc3ys3gBeYmTS4fHmyVQsEXR4LZ8KLjGbn5uT5uY9ZjAwslWErjpnlhnnM8SrwxcV04Yt tXIDwelcUsqpU4JhZLrBBicwBSoFjahJ4mMu/fYHIc6UpCpM8aaAauSW3WdjH3j4FmtVK8Ype lWq50HVIBTqtKQgmnBO1VGmNw2ywaclXvL1/cm59GLWrfVb1Nc4IEwrTxo29YxbEKrPme2aRS AeAVZ12w5IxP1uOYfWGg/67Tm4qbu2zB3p7iIzpgo3kYObbIHC39hqmze3cJnt4CIZITB4E4z 8hcm/y/9rxeQMK3KP3Nfa2YazB7wfvLuYBsRNFb9+TTvKwPCJK+zG+dTHN9fuLah4K9VIZutm XVvB8eOLsIqHJiHX6kggNhxBkb9ff8TzZVLcMVjjcENL1QBqKWOeNhcXpLbwLGuLeVaEPT4KN n+u1/wbk56tn5iQrRYk7bxLVgEzWiivCvPysQr1w+VOg7aNOntAzbjMqkvc7SOpsfveEeyLOS S8RlSM2XZ4Mygc0UinPfUYqgQKpI8vVnEYpHfAs1YsspPjCWZ895ZrAYszZKQY7N4OyxrIbmv xs+y6cvOAyGFEPVEuShB+gp4zo2L3YfLCpcBbaRcMFQyurY3EOTWSX21OlF2SI/i81AzpEjXZ XycIGg4ZQQORkXSIh107YjDUxN0yMI7RwM00PZbc9BfVC+JYYo/5yTvl+/nQKG+Bb8DLY78iH KxGBsAhlaosgUy02JMfOKcKFrhNSGHp+zl2eVvKMte1otq4avknrGOmvCp/oMIgaG5nxOiHmA BXx444SY1V5/OI26zs+NAtojz9T2U1x6JNGjHAN8Ovwenf0TlYKIdkpVqoWgcHHdFuIwTljp3 gVHlsRL38SZ60oP7ayr1uABKJYq5dmQnYkEg9UnTpnEhn4HgcMpcbeTVeH7SkL210IjecNHuS 7HdlL8USGTz+BVtt02SYqJ/9nEpKA9BrmhJEo3aDcUfgVbC+KEYr9v1Uunu7mVRFpuqrGqzw+ /93uy67fwbaZZhw2vl4yrsj0iusgx/J0k04jyLOtFMqGEblk91++mxsntfrz+U80nDaQWdbbD Y2UTDePp6x3hiUn+h4c0C/pij5CC2Ubo1iF2WuJOaJhibl4D5O+pXqMpb/r/kEjznXPqOvaB7 3CPDHlT80r5qK91iaJfPKKE6e97A2x99s00vfBQhkLJsuLEuX3IIzCMP5AbRKh6s0S62GiX9P HwXoyuUlutq4hnBtWxE3GGQCKEgmXbsrPgP+QA4jEneL1/6vUjJVkzHW4AIQ7ztIZ+MpSzq8y VS77e4bH15fvglOiyHzGlBUm4y0IxHgq4+g507NX6pjd31Zmb0QQjjmMoDTS+2zVrbcKItO9d Rj7OwDytLT5TaVG6PEBwQdlxZQvfoWc9dhvnkwyGTOlFzAUpGz9xUhSBx2ZXcPLLLj8yARPyg +BwtVF319SN6GVdiX0Y3ctXK4LNrw37dq/vguc1g++dHIGR3jjsabu0+6BV4wbhOPx5r4xGa+ Vetd+RSdBGAs8l3WjQ5dy95h7uUFrOK0bhanYQyYsIozMS8GpSZAw3wpfkt6hNnwR2fSqrDiF x3Pxkwfdt+iQp/dLbgtFwjSfOMnaflCj6GaG2A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > I'm using C-s in large Dired buffers all the time, and before the patch > the search lags were too long (~2 sec on every match). But now with > the patch the search is instantaneous even on very large Dired > buffers. I do have a very large buffer, and in emacs -Q the first match is not found before at least 10 or 15 seconds have passed. I have a somewhat older laptop, but definitely not that slow. > The search might be still slow only on one very rare case: > when the search string also occurs outside of file names. > For example, when the Dired contains permissions "-rw-r--r--", > then searching for "r" or "rw" will be slow. I know. That's not what I did. I had started the search using M-s f C-s, not C-s, however. But let me check for my local changes to the repo first. Maybe there is a culprit. > Do we need more optimization for such rare cases? Not really worth it I think. One small thing I noticed (but that does not have a large impact) was that `search-within-boundaries' is called repeatedly, and the binding #+begin_src emacs-lisp (subregexp (and isearch-regexp (save-match-data (catch 'subregexp (while (string-match "\\^\\|\\$" string i) (setq i (match-end 0)) (when (subregexp-context-p string (match-beginning 0)) ;; The ^/$ is not inside a char-range or escaped. (throw 'subregexp t))))))) #+end_src is computed every time with the same bindings in effect. This could maybe be factored out (i.e., the computation could maybe be moved upwards in the call tree). Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 03 22:05:11 2025 Received: (at 78520) by debbugs.gnu.org; 4 Jun 2025 02:05:11 +0000 Received: from localhost ([127.0.0.1]:44272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMdV8-0002p5-Ro for submit@debbugs.gnu.org; Tue, 03 Jun 2025 22:05:11 -0400 Received: from mout.web.de ([212.227.15.4]:35033) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMdV6-0002lX-7Y for 78520@debbugs.gnu.org; Tue, 03 Jun 2025 22:05:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749002688; x=1749607488; i=michael_heerdegen@web.de; bh=ZFQZ3T7GOPUntAe1DSo2e5zxVVdUyVXtH4KGgldflio=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DYbDg0Ke7ObXlDQ9cCpg1+JrbfJaFb5nxmF5io1IKr477o2o+SzooWo7thnXbKYv S+m7cwKAgjpOgYNSsFJvb+e56o/hCI6fQbUGxkzLJyRpS2boTEwyxAZmD8jV2BZW/ yli9ZBWwiHfBt4+Byyx7N0LHwLAqUsJOEHKTcjMizztcLNcsygvj/U8TdiNrJIkPd XqL6fSPcJiKKH9eHBTufRPMXrBoeXERV0+OJeBCJ6jhtW62Jr8mo8P4N7Y70Jpq6V nLHtS/QxELzCMKO5npoxFRhuLiaL6Owi7JFAZPW/mRi2zTiC9K1MRUgbhGKUE6qYJ KoGHi4D4y2wWmiuBrQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MfKtb-1uoHTA3UkN-00pmaT; Wed, 04 Jun 2025 04:04:47 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87msaomgab.fsf@web.de> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> Date: Wed, 04 Jun 2025 04:06:28 +0200 Message-ID: <87iklcmfa3.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:7sSUDc/BgDfiNkW7MwEDkHNb3+AdxSzxczFFd76Tu2TFo3oSOA8 Xn6/8pejnRbM8iklmVhaiTTtxsHOLh08g9ZAZ1JfWWdo4zCOFsdNM3OOoAMiZc4aLX2i+Ka O+5+eOWWcgKVzf+oCB+8GgoyDfBB/Xp8iisY6FZinnYXDNcGxBWjj/9829Sr1FZCxYMH8sX fa2CR9inH8hYZ9EL6PgRw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Vp//AODFPhU=;WrcTGOkk6aWPVEIY11ERgZuqD0H o/f+1/lf69kpK5RhmvprBUEiFC3RUgX1o+75zqk6APRkve/wRgszt9+5JEdEwLQrXg/6ogRH2 SOFOaxUbrqKITceSVUFKIHpwask3HJJ69M6WSrP1P53iAQaQvh2+6tHM+ldbUvjFYTQI9m/Fb LZybqjt+idLjm9bg0y9aN7exvfidRWzjD61MGAXFkIOdc7WdTQFLGkH8GK1tTqwFGeQYoXiPL 0qmb21pb953bQYyBQ0b3GHFqccfxoc4mayO6YbioYlbaa+gmOud5n2gqghajBspWhsotEfJHR v12W3eHPt6JkMsm2ltAeLqDM0w/lVL9U48wpOQCJWxepztLjfl+oVL52XRpKnrBhxsMe7lwwS e0k5Mqo74XBO2ojXP6NqrfdPtCZtWE63kicgTjviIwxqeOHXYQgvkdwXDbxxHnZcY+zAUOgLh gyv2x1U7AVfZrJmZ1p1zZUJYfCp7EqMapqRDPd8hV3kIPTyjcPiWjKCxsJZ8FgU++EPqH35Bi IoQQSuB1q11967XH3jsPDJNB2eUBD0nTvEYwgYnziL7dErQ6Y6hMq8V7nCOuY+ddJLpbpfLnK e8clVFGoCX8eC2UXkFUH8Prbrzy+t8mjN8/BvKMSWxgmKNRlS9V34mcB6qIszwDEYt+BmgmyU acxIWX7KSbxbNXFD6ZvCyv1xxUYutnNkE0nm82Zzkf/vaLY8t76e5vuP+eu2iAfoVY/lkxMpE X9KoJG63aX+aecVLxwVZ0AD7hJtz7UKRqhlxvBKZCM6tvtjfPUYNJwuTydYmUnbqCqyhqLyZg WnKjgJP7pX8wmz63OBiMZiaJP0lmQoGruhSTYx7uLq38qXL9KiiV7rABTZOya6M7IBGRK57ta MWMSIHLrquBpJluxzJZJqTVrJ7nSJPK3AJ+r5+pSxwkvM0Z0kWNpoQ0Wk3V1ddncWEqh1yBGY eKqCqJYBEJcsounEBCjxd6xA9/TvKuDHNZZPS+UkU6uiQ6D7tgW75QrB1O+xcXtnQ+AuxfItH L3aCrMprk4vrzro16qD+rUvrS/2U5NXnwEA54RmeS7LggCLdLSIXOPp395oNE08KUDtmkXUoq KlJHgBbkN3DLNrcO150UIPSskv3w03Bi9XN62AfF4HZjxv9PNPdytWGue5SyAlWyQU8AO2vgJ QpJeiylzQl9GEBo06EeUSUfhgbRi3L/PNmGgd3PJJEh2e5X4/qh5c6osf/cdmIPQMNuAVYzO6 sJcJragwlr/5Ee8mQaMDKLrCXhkUI/4LOuLCjB/BWZO4/RM06huSIfYo1AX+9Xm6faGgE5Th7 Ni+z9OCSNuPev6k4sUdoLvSavs9ZUchWpYf1cS/IDbMZZeZ2yO0vE0feHlg6YkQCb0Q4USnUd MfeZg655MmVr6UvnpSXi3gcn3ReLRuwudjxKgu2+LLuOXpYTVF9UwXnoBUm1A0zcZQvNYwZO4 2qx3nleEtU2OVPwVumJE9oj7nFabpiivHTse/KlL5xi4gUjs+QGdob/MJVpLooiXJtyO7SHZv YvhW8YGT8vYGvu0D2ezazGIJCJNdBN5Ueg33JguX20nEuwRFhd3oypQkb0INTleQB+PDmHAqt KEvXGDwa4N9TZ9SVNqpCWl5i18xxSvC+VRUL7z8uJU+BmC/iZ0iBXgz1Ozsv+few7YOHHdp3E d+ufxAWI5vksv4kpjIYff3JzcZHlpfAm3RazXILCvyzjSpWpM7AQp2Avn3MoSEw8pt1UT2deu a9dDmNv3ACM1mKkqJEJeHgFSF+L1w4sF3cwSyaeWQ14/CQ3Rf6VLo5eZtX4vvjmQZlRC4Kj9C 088JpTKR1Zw63WMKKo7Iz1/je7CKQjBSOf5rUDbm586HLNSyyXVAcK+Nx5+on6A8oivuE5G8D beb4tJpnTo0xKfrIEfJS96YmVLj08g0MtdXgJj6Ir8cFHcDBkeC4NCUbLMiAc5L3iB1FUABnS Hsp5Rj4hlLa6Qty+JzG+76fBQyyoPXmDESSkjqmGegx54HjzWx225IpSLB45/mnzt50YpEdHD q4gZKqr3yLGcNVvZSDIc5lJlmOCKn/QngjKpeN+RPMjcd8Hs+NwzGRF5ogDTHyyqPhzrLoN1Z bvgJM2mXWEljJP5dXPTxCFB/ao+qcaGr/DCO+hkDO6k1Yuh58yMXTObwvogg2S7MyUs5fZr3n rFMNIqqTfoodX7+vNaJzXhqbC79Rl6JXa++Jev1I+ctHdDMqw2jxh/TRMy+pygXweNd2NYqaL 3lckzOUNNY2lXwgVaKZxG8BP4Y67pkKB7Z6DKl0rGu01FuhecI+bLa53Z2H1KwQr8ebqMuhpL aLEBTJgw2U+aQgynqgJKTcJmuGleEAupPz129BS9j4Op7JsCsWS0i8+96Si2tkfjk2APPF9Oa dGePmiOLZWQpT1ktPoRvoImHU5+GcwAhG9JMkEeBWY3LV4Xjg7YrzSqi0V6i+ZSl8PURc9kNe rZDtM+fGVt+1/ArnMU2lqbklu2yJMaRjNOrc1B8W6R1q1Bsyi/c94Ghh8g9dulhcboHxteNaK GTgOmJ2xZ4gd/TaS/Rb3rG8HeweK7kZYTup1ustCWph9BBEjR2R+pmTN1g0o7ofrz4rKwGiPR TvEa/EsL0nlel2aoXfW22k1uJ4besPgZ2R6foVPfpPlzpSAiV1OL5EmhsvK1rEI2AeyfCVcdm 66xqYfdFe42lWuThTlg3x/eHO0F7h1Ezf955xpwxyvQjBaRq38DqejHoqP7UJ2SVcPznASFHK 61MUvzhA7a0DGgxrvR6aCVIaXMraiBBn2lIOlG/uF6Ech6+41w+28JwGVw092use1mOveLA2K sTbPfZ0Ia9vsO2s9cFUI98JyGXQbuXg5RFCyfMkE40J1pWaZPXFuOAGaIwft0V5L0f5teyxFA xfVdAXg02B0wBl99XZfxCW+LoJZyKb4AA6vteP7K87qqf0slYe0b3sTZysUaVUCU9KOvsd+Tj RG2yUWdjUX/GX92Dg9qHcASXeGlxVCXW6jBOTtT7nLHSjdQp7QvjBnKL3kWdJ3f6zOYNiW9UW dELrjql83JGzpx4CvfUfuO8tftOaGGvz7NOeGnRRHLH8T6IArKReRACSeygWPKR+Pl29c1Gu3 dNH5dZAIGj9qKnrageaL5+2+YaPcBq/Kb9JA0PSM1hCsZXR0lKZgcL1Hl336rXvXY95m9UT2a PV+rqOG1H4gYlE96tlpJn5LAFx5r9zIF8TPSXk2Z3bTx4vTb/rlQGL8cZvZ9BGeYsO3p/Dhgm AxtTZ2S+d4LpKd6P X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > But let me check for my local changes to the repo first. Maybe there > is a culprit. Ok - good news: it was just that. I had a pending fix for Bug#73018 that caused the bad performance. Without it I see a very good performance. > > Do we need more optimization for such rare cases? > Not really worth it I think. But if you want to give it a try, don't hesitate either. If the user happens to search for something like the user or group name in file names, the behavior is annoying. And a confusing surprise. So even if it's a corner case, I think it could be worth trying to improve this, given you have the time. Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 04 02:15:11 2025 Received: (at 78520) by debbugs.gnu.org; 4 Jun 2025 06:15:11 +0000 Received: from localhost ([127.0.0.1]:45975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMhP4-0002JA-Et for submit@debbugs.gnu.org; Wed, 04 Jun 2025 02:15:11 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:48661) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMhP1-0002Dp-OP for 78520@debbugs.gnu.org; Wed, 04 Jun 2025 02:15:08 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8007843B22; Wed, 4 Jun 2025 06:14:58 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87iklcmfa3.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> Date: Wed, 04 Jun 2025 09:12:18 +0300 Message-ID: <878qm8f3uh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdduieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhitghhrggvlhgphhgvvghruggvghgvnhesfigvsgdruggv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> But let me check for my local changes to the repo first. Maybe there >> is a culprit. > > Ok - good news: it was just that. Good. > I had a pending fix for Bug#73018 that caused the bad performance. > Without it I see a very good performance. Does the problem reported in bug#73018 still exist? >> > Do we need more optimization for such rare cases? >> Not really worth it I think. > > But if you want to give it a try, don't hesitate either. If the user > happens to search for something like the user or group name in > file names, the behavior is annoying. And a confusing surprise. > So even if it's a corner case, I think it could be worth trying to > improve this, given you have the time. Searching the user name in file names is too rare use case, and still can be fast when starting the search outside of filenames, i.e. using the default search function. > One small thing I noticed (but that does not have a large impact) was > that `search-within-boundaries' is called repeatedly, and the binding > #+begin_src emacs-lisp > (subregexp > (and isearch-regexp > (save-match-data > (catch 'subregexp > (while (string-match "\\^\\|\\$" string i) > (setq i (match-end 0)) > (when (subregexp-context-p string (match-beginning 0)) > ;; The ^/$ is not inside a char-range or escaped. > (throw 'subregexp t))))))) > #+end_src > is computed every time with the same bindings in effect. This could > maybe be factored out (i.e., the computation could maybe be moved > upwards in the call tree). This would require adding a new buffer-local variable with an ad-hoc name. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 04 19:39:58 2025 Received: (at 78520) by debbugs.gnu.org; 4 Jun 2025 23:39:58 +0000 Received: from localhost ([127.0.0.1]:54834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMxi9-0002PX-VH for submit@debbugs.gnu.org; Wed, 04 Jun 2025 19:39:58 -0400 Received: from mout.web.de ([212.227.15.4]:55065) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMxi6-0002P5-U3 for 78520@debbugs.gnu.org; Wed, 04 Jun 2025 19:39:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749080385; x=1749685185; i=michael_heerdegen@web.de; bh=RGENHtyAjl/8DyBPR+loSoZIpPgwcjYvs/77zCUvmcM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=LVEoxLsas/ldq+BJIPhBnwvf8a4simK080FyEypSZnk/hhDD5AKoy+R3sTLQVAlS TemvmaLSWmw8afW2CPyt8FsVl/APD57ABRfMdc2JHxaUcV2+zKgLFPMbqWSQCoIH2 hDY+UCBbQiy3PvDrDJAQCZgJPqgJSPYr3PlBMVqndEs7xTiAIb0+/89y33eWCGfef 5aF4T1quG7PlB2lOZeyBcI4YiNdHuQZD28LUdLL2BAbdaDbxSfUymKvl5V2gq3s1E fMK5Xv8yB6/7W+cDXO3lAfYJFew9L6AczKRIRvOPAVT2GbhdpK6+BWI2lsEmfmfv1 pLkETuCWg0VPfPpWTQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.164]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N0Zns-1ujqFh2akm-00tGbG; Thu, 05 Jun 2025 01:39:45 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <878qm8f3uh.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> Date: Thu, 05 Jun 2025 01:41:26 +0200 Message-ID: <87jz5r5b2x.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:RGzSiTQKZFuVN90LXACeIw8uN0qgtwrKaezYf/Tf/bZnXybveQ4 3+25SgYxjacIEbgc0XB6CpAkxr6CIOrnmOTStnpjB9XeMf7yLt3T4KgIxhQtkK+c/pPdh4V RCR8OjBvPgezI7ZTyXVQv6FI2hga84tPCV3eVfcu3uiFByzbplYl0qM3NdS6eXc6Ek4dV4m Bqtdpa6MT+wcXp3Ju3psg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rialcEowy3M=;yqfYm6prG1w1AxTDM7IKV05m2QA ZJtZJWdL4En1wRgNIwicV8UKVyRppOqp0ueByEICJHkTZb9y7r8lligBW81J1vthFxmZDd0sX /msqj1/zDbijS3ZGFf3EffH+a/9iFU8RiLMXfdPw0okKp9yNbNDAVUWxnKgorkZ9U7OlMsNpO EM4T9Xe8NAoW70ArLvBEnrc+GPAkT4XqfOlFwhg6J8N+DWHydQqa3Td7pgAhNSr8UPjV5J61j mdDOgG9nylXGCv7fOkC22bHR5uFqFTKToz3WZ9KTn2qXxv0LmjvjU+0EDC+RDO9PzekOHJtfw kSDSTB+k9JH7PSuCWucuTVx4HRCtzpxl0PCqCN+wYKGoQi7uFPGZ7Sl7kXKH2GIHEsob3TCPW 2RLIZhe9rkCmoBjwyK+46plDJXeOErF2hFRPWrVZfpmW9dhF9SnMeevoI57JkS4T00yGGnVdD IMRAaXL4VM+igOUwlUvEc9f3ZoaMJgH3HDVAgWEahvyJVItI/AnybjpS3p2Xi1GcE31CGY2Ys U0ZJWuMIgOcABC94wGSiG2UgHEKfMDJWpfKYWxxHPtV1rJ5Th68NMnZdJr7uXWGE9fpPGcMN6 5xvHg66iPk3aHKOkIPXZgP1tzPG19bKfbZqAHTTA1t1qVuOQcFT88ZAVDhHn7/iyhMXSgDq5u 8ARKPBYGGnsYmBJVa0bBZzK1xAC/J+/2/hRFvyCDGqaahKk70oeTULuoG4ZxlKMb5+mdazfom UbTFuGQSbEo8BL/Tta2qq5ErAwXymaJAPWzy2Rvu9jlwuH1FK/hLOCGVo1Wk5i3YbS7vV/8wN pAx5dnjABCqm5aXlKskTNCW4IFFFKMFG7qSNUVQ7YulgaEuU1/AzfX4dLxfjcutxxP/TtCNK5 jbmGHrlSHzOK4jnfiuF6eI50+W34cwS4Wa7bAtdwcbLQv69tVeNllENx0rTyuMS/D/51j2P6k lf6g101gBCGUtkYkmhYk5uaBXyM8uWeGLlwQGqOg/1KijNKlNwBfAyTEvUapEvmqhGQoCMfjc a21hOWeILn8V3DXuXgxN2PVDW/fBKmEflpNjtiheLghgy1XdUYALeN/tTs8wirUH9MyakXDM/ ki3vqHiiAEx0dfJPzZsjAOSnNcpXv7fWbX97dyGjOtKD6FoMxxXd5Z6JlqWThJRPkIB+4BHsY zMmKK11ru9Pz4XQEPRphMDExTOyBhaY1NSGfhX1SjIdbPaa/i4CKKZ4KNsCMrRYDLCbJK8xC1 qdcgPwFgSsQlbEykqbsyEBZmVXj31YdtmrF7oe4AcmWfLfcLtSJtqjf8NK7KsPf2IKJupV64+ HCJpIkiwRfOpjLTgF9Op9SR8Z0hpi/QNQRgvvq7FvzL92mzaBJ6pxKIVCwL1+p47crR+gb2I6 dTQsCtYMP6cQY4LsDXlLVCq5wQVxx3xHoqxa5bTlpvc4kz4Ie9ip6O6Q/QW9kPYq/IlOM+Sw+ BPVdV5PoANao0SMMtmXKKkU9BPAYvk4KhbL+e+IChWzXoHRgnjYiaJvqX3UrH2yxc3AQOW+9G QwrGG2RlWpnIzWzE6CoyX+9IIHcTdUixpiUcCVHA6hcfVZ+DotGQ8W8uXp2d8zqXVJ7azizTy we/UhbbXOqZwoCZGASt8rKALILhyfh9DKJv8UtxXTgHRZ7phQ4cmVr4lc/lzekTYL8vwZaB2S +uICy9XrYBwByixmqfnnarfsouPIr5Ix3/mXtnLx3ga+R18BC8c5P+/V8emFm4Kw26NIh6oYm ozGoA1xLKXo0HEIsrfyuCg+HlYQk7ns4sUCvDpQ6+NwQ9pI5ei4tJk8SJTULJan3pwG/aGz56 H0H48fvpF1zVpClHWxlOlY4ATxj3nG3nHdXwAtU7lZkzs0bo3IOg967p6ona/TGqZrEd09KoN NsJHJCESUp7S/YS8yL4WBfunAadQ6H/02Y7QsA3ObaiREek8/TCh894zByPoX7/H8iX7ns2SR 0C/kLJGxPpboAfGNvPP71GhTTuq8G8dEEJT3v0rLZIRhQpvdEVehVPquyj0WSSN+dgs1yUcjE zkTMSOtlXVOCBb8j4DBpKU4jAXcsolkexbN8ME5AMPJX/6OFlW8/Ue2Lp94uHmLopkWk78mzw xs3r5e/Hp3fmuDwjOfxkPzNVuZrU4yWI/E4t1uOLDbxidY1shdwXoLYWozeWe6PHKD6p1FoR3 LiagZ/5mMXEqvQQjKFnuvah521BMEBsy4QP9MXfRF9F04XIhuw45aso7qm7V3EmaAfl3rDzq9 JZGvnX3Mm2Yn/ObBzAeW5y1J5Hp9yWowIQ+bDAYZeyZaCyEJrsqphkY2mc+9lsrKSlptkg5l4 7Gr2DK+d1CSaoveriYwODQBsY7nu6WfUeFOTX6hKCi8cF9rKx/+4N5GrZBjvEXCbsRP/vjAPF QfA2ExLAwojkpTAy3g1GZI46Ms3avUbseyjqT+aIO+SvQApwCNR0J5avCg7wglBl8HImLF1jg 8IFtVEZgRghD1JWrKeZ/Z5xIh6WiqM5SmMbA/V6sTdERL2hSqJOhAAFBmydR0yr9ZWXMVNy3C LNjDyBa4hU6up7Nrj3kUrLNyCg/KS7Z/AXxF0LJ4OsFmAl4798RDSI8LkjlMoHeArVIPZL+aH zCiO0BCP2N/A0+XPtintWFw/Qz5PKmDAsvZxpwtjjHZIDb3znFUExv3a0fHAwBEa9pSoCynJP 4IfhUn9lfhyFjpWRYz+qHZZe2gUkM1dOhdrzjj6t+WPrVyVzfHMgE7Fy4W0m2nyF814b6y4Ts JQCY8MkHKmM1v7q3yki7Uj3Pesi0FshdDe1ETUmmqirD+5OV3iASasmwCcVfYH1xHxE7qgJNW oCio3UQvf5cCddUxFvsxiE0ebf9OvD3+GGcJIc2xh2u92rmvXUvtTT3PKfNUEMoit3Adjt09J 73byZoyb0AkCJiF30HVQtOHH24dlIwbDAWE+Y6OWxQZL2ivNbG+sLnpW8sa+AbQe11ZxxWdpV V8Y2ezRBRU70D7lWxSjOnULi65zSt6QPhnbHznMMu/A6x8EdEyGKPWM+bdB+evZzQYXG0l2Xy HKm68MiyEhz9JVDZnzpTH3eU1mUwAn/i0TSRb8HPHrbN4cDrsxlUVwKJgFisbF7lWFjhZZ0lp azdoBaAIdxU5+CwrUPPV+BKb2TI80IpVXFzsHJ01hjYh+aO+/9j9Aw1jCp/VQonZmPk6Sv+K3 yY2emXYeXtA9vKpeLhUytzUOTNFhET58WQ/enpvtOniGgc9v6t0sntVTiXxtCtAHJ9NvSWYRU dfHFYsRqugtj6IdLaPfR3V41NRnIfmID1qseAA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > > I had a pending fix for Bug#73018 that caused the bad performance. > > Without it I see a very good performance. > > Does the problem reported in bug#73018 still exist? No, the problem discussed there seems to be fixed. Good :-) > > One small thing I noticed (but that does not have a large impact) was > > that `search-within-boundaries' is called repeatedly, and the binding > > #+begin_src emacs-lisp > > (subregexp > > (and isearch-regexp > > (save-match-data > > (catch 'subregexp > > (while (string-match "\\^\\|\\$" string i) > > (setq i (match-end 0)) > > (when (subregexp-context-p string (match-beginning 0)) > > ;; The ^/$ is not inside a char-range or escaped. > > (throw 'subregexp t))))))) > > #+end_src > > is computed every time with the same bindings in effect. This could > > maybe be factored out (i.e., the computation could maybe be moved > > upwards in the call tree). > > This would require adding a new buffer-local variable > with an ad-hoc name. Or some kind of reorganisation of the whole logic of the involved functions, but that's just not worth the trouble. (buffer-local variable... would we not want to support multi isearch?) But let me please come back to wdired, I have some questions about that before I continue to experiment: 1. In `wdired-change-to-wdired-mode', we do this: | (when wdired-search-replace-filenames | (add-function :around (local 'isearch-search-fun-function) | #'dired-isearch-search-filenames | '((isearch-message-prefix . "filename "))) | (setq-local replace-search-function | (setq-local replace-re-search-function | (funcall isearch-search-fun-function))) | ;; Original dired hook removes dired-isearch-search-filenames that | ;; is needed outside isearch for lazy-highlighting in query-replace. | (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t)) Does that mean that after switching to wdired there is no way to switch between filename-only and normal search and replace? Is the behavior determined when switching to wdired, or can it still be change while in wdired-mode? 2. How was that - was it possible to control whether to search and replace in the symlink targets? TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 05 02:39:45 2025 Received: (at 78520) by debbugs.gnu.org; 5 Jun 2025 06:39:46 +0000 Received: from localhost ([127.0.0.1]:57844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uN4GP-00043N-Hj for submit@debbugs.gnu.org; Thu, 05 Jun 2025 02:39:45 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:48849) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uN4GN-00042x-6b for 78520@debbugs.gnu.org; Thu, 05 Jun 2025 02:39:43 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id E0DD943A07; Thu, 5 Jun 2025 06:39:35 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87jz5r5b2x.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> Date: Thu, 05 Jun 2025 09:35:07 +0300 Message-ID: <87v7pa1z98.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdefvdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhitghhrggvlhgphhgvvghruggvghgvnhesfigvsgdruggv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > But let me please come back to wdired, I have some questions about that > before I continue to experiment: > > 1. In `wdired-change-to-wdired-mode', we do this: > > | (when wdired-search-replace-filenames > | (add-function :around (local 'isearch-search-fun-function) > | #'dired-isearch-search-filenames > | '((isearch-message-prefix . "filename "))) > | (setq-local replace-search-function > | (setq-local replace-re-search-function > | (funcall isearch-search-fun-function))) > | ;; Original dired hook removes dired-isearch-search-filenames that > | ;; is needed outside isearch for lazy-highlighting in query-replace. > | (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t)) > > Does that mean that after switching to wdired there is no way to switch > between filename-only and normal search and replace? Correct. > Is the behavior determined when switching to wdired, or can it still > be change while in wdired-mode? Since wdired is intended for editing filenames, we restrict search/replace to filenames only. > 2. How was that - was it possible to control whether to search and > replace in the symlink targets? To search/replace in the symlink, 'dired-isearch-search-filenames' uses the text property 'dired-symlink-filename'. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 08 23:13:10 2025 Received: (at 78520) by debbugs.gnu.org; 9 Jun 2025 03:13:10 +0000 Received: from localhost ([127.0.0.1]:53443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOSwf-0005Pb-Ve for submit@debbugs.gnu.org; Sun, 08 Jun 2025 23:13:10 -0400 Received: from mout.web.de ([212.227.17.12]:40393) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOSwc-0005P0-43 for 78520@debbugs.gnu.org; Sun, 08 Jun 2025 23:13:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749438772; x=1750043572; i=michael_heerdegen@web.de; bh=2VWnJlEpBkO/zl0PoNeiV86SEdHxi+5tNP8s6c+uCMw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=BDFZqACmm+SHkUvkh/O9OlEyxh3fno5UD5md5oemDRnKf7J2WSDMrumWu35lQdkk VUg5AfUsWbCQqaiO5t0wcyADtP8G7iG8eWPCeyGPY0zRsowMc0ECjsGHoHjDFzTpX 6LI9DoKLoRdkx+tYIeQ8NJQVjq/TsqIx0JCoMdfFzY0ZY2G/4BNVoV81C/Rx2SwH+ zZQ8FAnv+T1U8qUKWNVXmFRzPBsiji/kSTUPPQECJwCJ6Koi+Bj4NiMl8sTvIS8fx VtTa/kff2AHYJNAUslFMcrf9BOhSkv5x4DTWpWS4f6t8L4ex9i7oHqehvqy5t+vGm FcYzMU74dct1obOYbA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.69]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MjxiM-1v8qNA0anw-00nok4; Mon, 09 Jun 2025 05:12:52 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87v7pa1z98.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <87y0uqyi0w.fsf@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> Date: Mon, 09 Jun 2025 05:14:31 +0200 Message-ID: <87a56hhai0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:dgxDUYf8ioiIGd1n8yaZQYj24JMo0eqB0Q3jow0e7LhbmattFMT N848DgMCjUZedkQ+xOiMVonwvCMTv1mCqHy93obTkTr1TxOU1y6qxysIp75hwIkhZX5zKv3 ibZa56PCb1E+MEvNFMlZXsatAPb0FY+yAfUJsrTLWgML6W7dCq7dY0dP+Nqe88Y9Gp2GRqR vJmqQn+FO+luHEv1R40Og== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Mdw7CnBaDGE=;jzIY/NufmgFHiX0k4PKTNcltS24 6kcK3nvLl2tw16xJ5vcfZe9yoBwYj5DZtF4gM5HibaYTL480n8egupp4dXFnSRrHdxC5PEafJ 72is03K+imwn37dUSU8NNc91OGNcxs3WHTZQ8lXY0mrSYw8Px/xzWxu6TFTovp/Ukk0iQcZDM JJ8EjbVYmDd/g9ouu/8Bjdx9lY+Bal+YSbt2skfMPYZJ8iJnxbIjFkxRCi4J+jm2m/jzD3m8K YNaxEFMwDVyyBgF9w8jgG5Lt4EV3UB5ZdUh5mA3i+2XhHGIphHxos0/FM58jb1fvY5ykFaCzO 5Sx6CLiETxNS2you0azMRs+onTFNpEIT5B+f3mvLs/dWgE38szq6XyN7AuSoeC+bR66LD/RN4 Ck1X2gRA9RrSsq0VTeqQosTdI40IrZ8JggS/8+inwG/t1pGEQwdQVewzJeH/Z9pcJV6UvieXs uJWRV2O9yG9Dy/ZqNOO67uzfPLfcACy7NlLb6L9CYGdke/o01nGNb/vFvKvRmNbDO+G2rQy8K KUn+y0eM2ItBm7ZyOtEOweIfhuLpVwtLJ+6Ce1rfx8VyQ8l1cVxFJ2PlwTsZBRGNsHsiUV88u vNNtZIoWLmMB1Hu+VxeXXxQJnhlWos6a08iZM/IEIKlCxLlIrpW7GS+RcL4Th7ILjpuG1l7+L /XbAeswm5ohTbu3SR/eEvXr/THWGhPHRaYQ845Pjsec6E7Jg/SU5huVk4Lq9oCrCyoHHBx2kw +J4n7Ux3CXoVedSOhnCeT3vdiNFsgLXF9BPqB2YbvZtcl5gUaeyZ9EoeXI7Zp8ZIC5RQDVjHi SIerjKgh9pRB40eH6/+OSIHCM4WBd25fVAJ2+SaiiKOuEKpMERPGgIMYBbsU5KkvYdqeTpWPE iajKnhMqUBaSQMi7+aRxgPhNGE3Ar3o8dIqQsLcuY2sTnFhko1CdrJ1s4idf/VxEHc3WIsB3+ mBlCGvhFBU2OQ+H/bm2mt26FUarVhijb//Rzab7OFKX2JQ2eAjyp/HmGqqRhp6fBaz5TkkXxA +y2RSto3M8h8V6RnYOusrl79w/6d2tf0buL09nZQKsYAXDUFhcNB/t9ANmW191LU1JdsocQhf vVktO8uXmehyLrTsRit3lDdAyjBWu/rPFr7YXRuHbmf9Yl/ckYtZFSYXJ+L6qDOXSX/tW1zCa zcjHIr/McYfM8IcaU5BynwoXprskmRym+lJ65oa7x4x75xJ9t2TnBVbrvWO8PiYNAF/YOyra+ 0MMj0b/lNMJyUqan3Xvla8DGvgAcXTpGtY4bbwEGcQrw4fi6SG4tZljfArdk1ACV1V1Sa3gkg A3JlNb3gpHwqjMFO2YhqV2UWblBWDp3zNf9WuzWz9s2qwh+TMOEg4fMk/zkrSQvbybM8v57A2 JpeO0QzPG50PVss1FeRhroDI6U3WLfuI5hfbkEq0XEeglkXV52PTcwVNSBNT3eLaw094g3dZK QRQUFEL6mS/9K308YQiRv5CfAAQJNjuPtIhTdnrDuwSysO61VsvtZVHSVjHEBANizRQe0xFP3 rpHMf5X22D7rmQQhNsKd1u6TKTHkTqGdqCkijwg9us55OvW7UBpnS0KD3L9O/dJNAti0bWYKu ARDPTbHHBeoK20Mgua/4gXF4uPAt/lzSz6d4qAKPhrKJvDz2lJOqKNWqroxhfFzp/x3Kz/AtO oiaF6k3DLucd04Qm4mySZFM/3ZrIuZvW4TFASDdjzokM4r5jDKewlDNIoTlh6faResYtU9E+l DdVW11QDNWjB929+RMIocu+3IneO98Sr6lYWQ6LX6VxTEcjBJ9fbGuVjrrhc3ymmw+VCLHwxY Cf59C4ntOAp8J9SMJla4X/uzYe3M9invJGJFRE0O6atQ1TMXzqCbbpzsVKHU8FKFRYhqTHnQB 2peDqq4EnwDYIUtwjr46HT4uhAFKkfasKmFQOu9jD0JBMtR0mUGLTzRPS9atsavuqC+Hek2hN gF/KOBXj3XXAuzzqasuT7skCWUeZMoWpnaMezrVQHghOPkn2yoOEZqP6AebaqglOTUp3H2oyC 1S60hxldoS2bc0MOv1W9bKzoqrBx32AW9nfEyRoEAjGsBNpRs74YQ8fmAqi2gKmRNz9rZzq0x cjSCxoo/fsx9JtDKqe2ZjsmWrwgxegOr+5zEhq0e43kxzK76rMSCHxqhQTJpaOq5QP46V/8Om uO3AHurQa1n1c/u0VgINMFN2cT7Y8isTcMlL9I056s4ZX//fDqVHt7VbuL3OKiTquh7sZ3gUX m+K4t/0AJirTShu1rWZXB4t/nIdBEhqXR9ZgirMdAc1WaP9kavfE7QCHENs/P3BWPwzhOKb7Y UN+1Lxcn04G4nnK4i8kZ7gXgwyCkg/4/R9gzU6DF9R40GIoPhSMmytDehye9o1l2aABJIsCIc +lzJ56AVBzU+BMQbt5DaSWsY1a2D6vfujGtwDKW8p+6pvcnPpoXcXLWWSb7TqgjxYAvlFCMnp KPMy2P35WjHyCF64uNIRf6JxqxLAKiJexz3NWVsw3+RnLbU0FRqpEufVXDKEVbsy9EW6dlMl7 0EfN8TYu4kgeRSdl7mMU/A1l6wkIqXZd/PppKc/ykKt1v8ffyAb0WtIe388ntMDzGGBPL2EhD GkbX0LAlvHb60q4xhyGfSqf/wsUXkeb0niSrsJw48ZBItZFoFZqDbIz83IM4dpSCL7GiOZ5rJ BVSVjXvEv78G1HdGiW8uaJ+glAcrNwsrKKYCQu9ev+lJ26YBUYbYCkhEcR0W61+vRiINi6BDf t/Vw32+N6jVbamnXsGcM429evm+wnJ+N/UU8gcfG4Xu4JKeF9N0Yjo082oDkiD4NcxB42Pb68 uPr5ns3jhboqeDkEX4t+m3AgYX01S0Ai0OZFULSs5OJ097tdiNWBTS24na6UEgAHqFPaBYPWq Objsq9eBjDIo90MtewXIL+bBTVlZjlhfCm9SJe/upvfjniMuyIWLslq9EFJzqAP3uYreDJ+ye IyE4ypax3XNGZHgqTgSXS1U529zxh64c6/vqwQxDMt9mNqMUoo7YTK8tKbl5TAbv0KhB6q6QH cWgi4QIaeCGnzqyAP4W8v0T0oJKvw7UW1ddUbhYzyaNSxeFUeSfGbWHrqTH1+Gqd9pdkb4XPb R5NxpXlDhH21TxA6rY64PTJ1HVUPbR79ak7OEcPImrUbmTk+9K6j27rAX4IBbn2nZWQj1F4Ne ZinRtobUZeYGa79rkQ0k+UrhhUnrJRes2ybeTGgWPMeXCVEfAcLAQO9Bw5ggkn/pgw+mF/qry dh6fKByPLbG7dPWk X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > > 1. In `wdired-change-to-wdired-mode', we do this: > > > > | (when wdired-search-replace-filenames > > | (add-function :around (local 'isearch-search-fun-function) > > | #'dired-isearch-search-filenames > > | '((isearch-message-prefix . "filename "))) > > | (setq-local replace-search-function > > | (setq-local replace-re-search-function > > | (funcall isearch-search-fun-function))) > > | ;; Original dired hook removes dired-isearch-search-filenames that > > | ;; is needed outside isearch for lazy-highlighting in query-replace. > > | (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t)) > > > > Does that mean that after switching to wdired there is no way to switch > > between filename-only and normal search and replace? > > Correct. > > > Is the behavior determined when switching to wdired, or can it still > > be change while in wdired-mode? > > Since wdired is intended for editing filenames, we restrict > search/replace to filenames only. It's also possible to change permissions. Anyway... > > 2. How was that - was it possible to control whether to search and > > replace in the symlink targets? > > To search/replace in the symlink, 'dired-isearch-search-filenames' > uses the text property 'dired-symlink-filename'. Ah - right, that was it. Thanks. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 09 02:37:57 2025 Received: (at 78520) by debbugs.gnu.org; 9 Jun 2025 06:37:57 +0000 Received: from localhost ([127.0.0.1]:53676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOW8r-0006Ri-0q for submit@debbugs.gnu.org; Mon, 09 Jun 2025 02:37:57 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52411) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOW8m-0006RF-Vo for 78520@debbugs.gnu.org; Mon, 09 Jun 2025 02:37:53 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 54C251F65B; Mon, 9 Jun 2025 06:37:45 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87a56hhai0.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87jz6abiyg.fsf@mail.linkov.net> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> Date: Mon, 09 Jun 2025 09:32:23 +0300 Message-ID: <87sek9tq48.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddtfedrvdejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopehsphgrtghisggsrgesrgholhdrtghomhdprhgtphhtthhopeejkeehvddtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhitghhrggvlhgphhgvvghruggvghgvnhesfigvsgdruggv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > 1. In `wdired-change-to-wdired-mode', we do this: >> > >> > | (when wdired-search-replace-filenames >> > | (add-function :around (local 'isearch-search-fun-function) >> > | #'dired-isearch-search-filenames >> > | '((isearch-message-prefix . "filename "))) >> > | (setq-local replace-search-function >> > | (setq-local replace-re-search-function >> > | (funcall isearch-search-fun-function))) >> > | ;; Original dired hook removes dired-isearch-search-filenames that >> > | ;; is needed outside isearch for lazy-highlighting in query-replace. >> > | (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t)) >> > >> > Does that mean that after switching to wdired there is no way to switch >> > between filename-only and normal search and replace? >> >> Correct. >> >> > Is the behavior determined when switching to wdired, or can it still >> > be change while in wdired-mode? >> >> Since wdired is intended for editing filenames, we restrict >> search/replace to filenames only. > > It's also possible to change permissions. Anyway... We have the option 'wdired-search-replace-filenames' that can be customized to nil. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 09 22:28:17 2025 Received: (at 78520) by debbugs.gnu.org; 10 Jun 2025 02:28:18 +0000 Received: from localhost ([127.0.0.1]:59560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOoim-0007M7-GN for submit@debbugs.gnu.org; Mon, 09 Jun 2025 22:28:17 -0400 Received: from mout.web.de ([217.72.192.78]:46955) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOoij-0007Kv-Ov for 78520@debbugs.gnu.org; Mon, 09 Jun 2025 22:28:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749522486; x=1750127286; i=michael_heerdegen@web.de; bh=MaRKT2QBhWTYqNQzQ8GwF2d8yrS2tHlagK//lt7/B2c=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=WtxbYIrtJaNNUCoZqS/UCxVyKLmjzzMoPlRyku7yR0Jcdj4LpmnHQgGVj/Hlvrps ZJd6TwpDjO4NRcZf2HMbecuDCzzWqRZ6Sn0eeZfZKtjqlrk2+pRGI7upz3tc5EDw8 wQgEzi9eUosag2QBufvxGapt6ah/KQvfe+hBZYC4Sfe0BNQfEx0cLTlcAxrapEQoc Qk/5TKqEQjMLuIoMWDd2a6brEbyH8G+m2JgHkC8Gn9TK8a05gx8aILmhOrfWfA92w YEAxV3S4EP6chnfYw6sxUtntxfS9EcfQi4b2n45s+C7uLdBlQCukKVvvhMYPyN/za WiUQH5oSotm3Hb5gDA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.69]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MqqPT-1vAouF2OI5-00lLoJ; Tue, 10 Jun 2025 04:28:06 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87sek9tq48.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <8634cy87fg.fsf@gnu.org> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> <87sek9tq48.fsf@mail.linkov.net> Date: Tue, 10 Jun 2025 04:29:45 +0200 Message-ID: <87jz5k9vmu.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TxCR2SbtjOjtXCcyo+D9P7FmWiqEARB1BZsNzE6Y69bM+7nsfSm afTo237hld+VygCM+W41Dqb3vao5mzBRecAEnApt3fzeBIgbJigmpLxLdyERWIJW94vB8gR 5eC9ITvAccYOJ+iYuoYhIlcoDwyW3GM5whNG+ZnrtZ4cqi05bQ7OQw9nfNShIseSWUrm2/S +qrBHJpA407oMPVvu/KnA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SeWCnqzXJfU=;8PGBl44MjTGqev8ndF+2g871PAq IkUL8nsWP0nhQA9/RmjKUxMtFqj+RIkIkKEERuvW1TwY6qfiTcFzEktqdu5foWBIQGoO3wYTJ oU1YCMN8ZAburwna3a8G1fHGRG10xTe/TAR052SKJ6DsAuzUMT1EosZ4bGJKSwnIBolWP41yy cVlUhUkfo+NRUKQZ+bMKZzGFKgbPRd1pmbz9MoQL2IQ780p9E7XHH2FNXLXMmFYNMwi/mSKyW 14Eefs2roh4gpZlooXFL5bZQT3Yobbnjl++e+FogWX9JEPywltVO2DWeU+yT1emGoClIDtiBh QeSzHUQjrWNXMk+qojBNlYgd8OyYVIPQxNjSCRHpK9juzlSC7HtNyZ2k/wd59xwziRJ8KpjLD ydKe7fNIQ7tQNgjXha58GSmj15EAZiElT5M6f3fdvtanvmYM3W7XC0wwaBXMslxLtze43j3Jx JJ/rYiqp8Ao5fHCTyswz8RoXvwIzoPLAubWFV8wLDGb629Ck2PJHq6Tk1kXdAlvZrB3/XP1zg eeWHp9xEED16MuT+hkaCayKhQPkRm7p+3uWhtFqCU8rThKgidoWHGay7Y8bHRk1h3vzhg7N07 w7vLHx5iXJVy8OuvKxH+4tRT6zfESHXHs2JdC1a5QujsfMqVbgmbMKZBK/r+ig7gLe9jN/Hyb 9zu2l/0p9daBLQTeoGn+jdFGzoN3911b6YgekOkANstUr4QPlrwUL3Hjw783vBShMAsI/lo4O Zf8msRfxqs1ChvnX8aJ6z5zoglCf5JeL42My57tev7s5yb1JHAiWjTKp9sNeojaI2SDPUnW27 MAPcGsMy6FOpFX2lj7d1bwC7SwCp+NwU92gQE2Okrl8BjK+OwFPGLi7o4wYAw28hOqAQt+HUi HVCKomN9qJu8/FXmlJib8fvWj8Z9Nt47MDy59ENO/fSwIBzIs/SeVTS85VkrgjAvVLp56MsE4 1BMksrExokGuQPR1MfR9UqvO3Erdan/3r3kwE6Lff7tLXY9CV+gcI0eGc2Yp/OFazhV4kLRNj N2mHcZvVhPwYwmD10OVxIao8TewJlmvWe9md+oHU4aVvQINWAvycKrWV7aqSfJlEhAF3peUbz Gtuowj9wAniLUutFDbWzAM/rhp8Gy32k+oU5KviHqOoqcJ8Wi5nayQSK0fPxZuWpkvntz5Y5Z cDwW9jwllc1abj+dFVEAyS+E2kkJVdvg2tebuowdLlzo1IDSyjTrKWXdFQ+bOiuUi2zq4GU51 54Yhe0CkE0Ykn0sDDB0tdLKg/jJJrdukwB7XyE8OBlymkQKJo28dajwnhyfXpBy0G1dYBbxvX 6FAIxOmXITOAF+BCQWecvQ3oiuY6NQV81/lL+jjodh7dsxnpGFBoyZpdWvXMK3rUfN0qybuXL iWvgoX/Z1t8+Rd8eBB2lxWkkVkEKU4xy5FPzf6MGxgl0SZIux7X1iQo0oYjAFeuf92aXXB5fj vkQ8Cby7tVqO7Culnctao7LHn9N1/jfKqqQHXla/MCU15H+ZOIwcnYnU0QAyKBttBY5fu1a5k lky9TbzFp0/zfm9kMN1jaD7EJKRV5MQaeGCsMKSh2KpbkgUJEJbZ/pA2g7b9eHhXrYn3hcR70 xGMs3Q1nfA20ng9XeUV0xm5E3oxIvLjPNo7gE4V+fQ2+e2lvrfI4ysU6XZAEKr3JVLI98eMXv uH1/FIXSWRpRT23UsIm4R78zN744TL5xkN2O4igE2Pq/09XTF+oLIpJfAKoeBKJVWDSG6WhcI PDcoN3HARA4daOeOQvr/NBoTyUz+gKBEgARSJFdLGQdHL54s+7XtyoUh6A0vd5ayQbxQmphSI AbgQ5YW7szGkcXgB0PNT/Vcv6C89DC/IUBwHqxzC3VJy0p9WUo47XitzVs1LWuK4NWDL0M2GZ EWzLC9Hfx6eGCsaEI3KXhczYqwlCAXekbNO9C64g3fEsGYe6vaGHhjoPHTp9i0Hr1X7W/l1+K 1jmm60y0TwQsFervi6WIdopCoI3oqfhIJmnWzQEY2uvh5AfktycUiLXM4EMIU2qmqiT/zRN5O cQVYv+kXOt9zdpT8hUYHa29BWNyTs8WF9fI9Ipd9TbLLio71THKFt9H6XofH/mo0qKTl+zyag FgHwc4kAqOZ7MRff2gOWSO1FxzLNBg+Zl0h1xDSP9OfgQlJwKsOn9LG2m7nrWLZjtwHWC+kRO jyFUBMXR1b6t0xW78smZp4bQHOXJF+Fti4xIr75iwbghobs74IrcqP3HPvTY1tWOUad1tvln+ oqewQ8NDOVvpnkn90+NIQma8WL0I+J/ZYb6u4j1JiHiIKeW9BRK6u43Yvx7OvQpe54aXSnYfD h/Xat5+XMcnz8wOzGwAA+OLcT0LKcJSIOQ96t1lv0J50gRr7RnihRp6n+KIceKFbbZVdk+UBJ Mb70PmTLf0oZD0Fvs+WBQQ5RbqGYB++UVfKwZHaz3/XBH+kPBShJMcWKbKl4v5vORrcJPONH5 oPXxlvcZQza5FqY1/Lr33Fkenx8dbDgAAsowgjTdzRI8OZqun70En0rM8CGQqxP4wXBQ9CaZI amZQiUpo3m2VmoK/Y0RP+sPj/uMLV/HN85AvHtGOTJfOLVARZOis1TyYBaVKGjiAuh+uJ04qJ P1slpC4EKmUDcKoxMNaNziViIY3NHRv7unti4u5qLtLkyy9tj8crLMZ7BGcZpDYMdG9ybXO3f UUVClrVocDB+92CX4as7iA1uM40Z97+oDv9icpfCpfNMHwqSAJH2NCB8vQMHrSmbPcBBWK/Hc GJxPVfz6bqOMcgGOWNZpW98cQE38vlf5QAzfNZtH4KEQDRtqUcBs6gzDfCT+7h52yTcG7sLib RMqzuvabsT3MesE3PYQCi1DfwDNYveyqgFw4AAVp0g1suZfT874LAQK67Hh+/GJI5sTt5XQhM pdXaJxHimgBfAqINGrnXrcz7CrvC/GHXfuMJwKZCDJkV61UoDiCtmb0YguxMBM/eNNCQnIS+L VvifaOFuFtNhd7njXCORsVlGT+kpMpn7F0iIz33FfhHyJmIpnI8Dqvi8S/YGSiP2l7iE0VnqU pmwPhym9LFOy3/tTbuPQuBxXK3Ttyue1sZeV8NwBXTjO/ZHd79W/yY3xUhrTd+zWsvXj+xUe8 AyfCPYNZJH/A9UzcImRpsg4KeCVDLGGlwPQzM+iu2iiVJ+ni6lZSz/OfDieqD2mGDXE/37s+P sw6L8F8W3SSW9/b4aM7BkcpmPLqIZ5AJfciMFcI4M2/OurEwkdCFPFPHhM2dFWzlYX9J2bR1S taOUmh04skD+xJb8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > > It's also possible to change permissions. Anyway... > > We have the option 'wdired-search-replace-filenames' > that can be customized to nil. That's what I wanted to note: different types of isearch behavior can potentially be useful in wdired, but it can be controlled _only_ via customization, in contrast to dired. It would be nice if toggling `dired-isearch-filenames-mode' would still do something. That it does nothing can be unexpected. Not the end of the world but something that I personally don't like that much. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 10 02:41:13 2025 Received: (at 78520) by debbugs.gnu.org; 10 Jun 2025 06:41:13 +0000 Received: from localhost ([127.0.0.1]:60189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOsfY-0007uJ-2K for submit@debbugs.gnu.org; Tue, 10 Jun 2025 02:41:13 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50217) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOsfU-0007t6-3i for 78520@debbugs.gnu.org; Tue, 10 Jun 2025 02:41:09 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6244943253; Tue, 10 Jun 2025 06:41:00 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87jz5k9vmu.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87cyc1yxyy.fsf@mail.linkov.net> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> <87sek9tq48.fsf@mail.linkov.net> <87jz5k9vmu.fsf@web.de> Date: Tue, 10 Jun 2025 09:28:34 +0300 Message-ID: <87ldq0p1ad.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddutdefkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmpdhrtghpthhtohepjeekhedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> We have the option 'wdired-search-replace-filenames' >> that can be customized to nil. > > That's what I wanted to note: different types of isearch behavior can > potentially be useful in wdired, but it can be controlled _only_ via > customization, in contrast to dired. It would be nice if toggling > `dired-isearch-filenames-mode' would still do something. That it > does nothing can be unexpected. Not the end of the world but > something that I personally don't like that much. So you propose to duplicate all related functions from dired to wdired? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 10 09:33:13 2025 Received: (at 78520) by debbugs.gnu.org; 10 Jun 2025 13:33:14 +0000 Received: from localhost ([127.0.0.1]:37703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOz6E-0001kk-K9 for submit@debbugs.gnu.org; Tue, 10 Jun 2025 09:33:13 -0400 Received: from mout.web.de ([212.227.15.4]:51511) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOz67-0001iL-Db for 78520@debbugs.gnu.org; Tue, 10 Jun 2025 09:33:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749562369; x=1750167169; i=michael_heerdegen@web.de; bh=UqCELoW4PhrT3fwiANcWFuasPP1FZrCY1UCn6NEPbo8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=vvqQfCkrb5Lg+Xhmg8Db5lQW8SSl2HetouB23MKXlUoeNUmiIpud2YZuuTC27ylJ y3enFsSHVqiF6Mr8gsS0RSH62WKONhv3hJY1BbYEEk3QMWEjmV5yXc3CHtrUEhEhQ n65YfA4qFwIVBUQy5R4A3C0tlStFJsu7/TZxpP9Et40vB8j1/7p6PU+EWxSvuCT46 MGZv3hZlcW/n9LYTHhS3FmogksZOLU+jzcnyCRW9vUo4uo4jrcKWBUVJPD7A2MXWE CPbv4mN+ig3RqnlJvmHkT/eUT2PWoBZRzuPM9R342Sk9170nMjY3O+584dUnORmmt rQkI+u9E1cDqMs8Www== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.69]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mx0Ix-1ujoGx3ZtL-017JtS; Tue, 10 Jun 2025 15:32:48 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87ldq0p1ad.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <86frgx6qji.fsf@gnu.org> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> <87sek9tq48.fsf@mail.linkov.net> <87jz5k9vmu.fsf@web.de> <87ldq0p1ad.fsf@mail.linkov.net> Date: Tue, 10 Jun 2025 15:34:27 +0200 Message-ID: <87o6uvwwik.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:6HgYwP+QJ7f3p2eA6PGyIFfUimbidwuQkq3NyU/m95chHmTbv84 3EGxVq0o7WbeJ1Sg3ULPo8sNsa5d/cv0NIwEXakfDATiDxSLZv9EXY3zvUDtAt45JGilYzQ ZXrB3g0Qy0Qs1ctKcocCGEMe6hn9A+/BmOxazo/2X8UhADYGuRM21cs8Y/oQypM+JnbNZMb tnKlDgCkq5k0bGdWDuOQA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Okmb8iidXIs=;+DpmZ4Bx7QKAZJ7SQy4GO8V0Hes CYhB2Xr1kce5hzs/2DHUba3RlVeoWqc3E9BN0PqEnCM9HHrUdqBbu8FDZeAO88k1iVx0GS5tI lXJIFC/5CWvyjdg+yoRmcYWB6CB2lfHXHxk3SaLrxRlKwG0JHvnjIZV8xeARX1sqjBLtmRCsd n+vE8nLQTaNvy7TaHnk1EiCRrT1Sci1uR1QFJQPRWTbkbX0B8QYvoNTWWN12Bd9Z/ofVQFzZN 2b8TVADRbOsxBdpDsgeTA1h/3oYQv7HISc5Zw+Ty6u09NpWuioGUuXGIYYwZU9kVGQLolG9m7 qXNLOQEBMnzT5qUJ2CmHozElRFuV9/dNcNWhaEq4owFnKHkinpevWKYaKeZAJiPMV/1MVdMPJ 6gD3Jtt9pqCF2QbQ+5G5sPQHoAtLGLBYzd/VViyPvTqKS1ZW4shaO/rKRXhrMjme7EejntfeA jK65FtvxtrQY+hOojZm/rXvAxliNO3nzAqO+PrSZordwvgcKR0sqJUEbf7de79pVX8s3ST1BF N462opoUDJU7OP8/TIhxeBn8G8TlXVQBTipVqOFOTJNbMfAaD9ftVhwdwvqj0NJ9NpU5z8T03 f23kCiHyIvEaIjvfWEbafA45TjcOn3wNgE4OZPvNowhI9D2Rtd5poYhsfuRbk5GinYXg+Hy+1 ZLiaxM31LiekRW+BwYTHz1LQY6VWKpKVwf0FTmJF87SdShuaUwpnClcOn2Cmdo+uMdc4pjuIx bjGF6xSc0PT9n64BDup76M/XJlWl/tihYEigQxPIEgUSN+txV49rVtwaMvCG3Z1oV3QfAx4Ru xK2lu0PyINy8U7gDXic8D7F2Ce/us3zv3420btJCepkZEjXokZrSoxN34oqbk52BeVG9mrYOX snqD6fNFePIURGepIN36mA1ELNS6trAX9HDn6hhxRRpYNeIONHuKqzhDjjKGEiR0nWIAj337o /FfrIpaFJRsYknTuF/MeNpAW1+w+nqSRpDZUnlClUL2XbdLs+qh3I1wUHR2ahO+YbDoMXrjQj 0S5PmoVwErVr60Lm243avXaFxDutWCU8SUwZThxNSV/LnqtCZn6U2lsH4BPp4pD+xcQnWkre/ aWbadVyN8qpnMfzAgR0ex4QEtB/M3THZ40s8O/CyLCCg5EmTR29NzS5/gsoZIOFd521Gx2YyR JkhZkDEjxfBBWZENIiDkfLqPOgzW+7qGflU9BEmzonCR81OSh97XLNxym3Xxk2Lhj3glRwh57 DvX+v+oKENhOF9TauOZ/vFaUTdY4Z0XCS1lp4W3i+j3t/YtBzU8JvX6CZuCZ46blhhyTSTCY6 5eZiXELRl2fafdhLXUPHF/pWlnoIUM0JzyjQexNgvI63vSFreW7rzE2kX+7bziF13jT3YJi8e xgHiHsjCCeXctxXVn+TFMkwkJrmK3aNy8pL1MW8IGQ1zJTNiuMhO6xBhzNAwTPnRE/PAJLXhU wQz67r1Wc6GOaDUj8MVRFv8EVY1MJasUxyADmqj2vFmcoNsg5i5/e64DT2OY9BlnVayJKiSRk M4Vxpn3tXZ3+HMojgIyjAh5A9Rq0odG/LjaesRnkwhTVSYN0ae7HUJ8Vy9WElVgiKvWHpkLdO T5O1H31XNgegnUiR5jp57USrt/pqDkuaHXEZR0zf18zQlyuwZdVikxwEMYBlDVJgdviFVkxB+ t6oHYjbiraZB04RuND62rmsO5WwMWgqOUhsQhJyBX37/JeX7v/B0cuBNUzSaZn2CPFvfEEPnZ Z80bmI+GifmJ37HKcFZaUgtNfAdK8fZcnYp2zNm97vnHcvzHHZcaErl4EiYSJ7xzffrX+PmB+ OoGJQ3Rki2IrF4+NoJCBbJfi9VFOCklOjhUbRf+kxPElXbClgGyZh74i3wzFqfo80ALf6TnJ1 lH7jKLZkOYiVs5veP4nHlDOhY5QHdqA2cJjEJbV4+ssxyBN4KyGrRHG3w1SaTBl1tkuxjhziZ vvBFGka4zZ5vesDcN4lHdKTOE/ENqusPeWMiCHWHadXZQPFI7oittxEQ2fJTpwB/KVolubdRU xwsVrr5MBKrr4yWhUdLFPOWeBo6J/42L14HXMQ8m+DwBx1HEgd+OmaNemDghO39N+JRsNQm1K xli3KHRL+h1o5SKPB1Q2ZhB6uUvVnQsU3WZx6Xq6hhuH73gHKoqZZBIYGSrvKSpoM5rgrk5+U oMIPKzI1kdvcqpVVQARwc5XAE+3R5Q4omthkEMqrnkRFgJlRXchGj7+w4F6U669DOH8DNjAob 9k064V2/IwtnUSC9r3099UQMBqmSlIiAsualck5Ibp+/+r0TPWuOIl6IUVwLNcZLYOpSg2Bj4 l23S4ZJsJHYqpOBb1KbJNYshq0R/+5gwn/SsBAz5WIRvjwNdTzQyGmAABrCIngauqkXkW69gH w86ZIuieUbytSS8mGDTDUsb9kI3k0I6b940E8LPJ2DeAVEOMug0MqJ3xD6KYN1FFkJs61KUPM RZVWzbX4s9bw1dVddvodFkemG4lGV2uZchS+nFqOLVNwYBn39M/az7541ccYBmohyMNQYrKf/ /G++OLFk1xfWNWR7d9Ha9u4J/XPQwcrCwEyI7INntr93YVHeWvgF9BZ1BwmL/Fj4YI1DsxTLZ gKLc2gzA/EZohElB6NvAqG/t4RNghTZy2cpV9RsWSoAfAlTZGnnXbEIKvQ5t27khW3jy5J8lj 7UV1TGxxIn34qtOU8PUL9pZfRL7LbuZC7M++Q0hD9o83X7sX5rv801ATtB5uPC67Ac27BN8sn pKYLZs5xEeu9pGoH97cz6w8FT6i+4bktgGmzGX8EdombHUqz9oLQzKqsWRq5UW91v0QSWfJBz T2aHGaaLnpwZNBwmDd6K7RAlIE9yNOYpoN6qro7qZRtinaHGOO1QV2bguOqEecPipdg45aHFX 8pCHOryWKvKnRZ216miWsUeP7Ffol+pCAb4kmIEouMCxVgLjhMtJyzcKtN+wIp/F7NG53mHLX ylgkSN/hDAyixR9JRQ/v6ztvBA5pfJBDcfQbXtK47q89/cPXDFFYYAD+NkJBdjVoKAQTvcKNY KLs9CBJ3m5rPvg17WupUlxfD0ioeYtCqT377E55eWalgQaizD7Z5M+BfKKc+9C5dB1W3xt/sW yPyFEakd+DUkf2SWs6RscToimV80Bx7hsH/hWDzUzPgp2CO7FLX7u8DxzrBlMjqi/Maa/Jbaj PDoRnALyLd8FbNSE5sdL96ZiXvNk3MzBYfyyOk0gdTMzz/k4a9viB1ek0nyBXUT5hREwcCU5H GL4BeCY09cklP64M X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > >> We have the option 'wdired-search-replace-filenames' > >> that can be customized to nil. > > > > That's what I wanted to note: different types of isearch behavior can > > potentially be useful in wdired, but it can be controlled _only_ via > > customization, in contrast to dired. It would be nice if toggling > > `dired-isearch-filenames-mode' would still do something. That it > > does nothing can be unexpected. Not the end of the world but > > something that I personally don't like that much. > > So you propose to duplicate all related functions from dired to wdired? Do we have to duplicate them? Can't we just use the same set of functions? Looks like that's more or less already the, but with an additional artificial different treatment of how the search and replace commands work by default. Or maybe I'm missing something. Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 11 13:18:13 2025 Received: (at 78520) by debbugs.gnu.org; 11 Jun 2025 17:18:14 +0000 Received: from localhost ([127.0.0.1]:51084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uPP5X-0000yw-9S for submit@debbugs.gnu.org; Wed, 11 Jun 2025 13:18:13 -0400 Received: from relay15.mail.gandi.net ([2001:4b98:dc4:8::235]:50115) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uPP5U-0000xI-Pj for 78520@debbugs.gnu.org; Wed, 11 Jun 2025 13:18:09 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D21E044272; Wed, 11 Jun 2025 17:18:00 +0000 (UTC) From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87o6uvwwik.fsf@web.de> Organization: LINKOV.NET References: <87y0uqyi0w.fsf.ref@aol.com> <87ldqo8u4s.fsf@mail.linkov.net> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> <87sek9tq48.fsf@mail.linkov.net> <87jz5k9vmu.fsf@web.de> <87ldq0p1ad.fsf@mail.linkov.net> <87o6uvwwik.fsf@web.de> Date: Wed, 11 Jun 2025 20:06:30 +0300 Message-ID: <87qzzqi4g7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdduvdejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepffegteefveelhfeljeefueehieduiedtfffhuddtkeeffffghfevheetgeeukeehnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdefrddvjedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtohepshhprggtihgssggrsegrohhlrdgtohhmpdhrtghpthhtohepjeekhedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvg X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> >> We have the option 'wdired-search-replace-filenames' >> >> that can be customized to nil. >> > >> > That's what I wanted to note: different types of isearch behavior can >> > potentially be useful in wdired, but it can be controlled _only_ via >> > customization, in contrast to dired. It would be nice if toggling >> > `dired-isearch-filenames-mode' would still do something. That it >> > does nothing can be unexpected. Not the end of the world but >> > something that I personally don't like that much. >> >> So you propose to duplicate all related functions from dired to wdired? > > Do we have to duplicate them? Can't we just use the same set of > functions? > > Looks like that's more or less already the, but with an additional > artificial different treatment of how the search and replace commands > work by default. Or maybe I'm missing something. `wdired-search-replace-filenames` is required anyway since it also sets `replace-search-function`. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 12 10:36:06 2025 Received: (at 78520) by debbugs.gnu.org; 12 Jun 2025 14:36:06 +0000 Received: from localhost ([127.0.0.1]:59185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uPj2D-0005tW-Su for submit@debbugs.gnu.org; Thu, 12 Jun 2025 10:36:06 -0400 Received: from mout.web.de ([217.72.192.78]:41113) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uPj28-0005sV-Pn for 78520@debbugs.gnu.org; Thu, 12 Jun 2025 10:36:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1749738951; x=1750343751; i=michael_heerdegen@web.de; bh=d91B6nyXcyG6/ssf4rSwvjQPhmVs30bwh8jrQzwl3bs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Q9M+a8Z7jD3x6FN8m+7bjVEOs3SSm5jv/PIMlsHvow5uteBR5e23E+HPdnE5sncc tkAttuJlEUL8GEhoWn34eYCjSabWVxCd4jy0X6LFdMLhvSe/9nUfJrBn2SGCp4SfT Qw999XmkfvEXo/gIo/weZLxB2Erfj8Ywop6rAco5iKgbrfc0OzkH5zQYdFwnp4pvr Y3WQeoFY91W2hsoj+dZaW3Hkv/bppusA56ziGe1ChTYlOcJJBvKmNXs59c306koG1 7LfFy5AznVjZyAOj3Cgw8+Nph6w9qbxCbJiFd9ZH8YgAPWFiHueKnctSEbYERyvtn 5TNCI6fwuMYy/8nTug== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.69]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MQ8ao-1uCTTT1Nzs-00XNYo; Thu, 12 Jun 2025 16:35:51 +0200 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#78520: 31.0.50; Performance issue in dired+isearch with dired-isearch-filenames In-Reply-To: <87qzzqi4g7.fsf@mail.linkov.net> References: <87y0uqyi0w.fsf.ref@aol.com> <861psf6bym.fsf@gnu.org> <87y0unxce2.fsf@web.de> <861pse4f36.fsf@gnu.org> <87frgs8lzo.fsf@web.de> <87frgqa7ty.fsf@mail.linkov.net> <87zfeydqb3.fsf@web.de> <87iklk1ws3.fsf@mail.linkov.net> <87tt4zkqhx.fsf@web.de> <87ikld7xc2.fsf@mail.linkov.net> <87msaomgab.fsf@web.de> <87iklcmfa3.fsf@web.de> <878qm8f3uh.fsf@mail.linkov.net> <87jz5r5b2x.fsf@web.de> <87v7pa1z98.fsf@mail.linkov.net> <87a56hhai0.fsf@web.de> <87sek9tq48.fsf@mail.linkov.net> <87jz5k9vmu.fsf@web.de> <87ldq0p1ad.fsf@mail.linkov.net> <87o6uvwwik.fsf@web.de> <87qzzqi4g7.fsf@mail.linkov.net> Date: Thu, 12 Jun 2025 16:37:31 +0200 Message-ID: <87jz5ht49g.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:x3TPCcDlPfnCbzbnBC4Y1bjX96LncwFDjjGspjE5Uyjns6Cu0/X zQYC6pvCzNLmQuYn+Gm7jv3uzef13Ng0meoXpjIVPgZGqsQG/WgIs1paqCp08Ax9uL6Slv5 n3Qu+BQHUmDU412zug6v1fBfSnU90fiCyKNtVbiT+xrPqi3KePtf8+WUK0hPC8DNGMlCMbE t8SgC3jWZ29Qv7TU3YFFg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gzp7+CjY1Y0=;QIJBt4yberYfnGGaSeR0frwiB3z plIyR11g+Mp+G5UzooS0fjrCTtvHQSNCihkObqAJwehmvT8U4I2Ekeb3UYznDQDBphBKYrwWJ /ulbAOKRaAuP7vCGOy489uX2C06rDeiJl5LTvsYjDXVSmFTwQGwNS1hsKVLEuP9av8nCElZIO Y25FknlsME9MiD63qxE/in9zr2GTlETPUNwYlkiTTot79+XO880xgzSTKGqvsbZ9TiffVmjBN KbxtNEKyUHHUglCAmXdHX939FSHgtxB2FEu63bkjKwOELNk2GY9KfE8prNFKOh6DlDqc0zdzJ UBz88P+TBFwaQ2sY9diHNNPUXX4wTuEs69NssjrQEUXziIvQWQtuBSK1Ic6jQ/WMU9jNvXOkJ FybTDBiVpN4Wte1VXqVYkN4jDW226IUX8F8Jybiy2QJaP1Jlm/6VP64qxbBy/X9MB1KfTYFGg eCOpiYxvpzWd41Vb/Q8mTiS+/vCxxtzRz2ZRHf2hB1+tigu9pY8hjxC+q3PlUV9Lyu5loycGU t0ENjsBFGp/JyvylT92STy91eQojV4Xiy5tf0szyQzIo0uCZusWJb9UBpD490+R7kLjj9anxo 7xZ5ATD/pTgU0GZcsemMZLqRu8c+EKz4punYzq0nqT5gIc0sacwMzd0lhIegiv/JgGyGWKLHg NvOpFAhNlM7mOcqS1nqPAtSZf1RRaKnmRWnLeT5HGk+9DEoqqh46pbM8+f2nJmwq1KIbbErQr DNJyAMAsGJRD7jzANrG4IoRgoIc+2eJw5B+m6my6nNUVtwltXijnseVlfZTT4iAJBN66CMhKm LHCRrDoxLIvqzauhqlVlse7Sc9Ls4r5h7aKq6L8nVZHoF0taRSBfYpuHJrxYUx5yoxZ3soOFz 5XT4hYt3q/HqAuuxrABnDNzGldm7qVVJPRWWTKsuO04k29aZehdXHckeh4afoGidOo4Unpr18 tTKaEoUhgZiw8LCeWXF1L4Plwk+Uc98JLIBilMhO28fldpJ1LYpaQ4Yngxu35LiIsn5QEX3jt PeH0nFNkids15iiGwlqelq4S/VNerBg6JiPoRoPQYqxikGuIxbIx0c6ycDNpN6p6bNgGianQ2 ctWw5w1lXkf5wUPuPAZk4BRGyZNRqt6hKD9kzyyzvdhK6K/vdInanqL2p4o9P4VBT1n6iYpZ+ Q5/d0XXhzB3oGY1xRUCe7qHiwAPLEgwuH8xo5o6Feye9oHupt8bZeMPFy5EjhH3xjgn7NF+XY 3Ntv7K4q39c3CSQBhvasn+GOTXJtTVPhLMAE9M/zF2HNck5XpN8i8L2uVE02PXhPEZtdw5HzF E28ZHY/jz0Lkqe8sBSRVaR6FAI54E09P+DQqsV5wmXVG15AFZAOIwhVcqj7hkHqTttbdTEnOW E2MJh5F33kjUxh6dqsgmoK7nZHt2S8T4E1YMjK6vDtK3emmuKRM0Atzcn5zI6Ztt0+yutSlKy ko842BrimRxx4WgtS/d3hNWSjRdCtWlH1jp9g5DCr0OD6/WWODbTDTKZQdLts4dlOSc4X/9Pz IkjhCGmsbHJaW9VjnCH1WxjvG/ZrAb8ACWeIUwNgGFGlvIGQHsZfbGaYShgxvvYZ2vywlupVM K0NEFEL7aHrZIpFfLcxTKSu5j0diYdnN3w2DSykxvyR6L3FrpfQe2RAdcy0x7tsq6WCMq8Ay6 +Tv3OY4n13LheuYzRJ8qGOPoLAedtHSNEpzrQ7jItNDGaSndx9Wd3P1L/kx+C4SWzxY1tCQe8 QTKJxnVzqsA3lJsGYrcQUl+nBorEoP+oUInne1DnSyXajyer/VUNzfJ41wNKCcU+5yhJFDr7X xcrmJ3tnwrnXBbK55Jd6/2RqQdkSND+b+9cZubK1GDizvUoD1tod0U77QpADdRHRgoD5ZCF7e ZgB+mNjWdswrrzaEolRBarK1zWnemi+BE9NOwSwB/a1lvMK30bev13D9p7zNZuaJpztmmWsuH a7qY+BqXGP4GKKVb9AGp70E+mcn4AJb5lOD4Htv4hll9VYE85rJUpu/BocirgMs/7N5maIlu2 gFyI3SGiNyNubnWU7PTLHmSj2WPBAaJ95wi7UzQJBpOvRtFXkK9osTjewC/Utm0Nr5vs1p6ip 5zW5TKZNucbNRbItFJQ9ZkRlZT8wpUuKj8u7ZbVWT3CtlrOlHEh7XKBDyAyKSwKWsMGzVSj1p QNerhpUYYAKGLGsWf+XOyrJavgR+i4qHUQfzZROcTvtbGlJl/zUilOUuCenm8KzsTliZtY8wE rHjDiqOh1Bm7MBx+9JRlD0tz0ZDTnhKo4nHzLa9Oyx3lxp+gA/+L5pDDUZAvBj00eA5Z7DpLt m6NIDaCgqA3bWLmx3i/UHDBK5X7Dv+fr2momKavWhg0NhJoFx6f+S0Aj2LB/nYttLsiWhxh0o YZsyAqZRB6CHwNkPtw9cQ+5m5KBUVbR+2Q7gbYy+3EUcYk/44s1erfk8NWnUUb+vw3G9xDRUO c5JtWgjw0cfvfgWFwS3cmudNQD196sxWeC8XO1CC+eJM3XO9fr9zlZEYGXvBK1UvkUCbZNBrm 2jC0XBHtlDU2H4FMlt+ao35c0zQVgetud9JIJAmeI05ZxT6Fu2ohuQTuu42lVXnBcIDcEOg75 NqwPVfyLAd94vasJXnQrBCVS55HQOPPMug2sW1YQlTQQMu8QjHTvhkfFlYXo1unfmzSVJljKu 51nmXZKmhEJWzDGYp9Qn6BpT3dOoKIvEup4x8tazOOFMRkPonwBn7OoaUjxmTc3WQIWT4/zi0 Mm8hjJbNlRkqF9kVXGWw5fJ04YES2YkMRV6s9N6RP7eyreNmZYRYwCoh+UvJgyYF3+ST7Wh7n RgwnHHotdr6J7iDmOIjrq895oS2DyM70pZzmc6i2qgL9BtX7MqpMCEIKXiGQ4I0cecj1ibVsD Sa+sM6F+BDsObOVs3IBR0c2SifuHx+yLYfs7o84/TJy3U2zk1ADGWMEXYYR6SHChrhsXpXsIq kDep8BlfCd+b3fmugr+xfQdtqfDxI5tmG5e9YEdfqqh/z0JpJG6E2aypaLoy3GuJEuWxcazDD aTHCGGHLzxNFo/7uOTQDnyCPJNTVJMurXniInN7kgI+GIvmsIxY2y9jSwR4ptAnfl9PBJ13DD 8Z8B1E7K9qxFKKp2WW2wzOP3LqoQv3Xti7nduQiv5Pwklymku92VXibw0sv0J/Wmfhq2Niq/I W+NtyMjgj2uGxXAthJhd1J/RtuF6gQWrhEvt+SYdgZhwQMtPCIIRDdIPWfHEwCN82YiLtS+xN wO0yBr1gO40U82EW X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78520 Cc: Eli Zaretskii , 78520@debbugs.gnu.org, spacibba@aol.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > `wdired-search-replace-filenames` is required anyway > since it also sets `replace-search-function`. Hmm - but we could also try to do this when query-replace is invoked. Similar to what we do when invoking isearch. Do we handle wdired differently only because of this problem? | ;; Original dired hook removes dired-isearch-search-filenames that | ;; is needed outside isearch for lazy-highlighting in query-replace. | (remove-hook 'isearch-mode-hook #'dired-isearch-filenames-setup t) Maybe we could solve this in some other way? Then, isearch and query-replace would just look whether filename only matching is enabled or not, and do the according setup when any of them is called by the user. Michael.