GNU bug report logs - #78502
[PATCH 0/3] gnu: Add ring-racers.

Previous Next

To reply to this bug, email your comments to 78502 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: guix-patches <at> gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 0/3] gnu: Add ring-racers.
Date: Mon, 19 May 2025 20:42:45 -0400

Andrew Wong (3):
  gnu: Add libyuv.
  gnu: Add ring-racers-data.
  gnu: Add ring-racers.

 gnu/packages/games.scm | 82 ++++++++++++++++++++++++++++++++++++++++++
 gnu/packages/image.scm | 27 ++++++++++++++
 2 files changed, 109 insertions(+)


base-commit: 670724edcfe7d71c517d4bb1680132b45accf0b8
-- 
2.49.0

Message #8 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 1/3] gnu: Add libyuv.
Date: Mon, 19 May 2025 20:45:09 -0400

* gnu/packages/image.scm (libyuv): New variable.

Change-Id: If7f5be6bcf88cf2d11e8d3c911f492f1ab8fd2d0
---
 gnu/packages/image.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 3a894a0d9a..bedaf2212c 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -2925,3 +2925,30 @@ (define-public libsixel
 want to view a SIXEL image file, all you have to do is @command{cat} it to
 your terminal.")
     (license license:expat)))
+
+(define-public libyuv
+  (package
+    (name "libyuv")
+    (version "2021.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+	     (url "https://chromium.googlesource.com/libyuv/libyuv")
+	     (commit "4620f1705822fd6ab99939f43ce63099bd3d9ae0")))
+       (sha256
+	(base32 "17vdm2g5qvrby7xa3agiqwh7ips33dxg6sw18s3q2xkfil4xw3mm"))))
+    (build-system cmake-build-system)
+    (arguments (list #:tests? #f))
+    (home-page "https://chromium.googlesource.com/libyuv/libyuv/")
+    (synopsis "YUV scaling and conversion functionality")
+    (description "libyuv is an open source project that includes YUV scaling and
+conversion functionality. It can:
+@itemize
+@item Scale YUV to prepare content for compression, with point, bilinear or box
+filter.
+@item Convert to YUV from webcam formats for compression.
+@item Convert to RGB formats for rendering/effects.
+@item Rotate by 90/180/270 degrees to adjust for mobile devices in portrait mode.
+@end itemize")
+    (license license:expat)))
-- 
2.49.0

Message #11 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 2/3] gnu: Add ring-racers-data.
Date: Mon, 19 May 2025 20:45:10 -0400

* gnu/packages/games.scm (ring-racers-data): New variable.

Change-Id: Iaae0719a5b28f9d9de7654509f52713d33738749
---
 gnu/packages/games.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 626438b824..d38cff05d6 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4919,6 +4919,26 @@ (define-public supertuxkart
 also available.")
     (license license:gpl3+)))
 
+(define ring-racers-data
+  (hidden-package
+   (package
+     (name "ring-racers-data")
+     (version "2.3")
+     (source
+      (origin
+        (method url-fetch/zipbomb)
+        (uri (string-append
+              "https://github.com/KartKrewDev/RingRacers/releases/download/v"
+              version "/Dr.Robotnik.s-Ring-Racers-v" version "-Assets.zip"))
+        (file-name (string-append name "-" version ".zip"))
+        (sha256
+         (base32 "0i6sq8c1vq7z5r5i1hana0v73xvj53696f2xwn37xicxds4d15wp"))))
+     (build-system copy-build-system)
+     (home-page "https://github.com/KartKrewDev/RingRacers/releases")
+     (synopsis "Data files for Ring Racers")
+     (description "This package contains data files for Ring Racers.")
+     (license license:gpl2+))))
+
 (define-public unknown-horizons
   (package
     (name "unknown-horizons")
-- 
2.49.0

Message #14 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH 3/3] gnu: Add ring-racers.
Date: Mon, 19 May 2025 20:45:11 -0400

* gnu/packages/games.scm (ring-racers): New variable.

Change-Id: Ib52dca1ad41d8f778db14857ad681d566c145952
---
 gnu/packages/games.scm | 62 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d38cff05d6..c1f7bc2277 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4939,6 +4939,68 @@ (define ring-racers-data
      (description "This package contains data files for Ring Racers.")
      (license license:gpl2+))))
 
+(define-public ring-racers
+  (package
+    (name "ring-racers")
+    (version "2.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.do.srb2.org/KartKrew/RingRacers")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "05lf799imbk0x3i2adaj0r84ck5yyrvzjvhs4k9dj7l4jg0x4sjz"))
+       (modules '((guix build utils)))
+       (snippet '(begin (with-directory-excursion "thirdparty"
+                          (delete-file-recursively "glm")
+                          (substitute* "CMakeLists.txt"
+                            (("add_subdirectory\\(glm\\)")
+                             "find_package(glm REQUIRED)")))
+                        (with-directory-excursion "src"
+                          (substitute* "CMakeLists.txt"
+                            (("glm::glm") "glm")))))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:tests? #f
+      #:configure-flags
+      #~(list "-DCMAKE_C_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
+              "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
+              "-DSRB2_CONFIG_DEV_BUILD=OFF"
+              "-DCMAKE_BUILD_TYPE=RelWithDebInfo")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'move-and-wrap-binary
+            ;; Install executable to $out/bin.
+            (lambda* (#:key inputs #:allow-other-keys)
+              (with-directory-excursion #$output
+                (mkdir "bin")
+                (rename-file "ringracers" "bin/ringracers")
+                (wrap-program "bin/ringracers"
+                  `("RINGRACERSWADDIR" =
+                    (,(assoc-ref inputs "ring-racers-data"))))))))))
+    (inputs (list glm
+                  libogg
+                  libpng
+                  libvorbis
+                  libvpx
+                  libyuv
+                  ring-racers-data
+                  sdl2
+                  zlib
+                  curl))
+    (home-page "https://kartkrew.org")
+    (synopsis "Technical kart racing game")
+    (description
+     "Dr. Robotnik’s Ring Racers is a technical kart racing game drawing
+inspiration from ``anti-grav'' racers, fighting games, and traditional-style
+kart racing.  Designed to minimize randomness and emphasize player expression,
+Ring Racers about more than precise handling—you’ll need to master tense
+combat, resource management, and taking risks under pressure.")
+    (license license:gpl2+)))
+
 (define-public unknown-horizons
   (package
     (name "unknown-horizons")
-- 
2.49.0

Message #17 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Andrew Wong <wongandj <at> icloud.com>, 78502 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#78502] [PATCH 3/3] gnu: Add ring-racers.
Date: Wed, 21 May 2025 07:03:59 +0200

Am Montag, dem 19.05.2025 um 20:45 -0400 schrieb Andrew Wong:
> * gnu/packages/games.scm (ring-racers): New variable.
> 
> Change-Id: Ib52dca1ad41d8f778db14857ad681d566c145952
> ---
>  gnu/packages/games.scm | 62
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index d38cff05d6..c1f7bc2277 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -4939,6 +4939,68 @@ (define ring-racers-data
>       (description "This package contains data files for Ring
> Racers.")
>       (license license:gpl2+))))
>  
> +(define-public ring-racers
> +  (package
> +    (name "ring-racers")
> +    (version "2.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.do.srb2.org/KartKrew/RingRacers")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "05lf799imbk0x3i2adaj0r84ck5yyrvzjvhs4k9dj7l4jg0x4sjz"))
> +       (modules '((guix build utils)))
> +       (snippet '(begin (with-directory-excursion "thirdparty"
> +                          (delete-file-recursively "glm")
> +                          (substitute* "CMakeLists.txt"
> +                            (("add_subdirectory\\(glm\\)")
> +                             "find_package(glm REQUIRED)")))
> +                        (with-directory-excursion "src"
> +                          (substitute* "CMakeLists.txt"
> +                            (("glm::glm") "glm")))))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list
> +      #:tests? #f
> +      #:configure-flags
> +      #~(list "-DCMAKE_C_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
> +              "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
> +              "-DSRB2_CONFIG_DEV_BUILD=OFF"
> +              "-DCMAKE_BUILD_TYPE=RelWithDebInfo")
There is a #:build-type flag to do that last thing.  Why are we setting
the other flags?
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'install 'move-and-wrap-binary
> +            ;; Install executable to $out/bin.
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (with-directory-excursion #$output
> +                (mkdir "bin")
> +                (rename-file "ringracers" "bin/ringracers")
> +                (wrap-program "bin/ringracers"
> +                  `("RINGRACERSWADDIR" =
> +                    (,(assoc-ref inputs "ring-racers-data"))))))))))
> +    (inputs (list glm
> +                  libogg
> +                  libpng
> +                  libvorbis
> +                  libvpx
> +                  libyuv
> +                  ring-racers-data
> +                  sdl2
> +                  zlib
> +                  curl))
> +    (home-page "https://kartkrew.org")
> +    (synopsis "Technical kart racing game")
> +    (description
> +     "Dr. Robotnik’s Ring Racers is a technical kart racing game
> drawing
> +inspiration from ``anti-grav'' racers, fighting games, and
> traditional-style
> +kart racing.  Designed to minimize randomness and emphasize player
> expression,
> +Ring Racers about more than precise handling—you’ll need to master
> tense
> +combat, resource management, and taking risks under pressure.")
> +    (license license:gpl2+)))
Less ad-speak would be nice, but we definitely should fix the second
sentence, which at least I myself can't parse.

Cheers

Message #20 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 78502 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> envs.net>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#78502] [PATCH 3/3] gnu: Add ring-racers.
Date: Thu, 22 May 2025 00:06:58 -0400

On 5/21/25 1:03a, Liliana Marie Prikler wrote:>> +      #~(list 
"-DCMAKE_C_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
>> +              "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
>> +              "-DSRB2_CONFIG_DEV_BUILD=OFF"
>> +              "-DCMAKE_BUILD_TYPE=RelWithDebInfo")
> There is a #:build-type flag to do that last thing.  Why are we setting
> the other flags?

I wrote this part of the definition a few months ago, but it seems like 
I was copying the flags set for a release version of the package as 
defined in the repository's CMakePresets.json[1]. On review, it appears 
the last two settings are redundant with Guix and the package's 
defaults, so I'll remove them next version.

>> +     "Dr. Robotnik’s Ring Racers is a technical kart racing game
>> drawing
>> +inspiration from ``anti-grav'' racers, fighting games, and
>> traditional-style
>> +kart racing.  Designed to minimize randomness and emphasize player
>> expression,
>> +Ring Racers about more than precise handling—you’ll need to master
>> tense
>> +combat, resource management, and taking risks under pressure.")
>> +    (license license:gpl2+)))
> Less ad-speak would be nice, but we definitely should fix the second
> sentence, which at least I myself can't parse.

Indeed. I'll revise it.

[1] https://git.srb2.org/KartKrew/RingRacers/-/blob/master/CMakePresets.json

Message #23 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH v2 0/3] gnu: Add ring-racers.
Date: Thu, 22 May 2025 00:41:05 -0400

This version fixes the messy description and redundant flags of the previous
version.

Andrew Wong (3):
  gnu: Add libyuv.
  gnu: Add ring-racers-data.
  gnu: Add ring-racers.

 gnu/packages/games.scm | 82 ++++++++++++++++++++++++++++++++++++++++++
 gnu/packages/image.scm | 27 ++++++++++++++
 2 files changed, 109 insertions(+)


base-commit: 670724edcfe7d71c517d4bb1680132b45accf0b8
-- 
2.49.0

Message #26 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH v2 1/3] gnu: Add libyuv.
Date: Thu, 22 May 2025 00:41:06 -0400

* gnu/packages/image.scm (libyuv): New variable.

Change-Id: If7f5be6bcf88cf2d11e8d3c911f492f1ab8fd2d0
---
 gnu/packages/image.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 3a894a0d9a..bedaf2212c 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -2925,3 +2925,30 @@ (define-public libsixel
 want to view a SIXEL image file, all you have to do is @command{cat} it to
 your terminal.")
     (license license:expat)))
+
+(define-public libyuv
+  (package
+    (name "libyuv")
+    (version "2021.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+	     (url "https://chromium.googlesource.com/libyuv/libyuv")
+	     (commit "4620f1705822fd6ab99939f43ce63099bd3d9ae0")))
+       (sha256
+	(base32 "17vdm2g5qvrby7xa3agiqwh7ips33dxg6sw18s3q2xkfil4xw3mm"))))
+    (build-system cmake-build-system)
+    (arguments (list #:tests? #f))
+    (home-page "https://chromium.googlesource.com/libyuv/libyuv/")
+    (synopsis "YUV scaling and conversion functionality")
+    (description "libyuv is an open source project that includes YUV scaling and
+conversion functionality. It can:
+@itemize
+@item Scale YUV to prepare content for compression, with point, bilinear or box
+filter.
+@item Convert to YUV from webcam formats for compression.
+@item Convert to RGB formats for rendering/effects.
+@item Rotate by 90/180/270 degrees to adjust for mobile devices in portrait mode.
+@end itemize")
+    (license license:expat)))
-- 
2.49.0

Message #29 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH v2 2/3] gnu: Add ring-racers-data.
Date: Thu, 22 May 2025 00:41:07 -0400

* gnu/packages/games.scm (ring-racers-data): New variable.

Change-Id: Iaae0719a5b28f9d9de7654509f52713d33738749
---
 gnu/packages/games.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 626438b824..d38cff05d6 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4919,6 +4919,26 @@ (define-public supertuxkart
 also available.")
     (license license:gpl3+)))
 
+(define ring-racers-data
+  (hidden-package
+   (package
+     (name "ring-racers-data")
+     (version "2.3")
+     (source
+      (origin
+        (method url-fetch/zipbomb)
+        (uri (string-append
+              "https://github.com/KartKrewDev/RingRacers/releases/download/v"
+              version "/Dr.Robotnik.s-Ring-Racers-v" version "-Assets.zip"))
+        (file-name (string-append name "-" version ".zip"))
+        (sha256
+         (base32 "0i6sq8c1vq7z5r5i1hana0v73xvj53696f2xwn37xicxds4d15wp"))))
+     (build-system copy-build-system)
+     (home-page "https://github.com/KartKrewDev/RingRacers/releases")
+     (synopsis "Data files for Ring Racers")
+     (description "This package contains data files for Ring Racers.")
+     (license license:gpl2+))))
+
 (define-public unknown-horizons
   (package
     (name "unknown-horizons")
-- 
2.49.0

Message #32 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH v2 3/3] gnu: Add ring-racers.
Date: Thu, 22 May 2025 00:41:08 -0400

* gnu/packages/games.scm (ring-racers): New variable.

Change-Id: Ib52dca1ad41d8f778db14857ad681d566c145952
---
 gnu/packages/games.scm | 62 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d38cff05d6..1156e5ba6d 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4939,6 +4939,68 @@ (define ring-racers-data
      (description "This package contains data files for Ring Racers.")
      (license license:gpl2+))))
 
+(define-public ring-racers
+  (package
+    (name "ring-racers")
+    (version "2.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.do.srb2.org/KartKrew/RingRacers")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "05lf799imbk0x3i2adaj0r84ck5yyrvzjvhs4k9dj7l4jg0x4sjz"))
+       (modules '((guix build utils)))
+       (snippet '(begin
+                   (with-directory-excursion "thirdparty"
+                     (delete-file-recursively "glm")
+                     (substitute* "CMakeLists.txt"
+                       (("add_subdirectory\\(glm\\)")
+                        "find_package(glm REQUIRED)")))
+                   (with-directory-excursion "src"
+                     (substitute* "CMakeLists.txt"
+                       (("glm::glm")
+                        "glm")))))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:tests? #f ;There are no tests.
+      #:configure-flags
+      #~(list "-DCMAKE_C_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'"
+              "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO='-O3 -g -DNDEBUG'")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'move-and-wrap-binary
+            ;; Install executable to $out/bin.
+            (lambda* (#:key inputs #:allow-other-keys)
+              (with-directory-excursion #$output
+                (mkdir "bin")
+                (rename-file "ringracers" "bin/ringracers")
+                (wrap-program "bin/ringracers"
+                  `("RINGRACERSWADDIR" =
+                    (,(assoc-ref inputs "ring-racers-data"))))))))))
+    (inputs (list glm
+                  libogg
+                  libpng
+                  libvorbis
+                  libvpx
+                  libyuv
+                  ring-racers-data
+                  sdl2
+                  zlib
+                  curl))
+    (home-page "https://kartkrew.org")
+    (synopsis "Technical kart racing game")
+    (description
+     "Dr. Robotnik's Ring Racers is a kart racing game drawing inspiration from
+``anti-gravity'' racers, fighting games, and traditional-style kart racing.
+Ring Racers is designed with an emphasis on player agency in the face of highly
+technical game-play challenges in both single-player and online multiplayer
+modes."
+    (license license:gpl2+)))
+
 (define-public unknown-horizons
   (package
     (name "unknown-horizons")
-- 
2.49.0

Message #35 received at 78502 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 78502 <at> debbugs.gnu.org
Cc: Adam Faiz <adam.faiz <at> disroot.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [PATCH v2 3/3] gnu: Add ring-racers.
Date: Sat, 7 Jun 2025 13:27:07 -0400

Pinging this as v2 appears to have not sent with the right CCs. How does 
the patch series look now?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.