GNU bug report logs - #78496
[PATCH] gnu: Add sqlitestudio.

Previous Next

Full log

Message #8 received at 78496 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Philippe SWARTVAGHER <phil.swart <at> gmx.fr>
Cc: 78496 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#78496] [PATCH] gnu: Add sqlitestudio.
Date: Wed, 28 May 2025 23:34:47 +0200

Hello,

Philippe SWARTVAGHER <phil.swart <at> gmx.fr> writes:

> * gnu/packages/databases.scm (sqlitestudio): New variable.
>
> Change-Id: I012a189d37661bf70b140048696ae97647bf0a6f

[...]

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases

I recommend running ‘guix style -S arguments sqlitestudio’.

> +                        (chdir "Plugins")

[...]

> +                        (chdir ".."))))

Rather (with-directory-excursion "Plugin" …).

> +                      (chdir "Plugins")
> +                      (invoke "make") ;building plugins in parallel corrupts them
> +                      (chdir "..")))

Likewise: (with-directory-excursion "Plugin" (invoke "make")).


> +    (synopsis
> +     "A free, open source, multi-platform SQLite database manager")

Maybe: “Graphical user interface to browse and edit SQLite databases”?

“Free” and “open source” is implicit and “multi-platform” is mostly
irrelevant in the context of a distro.

> +     database files. It is aimed for people, who know what SQLite is, or what
> +     relational databases are in general.")
   ^
Please remove the extra leading spaces.  Also: two spaces after
end-of-sentence period, as reported by ‘guix lint’.

The rest LGTM.

Could you send an updated patch?

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.