GNU bug report logs - #78494
[PATCH python-team] gnu: awscli-2: Skip failing tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78494: closed ([PATCH python-team] gnu: awscli-2: Skip
 failing tests.)
Date: Mon, 26 May 2025 16:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 26 May 2025 17:30:44 +0100
with message-id <87wma3jpvv.fsf <at> gmail.com>
and subject line [PATCH python-team] gnu: awscli-2: Skip failing tests.
has caused the debbugs.gnu.org bug report #78494,
regarding [PATCH python-team] gnu: awscli-2: Skip failing tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78494: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Nikkilä <hello <at> lnikki.la>
To: guix-patches <at> gnu.org
Cc: Leo Nikkilä <hello <at> lnikki.la>
Subject: [PATCH python-team] gnu: awscli-2: Skip failing tests.
Date: Mon, 19 May 2025 17:52:42 +0300

Skips two failing tests with the awscli-2 package, which have been
failing the build recently.

The first one is related to the version of prompt-toolkit that's being
used as an input. Upstream doesn't support some of the later versions,
however this doesn't seem to cause any visible problems right now apart
from the test failing, at least on aarch64.

The other issue is due to `os.environ["PATH"]` throwing a KeyError once
in a while, seems like this test is being affected by some other test
since running it in isolation works for me. See
<https://ci.guix.gnu.org/build/10641072/log> for an example.

* gnu/packages/python-web.scm (awscli-2)[arguments]<#:test-flags>: Skip
failing prompt-toolkit tests, likewise for emrutils.
---
 gnu/packages/python-web.scm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 2443ab1195f..462ca1008fe 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -5207,12 +5207,19 @@ (define-public awscli-2
     (arguments
      (list
       #:test-flags
-      ;; The resource leak tests use ps to check for memory consumption.
-      '(list "--ignore=functional/botocore/leak/test_resource_leaks.py"
+      '(list ;; This version of prompt-toolkit has issues with awscli-2, see
+             ;; <https://github.com/aws/aws-cli/issues/9453#issuecomment-2822186530>.
+             "--ignore=functional/autoprompt/test_prompttoolkit.py"
+             ;; The resource leak tests use ps to check for memory consumption.
+             "--ignore=functional/botocore/leak/test_resource_leaks.py"
              ;; These tests complain about unavailable TLS certs.
              "--ignore=functional/ec2instanceconnect/test_opentunnel.py"
              ;; These seem to require Internet access.
-             "--ignore=unit/botocore/test_awsrequest.py")
+             "--ignore=unit/botocore/test_awsrequest.py"
+             ;; Flaky, something to do with PATH disappearing from os.environ?
+             ;; Passes when run on its own, so maybe something else is
+             ;; modifying this during the test run.
+             "--ignore=unit/customizations/emr/test_emr_utils.py")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'ignore-deprecations
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 78494-done <at> debbugs.gnu.org
Subject: [PATCH python-team] gnu: awscli-2: Skip failing tests.
Date: Mon, 26 May 2025 17:30:44 +0100

[Message part 4 (text/plain, inline)]

Hi,

Thanks for the patch.

Pushed to master as 127f232d1dce05bb843d28bf9501fd2b7c2e64de.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.