GNU bug report logs - #78474
31.0.50; Wrong char insertion in rxvt

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: bzg <at> gnu.org, Sebastien.Hinderer <at> inria.fr, rpluim <at> gmail.com, samuel.thibault <at> gnu.org, 78474 <at> debbugs.gnu.org
Subject: bug#78474: 31.0.50; Wrong char insertion in rxvt
Date: Sat, 02 Aug 2025 17:49:48 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: Samuel Thibault <samuel.thibault <at> gnu.org>,  Eli Zaretskii
>  <eliz <at> gnu.org>,  bzg <at> gnu.org,  Sebastien.Hinderer <at> inria.fr,
>   78474 <at> debbugs.gnu.org
> Date: Sat, 02 Aug 2025 15:17:35 +0200
> 
> Robert Pluim <rpluim <at> gmail.com> writes:
> 
> >>>>>> On Fri, 25 Jul 2025 13:08:07 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:
> >
> >     Manuel> Samuel Thibault <samuel.thibault <at> gnu.org> writes:
> >     Manuel> [...]
> >
> >     >>> Here are my results with this new benchmark:
> >     >> 
> >     >> (Several measurements are really needed because of variability)
> >
> >     Manuel> Why not.  So, here is the benchmark code I used:
> >
> > So it looks to me like not emitting \t\b is slightly faster. Could you
> > repost your patch with a user option to enable/disable it? Then we can
> > discuss what the default should be. Iʼm leaning towards the default
> > being not emitting it, since the resulting redisplay will be correct
> > in any case.
> 
> Hi Robert and all,
> 
> Here it is.  I'm not quite sure about the user option name, its
> documentation and NEWS entry.  Samuel could you test if this new default
> works for screen readers and also if setting
> `inhibit-overshoot-in-tty-motions' to nil make them unwork.

Thanks, a few minor comments below.

> +---
> +** New user option 'inhibit-overshoot-in-tty-motions'.

I see no reason to make this a user option.  It should be a simple
variable.  Also, I'd call it tty-cursor-movement-use-TAB-BS and set it
to nil by default.

> +The display optimization where the combination TAB characters +
> +BACKSPACE to move to a position on a TTY frame is now disabled by
> +default and controlled by this user option.  This option can be set
> +customized to nil to keep the old behavior.  This is to accomodate to
> +some software such as screen readers.

This is a somewhat incompatible change.  So this NEWS text should be
in the "Incompatible changes" section.

I also think lisp/term/rxvt.el should force this variable to avoid
TAB+BS, since rxvt is known to produce buggy behavior with that
combination.

Otherwise, this should be good to go.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.