GNU bug report logs - #78446
[PATCH] * lisp/emacs-lisp/find-func.el: Fix Eager macro-expansion failure

Previous Next

Full log

Message #26 received at 78446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: sunlin7 <at> hotmail.com, monnier <at> iro.umontreal.ca, 78446 <at> debbugs.gnu.org
Subject: Re: bug#78446: [PATCH] * lisp/emacs-lisp/find-func.el: Fix Eager
 macro-expansion failure
Date: Wed, 21 May 2025 16:17:10 +0300

> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Cc: sunlin7 <at> hotmail.com,  monnier <at> iro.umontreal.ca,  78446 <at> debbugs.gnu.org
> Date: Wed, 21 May 2025 13:11:04 +0100
> 
> Hello,
> 
> On Tue 20 May 2025 at 03:44pm +03, Eli Zaretskii wrote:
> 
> > I'd prefer the other solution, to move the setter function before its
> > first use, or its first use after the function is defined.  The
> > bound-and-true-p use looks strange in a file that defines the
> > function.
> 
> Yes, good point.
> 
> Lin's patch looks good to me; I would prefer review from Eli and/or
> Stefan before installing it.

It just moves a function into another place in the file, right?

LGTM, except that the comment should begin with a capital letter.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.