GNU bug report logs - #78446
[PATCH] * lisp/emacs-lisp/find-func.el: Fix Eager macro-expansion failure

Previous Next

Full log

View this message in rfc822 format

From: Lin Sun <sunlin7 <at> hotmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Sean Whitton <spwhitton <at> spwhitton.name>
Cc: "monnier <at> iro.umontreal.ca" <monnier <at> iro.umontreal.ca>, "78446 <at> debbugs.gnu.org" <78446 <at> debbugs.gnu.org>
Subject: bug#78446: [PATCH] * lisp/emacs-lisp/find-func.el: Fix Eager macro-expansion failure
Date: Wed, 21 May 2025 06:41:24 +0000

[Message part 1 (text/plain, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
Sent: Tuesday, May 20, 2025 12:45 PM
> I'd prefer the other solution, to move the setter function before its
> first use, or its first use after the function is defined.  The
> bound-and-true-p use looks strange in a file that defines the
> function.


Agree, and that's should be better.
I found the lisp/jka-cmpr-hook.el:57 has similar behavior that (defvar jka-compr-compression-info-list) first, then defcustom it on the tail for everything been ready.

I attach the patch with defvar find-function-mode-lower-precedence first, then defcustom it at the tail of the file find-func.el (similarly to the jka-comp-hook.el).

Please help review again. Thank you!

[0001-lisp-emacs-lisp-find-func.el-Fix-Eager-macro-expansi.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.