GNU bug report logs - #78428
[PATCH] gnu: elogind: Adjust patch for pkttyagent path.

Previous Next

Full log

Message #17 received at 78428 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 78428 <at> debbugs.gnu.org
Subject: Re: [bug#78428] [PATCH] gnu: elogind: Adjust patch for pkttyagent
 path.
Date: Tue, 20 May 2025 16:58:02 +0900

Hi,

Sergey Trofimov <sarg <at> sarg.org.ru> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Hi,
>>
>> Sergey Trofimov <sarg <at> sarg.org.ru> writes:
>>
>>> * gnu/packages/freedesktop.scm (elogind):
>>> [#:phases]<fix-pkttyagent-path>: Adjust the regexp to work with source
>>> version 255.17.
>>>
> [...]
>>
>> Oof.  It's terrible that these substitution fail silently.
>
> I remember phases had to return #t, it got relaxed in
> https://codeberg.org/guix/guix-mirror/commit/9621809ce8d984fff6421cb55fc851a24954be06

Yeah, the return value wouldn't here though.  What I meant was that it
would be nice if substitute* could fail when a pattern failed to match
(and thus substitute) anything.  See for example bug#36772.

>> 
>> This packages rebuilds about 4K, so we'll need to make a
>> 'elogind-fixed' package and use it as a replacement (graft). Would you
>> like to do so in this same change? You can send a v2.
>
> Sure, done.

Thanks.  I'll take a look now.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.