GNU bug report logs - #78422
[PATCH electronics-team] gnu: Add python-apycula.

Previous Next

Full log

View this message in rfc822 format

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78422 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: [bug#78422] [PATCH electronics-team] gnu: Add python-apycula.
Date: Wed, 14 May 2025 12:39:31 +0200

On Wed, May 14, 2025 at 12:30:07PM +0200, Cayetano Santos wrote:
> +      #:tests? #f                       ;requires network
This is a pity - any chance we could disable just a single test that
needs networking or do all tests need it?
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'sanity-check-fix
> +            (lambda _
> +              (substitute* "setup.py"
> +                (("'gowin_bba")
> +                 "# 'gowin_bbva")))))))
You (probably) could just substitute with an empty string "" (aka
deleting) instead of commenting it out.  But it doesn't really matter.
Maybe a comment on why this fixes anything could be a nice pointer for
future us on why it is/was necessary?


Apart from these questions this LGTM.

If it builds, works as expected and the linter is happy this could be
merged IMO.


Thanks for your time and effort!
gabber

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.