GNU bug report logs - #78416
[PATCH] * src/lread.c (get-load-suffixes): Avoid module suffix with compressed suffix

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: luangruo <at> yahoo.com, 78416 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: bug#78416: [PATCH] * src/lread.c (get-load-suffixes): Avoid module suffix with compressed suffix
Date: Sat, 17 May 2025 09:57:47 +0300

> From: Lin Sun <sunlin7 <at> hotmail.com>
> CC: "78416 <at> debbugs.gnu.org" <78416 <at> debbugs.gnu.org>, Po Lu
> 	<luangruo <at> yahoo.com>
> Date: Sat, 17 May 2025 00:01:49 +0000
> 
> Update the patch towards the previous review comments. 

Thanks, but I think you've misunderstood the comments.  We should only
ignore the ".gz" suffix.  Ignoring other suffixes would be a potential
regression, because there's nothing wrong in trying to load a file
called, say, foobar.so.abc.  The current code supports that, and I see
no reason to drop that support.

The ".gz" suffix gets in the way because dynamic loaders cannot load
such compressed shared libraries.

So the condition for not appending a suffix from
load-file-rep-suffixes should also test the value of 'ext', and only
refuse to append it if it compares equal with ".gz".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.