GNU bug report logs - #78414
[PATCH] gnu: openscad: Fix python support

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78414: closed ([PATCH] gnu: openscad: Fix python support)
Date: Fri, 16 May 2025 14:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 16 May 2025 14:18:56 +0000
with message-id <87r00o7i5r.fsf <at> kitej>
and subject line Re: [bug#78414] [PATCH] gnu: openscad: Fix python support
has caused the debbugs.gnu.org bug report #78414,
regarding [PATCH] gnu: openscad: Fix python support
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78414: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78414
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: nomike <nomike <at> nomike.com>
To: guix-patches <at> gnu.org
Cc: nomike <nomike <at> nomike.com>
Subject: [PATCH] gnu: openscad: Fix python support
Date: Wed, 14 May 2025 02:16:47 +0200

* gnu/packages/engineering.scm (emacs-scad-mode): Add missing nettle input; add patch for CMake to fail build if nettle isn't found

Change-Id: Ic6bea14048daac56dc8773bf8fbdbd3bb1f0eae9
---
Python support requires Nettle as an input which is nowhere documented.
Also due to a bug in the CMake scripts, the build process doesn't fail if
CMake is missing but just disables Python support in that case.

I've filed an upsrtream bug report and pull request for fixing CMake,
added a temporary patch to the packet until the PR is merged
and added the missing Nettle input.

 gnu/packages/engineering.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 377f9cc791..540a122b01 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -137,6 +137,7 @@ (define-module (gnu packages engineering)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages mpi)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages nettle)
   #:use-module (gnu packages networking)
   #:use-module (gnu packages openkinect)
   #:use-module (gnu packages parallel)
@@ -3236,6 +3237,9 @@ (define-public openscad
       list(APPEND CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
       find_package(EGL REQUIRED)
       target_link_libraries(OpenSCAD PRIVATE EGL::EGL)")
+                  ;; <https://github.com/openscad/openscad/issues/5897>
+                  (("find_package\\(Nettle 3.4\\)")
+                   "find_package(Nettle 3.4 REQUIRED)")
                   ;; Use the system sanitizers-cmake module.
                   (("\\$\\{CMAKE_SOURCE_DIR\\}/submodules/sanitizers-cmake/cmake")
                    (string-append (assoc-ref inputs "sanitizers-cmake")
@@ -3263,6 +3267,7 @@ (define-public openscad
                     mesa ; or libglvnd if we had mesa-glvnd, too
                     mimalloc
                     mpfr
+                    nettle
                     opencsg
                     python
                     python-numpy
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: nomike <nomike <at> nomike.com>
Cc: 78414-done <at> debbugs.gnu.org
Subject: Re: [bug#78414] [PATCH] gnu: openscad: Fix python support
Date: Fri, 16 May 2025 14:18:56 +0000

[Message part 4 (text/plain, inline)]

Patch applied as a59445e65d7812f586ae743b4a085258162a6995.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.