GNU bug report logs - #78410
Patch for tiny improve cl wrapper script

Previous Next

Full log

Message #8 received at 78410 <at> debbugs.gnu.org (full text, mbox):

From: Nick Bowler <nbowler <at> draconx.ca>
To: Yang Kun <ikspress <at> outlook.com>
Cc: 78410 <at> debbugs.gnu.org
Subject: Re: bug#78410: Patch for tiny improve cl wrapper script
Date: Thu, 15 May 2025 13:45:16 -0400

On Tue, May 13, 2025 at 11:05:54PM +0800, Yang Kun wrote:
[...]
> diff --git a/lib/compile b/lib/compile
> index c404e89..a2afc93 100755
> --- a/lib/compile
> +++ b/lib/compile
> @@ -28,12 +28,8 @@ scriptversion=2025-02-03.05; # UTC
>  # bugs to <bug-automake <at> gnu.org> or send patches to
>  # <automake-patches <at> gnu.org>.
>  
> -nl='
> -'
> -
> -# We need space, tab and new line, in precisely that order.  Quoting is
> -# there to prevent tools from complaining about whitespace usage.
> -IFS=" ""	$nl"
> +# We need space, tab and new line, in precisely that order.
> +IFS=$' \t\n'

IFS=$' \t\n' is a bashism which is not supported in most other shells.
The original code is portable.  This seems to have nothing to do with
the rest of your change, so why change it at all?

Cheers,
  Nick

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.