Subject: Re: [bug#78401] [PATCH] gnu: mupdf: Update to 1.26.0.

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 14 May 2025 22:55:58 +0900

Hi,

Divya Ranjan <[email-masked]> writes:

> * gnu/packages/pdf.scm (mupdf): Update to 1.26.0.

Various changes done here are not listed in the change log.  Please
consult other commits for examples or (info "(standards) Style of Change
Logs").

> Change-Id: I9b650356c8f6cbb36008c1956a59f4dd99c8d964
> ---
>  gnu/packages/pdf.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index a1c9da2c8a..91d47a74e3 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -862,14 +862,14 @@ (define-public python-pydyf
>  (define-public mupdf
>    (package
>      (name "mupdf")
> -    (version "1.25.2")
> +    (version "1.26.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "https://mupdf.com/downloads/archive/"
>                             "mupdf-" version "-source.tar.lz"))
>         (sha256
> -        (base32 "0lg45wp3ici2g2i49fmwa1k32bgkqqgl51nxnqqk0i8ilmdh8hnx"))
> +        (base32	 "1nncar9w0qdpwp4s00nazr7hbl2kpbp665a6gwpsmdz5d7j1hqz9"))

Extraneous whitespace inserted.

>         (modules '((guix build utils)
>                    (ice-9 ftw)
>                    (srfi srfi-1)))
> @@ -895,6 +895,7 @@ (define-public mupdf
>             libx11
>             libxext
>             mujs
> +	   brotli

Is this strictly needed for the update?  Otherwise, it'd be best done in
a distinct, separated commit.

>             openjpeg
>             openssl
>             zlib))
> @@ -907,6 +908,7 @@ (define-public mupdf
>        #~(list "verbose=yes"
>                (string-append "CC=" #$(cc-for-target))
>                "XCFLAGS=-fpic"
> +	      "USE_SYSTEM_BROTLI=yes"

I assume that's necessary and not something the build system
automatically tries?  If the later, do not explicit it (it makes inputs
rewriting less useful).

>                "USE_SYSTEM_FREETYPE=yes"
>                "USE_SYSTEM_GUMBO=yes"
>                "USE_SYSTEM_HARFBUZZ=yes"
> @@ -921,7 +923,7 @@ (define-public mupdf
>                "USE_SYSTEM_CURL=yes"
>                "USE_SYSTEM_LEPTONICA=yes"
>                "USE_SYSTEM_TESSERACT=yes"
> -              "USE_SONAME=no"           ;install as libmupdf.so
> +              "USE_SONAME=yes"

What is the rational for the above change?

-- 
Thanks,
Maxim