GNU bug report logs - #78396
[PATCH] Add option for not highlight parens inside comments or strings.

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: eg642616 <at> gmail.com, 78396 <at> debbugs.gnu.org
Subject: bug#78396: [PATCH] Add option for not highlight parens inside comments or strings.
Date: Sat, 31 May 2025 14:48:00 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
>   78396 <at> debbugs.gnu.org
> Date: Tue, 27 May 2025 17:02:20 -0400
> 
> Ideally, we'd want to match closing-parens-in-comments with
> opening-parens-in-comments.  But yes, it's good to refrain from giving
> the above bogus highlighting.
> 
> >> I've made an option for disable/control this behavior, by default its
> >> disabled but I wonder if this should be activated instead.
> > I'm worried by using syntax-ppss-context here: couldn't it sometimes
> > significantly slow down the highlighting of parens?  Stefan, WDYT?
> 
> `syntax-ppss` is not cheap, but here it's not used inside a loop and
> should be called only once per user-interaction so I'm not worried.
> I see there are two calls, tho, so I'd try to consolidate them so we call
> it at most once.

Thanks.

Elijah, would you like to update your patch as suggested by Stefan
above?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.