GNU bug report logs - #78391
30.0.92; remapped command's docstring still claims to have menu invocation

Previous Next

Full log

Message #11 received at 78391 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Jake <jforst.mailman <at> gmail.com>, 78391 <at> debbugs.gnu.org
Subject: Re: bug#78391: 30.0.92; remapped command's docstring still claims
 to have menu invocation
Date: Mon, 12 May 2025 10:50:26 -0400

> Thanks.  Does the patch below give good results?
>
> Stefan, any comments?
>
> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
> index e7bbd25..aacdcc5 100644
> --- a/lisp/help-fns.el
> +++ b/lisp/help-fns.el
> @@ -624,8 +624,11 @@ help-fns--key-bindings
>                (let ((start (point)))
>                  (help-fns--insert-menu-bindings
>                   menus
> -                 (concat "It can " (and keys "also ")
> -                         "be invoked from the menu: "))
> +                 (if remapped
> +                     (concat "Without the remapping, it could "
> +                             (and keys "also ") "be invoked from the menu: ")
> +                   (concat "It can " (and keys "also ")
> +                           "be invoked from the menu: ")))
>                  (fill-region-as-paragraph start (point))))
>              (ensure-empty-lines)))))))
>  

It gives a rather redundant text since the same "Without the remapping"
is used just above for the key bindings.  As a user I'd prefer it
integrated into that previous sentence to end up with a text along the
lines of:

    Its keys are remapped to ‘ibuffer’.
    Without this remapping, it would be bound to C-x C-b
    and to the menu entry Buffers → List All Buffers


- Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.