GNU bug report logs - #78385
[PATCH electronics-team] gnu: yosys: Improve package style.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Ekaitz Zarraga <ekaitz <at> elenq.tech>, 78385 <at> debbugs.gnu.org
Subject: [bug#78385] [PATCH electronics-team] gnu: yosys: Improve package style.
Date: Mon, 12 May 2025 20:44:07 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/fpga.scm (yosys): Improve package style.
>
> Change-Id: Ifa88e523d1637ba05166000056830faa53b45706
> ---
>
> [arguments] <#:phases> {fix-paths}: Replace search-input-file by this-package-input.

Hm, search-input-file is as good style as this-package-input, if not
better style, as it errors out early when a searched file is missing.
It also plays better with inheritance, as the gexps have a tendency to
bake references that can't be altered (easily) in inherited variants.

> {use-external-abc}: Move to fix-paths phase.

Is there a rationale to this?  I like descriptive phase names, so the
former appears better to me.

I think I'd keep the current status quo here.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.