From debbugs-submit-bounces@debbugs.gnu.org Sun May 11 16:22:46 2025 Received: (at submit) by debbugs.gnu.org; 11 May 2025 20:22:46 +0000 Received: from localhost ([127.0.0.1]:43483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEDC7-0004qe-9o for submit@debbugs.gnu.org; Sun, 11 May 2025 16:22:46 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54820) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEDC3-0004q3-Rr for submit@debbugs.gnu.org; Sun, 11 May 2025 16:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEDBw-0006tj-Ho for guix-patches@gnu.org; Sun, 11 May 2025 16:22:32 -0400 Received: from latitanza.investici.org ([2001:888:2000:56::19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEDBs-00059b-MP for guix-patches@gnu.org; Sun, 11 May 2025 16:22:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1746994943; bh=GXncxpwahH2EHc2D7EvrqBpWcGlObptYHBgyyWE19zw=; h=From:To:Cc:Subject:Date:From; b=mOsrGselzoYEdAy9k0uPIue/37mbDLfwwu/Ey9h84Q5JmMQ43wFVow8zlqROhFFGk 16ZisjcN2XPqPe9RWXon22FJ3yoMi2gu3Durhem8WsEq8GpoSZ1fhT1HyrCtAdK+8P g1a/w9JX3ZTfRikiP6QVOXpM636S/7dEKUAwpTcc= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4ZwZ0b1HbqzGp90; Sun, 11 May 2025 20:22:23 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZwZ0Z5qxXzGp9P; Sun, 11 May 2025 20:22:22 +0000 (UTC) From: Cayetano Santos To: guix-patches@gnu.org Subject: [PATCH electronics-team] gnu: yosys: Improve package style. Date: Sun, 11 May 2025 22:17:21 +0200 Message-ID: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Gabriel Wicki , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:888:2000:56::19; envelope-from=csantosb@inventati.org; helo=latitanza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/fpga.scm (yosys): Improve package style. Change-Id: Ifa88e523d1637ba05166000056830faa53b45706 --- [arguments] <#:phases> {fix-paths}: Replace search-input-file by this-package-input. {use-external-abc}: Move to fix-paths phase. gnu/packages/fpga.scm | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm index 2298dde595..b1f53560a8 100644 --- a/gnu/packages/fpga.scm +++ b/gnu/packages/fpga.scm @@ -205,34 +205,33 @@ (define-public yosys #:phases #~(modify-phases %standard-phases (add-before 'configure 'fix-paths - (lambda* (#:key inputs #:allow-other-keys) + (lambda _ (substitute* "backends/smt2/smtio.py" (("\\['z3") - (string-append "['" - (search-input-file inputs "bin/z3")))) + (string-append "['" #$(this-package-input "z3") "/bin/z3"))) (substitute* "kernel/fstdata.cc" (("vcd2fst") - (search-input-file inputs "bin/vcd2fst"))) + (string-append #$(this-package-input "gtkwave") + "/bin/vcd2fst"))) (substitute* "kernel/driver.cc" (("^#include \"libs/cxxopts/include/cxxopts.hpp\"") "#include ")) (substitute* '("passes/cmds/show.cc" "passes/cmds/viz.cc") (("exec xdot") - (string-append "exec " - (search-input-file inputs "bin/xdot"))) + (string-append "exec " #$(this-package-input "xdot") + "/bin/xdot")) (("dot -") - (string-append (search-input-file inputs "bin/dot") " -")) + (string-append #$(this-package-input "graphviz") "/bin/dot -")) (("fuser") - (search-input-file inputs "bin/fuser"))))) - (replace 'configure - (lambda* (#:key make-flags #:allow-other-keys) - (apply invoke "make" "config-gcc" make-flags))) - (add-after 'configure 'use-external-abc - (lambda* (#:key inputs #:allow-other-keys) + (string-append #$(this-package-input "psmisc") "/bin/fuser"))) (substitute* '("Makefile") (("ABCEXTERNAL \\?=") (string-append "ABCEXTERNAL = " - (search-input-file inputs "/bin/abc")))))) + #$(this-package-input "abc-yosyshq") + "/bin/abc"))))) + (replace 'configure + (lambda* (#:key make-flags #:allow-other-keys) + (apply invoke "make" "config-gcc" make-flags))) (add-after 'install 'add-symbolic-link (lambda* (#:key inputs #:allow-other-keys) ;; Previously this package provided a copy of the "abc" base-commit: 300d29e69988caf23684f08effa51f621c7ec083 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 07:22:12 2025 Received: (at 78385) by debbugs.gnu.org; 12 May 2025 11:22:12 +0000 Received: from localhost ([127.0.0.1]:50766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEREZ-0003ZL-Ui for submit@debbugs.gnu.org; Mon, 12 May 2025 07:22:12 -0400 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:37633) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uEREW-0003Yq-6K for 78385@debbugs.gnu.org; Mon, 12 May 2025 07:22:09 -0400 Received: from coney (mob-194-230-148-150.cgn.sunrise.net [194.230.148.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA id 761E71FFFF; Mon, 12 May 2025 13:22:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erlikon.ch; s=20250312; t=1747048920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EJ4L+RFMnv9aRKMaWFohGu+rcaUabYuEGxvjxHKXNFg=; b=MHlozZkJM9g1cLZZnIhRcz/aefq4lB+mIyDVq42wdfHUKGV9WrnEZVl9tl4n3kUSa+fwmP 6rMIa+H0efKVI76IaGdht4fjrG1I3kQO3dc7Wd6LubO0tAbvsMrudHd6hBi913HROfqxtl G2aiDeSu0UHrSOKRLPHsNXNCrhvQBj7NifR6vxeW0uhMSG+1yn5oRiQQJNQX/6jGIQ0y9k Pa33AqbST+N/Pg/9n8vytEra7pOIZ/DtrG6lS5k7JCRH53Mie16yOrOzYeZDI1vyYPw3HH Z4AugvWOJh3GXK5AnGw0kqM+6XC3psF3hQOuZo2f30/YngzmKFITGc5CIE/VeF59CPcLHh VynCnVvVYlq8aLFnais7FD00Sq+l4DoplxHkR1r5iviAdLwGiNMSK0ny8wEWZPaCbk2fAu 3WI9MCcRobtqwirZ+O4Wr8SoUY3izEKjjlRGgPQyK17d7VKX7lkGcptDeYYHZzxJjosyXP D9tzgLwuW6/xmyvNvOPx9VvAVbd0g/Uded2niIH+EmgTsDRiDfvA//RKUhTpr+9H79mPFJ Pgwz2sVNjqZs+CDNvObllsF6z9b3EoRjQHqGrr4FyqjqX/P1N0e+vLmL2z70EaGsvrI6sd HAH/I9WIMNiNrR1CTr+PDZqTCCbXgYlQXH8RZrMviPeXq/mJcVTkQ= Date: Mon, 12 May 2025 13:21:51 +0200 From: Gabriel Wicki To: Cayetano Santos Subject: Re: [bug#78385] [PATCH electronics-team] gnu: yosys: Improve package style. Message-ID: References: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78385 Cc: Maxim Cournoyer , Ekaitz Zarraga , 78385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) LGTM Thanks for your time and effort! From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 07:44:23 2025 Received: (at 78385) by debbugs.gnu.org; 12 May 2025 11:44:23 +0000 Received: from localhost ([127.0.0.1]:50860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uERa2-0007c7-OG for submit@debbugs.gnu.org; Mon, 12 May 2025 07:44:23 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:55577) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uERZx-0007bk-S2 for 78385@debbugs.gnu.org; Mon, 12 May 2025 07:44:18 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-7410c18bb00so4703073b3a.3 for <78385@debbugs.gnu.org>; Mon, 12 May 2025 04:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747050251; x=1747655051; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=95bmYZ3pWIkv27cZ6wFmjt/6ZK0Dqpz0phIqdO9sb90=; b=a+iTjvmoACHEX1fPtV4NAEwQktWZM1rsP8RpoNVUKQN3S3oLIiTzcbtArtLk1OgJdP ZUAxgx/TUeyZ0xzkNKfUd03x2EWGZCIFU4L5sJkjZDdhqPi6wRX57/CYpFq+FyReJrDb +4JDNQ1GmE1z98aVFKqoUV6bkC0m3yHGIcztowQMST4HVIsRMPKkYqrem6UQC9JmF7Sp hj1GH6ffeZPrC2T+NgNAXCfpEjjVw9tZ2hC36ElPzOUincpYt+0bLQZAZRXOPXTxS+eK 0K1PTfFko6dadpu5h/xIswDP/WvF2Jl1oxHNP3i8nnkUFwze/uaTm7wLLuaaZ7vxs3yo sSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747050251; x=1747655051; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=95bmYZ3pWIkv27cZ6wFmjt/6ZK0Dqpz0phIqdO9sb90=; b=qIc9pC6dYYNQF3dSqnePY/4cIk7RYcIoiiZkwXt+YhDzcdmapC8pMqXRtCOB/l8Xjb pR7261R61MY3+NQPkKFBLbZySl5xgGd8SEL7iCvR9wLni0D+RqoZgJ4CTsm6qMZOOCNi bBubYes+JWgK0dMqKwBEad43MNTJAIOUscu8mqUh6M0SST1L2stEBqY5cJLEgiDWoo/f huxnLuN4tFbHUR40zrsDnsnDDEaDMLG0mHSdScCEs75Y1WVq7rdnIQhQHEGwmkyAm53x FyuPpvNwkP003iPLq8t2sSyXXG5yGfw1DEsLN8r8usHop1ALHT0YACfZ1LR1Nukc01jN p0/Q== X-Gm-Message-State: AOJu0YzqTDZKLk32W1oLpCVUQlsFfzYreZFTlref91HLma+5aWwc3TXc VXL29wOSus7ixawL1pMKC7teuuDkeQjLu31BaA8cc/PLnKl5uqhZ X-Gm-Gg: ASbGncuKLBzK0jMBphdxjy6k8/1ePCnj5uCKA2X1/PuJS9489/HDcGYscwfuiTcUI6O o2gxNDQK1DS74Gw1cC7krIwJ9TtwAdbgAG2Zip6mpXu4W6DxpS7Y+UZt3fDwf51X+6el11+BC7F sP0G7ERbY93ijeFOPV1cXcdHYlKGYL8467omkAw3lITIoMaQ98I/t5/ePNkE0UPzBmn3JNgZYqN uG8Kvx6uoi+qSCry9iYppZPsU4nXUIWoaZ7u18oc/UU/x5uFiYqDwFt44lCBv0eZzkqTgNEhbnu SO2xDLyEIi6PbOEePqAR4b9F3hY8/1mg10OBPaeDpQmpOx8nkA== X-Google-Smtp-Source: AGHT+IHiEjiJcN4o2RqQSEFuYVbZuHNcVmH6yNRAvUP4tS/pYSFN9c178UZAqkXMvbWlrGsxJkyCtg== X-Received: by 2002:a05:6a00:1491:b0:736:3be3:3d76 with SMTP id d2e1a72fcca58-7423bfeb4e0mr17184213b3a.17.1747050251328; Mon, 12 May 2025 04:44:11 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74237a8f674sm5844720b3a.168.2025.05.12.04.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 04:44:10 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78385: [PATCH electronics-team] gnu: yosys: Improve package style. In-Reply-To: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> (Cayetano Santos's message of "Sun, 11 May 2025 22:17:21 +0200") References: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> Date: Mon, 12 May 2025 20:44:07 +0900 Message-ID: <87bjryqcjc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78385 Cc: Gabriel Wicki , Ekaitz Zarraga , 78385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Cayetano, Cayetano Santos writes: > * gnu/packages/fpga.scm (yosys): Improve package style. > > Change-Id: Ifa88e523d1637ba05166000056830faa53b45706 > --- > > [arguments] <#:phases> {fix-paths}: Replace search-input-file by this-package-input. Hm, search-input-file is as good style as this-package-input, if not better style, as it errors out early when a searched file is missing. It also plays better with inheritance, as the gexps have a tendency to bake references that can't be altered (easily) in inherited variants. > {use-external-abc}: Move to fix-paths phase. Is there a rationale to this? I like descriptive phase names, so the former appears better to me. I think I'd keep the current status quo here. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 08:00:45 2025 Received: (at 78385) by debbugs.gnu.org; 12 May 2025 12:00:45 +0000 Received: from localhost ([127.0.0.1]:50975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uERpt-000085-4O for submit@debbugs.gnu.org; Mon, 12 May 2025 08:00:45 -0400 Received: from devianza.investici.org ([2c0f:f930:0:4::108]:39839) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uERpm-00007f-11; Mon, 12 May 2025 08:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1747051233; bh=+uH/qQlPCYRBL+AMSARR7UHpvaujeFgFfPFzw23YZ3s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=msoJQptUib/HxJFxeZk+qicojMoNLbdXHsTdD9R5zdwj43mhkn6EPLwEQAHUX1CuV ldPQcqdW1/2L37YOdb+fNiRD4nc5Q5ysyRC35zVnvPKcqMuwNBUq+FK28kRQvSyXeT t4/l/S3uQxwdw1BPemcPGUSuTzZz90T4XB2ZmEmw= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Zwyq521dGz6xfH; Mon, 12 May 2025 12:00:33 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Zwyq46KCKz6xfG; Mon, 12 May 2025 12:00:32 +0000 (UTC) From: Cayetano Santos To: 78385-done@debbugs.gnu.org Subject: Closing In-Reply-To: <87bjryqcjc.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 12 May 2025 20:44:07 +0900") References: <9534194559e114b0bcbfccb36de133b82bbe18c0.1746994641.git.csantosb@inventati.org> <87bjryqcjc.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Mon, 12 May 2025 14:00:31 +0200 Message-ID: <87zffi82e8.fsf@inventati.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78385 Cc: Ekaitz Zarraga , Gabriel Wicki , 78385@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >lun. 12 mai 2025 at 20:44, Maxim Cournoyer wrote: > Hm, search-input-file is as good style as this-package-input, if not > better style, as it errors out early when a searched file is missing. > It also plays better with inheritance, as the gexps have a tendency to > bake references that can't be altered (easily) in inherited variants. My bad, for some reason, I was convinced the this-package-input form was best suited for cross-compiling / transformations. Closing, then. C. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaCHi3xccY3NhbnRvc2JA aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgs+rAP0Tuzq/lp9JyWMDIMeVn5Inv6kA osRbp4DeXhwyJUSkJgD9F9WyBPPlMr41QN1TaA0x8TiewrlqbQgHSEWY2vjyHAI= =URdT -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Jun 19 14:31:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 Jun 2025 11:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator