GNU bug report logs - #78375
daemon: Replace random_shuffle() with shuffle()

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78375: closed (daemon: Replace random_shuffle() with shuffle())
Date: Mon, 12 May 2025 08:55:07 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 12 May 2025 10:11:42 +0200
with message-id <87a57i5jup.fsf <at> gnu.org>
and subject line Re: [bug#78375] daemon: Replace random_shuffle() with shuffle(), [PATCH] Replace random_shuffle with shuffle
has caused the debbugs.gnu.org bug report #78375,
regarding daemon: Replace random_shuffle() with shuffle()
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78375: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78375
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Congcong Kuo <congcong.kuo <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: daemon: Replace random_shuffle() with shuffle()
Date: Sun, 11 May 2025 17:24:02 +0800

[Message part 3 (text/plain, inline)]

Hello,

I am trying to build libstore using the Zig build system. The default C++ version of ‘zig c++’ is gnu++17 and random_shuffle() has been removed in C++ 14 standard.

Even though guix is built using gnu++11 currently, I think it is not harmful to replace a deprecated function.

Regards,
Kuo

[0001-Replace-random_shuffle-with-shuffle.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Congcong Kuo <congcong.kuo <at> gmail.com>
Cc: 78375-done <at> debbugs.gnu.org
Subject: Re: [bug#78375] daemon: Replace random_shuffle() with shuffle(),
 [PATCH] Replace random_shuffle with shuffle
Date: Mon, 12 May 2025 10:11:42 +0200

Hello,

Congcong Kuo <congcong.kuo <at> gmail.com> writes:

> I am trying to build libstore using the Zig build system. The default
> C++ version of ‘zig c++’ is gnu++17 and random_shuffle() has been
> removed in C++ 14 standard.
>
> Even though guix is built using gnu++11 currently, I think it is not harmful to replace a deprecated function.
>
> Regards,
> Kuo
>
> From fc7ccca0a1a58e16d1c4729b31bc477deddb308b Mon Sep 17 00:00:00 2001
> From: Congcong Kuo <congcong.kuo <at> gmail.com>
> Date: Sun, 11 May 2025 16:31:22 +0800
> Subject: [PATCH] Replace random_shuffle with shuffle
>
> ---
>  nix/libstore/gc.cc | 5 ++++-

I added a commit log following our conventions and applied it, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.