From debbugs-submit-bounces@debbugs.gnu.org Sun May 11 11:43:37 2025 Received: (at submit) by debbugs.gnu.org; 11 May 2025 15:43:38 +0000 Received: from localhost ([127.0.0.1]:38034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uE8py-0002qO-O9 for submit@debbugs.gnu.org; Sun, 11 May 2025 11:43:37 -0400 Received: from lists.gnu.org ([2001:470:142::17]:43644) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uE2uu-0004VW-9y for submit@debbugs.gnu.org; Sun, 11 May 2025 05:24:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uE2uo-0000y2-0K for guix-patches@gnu.org; Sun, 11 May 2025 05:24:10 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uE2um-0005eN-Ef for guix-patches@gnu.org; Sun, 11 May 2025 05:24:09 -0400 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-72d3b48d2ffso3705319b3a.2 for ; Sun, 11 May 2025 02:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746955446; x=1747560246; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=siPKrj+SL83/lYb36vHj+G7WsTe2WIGE/q0K7ONU+hA=; b=JvBZEPRv0modtbtsBpie7NFf9ba4VCqbnESm5oXj3BiACn/u50wLnuToeMyk+whP57 m37jftlUw84tsOos9F3XpysjJLz/6sYw08+ZvPj7p6OxkH7AtUDzdjeVMefDUDIAnoL6 s+XT4ViY1QdLZnyJbfHOUoDVUc0KRHgp9V20PHzFt48eTxPFBhV6dNme2zNba2LHU4U+ edCp92r6lrLjcajVw3HouO+FZNuwOqtFCEIw6luacER7IyJ3DQHQlITSIXQhpPpmZGkF 72FiEKCMiI++oYyiZQtM7c+ygrviuMJ8zg2Ob+jgi2cmBxhv3BLRzq2IoReLgR0r2Trh Dhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746955446; x=1747560246; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=siPKrj+SL83/lYb36vHj+G7WsTe2WIGE/q0K7ONU+hA=; b=qyA6bzbDwaakkM7kv5JeCFMk12fDSw52BpKrxod9/AoFvvGizol6Qhc7XxFIXcPoo9 FiVPjwlIx7Qd8uyyga+2b9XnvDCRro3deDRsd7rqEVvzk/S6w6kV2vymgayz11AdLOAa 7LnVzimrCNGnmFnppKQubAxqI/4A1lhL2RdCKfHy+FeE78vRqkBODkpbKGdJX5LYIboS GhmDUWRcMeV5vk4VAi3io17qO+Mad+AEpmMgThuXFl+iWU9cPstsyqZPvKMdJAG0mJOI Y6+XfIuSQTtLuoZmIjQKtdCnl4Jcqmf94hARvYVHTfUU9i8Tsnwe5Yf04haLW9VmP7B5 MjPA== X-Gm-Message-State: AOJu0Yzu0dunr76E/rmIH3e6Lh8VMmR80+lc+RkyjkTfBu+IGcBLAqqX 0o+0ChLoUySrBv5gDTcOp6zxgCPe7d0vxka1e26DSL1n9+2ueH0Jb417GJqG X-Gm-Gg: ASbGncv0+cleufaw7eEgteYA70F4XNCR8aNS4MvfS4O6f5ukLCsl+Z6q6IN5dMX77cz 9VRAzLOhCnjCFpCLpKQsFsbB2qI5r0cDkbO0cLv4WfocoRJ7mmrgnpJrzbNec/uKETW2iQjNPuF Y//1eYTEL/e+Aqqyd9jMVnqFmOIMPJ+UZcD7SjPciQgSI887ExpMS8n4VxvLY3dciWtm6uo8U8S rM5wMfwHMzDKTm8TuS8vZ9AqZThiYybhaN42O5FEL5LqvilkK0uMNVDG7qr49GgMXeoTNboTZS4 aHndnlk7/mYROBfFKj5Ab+Xq1cn/bm6i4y7Bb++NbUfKI3g4aLBD+29VJ6ONU3SNQ3G86xGyFOF obKBLvahFTFhmzbLoTNAYJybZTbyomB4dhPCW X-Google-Smtp-Source: AGHT+IGIgSzuV5fvmSLf4YuwDDlElUOyi/h5iMlMUWJCWu6p39MvIysVexL+VaeGewiUtDN7bil5Ng== X-Received: by 2002:a05:6a00:1488:b0:736:5438:ccc with SMTP id d2e1a72fcca58-7423be886d6mr11454030b3a.9.1746955446088; Sun, 11 May 2025 02:24:06 -0700 (PDT) Received: from [198.19.249.3] (ec2-13-52-193-232.us-west-1.compute.amazonaws.com. [13.52.193.232]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74237a0ea3csm4334176b3a.103.2025.05.11.02.24.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 May 2025 02:24:05 -0700 (PDT) From: Congcong Kuo To: guix-patches@gnu.org Subject: daemon: Replace random_shuffle() with shuffle() Date: Sun, 11 May 2025 17:24:02 +0800 X-Mailer: MailMate Trial (2.0r6255) Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_MailMate_A99E1C92-A90B-4753-BCA2-F4BC97B5F568_=" Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=congcong.kuo@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 11 May 2025 11:43:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=_MailMate_A99E1C92-A90B-4753-BCA2-F4BC97B5F568_= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, I am trying to build libstore using the Zig build system. The default C++= version of =E2=80=98zig c++=E2=80=99 is gnu++17 and random_shuffle() has= been removed in C++ 14 standard. Even though guix is built using gnu++11 currently, I think it is not harm= ful to replace a deprecated function. Regards, Kuo --=_MailMate_A99E1C92-A90B-4753-BCA2-F4BC97B5F568_= Content-Disposition: attachment; filename=0001-Replace-random_shuffle-with-shuffle.patch Content-ID: <1ED55F54-51AB-433F-ACE4-AAD92C871AE6@gmail.com> Content-Type: text/plain; name=0001-Replace-random_shuffle-with-shuffle.patch Content-Transfer-Encoding: quoted-printable =46rom fc7ccca0a1a58e16d1c4729b31bc477deddb308b Mon Sep 17 00:00:00 2001 From: Congcong Kuo Date: Sun, 11 May 2025 16:31:22 +0800 Subject: [PATCH] Replace random_shuffle with shuffle --- nix/libstore/gc.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nix/libstore/gc.cc b/nix/libstore/gc.cc index 1651911..261ea79 100644 --- a/nix/libstore/gc.cc +++ b/nix/libstore/gc.cc @@ -4,6 +4,7 @@ = #include #include +#include #include = #include @@ -745,7 +746,9 @@ void LocalStore::collectGarbage(const GCOptions & opt= ions, GCResults & results) alphabetically first (e.g. /nix/store/000...). This matters when using --max-freed etc. */ vector entries_(entries.begin(), entries.end()); - random_shuffle(entries_.begin(), entries_.end()); + std::random_device seeder; + std::default_random_engine generator(seeder()); + std::shuffle(entries_.begin(), entries_.end(), generator); = foreach (vector::iterator, i, entries_) tryToDelete(state, *i); -- = 2.45.2 --=_MailMate_A99E1C92-A90B-4753-BCA2-F4BC97B5F568_=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 04:54:39 2025 Received: (at 78375-done) by debbugs.gnu.org; 12 May 2025 08:54:39 +0000 Received: from localhost ([127.0.0.1]:50053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEOvm-0003tb-Uu for submit@debbugs.gnu.org; Mon, 12 May 2025 04:54:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36506) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEOvj-0003t5-BR for 78375-done@debbugs.gnu.org; Mon, 12 May 2025 04:54:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEOvd-00032C-KB; Mon, 12 May 2025 04:54:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=l0McKcPPIf13z4RUwt7Go3chuPoRM7Fm6RvocEl4CHU=; b=WOhHfGaM2bXQjeoe60qM 6t+sfYezo8LPQH3dKwCLPjjngM7O0mQ7YqpEZxt9lqxc4MkbqS4Bkdkad1pGym1g4uj7cEiJYH7jk vOCxDHFBky2F1KXU1xSkrkeCuaYz+l2RqZeo2v37VOVtXz8M+/fRDlFCusz6Atr/a8y5hSRt4qENq k5MiBe2yBDJlO/dwvo3T5vIlpjQ0HZwuCKIM7F2gTOXvK1JLI7WXZRXJ0LiBbTtTQ58OSA4gpS0nx SpLFITriBmBXXB69lwH+/vZEqts+EqAXuUesekD4VQ2RpMGqAHiIjeMsPeA/UpBFZmKwiHV+KRNSM royY1daOxAnzUg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Congcong Kuo Subject: Re: [bug#78375] daemon: Replace random_shuffle() with shuffle(), [PATCH] Replace random_shuffle with shuffle In-Reply-To: (Congcong Kuo's message of "Sun, 11 May 2025 17:24:02 +0800") References: Date: Mon, 12 May 2025 10:11:42 +0200 Message-ID: <87a57i5jup.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78375-done Cc: 78375-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Congcong Kuo writes: > I am trying to build libstore using the Zig build system. The default > C++ version of =E2=80=98zig c++=E2=80=99 is gnu++17 and random_shuffle() = has been > removed in C++ 14 standard. > > Even though guix is built using gnu++11 currently, I think it is not harm= ful to replace a deprecated function. > > Regards, > Kuo > > From fc7ccca0a1a58e16d1c4729b31bc477deddb308b Mon Sep 17 00:00:00 2001 > From: Congcong Kuo > Date: Sun, 11 May 2025 16:31:22 +0800 > Subject: [PATCH] Replace random_shuffle with shuffle > > --- > nix/libstore/gc.cc | 5 ++++- I added a commit log following our conventions and applied it, thanks! Ludo=E2=80=99. From unknown Fri Sep 05 20:37:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Jun 2025 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator