GNU bug report logs - #78369
[PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d.

Previous Next

Full log

View this message in rfc822 format

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78369 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: [bug#78369] [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d.
Date: Mon, 12 May 2025 13:45:19 +0200

Hi!

On Sun, May 11, 2025 at 12:41:57PM +0200, Cayetano Santos wrote:
> +               ;; Pull the bitstream database for ECP5 devices; this is useful
> +               ;; only by prjtrellis: there is no need to package it separately.
*this is useful for prjtrellis only
would be the (more) correct English phrasing.

> +        ;; The examples test directory requires nextpnr, using this package as a
> +        ;; backend, which is provided by nextpnr-ecp5: the tests are to be run
> +        ;; in this later package.
This seems like an overly complicated phrasing that I am not sure I
understand correctly.  Where are the tests run, actually?  Package
nextpnr does not depend on this package IIUC.

The patch looks good, increasing the quality of the code comments would
be great, though.  Would you mind sending in an updated version of this patch?

Thanks for your time and effort!
gabber

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.