From unknown Sat Aug 16 18:19:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78369 <78369@debbugs.gnu.org> To: bug#78369 <78369@debbugs.gnu.org> Subject: Status: [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d. Reply-To: bug#78369 <78369@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:19:56 +0000 retitle 78369 [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898= 329d. reassign 78369 guix-patches submitter 78369 Cayetano Santos severity 78369 normal tag 78369 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 11 06:42:43 2025 Received: (at submit) by debbugs.gnu.org; 11 May 2025 10:42:43 +0000 Received: from localhost ([127.0.0.1]:58739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uE48o-0001F0-FC for submit@debbugs.gnu.org; Sun, 11 May 2025 06:42:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45002) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uE48l-0001Eg-SA for submit@debbugs.gnu.org; Sun, 11 May 2025 06:42:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uE48f-0002WH-Iv for guix-patches@gnu.org; Sun, 11 May 2025 06:42:33 -0400 Received: from latitanza.investici.org ([82.94.249.234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uE48c-0004nj-QK for guix-patches@gnu.org; Sun, 11 May 2025 06:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1746960140; bh=auk0/TcARcaLm40HofRl8xaeRKX1ckNLrd+9Kcsh0No=; h=From:To:Cc:Subject:Date:From; b=uoldaaY3QRyTKWUOgyRWYa2w5MMjyAAruw/ZrcuaNgEe2eGzAWWjfY/D5E7QbPFUg ixIHPa9oBdDCDRPaR9FYZ4r2JzT4tAQjq5g7z+UNCx9em207A+FabG1TPMFVIvTx54 0bPo+8R2DLY/fuUT9bFxmzO36KdLMAlE9rQV4e7A= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4ZwK7J0MJTzGp9f; Sun, 11 May 2025 10:42:20 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZwK7H5DwvzGp9V; Sun, 11 May 2025 10:42:19 +0000 (UTC) From: Cayetano Santos To: guix-patches@gnu.org Subject: [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d. Date: Sun, 11 May 2025 12:41:57 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Gabriel Wicki , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=82.94.249.234; envelope-from=csantosb@inventati.org; helo=latitanza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/electronics.scm (prjtrellis): Update to 1.4-0.898329d. Change-Id: I7773415ee875fe266e523ee8fda25467db1b85f5 --- gnu/packages/electronics.scm | 95 +++++++++++++++++++----------------- 1 file changed, 49 insertions(+), 46 deletions(-) diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm index da37a9fb33..f7134fac8e 100644 --- a/gnu/packages/electronics.scm +++ b/gnu/packages/electronics.scm @@ -423,50 +423,53 @@ (define-public openboardview (license license:expat))) (define-public prjtrellis - (package - (name "prjtrellis") - (version "1.4") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/YosysHQ/prjtrellis/") - (commit version) - ;; Pull the bitstream database for ECP5 devices; this is useful - ;; only by prjtrellis: there is no need to package it separately. - (recursive? #t))) - (file-name (git-file-name name version)) - (modules '((guix build utils))) - (snippet - ;; Remove bundled source code for which Guix has packages. - '(with-directory-excursion "libtrellis/3rdparty" - (for-each delete-file-recursively - '("pybind11")))) - (sha256 - (base32 "0c3asdfrjmnc6q3vawn3nfghgg43iajwy2zb8kck9d3wrypbhlmc")))) - (build-system cmake-build-system) - (arguments - (list - ;; The examples test directory requires nextpnr, using this package as a - ;; backend, which is provided by nextpnr-ecp5: the tests are to be run - ;; in this later package. - #:tests? #f - #:phases - #~(modify-phases %standard-phases - (add-after 'unpack 'chdir - (lambda _ - (chdir "libtrellis"))) - ;; point to pybind11 include dir - (add-after 'chdir 'setenv-pybind11 - (lambda* (#:key inputs #:allow-other-keys) - (setenv "PYBIND11_INCLUDE_DIR" - (string-append #$(this-package-input "pybind11") - "/include/pybind11"))))))) - (native-inputs (list python)) - (inputs (list openocd boost pybind11)) - (synopsis "Placement and routing for ECP5 FPGAs") - (description - "Project Trellis is a Nextpnr backend compatible with ECP5 FPGAs. + ;; Last release is 2 years old. + (let ((commit "898329dddf6ce6463299973081f109d645b9c55f") + (revision "0")) + (package + (name "prjtrellis") + (version (git-version "1.4" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/YosysHQ/prjtrellis/") + (commit commit) + ;; Pull the bitstream database for ECP5 devices; this is useful + ;; only by prjtrellis: there is no need to package it separately. + (recursive? #t))) + (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet + ;; Remove bundled source code for which Guix has packages. + '(with-directory-excursion "libtrellis/3rdparty" + (for-each delete-file-recursively + '("pybind11")))) + (sha256 + (base32 "1qljgn7rxz114vki21rms70zi9rgr4gw7crdfihxx1n68zgv60gg")))) + (build-system cmake-build-system) + (arguments + (list + ;; The examples test directory requires nextpnr, using this package as a + ;; backend, which is provided by nextpnr-ecp5: the tests are to be run + ;; in this later package. + #:tests? #f + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'chdir + (lambda _ + (chdir "libtrellis"))) + ;; point to pybind11 include dir + (add-after 'chdir 'setenv-pybind11 + (lambda* (#:key inputs #:allow-other-keys) + (setenv "PYBIND11_INCLUDE_DIR" + (string-append #$(this-package-input "pybind11") + "/include/pybind11"))))))) + (native-inputs (list python)) + (inputs (list openocd boost pybind11)) + (synopsis "Placement and routing for ECP5 FPGAs") + (description + "Project Trellis is a Nextpnr backend compatible with ECP5 FPGAs. The following features are currently available: @itemize @item logic slice functionality, including carries @@ -478,8 +481,8 @@ (define-public prjtrellis @item global networks and PLLs @item transcievers (DCUs.) @end itemize") - (home-page "https://github.com/YosysHQ/prjtrellis/") - (license license:expat))) + (home-page "https://github.com/YosysHQ/prjtrellis/") + (license license:expat)))) (define-public opensta ;; There are no releases, we use last commit. base-commit: 4fe484ee7e9d598a9d0a249c375b75a14b95d1b4 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 07:45:40 2025 Received: (at 78369) by debbugs.gnu.org; 12 May 2025 11:45:40 +0000 Received: from localhost ([127.0.0.1]:50873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uERbH-0007ku-Rn for submit@debbugs.gnu.org; Mon, 12 May 2025 07:45:40 -0400 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:47251) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uERbE-0007kZ-5x for 78369@debbugs.gnu.org; Mon, 12 May 2025 07:45:37 -0400 Received: from coney (mob-194-230-148-150.cgn.sunrise.net [194.230.148.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA id A886A1FF2B; Mon, 12 May 2025 13:45:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erlikon.ch; s=20250312; t=1747050328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KfvTOW/6IvG1DUD5//jW7G9y2/w8t+OgVVqwn59DQf0=; b=SHx5FP2dSB4v+G8bDexczgO5nPV36+LuZ/a+7Ye6dyU9pNiBKFhVJ1iS8nRcDEqRzovLj7 fqT2By+bRJqnyPhuW5ITCrd5/caiX7LOxh3YPAjE0y6boBqzOHVIaKtMh+zYl3eJrCnNP7 SGQUfZvNg+KbIvsRtWPZt0Ovmde/Lmq0GaXym8M4gvrFuSkHk5J21YPZxjo+si+F3EtZdj AfOV/9cQtKFW60WHf4+RtwZqAZ8L9ksoH8TqtYVDg2n+5t0FQRjboyCh7iecgoLpbDjFOG n6nO+Pc6MNMIxg84ybDbWdgRVENfBRe+suXwSd/YsXk+fgdmK/5cE9+y1+n06pJlBZy6wD fYtRXIDiCddxIHvaZUBotOK6wIwlIyFbPtEjWohSa3LCPT6BR13iZAiA7E2xSOI+0l+u2x SVn4ezJzLkWZBLk3bj3FxccHOHdVD+nhsHqfhzmGO0F9R/S7WDI+eMgIacQDbQPEnz6VXi lFCIXJcvLXlrX2U0KgLbQjj9BNvDkH10JnnUNdUH0sL/2qXHe9VfAYA4IVmqaRNrHrGGix BcJKh17MzwryyfGTbVNZqNoVuFuLqPIroPr4pzXr7LE/exSLf46siTBM3kGIHUEw5HyVIU 6jZWIUlDo3w1dT0zcMzUK0udjw/r9Veq6Vr+Pka3EG9b1iOR+pNGk= Date: Mon, 12 May 2025 13:45:19 +0200 From: Gabriel Wicki To: Cayetano Santos Subject: Re: [bug#78369] [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78369 Cc: 78369@debbugs.gnu.org, Maxim Cournoyer , Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! On Sun, May 11, 2025 at 12:41:57PM +0200, Cayetano Santos wrote: > + ;; Pull the bitstream database for ECP5 devices; this is useful > + ;; only by prjtrellis: there is no need to package it separately. *this is useful for prjtrellis only would be the (more) correct English phrasing. > + ;; The examples test directory requires nextpnr, using this package as a > + ;; backend, which is provided by nextpnr-ecp5: the tests are to be run > + ;; in this later package. This seems like an overly complicated phrasing that I am not sure I understand correctly. Where are the tests run, actually? Package nextpnr does not depend on this package IIUC. The patch looks good, increasing the quality of the code comments would be great, though. Would you mind sending in an updated version of this patch? Thanks for your time and effort! gabber From debbugs-submit-bounces@debbugs.gnu.org Wed May 14 22:10:48 2025 Received: (at 78369-done) by debbugs.gnu.org; 15 May 2025 02:10:48 +0000 Received: from localhost ([127.0.0.1]:48171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFO3c-0003MH-8O for submit@debbugs.gnu.org; Wed, 14 May 2025 22:10:48 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:53732) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uFO3Z-0003Ly-DG for 78369-done@debbugs.gnu.org; Wed, 14 May 2025 22:10:46 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22e7eff58a0so4588715ad.3 for <78369-done@debbugs.gnu.org>; Wed, 14 May 2025 19:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747275039; x=1747879839; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WtJcJtjU/UkUEtyFy0HFCVvOJNEIsJ+DnIGIcu2yjak=; b=lyacU+FSiJIpZPAwSxV/fSRLY0SskobPwbmopdGiszuW9IzrHUho1iZq4kXpJ4Pfx2 i0OLH0n4F1pApdCu9vN/SdiAQcbZO79fBHIvR9ZMoBzONQUOW0le7T3b4MYfYfEdQ3gm Re3jn5xULhBoPkU3sz8T3YTKg8/vfUtB6emuYcNR/4tJZQ7ueHMxJkAO+Tx4FixZH9wB nql1OwkjfkW2fX7J0weZkChGwr5Moi4REbVsuSGbMhOl3bEtzbsJgN8Cr1gEo5qaEUdq 0DkIIskQiWSCPkH2Z5imQgddWB4Qju+oGtqAIBZQP4jYKtxNDaFbuWkF1/R/uxx9RC6E fKYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747275039; x=1747879839; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WtJcJtjU/UkUEtyFy0HFCVvOJNEIsJ+DnIGIcu2yjak=; b=cnbmFXbVEb47Lq3nT1X7Qr/vF7UnhKEUYUlj9AYePkueP1dXNNIcT/J7BHAl+LfF+N F/IU8H8YPRStSyZrKXkDK8X52NPsqhGuG7ngOuNQQ0/mz+Qpn08Vr0AvpiEWwrYKR0dr i2jnwmfzqFXVRyZMObS9hKhRUQWCqwDcAQZXqHGO62vr3XJFOPLKjDjkRkYO5aC6fLqu LpPSJCQntXvFT1fjkHFhNW3L19OrQNY/ut9uAkM3nndyypuIabELlzwxndbAPxspwrYE cwNJzlHX3dUhA6QZKWEaF6bcPHKKcpJnac2iTG26lj7Vd9RZo+/MKebRReSpAqYRs31w JNrQ== X-Gm-Message-State: AOJu0YwdOmAwoDMivxDiJB1j2wbGOJQbuBTblHMx63cj7GjMveQDtUSL YF44S5LMA5SC7zaaYlCRbMxLzsMbxR0a/D8pURPh11fls7no2sWS X-Gm-Gg: ASbGncuJDWgpnzQ43T82dAZ7LLvVK43tHto9q1KgaMj/IIl8LnMpSZTRW6IZBLqCNXh Znl2xqH3MV+Gb83LINDVxStiaXEyKdgLFxn7IXFHdZAQnZBhB1wpzwQIxucerSxeJzU9WHh1nPc 06EVkDq1PEsZx3BZFRO6QmB8aZXuOH3o+wLSBWoEYBEOVvGJ2U1xJUyFx+/Nbv9h+EPrpk/Uc+W AVBQfh89MDtJDFW1la/MbMrNtT7vxKj6OjIDEtI/xBQEtfW8Ba+UMDoczhhvE+t2QdsZK14QXgF 91V2+lFZZAkVZpC5YBXwPYUn8XZQApB/2CazUVUZAaF+6vyU4g== X-Google-Smtp-Source: AGHT+IGcOSV/uRlBYMPZ3U2SQzu1oYSXWrChFYv+awSyJqG15JAOb1awmaNdQwizKj9VkBKL8r6nqw== X-Received: by 2002:a17:903:1aef:b0:21c:fb6:7c3c with SMTP id d9443c01a7336-231b5e96ac3mr9924815ad.17.1747275039200; Wed, 14 May 2025 19:10:39 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc828b242sm105652095ad.185.2025.05.14.19.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 19:10:38 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: [bug#78369] [PATCH electronics-team] gnu: prjtrellis: Update to 1.4-0.898329d. In-Reply-To: (Cayetano Santos's message of "Sun, 11 May 2025 12:41:57 +0200") References: Date: Thu, 15 May 2025 11:10:36 +0900 Message-ID: <87msbek4ir.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78369-done Cc: 78369-done@debbugs.gnu.org, Gabriel Wicki , Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cayetano Santos writes: > * gnu/packages/electronics.scm (prjtrellis): Update to 1.4-0.898329d. I've made the following changes: --8<---------------cut here---------------start------------->8--- 1 file changed, 7 insertions(+), 12 deletions(-) gnu/packages/electronics.scm | 19 +++++++------------ modified gnu/packages/electronics.scm @@ -423,7 +423,7 @@ (define-public openboardview (license license:expat))) (define-public prjtrellis - ;; Last release is 2 years old. + ;; The last release is 2 years old; use the latest commit for now. (let ((commit "898329dddf6ce6463299973081f109d645b9c55f") (revision "0")) (package @@ -450,21 +450,16 @@ (define-public prjtrellis (build-system cmake-build-system) (arguments (list - ;; The examples test directory requires nextpnr, using this package as a - ;; backend, which is provided by nextpnr-ecp5: the tests are to be run - ;; in this later package. - #:tests? #f + #:tests? #f ;no test suite + #:configure-flags + #~(list (string-append "-DPYBIND11_INCLUDE_DIR=" + (search-input-directory %build-inputs + "include/pybind11"))) #:phases #~(modify-phases %standard-phases (add-after 'unpack 'chdir (lambda _ - (chdir "libtrellis"))) - ;; point to pybind11 include dir - (add-after 'chdir 'setenv-pybind11 - (lambda* (#:key inputs #:allow-other-keys) - (setenv "PYBIND11_INCLUDE_DIR" - (string-append #$(this-package-input "pybind11") - "/include/pybind11"))))))) + (chdir "libtrellis")))))) (native-inputs (list python)) (inputs (list openocd boost pybind11)) (synopsis "Placement and routing for ECP5 FPGAs") --8<---------------cut here---------------end--------------->8--- And pushed! -- Thanks, Maxim From unknown Sat Aug 16 18:19:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Jun 2025 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator