From unknown Thu Aug 14 20:53:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7834 <7834@debbugs.gnu.org> To: bug#7834 <7834@debbugs.gnu.org> Subject: Status: 24.0.50; doc of `put-image' Reply-To: bug#7834 <7834@debbugs.gnu.org> Date: Fri, 15 Aug 2025 03:53:34 +0000 retitle 7834 24.0.50; doc of `put-image' reassign 7834 emacs submitter 7834 "Drew Adams" severity 7834 minor tag 7834 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 12 17:40:06 2011 Received: (at submit) by debbugs.gnu.org; 12 Jan 2011 22:40:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pd9ML-0000Gb-RR for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:40:06 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pd9MJ-0000G5-H2 for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:40:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pd9Ta-0008Si-5r for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:47:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:50028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pd9TT-0008Pk-8i for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:47:34 -0500 Received: from [140.186.70.92] (port=41843 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pd9Rw-0005ql-3N for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pd9RV-0008EI-Ro for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:45:26 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:22188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pd9RV-0008E9-Mg for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:45:25 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p0CMjMFY027409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Jan 2011 22:45:24 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p0CM20xh022551 for ; Wed, 12 Jan 2011 22:45:22 GMT Received: from abhmt016.oracle.com by acsmt354.oracle.com with ESMTP id 954918021294872225; Wed, 12 Jan 2011 14:43:45 -0800 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Jan 2011 14:43:44 -0800 From: "Drew Adams" To: Subject: 24.0.50; doc of `put-image' Date: Wed, 12 Jan 2011 14:43:45 -0800 Message-ID: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuyqiuaLDonjmhLShajeFAIFxmvaQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) The doc string does not tell you what you need to know. Look at the code for `image-dired-dired-toggle-marked-thumbs', for instance. You will see that it makes use of the `put-image' overlay property (to gather the right overlay(s)). That property was added by the call to function `put-image'. But there is nothing in the doc for function `put-image' that mentions that it adds property `put-image' to the overlay that it creates. In fact, the doc says nothing about this overlay, just calling it "an overlay". Well, at least it says that the overlay has a `before-string' string with a `display' property whose value is the image. 1. The doc should mention the `put-image' property, which is the only way for you to recognize such an overlay AFAICT. 2. Why not have `put-image' return the overlay itself? That would simplify code such as that of `image-dired-dired-toggle-marked-thumbs', which, just after calling `put-image', tries to examine all overlays at point just to find the right one - the one with a `put-image' property. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-01-03 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 13:45:03 2011 Received: (at 7834) by debbugs.gnu.org; 14 Jul 2011 17:45:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhPy7-0007m5-0Q for submit@debbugs.gnu.org; Thu, 14 Jul 2011 13:45:02 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhPxg-0007kJ-Na for 7834@debbugs.gnu.org; Thu, 14 Jul 2011 13:44:39 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QhPxS-0005h3-QL; Thu, 14 Jul 2011 19:44:18 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 24.0.50; doc of `put-image' In-Reply-To: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> (Drew Adams's message of "Wed, 12 Jan 2011 14:43:45 -0800") Date: Thu, 14 Jul 2011 19:21:52 +0200 Message-ID: References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Joni Mitchell's _Court and Spark_: "Trouble Child" X-Hashcash: 1:23:110714:7834@debbugs.gnu.org::7zXEL99NYm3tLamh:00000000000000000000000000000000000000000GJDg X-Hashcash: 1:23:110714:drew.adams@oracle.com::ui2gdfjngO0q/NRC:0000000000000000000000000000000000000000gupS MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QhPxS-0005h3-QL X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311270259.29167@pJW4kzKZ4Af4oMQ0WK5jlg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7834 Cc: Stefan Monnier , 7834@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > 1. The doc should mention the `put-image' property, which is the only > way for you to recognize such an overlay AFAICT. I've now done this. > 2. Why not have `put-image' return the overlay itself? That would > simplify code such as that of `image-dired-dired-toggle-marked-thumbs', > which, just after calling `put-image', tries to examine all overlays at > point just to find the right one - the one with a `put-image' property. That's a good idea. Stefan, however, is really against primarily side-effect-ey functions returning usable values, so we should check with him first. Stefan? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 10:43:04 2011 Received: (at 7834) by debbugs.gnu.org; 15 Jul 2011 14:43:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhjbc-0002Mz-CU for submit@debbugs.gnu.org; Fri, 15 Jul 2011 10:43:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhjbY-0002MT-LL for 7834@debbugs.gnu.org; Fri, 15 Jul 2011 10:43:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOlQIE5MCqt8/2dsb2JhbABTp2N4iHrCVYY6BJ8lhDA X-IronPort-AV: E=Sophos;i="4.65,535,1304308800"; d="scan'208";a="126015308" Received: from 76-10-171-124.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.124]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Jul 2011 10:42:54 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 56776660D5; Fri, 15 Jul 2011 10:42:54 -0400 (EDT) From: Stefan Monnier To: Lars Magne Ingebrigtsen Subject: Re: 24.0.50; doc of `put-image' Message-ID: References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> Date: Fri, 15 Jul 2011 10:42:54 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 14 Jul 2011 19:21:52 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7834 Cc: 7834@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> 2. Why not have `put-image' return the overlay itself? That would >> simplify code such as that of `image-dired-dired-toggle-marked-thumbs', >> which, just after calling `put-image', tries to examine all overlays at >> point just to find the right one - the one with a `put-image' property. > That's a good idea. Stefan, however, is really against primarily > side-effect-ey functions returning usable values, so we should check > with him first. This function creates a new object, and that's a good idea to return it. The cases to which I'm opposed is when the function returns something which the caller knows even before calling the function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 10:51:37 2011 Received: (at control) by debbugs.gnu.org; 15 Jul 2011 14:51:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhjjt-0003Qx-BQ for submit@debbugs.gnu.org; Fri, 15 Jul 2011 10:51:37 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhjjr-0003Qk-R5 for control@debbugs.gnu.org; Fri, 15 Jul 2011 10:51:36 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qhjjg-0003vp-KU for control@debbugs.gnu.org; Fri, 15 Jul 2011 16:51:24 +0200 Date: Fri, 15 Jul 2011 16:51:24 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #7834 X-MailScanner-ID: 1Qhjjg-0003vp-KU X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311346284.68869@ipxSZwOFcEdE+M8ojFzIUg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 7834 pending From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 10:52:02 2011 Received: (at 7834) by debbugs.gnu.org; 15 Jul 2011 14:52:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhjkE-0003Rb-LH for submit@debbugs.gnu.org; Fri, 15 Jul 2011 10:52:02 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhjk9-0003RH-FJ for 7834@debbugs.gnu.org; Fri, 15 Jul 2011 10:51:57 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qhjju-0003w4-Cc; Fri, 15 Jul 2011 16:51:38 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: 24.0.50; doc of `put-image' In-Reply-To: (Stefan Monnier's message of "Fri, 15 Jul 2011 10:42:54 -0400") Date: Fri, 15 Jul 2011 16:51:09 +0200 Message-ID: References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEWJn51XRzrP0c0xJCFV dW/u8u4WDxBPNClkWEdRPDK5jiW4AAACR0lEQVQ4jV2TQYrjMBBFRchili3ajOVdE5gDBAUl3jm0 FskBfAKD9qEHZO8i2uDyUqiZWLedkqV43FNgAv/l66vKZdLwudhLJe9bMLorOs+sARJ1XlUBjNPD +5aO1hdr8CKN1Vq3cPXerkCPYLJFkReF9Z5w8Q1M0zhcL9BLdAjVPEF+m6b8bIzJfhChgs6rvjSn s24HDPGFp4YopcJR8sXlp1wzMAOYCwALANHh/cv538OthYEyCgamGXBefgIfjzqn8ICpRUNLXMMx 5eR6N/JOMzOwcTIwdkTsf6Ln9LnnHHO7h20HABgZXhf1Zu+citdDqi0DiOGKCiWESCxAHkETsWqa huvjPIr/AQ+yttSnPlaOo+4sjaBRQj0J6qG6YgaN4K9KlaX3LmV3PoGRyopU5G231JwhuJRbWUkS Kqi/6hqBEH9eA8Ai22oB2JF7/ZSpiKw2bxHs95Ze35N+xo3YJMfhK5PnBUh5f4KvLJPyuoBttdm9 7WoEQZfXTC4puycIf6T0qVfppJrINSBk1iPIsqu33JeZ7Gc5Gur0opqSstA8+QYablk4HrubHfXi iHtNJT88o+NIYh0/OG83JBlqkt4M1sMXjPxz4A7HolhsMdSEzgI+QHGbNpsVCAoyb1ne3lcOwKXH 9cZCB+yWcN1LedEGw29ah5dBUngfZhRMSyUQp3eBeZvWACcbJg/zN9AGkDI8LfCuGKPx5xvAT9Rb Kodb7GQBRejaWnpp04XvCThXco6IoXiHFcC5lq509ozavJ+p878Nd2dXfIPfEQAAAABJRU5ErkJg gg== X-Now-Playing: Joni Mitchell's _Miles of Aisles_: "Jericho" X-Hashcash: 1:23:110715:monnier@iro.umontreal.ca::ZW1Ng3Whdw9BXuLP:00000000000000000000000000000000000003KPq X-Hashcash: 1:23:110715:7834@debbugs.gnu.org::qgDs+z7cihcGJ4Ah:00000000000000000000000000000000000000000Z9z5 X-Hashcash: 1:23:110715:drew.adams@oracle.com::LJM7+zNrLp5FzCyV:0000000000000000000000000000000000000000btgk MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qhjju-0003w4-Cc X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311346298.49733@mKU0W1tpv+QuvdxuM87lmQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7834 Cc: 7834@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: > This function creates a new object, and that's a good idea to return it. > The cases to which I'm opposed is when the function returns something > which the caller knows even before calling the function. Okidoke. I'll mark this bug as "pending", since changing the return value of `put-image' is a new feature (and may possibly break something that relied on the un-announced old value). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 17:01:25 2011 Received: (at 7834) by debbugs.gnu.org; 15 Jul 2011 21:01:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhpVl-0001Ag-0J for submit@debbugs.gnu.org; Fri, 15 Jul 2011 17:01:25 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhpVi-0001AQ-Pq for 7834@debbugs.gnu.org; Fri, 15 Jul 2011 17:01:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAPOpIE5MCqt8/2dsb2JhbABUp254iHrCXIY6BJ8lhDA X-IronPort-AV: E=Sophos;i="4.67,210,1309752000"; d="scan'208";a="126050881" Received: from 76-10-171-124.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.124]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Jul 2011 17:01:16 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 9071A67459; Fri, 15 Jul 2011 17:01:15 -0400 (EDT) From: Stefan Monnier To: Lars Magne Ingebrigtsen Subject: Re: 24.0.50; doc of `put-image' Message-ID: References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> Date: Fri, 15 Jul 2011 17:01:15 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Fri, 15 Jul 2011 16:51:09 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7834 Cc: 7834@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > I'll mark this bug as "pending", since changing the return value of > `put-image' is a new feature (and may possibly break something that > relied on the un-announced old value). OK. You can also install the change in the `pending' branch and close the bug as "fixed in 24.2". Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 17 13:50:08 2011 Received: (at 7834) by debbugs.gnu.org; 17 Jul 2011 17:50:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiVTj-0000qp-Ol for submit@debbugs.gnu.org; Sun, 17 Jul 2011 13:50:08 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiVTg-0000qJ-U6 for 7834@debbugs.gnu.org; Sun, 17 Jul 2011 13:50:06 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QiVTV-0002JE-Dy; Sun, 17 Jul 2011 19:49:53 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: 24.0.50; doc of `put-image' In-Reply-To: (Stefan Monnier's message of "Fri, 15 Jul 2011 17:01:15 -0400") Date: Sun, 17 Jul 2011 19:49:46 +0200 Message-ID: References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEX8/PwFAQU5ODj+/vz8 /PrKzbv9/fdqbmoNCQv////9/f37+/v4+PT+/v36+vn4mhQZAAACV0lEQVQ4jXXUMWvbQBQH8Bs8 SSRwQ6hXHwRp8FYyZChkyNTSQG3UxKBOgcytwJxNsshg7CGrB0EcPHSJi8MNmXpUQ0sNphkKnRRi 6NClqL3P0PfuTraTNH8jn3y/ezr7dBZJdIbJ/RDTZP+Bm/Fk/iAZwPtdMta5Mc0EDudCw9j2GJmj IHwnzggHOeOVIIycERk7ZPQQBIG4JCXEGQt8K8ANbEIywjF45QnAh3yf84Bz3gykVKlSuRREQ8oY 6zOf8SjCs06n65gKBR87jG0ebdUY8/sRqxpYt/D66RZU+B5jXbEExpqHP2Au7kV+3HWJBRjpfUnO OKZPy1VhweMRO4H1Pb/9GvC47B0Ld80C92Z2tW+Z1zwmBCFFODE3ZLidMN6sfiOLirruH0SbM8ai ariEN3CR38kBLb/1+373Luw3kneUnrZoeRXqWRI1oIJ2K5RuhHIBQQPhc0xPK1iRf0T4s4BaTHsA vTD/ZCoYQ2gnBzHFdENhAAYFdYRIA1TIAihAq514BYhVqLUHfWohX0A4zc5mA2rSC9WyYroNK2Lm pk/sD0wLSCoFOGtFRfP6EORVAfbW+gjTo2fntbioMFDp02YYBBwWtpijgBi2DcRradgIBc5xqa7v J7fLbpOnSiol0zyXCBfrsF+lkFIfcOri7jegJO5jl0gFAgobHiBDkK4UgqzLAuwiSh1Xv+RPDViR YgEREv8z0MA55KXecKYEJoH+XEDjlP5qyM21BNkh5AV8p93Sjq6YZ8P5HEsEkVd7V3vqV0k9x0eG 3p36OXH3kfFIHoV/H34cMXlFw6QAAAAASUVORK5CYII= X-Now-Playing: Blaine L. Reininger's _Live In Brussels Bis_: "The birthday song" X-Hashcash: 1:23:110717:monnier@iro.umontreal.ca::aApzph8ZGIUx9mod:0000000000000000000000000000000000000NlqZ X-Hashcash: 1:23:110717:drew.adams@oracle.com::VCamaDgFCUtHoTic:0000000000000000000000000000000000000000QKK7 X-Hashcash: 1:23:110717:7834@debbugs.gnu.org::/MfHNhncw9jzlqIT:00000000000000000000000000000000000000000NpHO MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QiVTV-0002JE-Dy X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311529793.58097@uWQfAr/tTTLHUn71ay25yw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7834 Cc: 7834@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: >> I'll mark this bug as "pending", since changing the return value of >> `put-image' is a new feature (and may possibly break something that >> relied on the un-announced old value). > > OK. You can also install the change in the `pending' branch and close > the bug as "fixed in 24.2". For me it easier to just mark it as pending. Having a long-lived tree that will need to be merged back later can be a bit complicated, in my experience. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 09 22:36:43 2012 Received: (at 7834) by debbugs.gnu.org; 10 Apr 2012 02:36:44 +0000 Received: from localhost ([127.0.0.1]:47680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHQwk-0004Sn-1t for submit@debbugs.gnu.org; Mon, 09 Apr 2012 22:36:43 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:57777) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHQwh-0004Se-F0 for 7834@debbugs.gnu.org; Mon, 09 Apr 2012 22:36:40 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHQve-0002ng-IO; Tue, 10 Apr 2012 04:35:34 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#7834: 24.0.50; doc of `put-image' References: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> X-Now-Playing: Marc and the Mambas's _"Untitled"_: "Twilights + Lowlifes" Date: Tue, 10 Apr 2012 04:35:33 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 15 Jul 2011 10:42:54 -0400") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SHQve-0002ng-IO X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334630134.84834@iVgl2MuC/D/8xEX/bHe+Xw X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7834 Cc: Drew Adams , 7834@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: > This function creates a new object, and that's a good idea to return it. > The cases to which I'm opposed is when the function returns something > which the caller knows even before calling the function. I've now installed this change. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 09 22:36:44 2012 Received: (at control) by debbugs.gnu.org; 10 Apr 2012 02:36:45 +0000 Received: from localhost ([127.0.0.1]:47683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHQwm-0004Sv-0c for submit@debbugs.gnu.org; Mon, 09 Apr 2012 22:36:44 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:57782) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHQwj-0004Sm-U7 for control@debbugs.gnu.org; Mon, 09 Apr 2012 22:36:42 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHQvh-0002np-Iq for control@debbugs.gnu.org; Tue, 10 Apr 2012 04:35:37 +0200 Date: Tue, 10 Apr 2012 04:35:37 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #7834 X-MailScanner-ID: 1SHQvh-0002np-Iq X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334630137.70605@7wKdmK00vkuSKDUn11w8ZA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 7834 fixed close 7834 24.2 From unknown Thu Aug 14 20:53:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 May 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator