GNU bug report logs - #78324
31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available

Previous Next

Full log

View this message in rfc822 format

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: 78324 <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: bug#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available
Date: Thu, 08 May 2025 22:07:58 -0600

After 852d50e commit, the help-echo in eglot code action indicator
doesn't show the "(and %s more actions)".

I've also noticed that blurb was left unused.

#+begin_src diff
                                'face 'eglot-code-action-indicator-face
-                               'help-echo blurb
+                               'help-echo "mouse-1: execute code actions at point"
                                'mouse-face 'highlight
                                'keymap eglot-diagnostics-map))
              (save-excursion
#+end_src

Can be possible add also the actions available counter to help-echo?
As shown in this patch:

#+begin_src diff
@@ -4145,12 +4151,13 @@ eglot-code-action-suggestion
                     (eglot--format "\\[eglot-code-actions]: %s"
                                    (plist-get (aref actions 0) :title))))
              (if (>= (length actions) 2)
-                 (setq blurb (concat blurb (format "(and %s more actions)"
-                                                   (1- (length actions))))))
+                 (setq blurb (format "(%s more actions available)"
+                                     (1- (length actions)))))
              (setq tooltip
                    (propertize eglot-code-action-indicator
                                'face 'eglot-code-action-indicator-face
-                               'help-echo "mouse-1: execute code actions at point"
+                               'help-echo (concat "mouse-1: execute code actions at point"
+                                                  "\n" blurb)
                                'mouse-face 'highlight
                                'keymap eglot-diagnostics-map))
              (save-excursion
#+end_src

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.