From unknown Mon Jun 16 23:53:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78324 <78324@debbugs.gnu.org> To: bug#78324 <78324@debbugs.gnu.org> Subject: Status: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available Reply-To: bug#78324 <78324@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:53:02 +0000 retitle 78324 31.0.50; [Eglot] help-echo in code action indator doesn't ind= icate if there are more code actions available reassign 78324 emacs submitter 78324 Elijah Gabe P=C3=A9rez severity 78324 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 09 00:08:18 2025 Received: (at submit) by debbugs.gnu.org; 9 May 2025 04:08:19 +0000 Received: from localhost ([127.0.0.1]:34148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDF22-0004HG-IV for submit@debbugs.gnu.org; Fri, 09 May 2025 00:08:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35876) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDF20-0004H3-E2 for submit@debbugs.gnu.org; Fri, 09 May 2025 00:08:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDF1s-0005PP-9n for bug-gnu-emacs@gnu.org; Fri, 09 May 2025 00:08:09 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uDF1m-0006uW-3k for bug-gnu-emacs@gnu.org; Fri, 09 May 2025 00:08:03 -0400 Received: by mail-ot1-x341.google.com with SMTP id 46e09a7af769-72c13802133so576121a34.3 for ; Thu, 08 May 2025 21:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746763680; x=1747368480; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=YqEXTHLYqoiCHQsw0PwH2XC7L6vDnWHQlZV0po3f1TU=; b=MvIAKDMHgUivLviyyTey+UZybfWsKfXH182b86SjnkV+S30rIxTviwtlq5k/4kDxBx UQFRmHpYxmRM9WBydYXtEAwtxopVzVmM8LpnBkNQX+43AJAnL84nAyDhpGQVEFfKdM4t CCpsf6HQLZwSfhyYX3pzzEA5WaH6KOjKL8R/aHdV9Lpdz3m9ar0wwx9IjxFKK76U6uDP oMeMabfSD6EjplNHlOmArkD3uhAQHJsoykIa34gvfz8ORnqX4eIEE3NiPKe7B/YSXOs2 wQ0cLvxmvIlD7SuDCRzVDCz8UDKp/DlzHzErNP6Y318fmDDKA6L180bmo887nD2c4geO YNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746763680; x=1747368480; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YqEXTHLYqoiCHQsw0PwH2XC7L6vDnWHQlZV0po3f1TU=; b=l2qwQyv3MvoivmhKFSSb1rNF1DToCIL2E6u00iGTCbetcHaC5qiIg9SRZHU8+j2pvQ 5c73raB8lQLxr86KrWRyqiFUhKPPZGv89SW2/jSOtZeUB8jG1M5q6JaGjguGeTcJIwzW jz0fWTb+tql/tpfeVO5TEKDKg0T4W9lbhzIEsrS7FAV3iXLz/Z2hifHL9faC7oCcSCLP h+hooBnxhQ5Dt7Vy2nyQbJ9VtvYl68uZiDMa5vnKop0cuMhX9VBqQ+0POEgb+AWcWBqz cx5GgMdRtKEHuY+ZeGjuUXJQSayCUCVx54zrANcpbH2/axiOjGBXZH5SHPwENUFEsrqK 5QTw== X-Gm-Message-State: AOJu0Yz7YG0HuT7lRFW27VSBbnwx87FmXvti65Up8EJ8nQGPoRR2n3z3 ex0/G8FlELpLgc0kmK8az1ntU57fC4t1Hz87I7PBQONe/XClbwdz++5fprzo X-Gm-Gg: ASbGncuD7n4Vce7qDgaJeLOdWrMDpAAuxd+6Sd3SPi23KKLSpYVlmbj1vAWLuVgCOLf YEjj+KqjlTCvoRoA2+8VsWOcOuVo61MITeEXsUnfgYZgMcxQ/TVZLDeNfkJD/ZCBygHUVjAM845 7g6WLWCgHFrNDLblpsFMPmK7JkjcGpJChuFawKAzm86TnKg7PeOmSgmvPKDjSS1EuyG1nHTuv+v 91JEjgCKR4+evX3hOeP7ypA1v2wpYC63bB46RexSeg6VTz7RxZ2qSAVlU45cWMaJtE2Qb4SJx7s MOKaChnmHL0Vn6+bQQ== X-Google-Smtp-Source: AGHT+IEUCrBBLIAOHWDhw8bNqkzszQCKhRmN87w3MNyy7ILPLs8u+xwUa5x1yWykh8/rylHpuYUNbg== X-Received: by 2002:a05:6830:4127:b0:72b:9316:d593 with SMTP id 46e09a7af769-732269cc9c1mr1331920a34.7.1746763680288; Thu, 08 May 2025 21:08:00 -0700 (PDT) Received: from fedora ([2806:10ae:e:d3c::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-732264b381asm402995a34.23.2025.05.08.21.07.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 21:08:00 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: bug-gnu-emacs@gnu.org Subject: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 08 May 2025 22:07:58 -0600 Message-ID: <874ixuxw81.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::341; envelope-from=eg642616@gmail.com; helo=mail-ot1-x341.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: After 852d50e commit, the help-echo in eglot code action indicator doesn't show the "(and %s more actions)". I've also noticed that blurb was left unused. #+begin_src diff 'face 'eglot-code-action-indicator-face - 'help-echo blurb + 'help-echo "mouse-1: execute code actions at point" 'mouse-face 'highlight 'keymap eglot-diagnostics-map)) (save-excursion [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eg642616[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (eg642616[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) After 852d50e commit, the help-echo in eglot code action indicator doesn't show the "(and %s more actions)". I've also noticed that blurb was left unused. #+begin_src diff 'face 'eglot-code-action-indicator-face - 'help-echo blurb + 'help-echo "mouse-1: execute code actions at point" 'mouse-face 'highlight 'keymap eglot-diagnostics-map)) (save-excursion #+end_src Can be possible add also the actions available counter to help-echo? As shown in this patch: #+begin_src diff @@ -4145,12 +4151,13 @@ eglot-code-action-suggestion (eglot--format "\\[eglot-code-actions]: %s" (plist-get (aref actions 0) :title)))) (if (>= (length actions) 2) - (setq blurb (concat blurb (format "(and %s more actions)" - (1- (length actions)))))) + (setq blurb (format "(%s more actions available)" + (1- (length actions))))) (setq tooltip (propertize eglot-code-action-indicator 'face 'eglot-code-action-indicator-face - 'help-echo "mouse-1: execute code actions at point" + 'help-echo (concat "mouse-1: execute code actions at point" + "\n" blurb) 'mouse-face 'highlight 'keymap eglot-diagnostics-map)) (save-excursion #+end_src -- - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Fri May 09 04:45:28 2025 Received: (at 78324) by debbugs.gnu.org; 9 May 2025 08:45:28 +0000 Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDJMG-00060x-8Y for submit@debbugs.gnu.org; Fri, 09 May 2025 04:45:28 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:54645) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uDJMD-00060g-TA for 78324@debbugs.gnu.org; Fri, 09 May 2025 04:45:26 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43d07ca6a80so8668045e9.1 for <78324@debbugs.gnu.org>; Fri, 09 May 2025 01:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746780319; x=1747385119; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KtdFr4vXe9U/WyiSNvUBl9YVxncGq0YLiV4lmd0iBlI=; b=mPugBFCyu8sSl8FFy8RNUzQAbVEDfT+WtQHr8qmYsS7O312UFW1MWorzKvRhcKPg5n lHMF10kQO+2r8jqWfzcsGLtMPijqUji7hv9KuyJWbkmWgP4yZIhvuB8jZs7JJ9y5JVcn ZtW1lxJKuw32lWeiZ+bcECpOyPfPemsYx4KZAv1vgK49e2CkIvjSX/RqR6NsA8zLyO8T udN2gkyIgltQQ2AFfvU9E5/g8Z+3sWdwa3XGba0DnIwDvWjC3Z3CaF+3usTIJr2NUxsi 6ukFTOZ/hrpzHC7Xe8hAZIYA/Et62Rbd977BSQ2L0O4xJgjOhSXnlA3Hg1KK2L1zzAnp VNbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746780319; x=1747385119; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KtdFr4vXe9U/WyiSNvUBl9YVxncGq0YLiV4lmd0iBlI=; b=lp7o9Zt17Qab4oUUUdHRuiz/KAjtNueK4LAwlHHbL0wLejPRKw8X16p/9sqSnYhxU7 HFlPIQnm6xdMJAiBm7PhKIzI+rgStJpY7Gz/1ewhWd1NwF02s4sa6mU3c3D6LEp8doZm ubmkNtO7L7De2ZOe3ggg6qNTQrREx7mI6VaJhKBKMu6zf7hcSey4yvmXhqb4m2+AVI+U df6q5w4phA3xipUpkSUsDqw2e3z9/D58jfjV9/qAYtBUI5IqjZ8S/3UNlcG+0G2/gP9Z 2GSIhl0IhPg2jr+Cd7qfVzI1JcsM7NubDQ8RVkqnXypuIvezRLA51I1h5ZOlzaJwOuBr dfNQ== X-Gm-Message-State: AOJu0Yww7SU8no0ZNYZgfeS9757Exfee8JGIcT10/5Hs/0GrYFn/vLyw ty8Fq67C6sFxbqbJqpmbBz3YVWnOAvGSBskz2msehhvJVdaR9b3LbotSTg== X-Gm-Gg: ASbGncs8aC/222BK5MW4g3mVvVzAwNz9UfPAKDRuyw+sUiJIyt9x3CUdSnY6ylAVABl 8iNIGxIeUSMGCh6zfQF7+Ny3KmuhUC4YDYPCGsmQI8fq0p8Swzy0GhHupzD4TRGgiWOvQUfI2Az U4qvueiT43kuMVVlGATelV2boNeCbwHRqBtanQyLQI/zseTloYV3e8aJYQXsypni2Nh5vHaTPdI 6XMfFP9anB0iSWza6vq4paFom6DxXAKZYSmETSD93MFmpKYrhKFtqWud8ELvCzcE8hi/S2Wj0XN ZQZMsDmqozeRCU4FurGBJM5zh2IQkJFUYwYe5Ztgi6e8veTxHOgRndw= X-Google-Smtp-Source: AGHT+IFrUZUWWjrEt2Ztp5d9j3Rpc4thhVf7J8OjoT56UllAYw7vTQ557EDYG1N4Muh983actRx57Q== X-Received: by 2002:a05:600c:4694:b0:440:94a2:95b8 with SMTP id 5b1f17b1804b1-442d6d6b65fmr17932105e9.16.1746780318927; Fri, 09 May 2025 01:45:18 -0700 (PDT) Received: from krug (87-196-80-78.net.novis.pt. [87.196.80.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d67d5c2asm22155025e9.1.2025.05.09.01.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 01:45:18 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available In-Reply-To: <874ixuxw81.fsf@gmail.com> References: <874ixuxw81.fsf@gmail.com> Date: Fri, 09 May 2025 09:45:59 +0100 Message-ID: <878qn6b29k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Elijah Gabe Pérez writes: > After 852d50e commit, the help-echo in eglot code action indicator > doesn't show the "(and %s more actions)". That's right. And that's by design (didn't you test and greelight the patch of bug#78106)? > > I've also noticed that blurb was left unused. Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [87.196.80.78 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:32f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) X-Debbugs-Envelope-To: 78324 Cc: 78324@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Elijah Gabe Pérez writes: > After 852d50e commit, the help-echo in eglot code action indicator > doesn't show the "(and %s more actions)". That's right. And that's by design (didn't you test and greelight the patch of bug#78106)? > > I've also noticed that blurb was left unused. Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:32f listed in] [list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [87.196.80.78 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (joaotavora[at]gmail.com) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Elijah Gabe P=C3=A9rez writes: > After 852d50e commit, the help-echo in eglot code action indicator > doesn't show the "(and %s more actions)". That's right. And that's by design (didn't you test and greelight the patch of bug#78106)? > > I've also noticed that blurb was left unused. Look again. It's used for ElDoc, there's a (funcall cb blurb) further down. > Can be possible add also the actions available counter to help-echo? > As shown in this patch: > > #+begin_src diff > @@ -4145,12 +4151,13 @@ eglot-code-action-suggestion > (eglot--format "\\[eglot-code-actions]: %s" > (plist-get (aref actions 0) :title)))) > (if (>=3D (length actions) 2) > - (setq blurb (concat blurb (format "(and %s more actions= )" > - (1- (length actions))= )))) > + (setq blurb (format "(%s more actions available)" > + (1- (length actions))))) > (setq tooltip > (propertize eglot-code-action-indicator > 'face 'eglot-code-action-indicator-face > - 'help-echo "mouse-1: execute code actions= at point" > + 'help-echo (concat "mouse-1: execute code= actions at point" > + "\n" blurb) This would break the current uses ElDoc . And if I follow your intention, it would still be wrong, as if 3 actions were present it would say sth like: mouse-1: execute code actions at point (2 more actions available) which doesn't make sense. In my opinion, there is nothing to do here. The richer blurb is only meant for the ElDoc outlet, because that points to a specific non-mouse binding which will immediately execute the singleton action at point or offer a menu of all actions. The mouse bindings always offer the menu. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri May 09 10:55:37 2025 Received: (at 78324-done) by debbugs.gnu.org; 9 May 2025 14:55:37 +0000 Received: from localhost ([127.0.0.1]:38411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDP8P-0000RD-IX for submit@debbugs.gnu.org; Fri, 09 May 2025 10:55:37 -0400 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:59595) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uDP8B-0000MT-O1 for 78324-done@debbugs.gnu.org; Fri, 09 May 2025 10:55:29 -0400 Received: by mail-qk1-x744.google.com with SMTP id af79cd13be357-7cad57f88eeso143514885a.2 for <78324-done@debbugs.gnu.org>; Fri, 09 May 2025 07:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746802514; x=1747407314; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W9kYUEwFiSBHc67VtQc0Bt0tmFlh8osQYYMXpy49MbE=; b=Jxyel6Ymvo/nj8kt4bj3J0Dhz2GF6ehYrMB0eSok6oNZytiL7dElxlpp5VUjcwMXVa 13uqLy0uuWNQJDhx0CzemQgJnH/uNaRxhfhmnn8PX04dPghN329vH9Xknvnqa/yNgVbx NbKF3gNUf0SXd/Y0OzOfJIZJERnGbwHYl+30BXPYiNhYcY08AJqfcbylNU//1oKGYyQ8 RCF/Gk9BclXQwJCi7znzDtYTxKC0UA8/mZdelDEKouQTPgBMvaPHqib0FQpElt4cQ7qx 0V3W6UXHGalapooN0gtjSCvyN/h4dklNNz7w92nn83JLqqnFKRYZA0I1dBGIGHIW0u2q jfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746802514; x=1747407314; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W9kYUEwFiSBHc67VtQc0Bt0tmFlh8osQYYMXpy49MbE=; b=fZbcKecDIVJcktL1taxyZuIefJmfEyXYdIpWkc7xEV2vNZklo6hyYakLtMqNIBigrI ElVskAqFMVHPagupoc3uTcwcwaKrMmX5cr+ZAfJXIISd5s1thSSzD1VNYF7k+oktzztI 6LtryOxQ+aw5dfGXApfQMR0GpGs2YFgSvq4A6wwevkpkbwykgXjAcvaaqNqe+iruUTdu c+81bVDKNCtcToy80Qfogxb+eBgWD+DWDMetIMVXEXZ+XT4ZMecPVt7xmgbtpUEoDSIc eCzDn84wOEGH3dmq0J0GUopthoYpkY70fN2p6L2V+TweoHt/Q3ZivsIJ5Jdc5o1jYQJ6 tFYQ== X-Gm-Message-State: AOJu0YwK4HmYQXeNTZVyVq6qfmoDb4VYv/DuqX8GE686Y2tH8dgkx1aQ Gz1oH+wO2Q4WeSUH5Gryz1ZTgrs/M6WvrB5PKItnboBE7yJ2Lw5GSTSIyPsY+u4IlS7B4twcZqQ Q1DqWT6zXp5Gq/AVuL5pUFwfYZdc= X-Gm-Gg: ASbGncv9K4Cj3S0aHOkw8+OxRDHU3nF3lLDFA8nWoxHZnJ+UiiBm8WQX66c5dsh++Od VGKfS8506G81UP4JeSqnMCCGhCv7ORbWGM0VEbXAiiAjrIR9MGry3U+9PMV3yrtoHseNY20dDQG gA1NPEWoBewSTHF+fXd1RF X-Google-Smtp-Source: AGHT+IEp+W8OL/j90+fCo0+V+lItcGINjnqM4ouYiSO84HA+0uvavCXowznrajAXCQhWB0eS/M15lWVvkXfbgj37fRg= X-Received: by 2002:a05:620a:248e:b0:7ca:cd16:8f52 with SMTP id af79cd13be357-7cd010d0fbemr535869085a.12.1746802513728; Fri, 09 May 2025 07:55:13 -0700 (PDT) MIME-Version: 1.0 References: <874ixuxw81.fsf@gmail.com> <878qn6b29k.fsf@gmail.com> In-Reply-To: <878qn6b29k.fsf@gmail.com> From: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Date: Fri, 9 May 2025 08:54:59 -0600 X-Gm-Features: AX0GCFvwuSrhPLBxqolNI6loMk5flkppPVrZvKkq0pUDO4wrNX5n_2CfHFvhyPY Message-ID: Subject: Re: bug#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: multipart/alternative; boundary="0000000000005302530634b5274b" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78324-done Cc: 78324-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000005302530634b5274b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora escribi=C3=B3: > Elijah Gabe P=C3=A9rez writes: > > > After 852d50e commit, the help-echo in eglot code action indicator > > doesn't show the "(and %s more actions)". > > That's right. And that's by design (didn't you test and greelight the > patch of bug#78106)? > Oops, right, i forgot that it's used in eldoc. > Can be possible add also the actions available counter to help-echo? > > As shown in this patch: > > > > #+begin_src diff > > @@ -4145,12 +4151,13 @@ eglot-code-action-suggestion > > (eglot--format "\\[eglot-code-actions]: %s" > > (plist-get (aref actions 0) > :title)))) > > (if (>=3D (length actions) 2) > > - (setq blurb (concat blurb (format "(and %s more > actions)" > > - (1- (length > actions)))))) > > + (setq blurb (format "(%s more actions available)" > > + (1- (length actions))))) > > (setq tooltip > > (propertize eglot-code-action-indicator > > 'face 'eglot-code-action-indicator-face > > - 'help-echo "mouse-1: execute code > actions at point" > > + 'help-echo (concat "mouse-1: execute > code actions at point" > > + "\n" blurb) > > This would break the current uses ElDoc . And if I follow your > intention, it would still be wrong, as if 3 actions were present it > would say sth like: > > mouse-1: execute code actions at point > (2 more actions available) > > which doesn't make sense. > > In my opinion, there is nothing to do here. The richer blurb is only > meant for the ElDoc outlet, because that points to a specific non-mouse > binding which will immediately execute the singleton action at point or > offer a menu of all actions. The mouse bindings always offer the menu. > Fine, then I'm closing this. > --0000000000005302530634b5274b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> escribi=C3=B3:
Elijah Gabe P=C3=A9rez <eg642616@gmail.com> writes:=

> After 852d50e commit, the help-echo in eglot code action indicator
> doesn't show the "(and %s more actions)".

That's right.=C2=A0 And that's by design (didn't you test and g= reelight the
patch of bug#78106)?

Oops, right, i forgot that it's used in eldoc.

<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex"> > Can be possible add also the actions available counter to help-echo? > As shown in this patch:
>
> #+begin_src diff
> @@ -4145,12 +4151,13 @@ eglot-code-action-suggestion
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (eglot--format "\\[eglot-code-actions]: %s"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(plist-get (a= ref actions 0) :title))))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (>=3D (le= ngth actions) 2)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq b= lurb (concat blurb (format "(and %s more actions)"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(1- (length actions))))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq b= lurb (format "(%s more actions available)"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(1- (length = actions)))))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq tooltip >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(propertize eglot-code-action-indicator
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'face 'eglot-code-a= ction-indicator-face
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'help-echo "mouse-1: exe= cute code actions at point"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'help-echo (concat "mous= e-1: execute code actions at point"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "\n" blurb)

This would break the current uses ElDoc . And if I follow your
intention, it would still be wrong, as if 3 actions were present it
would say sth like:

=C2=A0 mouse-1: execute code actions at point
=C2=A0 (2 more actions available)

which doesn't make sense.

In my opinion, there is nothing to do here.=C2=A0 The richer blurb is only<= br> meant for the ElDoc outlet, because that points to a specific non-mouse
binding which will immediately execute the singleton action at point or
offer a menu of all actions.=C2=A0 The mouse bindings always offer the menu= .

Fine, then I'm closing this.
--0000000000005302530634b5274b-- From unknown Mon Jun 16 23:53:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Jun 2025 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator