Subject: bug#78324: closed (Re: bug#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 09 May 2025 14:56:02 +0000

Your bug report

#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78324: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78324
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#78324: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available
From: Elijah Gabe Pérez <[email-masked]>
To: João Távora <[email-masked]>
Cc: [email-masked]
Date: Fri, 9 May 2025 08:54:59 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

João Távora <[email-masked]> escribió:

> Elijah Gabe Pérez <[email-masked]> writes:
>
> > After 852d50e commit, the help-echo in eglot code action indicator
> > doesn't show the "(and %s more actions)".
>
> That's right.  And that's by design (didn't you test and greelight the
> patch of bug#78106)?
>

Oops, right, i forgot that it's used in eldoc.

> Can be possible add also the actions available counter to help-echo?
> > As shown in this patch:
> >
> > #+begin_src diff
> > @@ -4145,12 +4151,13 @@ eglot-code-action-suggestion
> >                      (eglot--format "\\[eglot-code-actions]: %s"
> >                                     (plist-get (aref actions 0)
> :title))))
> >               (if (>= (length actions) 2)
> > -                 (setq blurb (concat blurb (format "(and %s more
> actions)"
> > -                                                   (1- (length
> actions))))))
> > +                 (setq blurb (format "(%s more actions available)"
> > +                                     (1- (length actions)))))
> >               (setq tooltip
> >                     (propertize eglot-code-action-indicator
> >                                 'face 'eglot-code-action-indicator-face
> > -                               'help-echo "mouse-1: execute code
> actions at point"
> > +                               'help-echo (concat "mouse-1: execute
> code actions at point"
> > +                                                  "\n" blurb)
>
> This would break the current uses ElDoc . And if I follow your
> intention, it would still be wrong, as if 3 actions were present it
> would say sth like:
>
>   mouse-1: execute code actions at point
>   (2 more actions available)
>
> which doesn't make sense.
>
> In my opinion, there is nothing to do here.  The richer blurb is only
> meant for the ElDoc outlet, because that points to a specific non-mouse
> binding which will immediately execute the singleton action at point or
> offer a menu of all actions.  The mouse bindings always offer the menu.
>

Fine, then I'm closing this.

Subject: 31.0.50; [Eglot] help-echo in code action indator doesn't indicate if there are more code actions available
From: Elijah Gabe Pérez <[email-masked]>
To: [email-masked]
Date: Thu, 08 May 2025 22:07:58 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

After 852d50e commit, the help-echo in eglot code action indicator
doesn't show the "(and %s more actions)".

I've also noticed that blurb was left unused.

#+begin_src diff
                                'face 'eglot-code-action-indicator-face
-                               'help-echo blurb
+                               'help-echo "mouse-1: execute code actions at point"
                                'mouse-face 'highlight
                                'keymap eglot-diagnostics-map))
              (save-excursion
#+end_src

Can be possible add also the actions available counter to help-echo?
As shown in this patch:

#+begin_src diff
@@ -4145,12 +4151,13 @@ eglot-code-action-suggestion
                     (eglot--format "\\[eglot-code-actions]: %s"
                                    (plist-get (aref actions 0) :title))))
              (if (>= (length actions) 2)
-                 (setq blurb (concat blurb (format "(and %s more actions)"
-                                                   (1- (length actions))))))
+                 (setq blurb (format "(%s more actions available)"
+                                     (1- (length actions)))))
              (setq tooltip
                    (propertize eglot-code-action-indicator
                                'face 'eglot-code-action-indicator-face
-                               'help-echo "mouse-1: execute code actions at point"
+                               'help-echo (concat "mouse-1: execute code actions at point"
+                                                  "\n" blurb)
                                'mouse-face 'highlight
                                'keymap eglot-diagnostics-map))
              (save-excursion
#+end_src

-- 
                                          - E.G via GNU Emacs and Org.