From debbugs-submit-bounces@debbugs.gnu.org Thu May 08 18:40:35 2025 Received: (at submit) by debbugs.gnu.org; 8 May 2025 22:40:35 +0000 Received: from localhost ([127.0.0.1]:33223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uD9ut-0000Lr-0S for submit@debbugs.gnu.org; Thu, 08 May 2025 18:40:35 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uD9up-0000LJ-4m for submit@debbugs.gnu.org; Thu, 08 May 2025 18:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uD9ui-0000Db-8Y for bug-gnu-emacs@gnu.org; Thu, 08 May 2025 18:40:24 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uD9uf-0005NQ-OQ for bug-gnu-emacs@gnu.org; Thu, 08 May 2025 18:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=F89W+YyWnFZGGRXBhRHOHsWCCPDtMMXzEcFZbb+PFK0=; b=n8YiGIlqBbRQQAm3BVBzfFzn69 9h83Fcs3hOUBwEbdA0FGsOEbL3SGXZwmAf7F0D898f3k9TH/0VNJ+2aLQ6TBQoOjvGFLnR+r82NeF JhvQvUS/1Kr2Xxeh1VYmlioXglzhvhfG2NakbwSTO0IFSa+bL0pNWjyQ84W3cOR0eyAbbdvQ/H0dV WZ8bGgFtE3MSPpSHT/dFyzL/Vq9WhnMKrvCaQQ+JBzUoJtN+PmMGcd9acBbcICwlnd1g1dQdOt2OB difQla4hqvCqLajD6ho+J69B9CM//2C+TCMrtQZ7m9bQsb8MZBKwVte2FL3N1Fq7qwD8puGR6wzr6 tfacLrKw==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1uD9th-00958O-2C for bug-gnu-emacs@gnu.org; Thu, 08 May 2025 18:39:21 -0400 From: Daniel Colascione To: bug-gnu-emacs@gnu.org Subject: Regression in case-insensitive filename completion User-Agent: mu4e 1.12.10; emacs 31.0.50 Date: Thu, 08 May 2025 15:40:16 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) With read-file-name-completion-ignore-case true, commit 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion behavior. Suppose we have file named fooBarQux. Previously, if I'd typed "foobar" and TAB while reading a filename, then the completion would be "fooBarQux". Now, it completes as "foobarQux", which is wrong and breaks, among other things, vc. From debbugs-submit-bounces@debbugs.gnu.org Fri May 09 02:28:28 2025 Received: (at 78323) by debbugs.gnu.org; 9 May 2025 06:28:28 +0000 Received: from localhost ([127.0.0.1]:34715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDHDg-0003y9-5o for submit@debbugs.gnu.org; Fri, 09 May 2025 02:28:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57316) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDHDd-0003xi-9F for 78323@debbugs.gnu.org; Fri, 09 May 2025 02:28:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDHDW-0005pk-PK; Fri, 09 May 2025 02:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3GfE2X3dbXboMzgaBDCl5Y9qUF24+2q5AR+QneKgz+o=; b=ECHQ4AnNcMJs XzvrRmtfaQmeQPk6KOrfohiyM2IfLg55n5astP6nUIJEpL/x//FZt6pT9UHP9cQIJVeBfMRymqXo6 0PiAoq7r0cy7wRyfpR+ms+ex3ZnAm8UtOuHVUzIreYDN7jiAzhBkh0Ao6h022T6ta84kjtvKWCgvQ Ukl8pYxN950/VPTv730NbzWhm74ObmiDPpGM0W1J6FswGILOUucnPQDcBRCxAs+Q98otd45CYx6j+ Bp5Fl2t1P2KkGYUBiFHXYhR1BoMu3dcsHcZTAxZRKvu9/OsaqvVX+yvWOD1+HwcTVIDY9BBFAvpXo lWurGreyrnmH3McSGnAOpA==; Date: Fri, 09 May 2025 09:28:14 +0300 Message-Id: <86plgicn7l.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione , Spencer Baugh , Stefan Monnier In-Reply-To: (message from Daniel Colascione on Thu, 08 May 2025 15:40:16 -0700) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Colascione > Date: Thu, 08 May 2025 15:40:16 -0700 > > With read-file-name-completion-ignore-case true, commit > 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion > behavior. Suppose we have file named fooBarQux. Previously, if I'd > typed "foobar" and TAB while reading a filename, then the completion > would be "fooBarQux". Now, it completes as "foobarQux", which is wrong > and breaks, among other things, vc. Spencer, could you please look into fixing this regression? From debbugs-submit-bounces@debbugs.gnu.org Fri May 09 02:40:24 2025 Received: (at control) by debbugs.gnu.org; 9 May 2025 06:40:24 +0000 Received: from localhost ([127.0.0.1]:34775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDHPE-0004h3-5p for submit@debbugs.gnu.org; Fri, 09 May 2025 02:40:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36704) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDHPA-0004eW-NF; Fri, 09 May 2025 02:40:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDHP4-0007aH-EL; Fri, 09 May 2025 02:40:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h90GGtRjTKDY+83jo3Mh+kPUyDYPbh2zMP1cnsg/yz8=; b=PLfHBtmBfNvN WRl0op/25M1/zfF6iRZq8vLlbhQLldiam+NlAPT+F+8o+HgizO1zkDcm7AfWNCSfIm9G1q6DCEQCs WrG5t/s6GyDVS5fVLd4+w0wny6Vzau5zuOTmdOr5ZCOGGLOlowYXboVH8UF4/XV/F17GoGlsN6Ve1 XMVTdUOcKdj6YrG8EDqotBuqgJsaEQtEd0NgPBcXmB6/aSHFQkSdiAzU38x4xptcoH8wSSpgB0fSh 0Kln8XPdHOmwYTX6ldNgzVA9PghimVoShwauHyH2xAWmYqx9E0OhUao0amPHkrfuv/R5jQtdiDfj4 IiVh6oRaz+INPSF2PAv6QA==; Date: Fri, 09 May 2025 09:40:11 +0300 Message-Id: <86ldr6cmno.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Thu, 8 May 2025 21:14:23 -0700) Subject: Re: bug#78325: 31.0.50; Regression in completion casing resulting from improving env var handling in read-file-name References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 78325@debbugs.gnu.org, sbaugh@janestreet.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 78325 78323 thanks > Cc: Spencer Baugh , > Stefan Monnier > From: Aaron Jensen > Date: Thu, 8 May 2025 21:14:23 -0700 > > (resending because there was an issue sending the first time, > apologies if this is received more than once) > > Run `emacs -Q` in the emacs source directory then: > > C-x C-f > in > > Expected completions: > > INSTALL > INSTALL.repo > info/ > > Actual completions: > > inSTALL > inSTALL.repo > info/ > > This worked prior to 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 (Improve > env var handling in read-file-name) > > It does not seem like an intended consequence. Thanks. This seems to be a duplicate of bug#78323, so I'm merging them. From debbugs-submit-bounces@debbugs.gnu.org Sat May 10 15:06:15 2025 Received: (at control) by debbugs.gnu.org; 10 May 2025 19:06:15 +0000 Received: from localhost ([127.0.0.1]:50627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDpWZ-0000sY-9d for submit@debbugs.gnu.org; Sat, 10 May 2025 15:06:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53906) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDpWO-0000qn-8m; Sat, 10 May 2025 15:06:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDpWI-0003d3-Pi; Sat, 10 May 2025 15:05:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9nEGFldfbq0FrQeOKko5pxEaeMTl8XYibI378nTXqho=; b=rqxa++tJDsm7 9Wqo0xdZXOMLPY53d5qDd7R2IdlYXJKYNttqHsKW2bN8+0XiRVfJlfNcXtuCeZ44wSLNt4XyR4CRr yjYIwK+PQM0bM+SGQGqQhZp5mpKSi7KU7BW2C4EZ+2W9DJczTaTijDS46zm3btGihQ7I34yG8NRjI gqpA4hzKYfFVklIeEtTZrm608jfU0ECrS7AcACs85yYCvp/P/pku2hoUXmH9YHaEY/YmWjBeHxfi5 S2vL5PlOjyH3sUbzzC0GUgALIvkb03hNwdkQTxkqGJbnvvt4PhpeOakFC9JeTt8g/v8I1KBKUMID9 1/YOmJ9WoGcls4F+OtBo3w==; Date: Sat, 10 May 2025 22:05:54 +0300 Message-Id: <86plgg8ewd.fsf@gnu.org> From: Eli Zaretskii To: Dieter Deyke In-Reply-To: (message from Dieter Deyke on Sat, 10 May 2025 19:55:43 +0200) Subject: Re: bug#78357: 31.0.50; read file name completion generates wrong file name References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 78357@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 78357 78323 thanks > From: Dieter Deyke > Date: Sat, 10 May 2025 19:55:43 +0200 > > I am on Debian with a case sensitve file system. I have a directory > named "~/media/SANSA CLIPP". After starting emacs -Q and setting the > option Read File Name Completion Ignore Case to t, > I type C-x d ~/media/sa then press the Tab key. Emacs completes the > file name to ~/media/saNSA CLIPP/ which does not exist. In previous > versions of emacs the "sa" would have been corrected to "SA". This is a duplicate of bug#78323, so I'm merging them. From debbugs-submit-bounces@debbugs.gnu.org Sun May 11 23:24:59 2025 Received: (at 78323) by debbugs.gnu.org; 12 May 2025 03:24:59 +0000 Received: from localhost ([127.0.0.1]:48803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEJml-00037Q-0c for submit@debbugs.gnu.org; Sun, 11 May 2025 23:24:59 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:58684) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEJmg-00037G-9U for 78323@debbugs.gnu.org; Sun, 11 May 2025 23:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=U84/AA8fxCmloNow9TK8qJT9wnD8Gfk9Sk4dpYatxmc=; b=NzVp92Q0XmVIt52A2FrSes5axZ beV3n+Qv5hj478nq2vHERwGxknGEGH8tplwXLcrKmCGL1h3KvQNrsGAKuo7DCeKYXYBV0Jze3l6c2 hXjMnj5cu2AY8bH3lwQgZl0rJdi5cSw7rGlDFsZ2aclFXhboY0ylwHaGzoQrlEHlQXL5aMUrgoXlv 8l8ua4m6YShX5326s84RN/kb+ARJWVT5dD/9pB9rdUklTqabUtY6RhqcUjVRglgfsGHfEaehVOd2W 1ZDWwxwZbKKXlMS1U62QFG1rEqT6B94eijxZWEw59cReg6DsyumnQTooTmV/bgOoUNCyZg3epr2Bc HJQI1jwQ==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1uEJld-009U6X-05; Sun, 11 May 2025 23:23:49 -0400 From: Daniel Colascione To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <86plgicn7l.fsf@gnu.org> References: <86plgicn7l.fsf@gnu.org> User-Agent: mu4e 1.12.10; emacs 31.0.50 Date: Sun, 11 May 2025 20:24:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 78323 Cc: Spencer Baugh , Stefan Monnier , 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Daniel Colascione >> Date: Thu, 08 May 2025 15:40:16 -0700 >> >> With read-file-name-completion-ignore-case true, commit >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> typed "foobar" and TAB while reading a filename, then the completion >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> and breaks, among other things, vc. > > Spencer, could you please look into fixing this regression? What do you think of reverting this change while Spencer finds the cause of the problem? From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 07:40:32 2025 Received: (at 78323) by debbugs.gnu.org; 12 May 2025 11:40:32 +0000 Received: from localhost ([127.0.0.1]:50854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uERWK-0007V0-2b for submit@debbugs.gnu.org; Mon, 12 May 2025 07:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uERWG-0007Uf-Lh for 78323@debbugs.gnu.org; Mon, 12 May 2025 07:40:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uERWA-00066t-A8; Mon, 12 May 2025 07:40:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HD2rblAxbp5J5cE6ph/rHCnHgllJGW26yLRcqas8pPA=; b=l4u2orD3xOVM aNRA3fxr5xZznVFkj1yTpdRafLt6bPrnbiXY8/QQnT3qBYZKNLA68+GSg9X3uTtPUWUktxw87wESN Rf9ic1mMphzB+ScVUoX4xuYZBQ7G/PCjeY4qF/tCtUDGWC+PEWHYBtCmMeW8OXW7vGArbWXgk2Ih/ injcJOeo6+tO+XPwYFx6DxQOCqmpGa4N5mclCgj4p6Bi3E1v49rHvIE8tbz5/iRw1Z5tikzuF3s+4 oftAKPLOzzOh+luxH2FvvP8MTHh4C7Pb1AMSOGItR59l+JB4Vz6Y2+5u8QTebGpdIylyp3+5zoxuc QRsgKVbJ6UVyexVFTveNEQ==; Date: Mon, 12 May 2025 14:40:18 +0300 Message-Id: <86sela6orh.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione , monnier@iro.umontreal.ca In-Reply-To: (message from Daniel Colascione on Sun, 11 May 2025 20:24:46 -0700) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: <86plgicn7l.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: sbaugh@janestreet.com, 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Colascione > Cc: Spencer Baugh , Stefan Monnier > , 78323@debbugs.gnu.org > Date: Sun, 11 May 2025 20:24:46 -0700 > > Eli Zaretskii writes: > > >> From: Daniel Colascione > >> Date: Thu, 08 May 2025 15:40:16 -0700 > >> > >> With read-file-name-completion-ignore-case true, commit > >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion > >> behavior. Suppose we have file named fooBarQux. Previously, if I'd > >> typed "foobar" and TAB while reading a filename, then the completion > >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong > >> and breaks, among other things, vc. > > > > Spencer, could you please look into fixing this regression? > > What do you think of reverting this change while Spencer finds the cause > of the problem? I wouldn't mind, but then I don't use these features. Let's hear Stefan's opinion first. Stefan? From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 10:42:58 2025 Received: (at 78323) by debbugs.gnu.org; 12 May 2025 14:42:58 +0000 Received: from localhost ([127.0.0.1]:53904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEUMr-0004O9-T0 for submit@debbugs.gnu.org; Mon, 12 May 2025 10:42:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61244) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEUMo-0004Nh-UU for 78323@debbugs.gnu.org; Mon, 12 May 2025 10:42:56 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 41678440F2A; Mon, 12 May 2025 10:42:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1747060968; bh=nsKxfydjRU8Q2IB3JYcv5KX6zVKHLL3zV9/l8dO/MXQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c4mkL1ars2ZUTTsFJeKcTmLd/YRlDWdjFzZY+tWCyscs7xkfpNf1F3+cBhkeHdmkG BE/8HqvDKovbOUSIA9taRTSK0Rus4HjIVOzTU9HYCSqD9cmevNoxf4IZcX4jmSTPp9 /CaqBWXBzATN/F9PgLW6pKPp3ineSGgJmz4d/QL4Z44tT2DRZewENKDX//U2SBLGqC RKn2Fvwsa3PrJc8rvZGHPR0cRiUxfF1zEoCkoTjVORrjOQ/z7OIn5/2+jufG6D4O9n Qpl4tpfAgCMULyoXCqsmwwJ2h+4ODbsY/nlt9NriNLkNAOB+Ru5LgwqhFyY7rPa/yr LcjWGR4ImEqNw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 12B9A440F0F; Mon, 12 May 2025 10:42:48 -0400 (EDT) Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D46D01203B5; Mon, 12 May 2025 10:42:47 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <86sela6orh.fsf@gnu.org> Message-ID: References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> Date: Mon, 12 May 2025 10:42:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: sbaugh@janestreet.com, Daniel Colascione , 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> >> With read-file-name-completion-ignore-case true, commit >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> >> typed "foobar" and TAB while reading a filename, then the completion >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> >> and breaks, among other things, vc. >> > Spencer, could you please look into fixing this regression? >> What do you think of reverting this change while Spencer finds the cause >> of the problem? > I wouldn't mind, but then I don't use these features. Let's hear > Stefan's opinion first. I'd first like to hear Spencer's opinion on how quickly he might be able to fix it or if it indeed breaks his assumptions too hard (so we'd need a different approach, in which case we may as well revert the change first). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 10:57:30 2025 Received: (at 78323) by debbugs.gnu.org; 12 May 2025 14:57:30 +0000 Received: from localhost ([127.0.0.1]:53996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEUav-0005Ha-Oo for submit@debbugs.gnu.org; Mon, 12 May 2025 10:57:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49508) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEUas-0005HK-Na for 78323@debbugs.gnu.org; Mon, 12 May 2025 10:57:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEUal-0002C2-Q3; Mon, 12 May 2025 10:57:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2ZHN7ZGWwe7i75pp/m5gu4MGV8+pj/hybJ+7y12210E=; b=CTYtXiOnkISo LvCiiF02W93gRCAFMME4lvME7deL4jeuMDcoJSEQuIDSermVg0idX+EKUSIPnUABamdKUFYvgD9Mf erRlh7P3thuGZ9KewE/Cq6CAuVU77o5hnkgGvHpam4pd/KXqJgJkZI4NYyR9NoQTNb29AzavdxgW2 jEz+kzGIOG9GWmT7sdfNncQ1v4qa9XRECmQu0JMUA9cULLzCjbUVE5Mg0K0SCZzguY9WOxjfRbWjv AjI80FjU9LikBbJeXAt3CMu3N3PCGGdonPMf5sBM/9T9g1Wa/tdyO61mtHhoFBqgwcQk5RJ8mRjUv 6rsuxwXjIKJa8TmHjup7Yw==; Date: Mon, 12 May 2025 17:57:16 +0300 Message-Id: <86cycd7u7n.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 12 May 2025 10:42:47 -0400) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: sbaugh@janestreet.com, dancol@dancol.org, 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Daniel Colascione , sbaugh@janestreet.com, > 78323@debbugs.gnu.org > Date: Mon, 12 May 2025 10:42:47 -0400 > > >> >> With read-file-name-completion-ignore-case true, commit > >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion > >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd > >> >> typed "foobar" and TAB while reading a filename, then the completion > >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong > >> >> and breaks, among other things, vc. > >> > Spencer, could you please look into fixing this regression? > >> What do you think of reverting this change while Spencer finds the cause > >> of the problem? > > I wouldn't mind, but then I don't use these features. Let's hear > > Stefan's opinion first. > > I'd first like to hear Spencer's opinion on how quickly he might be able to > fix it or if it indeed breaks his assumptions too hard (so we'd need > a different approach, in which case we may as well revert the change first). So, Spencer, the eyes of all the world are upon you. From debbugs-submit-bounces@debbugs.gnu.org Tue May 13 12:23:45 2025 Received: (at 78323) by debbugs.gnu.org; 13 May 2025 16:23:45 +0000 Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEsPx-0001MR-6e for submit@debbugs.gnu.org; Tue, 13 May 2025 12:23:45 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:33143) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uEsPt-0001MC-Od for 78323@debbugs.gnu.org; Tue, 13 May 2025 12:23:42 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <86cycd7u7n.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 May 2025 17:57:16 +0300") References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> Date: Tue, 13 May 2025 12:23:36 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1747153416; bh=+5rWeTZfhjKuPwQLySv0RHAxa56PvgmWeGk6w6aX69M=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=fzJggpLAMH3Wf2snM8r3mRKWQPbDRWPTYK1YndVoVvR2TQiwPko9aoINQAx0ElxC1 EvmY4e8sv5jiSkHDaYqL8GrG7rNdeZQrDUR0Jvzso4P9O/IfWBcdsnr4AqCeIej+Ul W0js2VzmbkhtAZ8xgz96oP7e9BJUgnTYFgeZbzr67DXyJkWNn6eAbtIB9HwkHGmF+f w0xv6WVSyjrPxvr67yhTx8wtvfA3o7zy9/CurTz0nXZEkV5gxSDBMq/0EVmlAMKsk7 n7McYb4wIvbKag3waSqu4oyTUV1nQWrt1H6B/jIE3o2GSKrDbPfuWcoNoZ7NwPlHkB 4rJonygCJHcRA== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: dancol@dancol.org, Stefan Monnier , 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: Daniel Colascione , sbaugh@janestreet.com, >> 78323@debbugs.gnu.org >> Date: Mon, 12 May 2025 10:42:47 -0400 >> >> >> >> With read-file-name-completion-ignore-case true, commit >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> >> >> typed "foobar" and TAB while reading a filename, then the completion >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> >> >> and breaks, among other things, vc. >> >> > Spencer, could you please look into fixing this regression? >> >> What do you think of reverting this change while Spencer finds the cause >> >> of the problem? >> > I wouldn't mind, but then I don't use these features. Let's hear >> > Stefan's opinion first. >> >> I'd first like to hear Spencer's opinion on how quickly he might be able to >> fix it or if it indeed breaks his assumptions too hard (so we'd need >> a different approach, in which case we may as well revert the change first). > > So, Spencer, the eyes of all the world are upon you. Sorry for the delay, I was away this weekend. Thanks for your patience. The attached patch should fix the issue; it's what I have installed at my site. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-completion-ignore-case-with-completion-file-name.patch >From 2418e67a71494396e8dbfd7fd5eabfb52a87198b Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Thu, 1 May 2025 13:56:37 -0400 Subject: [PATCH] Fix completion-ignore-case with completion--file-name-table 509cbe1c35b3d "Improve env var handling in read-file-name" caused try-completion and all-completion operations with completion--file-name-table to no longer update the case of text which was already present in the input string. That is, completions would be returned ignoring case, but the completions would have letter-casing which matched the input string rather than matching the actual file names. Fix this by always using text from the file name completions whenever it might have changed case. Also, fix a related bug where mixing completion-ignore-case and expanding environment variables would cause `read-file-name' to return the wrong result; do this by suppressing completion-ignore-case in the problematic case. * lisp/minibuffer.el (completion--file-name-table): Use text from the completions, not the input string. (bug#78323) * test/lisp/minibuffer-tests.el (completion-table-test-quoting): Test with completion-ignore-case as well. --- lisp/minibuffer.el | 28 +++++++++++++++++++--------- test/lisp/minibuffer-tests.el | 16 +++++++++++++++- 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 7b2b986aa1d..6f9e6c67541 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3597,6 +3597,16 @@ completion--file-name-table (if (eq (car-safe action) 'boundaries) (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) (let* ((sifned (substitute-in-file-name orig)) + (orig-start (car (completion--sifn-boundaries orig table pred ""))) + (sifned-start (car (completion-boundaries sifned table pred ""))) + (orig-in-bounds (substring orig orig-start)) + (sifned-in-bounds (substring sifned sifned-start)) + (only-need-double-dollars + ;; If true, sifn only un-doubled $s in ORIG, so we can fix a + ;; completion to match ORIG by just doubling $s again. This + ;; preserves more text from the completion, behaving better with + ;; non-nil `completion-ignore-case'. + (string-equal orig-in-bounds (minibuffer--double-dollars sifned-in-bounds))) (result (let ((completion-regexp-list ;; Regexps are matched against the real file names after @@ -3611,21 +3621,21 @@ completion--file-name-table (if (stringp result) ;; Extract the newly added text, quote any dollar signs, and ;; append it to ORIG. - (let ((new-text (substring result (length sifned)))) - (concat orig (minibuffer--double-dollars new-text))) + (if only-need-double-dollars + (concat (substring orig nil orig-start) + (minibuffer--double-dollars (substring result sifned-start))) + (let ((new-text (substring result (length sifned)))) + (concat orig (minibuffer--double-dollars new-text)))) result)) ((eq action t) ; all-completions (mapcar - (let ((orig-prefix - (substring orig (car (completion--sifn-boundaries orig table pred "")))) - (sifned-prefix-length - (- (length sifned) - (car (completion-boundaries sifned table pred ""))))) + (if only-need-double-dollars + #'minibuffer--double-dollars ;; Extract the newly added text, quote any dollar signs, and append ;; it to the part of ORIG inside the completion boundaries. (lambda (compl) - (let ((new-text (substring compl sifned-prefix-length))) - (concat orig-prefix (minibuffer--double-dollars new-text))))) + (let ((new-text (substring compl (length sifned-in-bounds)))) + (concat orig-in-bounds (minibuffer--double-dollars new-text))))) result)) (t result)))))) diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index bed797bdb14..111335a2b5e 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -108,7 +108,21 @@ completion-table-test-quoting (should (equal (completion-try-completion input #'completion--file-name-table nil (length input)) - (cons output (length output))))))) + (cons output (length output))))) + ;; Everything also works with `completion-ignore-case'. + (let ((completion-ignore-case t)) + (pcase-dolist (`(,input ,output) + '( + ("data/M-CTTQ" "data/minibuffer-test-cttq$$tion") + ("data/M-CTTQ$$t" "data/minibuffer-test-cttq$$tion") + ("lisp/c${CTTQ1}et/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + ("lisp/ced${CTTQ2}SE-U" "lisp/ced${CTTQ2}SEmantic-utest") + ("lis/c${CTTQ1}/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + )) + (should (equal (car (completion-try-completion input + #'completion--file-name-table + nil (length input))) + output)))))) (ert-deftest completion--insert-strings-faces () (with-temp-buffer -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 14 07:18:55 2025 Received: (at 78323) by debbugs.gnu.org; 14 May 2025 11:18:55 +0000 Received: from localhost ([127.0.0.1]:40554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFA8U-0007Lg-Ou for submit@debbugs.gnu.org; Wed, 14 May 2025 07:18:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uFA8Q-0007KR-RU for 78323@debbugs.gnu.org; Wed, 14 May 2025 07:18:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFA8J-0001HS-S3; Wed, 14 May 2025 07:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l9wRCP0rcqYDt3QCp6NguvVzCPKZxQZK5mEACZhQjJc=; b=DUxEILgP5e51 Ff8GJsrUnUH/gPI2g7Nv66n0itKIdv4zO9Per4PMQnhTeoh912oaJlFJk9a0nKpMe/sTEy1OZDcra +OKM/ZbXoVtdVPpkozUsbtShYBkoTKVet7ICz5lkzC3YVldw3jASyLmiua3Nic9itZkHxR16IIsi3 MLLHsRXGwYJqxT5FH7FnKbQ7yWf4A8ID9NgFOsjldJtyGxzE4PFtHXkKlMtmvGlQTQYAvU4K13+06 gbRoecE1aeEFePFg0Bz9BHa/ldzO4iLd0Ww/QPP8goF8iCCHdN7Znid5Zbm130X+ae1Bsrvscm/7Z aQ77mcqo07pz5Nsvu02IKw==; Date: Wed, 14 May 2025 14:18:41 +0300 Message-Id: <86zfffzbhq.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh , dancol@dancol.org, Dieter Deyke , Aaron Jensen In-Reply-To: (message from Spencer Baugh on Tue, 13 May 2025 12:23:36 -0400) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: monnier@iro.umontreal.ca, 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: Stefan Monnier , dancol@dancol.org, > 78323@debbugs.gnu.org > Date: Tue, 13 May 2025 12:23:36 -0400 > > Eli Zaretskii writes: > > >> From: Stefan Monnier > >> Cc: Daniel Colascione , sbaugh@janestreet.com, > >> 78323@debbugs.gnu.org > >> Date: Mon, 12 May 2025 10:42:47 -0400 > >> > >> >> >> With read-file-name-completion-ignore-case true, commit > >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion > >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd > >> >> >> typed "foobar" and TAB while reading a filename, then the completion > >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong > >> >> >> and breaks, among other things, vc. > >> >> > Spencer, could you please look into fixing this regression? > >> >> What do you think of reverting this change while Spencer finds the cause > >> >> of the problem? > >> > I wouldn't mind, but then I don't use these features. Let's hear > >> > Stefan's opinion first. > >> > >> I'd first like to hear Spencer's opinion on how quickly he might be able to > >> fix it or if it indeed breaks his assumptions too hard (so we'd need > >> a different approach, in which case we may as well revert the change first). > > > > So, Spencer, the eyes of all the world are upon you. > > Sorry for the delay, I was away this weekend. Thanks for your patience. > > The attached patch should fix the issue; it's what I have installed at > my site. Thanks. Daniel, Dieter, and Aaron, could you please see whether this fixes your problems as well? From debbugs-submit-bounces@debbugs.gnu.org Wed May 14 07:37:24 2025 Received: (at 78323) by debbugs.gnu.org; 14 May 2025 11:37:25 +0000 Received: from localhost ([127.0.0.1]:40739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFAQN-0004Yh-3G for submit@debbugs.gnu.org; Wed, 14 May 2025 07:37:24 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:47291) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uFAQH-0004Wk-IN for 78323@debbugs.gnu.org; Wed, 14 May 2025 07:37:19 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43cf848528aso58594595e9.2 for <78323@debbugs.gnu.org>; Wed, 14 May 2025 04:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747222631; x=1747827431; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fe2JpivbK5xz20fHardv8Bf5P6+P6ez5RQAHfrp8kxM=; b=jzmtSN/Zv/oAFytFc0k7qqDhdYzSI/+JT7UX83KXhJnylEcBklboT3iAi1NNEWCsw6 B5VktANpgnwnrfJXAOhZ6DIWSUR9rFn+dHVQOkQq78YOz9X5yvDj0SEbwjFsXGVIN2Dm WaJVVv54qAyAh7sotTmTPqHRdqI58fuLX1UrO//QJZtF6F+cqI2ynZrNK8glI9CZc6Pa 4UggltP8YyoZ59+bdkMI+KXjbxjJKMzoyQIrPZhcL3+oqK4i/pweqwypMsQS7cvJDrJT X4tdNKCUyJMlToWKjzCB0EExNWZ7OypDTQ34XjG4dBHu4L5WDGViMH5vyEcRw4ZmUDd2 EwSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747222631; x=1747827431; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fe2JpivbK5xz20fHardv8Bf5P6+P6ez5RQAHfrp8kxM=; b=ZP0k2o1ht9nf5fDOpAl1jl8UKFzXuX5OQ45YRwfd4WMzepY1PKljzRi+xqgAz2vVkX gHPL9ZDNJbOGI9t12ckE/+kpZ9kERWn7Tdq3fVtGCEg/8vbCemLJGhQ2WyhjuCFXWyMP aJWeZz99oLMEsAkJrUTjSblKo2WQ6EkZEb6e575nyGkoUTojgY/SiounzoHXX+QDnADk 6pZ2goMzeCVnlmVriBuuGFvv2v5t8E9qqvwrx555hN0GuSf1xMwKFGB1tNqlGwQEZ0sx S5bOncOYEXyHKSO4oH+JXRx9PJ1XaPNW2HFc2cUO3f1zSzTIIM2qolrCJ1FymF4JLeYh DWpA== X-Forwarded-Encrypted: i=1; AJvYcCXyMmVMeA7z8pxppvtXxE/7uUIQhzqhVvRcH2mfCTzuEIP7CXoMvgUiGRZiUqwjaX0Hiw8sBA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzKl4KcSYHK05dZULHy24Ju83vSQzsDHvnY1Zt6bUIzdlp/2pSy 1y9R3dMLayCkP3BpRmAzLGxyNaNRunZqs1+3krOoBByDoC6pC79r2d3MeX2u X-Gm-Gg: ASbGncumwW4E1247fZfxDUFMW4gSZJNmr7AbRhviMXuhWYCFelVxhfz0U2zyRUJLAVs aDIQ4/GnN25DNeZq9q5skdNJe2h5CNOnwoUX05GKbrZI1+A1dc7PfekrCgi8UT4o9GWqeiN5TpE gWeL12XeAAbg/UY380qds45QiQpE+cHcaGc9E0B6BIxpWdB1iZVaXA8W0VqVQcveJuZziNsFpqV 8l7i7PiZDtef3RiobNZtHVKEKHCUZ7pxsF/YRdnArR/+szOI8hkvebDNrmJ4Dj49wXvjQ+F1Otu V0RQfDUFAHenysUk6w+adJfGIeFjgH1oA9LrEgbKtTD5A0JdaZWPKRPLcCWX3xAnupXpbRGFEPu 5HqvUw7KTDqR/nZE= X-Google-Smtp-Source: AGHT+IHvbOxzNpablcGcT9G2OE8tw1QxOR2+5ReA1N4xLYfqGxMAYpA9zpcgiHCUjj8ColGpde+VHg== X-Received: by 2002:a05:600c:a42:b0:442:cd13:f15d with SMTP id 5b1f17b1804b1-442f217a65fmr24374455e9.29.1747222630771; Wed, 14 May 2025 04:37:10 -0700 (PDT) Received: from deyke2.fritz.box (p508b38ce.dip0.t-ipconnect.de. [80.139.56.206]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39ef400sm25301565e9.33.2025.05.14.04.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 04:37:10 -0700 (PDT) Received: from [127.0.0.1] (helo=deyke2.localdomain) by deyke2.fritz.box with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uFAQ9-00000000Pzs-2Q8C; Wed, 14 May 2025 13:37:09 +0200 From: Dieter Deyke To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <86zfffzbhq.fsf@gnu.org> References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> Date: Wed, 14 May 2025 13:37:09 +0200 Message-ID: <87wmajfmoq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78323 Cc: Spencer Baugh , 78323@debbugs.gnu.org, dancol@dancol.org, monnier@iro.umontreal.ca, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: Stefan Monnier , dancol@dancol.org, >> 78323@debbugs.gnu.org >> Date: Tue, 13 May 2025 12:23:36 -0400 >> >> Eli Zaretskii writes: >> >> >> From: Stefan Monnier >> >> Cc: Daniel Colascione , sbaugh@janestreet.com, >> >> 78323@debbugs.gnu.org >> >> Date: Mon, 12 May 2025 10:42:47 -0400 >> >> >> >> >> >> With read-file-name-completion-ignore-case true, commit >> >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> >> >> >> typed "foobar" and TAB while reading a filename, then the completion >> >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> >> >> >> and breaks, among other things, vc. >> >> >> > Spencer, could you please look into fixing this regression? >> >> >> What do you think of reverting this change while Spencer finds the cause >> >> >> of the problem? >> >> > I wouldn't mind, but then I don't use these features. Let's hear >> >> > Stefan's opinion first. >> >> >> >> I'd first like to hear Spencer's opinion on how quickly he might be able to >> >> fix it or if it indeed breaks his assumptions too hard (so we'd need >> >> a different approach, in which case we may as well revert the change first). >> > >> > So, Spencer, the eyes of all the world are upon you. >> >> Sorry for the delay, I was away this weekend. Thanks for your patience. >> >> The attached patch should fix the issue; it's what I have installed at >> my site. > > Thanks. > > Daniel, Dieter, and Aaron, could you please see whether this fixes > your problems as well? Yes, it works for me now. Thanks! -- Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20 From debbugs-submit-bounces@debbugs.gnu.org Wed May 14 12:10:49 2025 Received: (at 78323) by debbugs.gnu.org; 14 May 2025 16:10:49 +0000 Received: from localhost ([127.0.0.1]:44573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFEgv-0001hz-0s for submit@debbugs.gnu.org; Wed, 14 May 2025 12:10:49 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:54325) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uFEgr-0001hg-Ic for 78323@debbugs.gnu.org; Wed, 14 May 2025 12:10:42 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7c5ba363f1aso1098552385a.0 for <78323@debbugs.gnu.org>; Wed, 14 May 2025 09:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747239035; x=1747843835; darn=debbugs.gnu.org; h=references:in-reply-to:to:date:from:message-id:cc:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/KivtvGLnss3J9i+d7+nGeoVjrTshiNjz3igZeT06dA=; b=Flmtn7SErt0FaxnDP+pvpYK1l2jxjkJ+2YpBgJVD8ce2+NOkU5vMPfLYzItjCBTKpV GmjyA5mNw+6SOP3kuJ2fjW9Y61rZn3ctWp2o+0iNNW37UvFqyONfVGxtEGEqgRLTMgNR AsCzwycZ2NYKwxtKON5lhqZmerjYCOh+Tp3NiK6eiVdiEcfo3Sa+dmd/pBG8RBbcC1/o XMwKckBNZuqY7JmqdLDUoX3KkTogEORYd8VlPkEvrAxwjEzxjXTCUWGxLI7Tkqe+yU/+ jeajerzb0R3Xk3M1O/IP+rHj6OrRTkl/MujE+t/958MakTvETrLqR3TUr2dzeMPvMm/v 6Z1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747239035; x=1747843835; h=references:in-reply-to:to:date:from:message-id:cc:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/KivtvGLnss3J9i+d7+nGeoVjrTshiNjz3igZeT06dA=; b=gqncJN6tzQVNFI16pc4hIcEAzDc117Ipxoygg0wgfBz63vFCXqe3NE6XfYSrUKdYEO TdLSX0sEyVNte+u4PXHBol8m0+ESrm3V53MGp2BMzAHOvg86jKfIndXMEad3nYVJT3Sr mzeAg2tQlYCrvy9XYUlxUzWhCUFjZINZtxU6rshgSJwuFxTtAez79Xjq88puDpUBl7ID xAbygD8UdDp5UcJq56klsuOvu9typ8BxwWeBvNzHnPW+iZzPsxNyuVOH2X22PAIoaLj8 /HLAK5+EcSTHbnMdu/hG/+Jh4b81ga1a2/JK72v8MzDtGMkaZkyTVTvIC+k5+4sTfGnz CKUg== X-Forwarded-Encrypted: i=1; AJvYcCXVPEH/CrcI3K5VMB1RvXXeut4EyqGuadxynjpFvJaENxpEyvQpf1A2//C8E3f1U9I3U4+y2Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwRXYgzEZ2u73CyEFV8zk1Gv2UlI3nqRH7rtpx64YZO8lFYHScN PFhMQoHCjvWx0lM08kRvvx9adU2jK4qlvHUJ7AWe2C6f/lNjliRGzSdRLg== X-Gm-Gg: ASbGncvAdSr1b6NabD86gbYh1HxbQBolUIJDYjgqd0y8eJKv5vrTBOnQwKJOhShmNxH NTQ2eTB8qqe5kd0l2S1/2pafy6E4Bz7f13zFkK3Bl9SKugCbp+P5IUU6cfn/hXzi2pLFmkjyTil Yswr5ShhCh4Tns9xV0ylN7dPAWqgpRy+HhKXGQK5O4MuNjPcEXTWGygN+x19/YhB535SZrTLspQ BdZ8YXQwCqXwhnuvmL3XL8V/lQVtUaX2GmJeEEwD74NLW2Am1NwGSc6FjRfZpj/0ruS4zhnt37P 9fcVYHDTOVFlGop/aQeBqIzjVMz/GSXYJkwPrc9PeuxiEe034MZm1l7rXX+1zD5iJiA47Vgp2D8 mwQVIVqgk1UlfGgqP49AO X-Google-Smtp-Source: AGHT+IFZzJopXjqJXZMs/aShqxqtaxW/u55NdBkd4sV8Fkn8XI6m6YbLu/jwb7DqoPrnl73E2GMgHA== X-Received: by 2002:a05:620a:1916:b0:7c5:7a03:8467 with SMTP id af79cd13be357-7cd28890c1bmr557312385a.55.1747239035268; Wed, 14 May 2025 09:10:35 -0700 (PDT) Received: from localhost (0.92.231.35.bc.googleusercontent.com. [35.231.92.0]) by smtp.gmail.com with UTF8SMTPSA id a1e0cc1a2514c-879f613b1absm8947415241.3.2025.05.14.09.10.34 for <78323@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 09:10:35 -0700 (PDT) Mime-Version: 1.0 Subject: Re: bug#78323: Regression in case-insensitive filename completion X-Mailer: Superhuman Desktop (2025-05-13T19:06:12Z) X-Superhuman-ID: mao4zkl1.685b3300-4cba-4bf4-b757-bf2c9434ca47 Message-ID: From: "Aaron Jensen" Date: Wed, 14 May 2025 16:10:30 +0000 To: "Dieter Deyke" X-Superhuman-Draft-ID: draft00d346d0ae987ae0 In-Reply-To: <87wmajfmoq.fsf@gmail.com> References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> <87wmajfmoq.fsf@gmail.com> Content-Type: multipart/alternative; boundary=db8eee90f32bc1550d8704193521e17cbba9336bac47da7a19f221adbef0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78323 Cc: Spencer Baugh , Eli Zaretskii , dancol@dancol.org, monnier@iro.umontreal.ca, 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --db8eee90f32bc1550d8704193521e17cbba9336bac47da7a19f221adbef0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 It work for=C2=A0me as well, thank you. Aaron On Wed, May 14, 2025 at 4:37 AM, Dieter Deyke < dieter.deyke@gmail.com > wr= ote: >=20 >=20 >=20 > Eli Zaretskii < eliz@ gnu. org ( eliz@gnu.org ) > writes: >=20 >=20 >>=20 >>>=20 >>>=20 >>> From: Spencer Baugh < sbaugh@ janestreet. com ( sbaugh@janestreet.com )= > >>> Cc: Stefan Monnier < monnier@ iro. umontreal. ca ( monnier@iro.umontrea= l.ca >>> ) >, dancol@ dancol. org ( dancol@dancol.org ) , 78323@ debbugs. gnu. o= rg ( >>> 78323@debbugs.gnu.org ) >>> Date: Tue , 13 May 2025 12:23:36 -0400 >>>=20 >>>=20 >>>=20 >>> Eli Zaretskii < eliz@ gnu. org ( eliz@gnu.org ) > writes: >>>=20 >>>=20 >>>>=20 >>>>>=20 >>>>>=20 >>>>> From: Stefan Monnier < monnier@ iro. umontreal. ca ( >>>>> monnier@iro.umontreal.ca ) > Cc: Daniel Colascione < dancol@ dancol. = org ( >>>>> dancol@dancol.org ) >, sbaugh@ janestreet. com ( sbaugh@janestreet.co= m ) , >>>>> 78323@ debbugs. gnu. org ( 78323@debbugs.gnu.org ) >>>>> Date: Mon , 12 May 2025 10:42:47 -0400 >>>>>=20 >>>>>=20 >>>>>>=20 >>>>>>>=20 >>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> With read-file-name-completion-ignore-case true, commit >>>>>>>>> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completi= on >>>>>>>>> behavior. Suppose we have file named fooBarQux. Previously, if I'= d typed >>>>>>>>> "foobar" and TAB while reading a filename, then the completion wo= uld be >>>>>>>>> "fooBarQux". Now, it completes as "foobarQux", which is wrong and= breaks, >>>>>>>>> among other things, vc. >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> Spencer, could you please look into fixing this regression? >>>>>>>>=20 >>>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> What do you think of reverting this change while Spencer finds the = cause >>>>>>> of the problem? >>>>>>>=20 >>>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> I wouldn't mind, but then I don't use these features. Let's hear Ste= fan's >>>>>> opinion first. >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>> I'd first like to hear Spencer's opinion on how quickly he might be a= ble >>>>> to fix it or if it indeed breaks his assumptions too hard (so we'd ne= ed a >>>>> different approach, in which case we may as well revert the change fi= rst). >>>>>=20 >>>>>=20 >>>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> So, Spencer, the eyes of all the world are upon you. >>>>=20 >>>>=20 >>>=20 >>>=20 >>>=20 >>> Sorry for the delay, I was away this weekend. Thanks for your patience. >>>=20 >>>=20 >>>=20 >>> The attached patch should fix the issue; it's what I have installed at = my >>> site. >>>=20 >>>=20 >>=20 >>=20 >>=20 >> Thanks. >>=20 >>=20 >>=20 >> Daniel, Dieter, and Aaron, could you please see whether this fixes your >> problems as well? >>=20 >>=20 >=20 >=20 >=20 > Yes, it works for me now. Thanks! >=20 >=20 >=20 > -- > Dieter Deyke > mailto: dieter. deyke@ gmail. com ( dieter.deyke@gmail.com ) > Get my Gnupg key: > gpg --keyserver keys. gnupg. net ( http://keys.gnupg.net/ ) --recv-keys > B116EA20 >=20 >=20 > --db8eee90f32bc1550d8704193521e17cbba9336bac47da7a19f221adbef0 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8
It work for=C2=A0me= as well, thank you.
3D=


Aaron


On Wed, May 14, 2025 at 4:37 AM, Dieter Deyke <dieter.deyke@gmai= l.com> wrote:

Eli Zaretskii <eliz@gnu.org> writes:

From: Spencer Baugh <sbaugh= @janestreet.com>
Cc: Stefan Monnier <monn= ier@iro.umontreal.ca>, dancol@dancol.org, 78323@debbugs.gnu.= org
Date: Tue, 13 May 2025 12:23:36 -0400

Eli Zaretskii <eliz@gnu.= org> writes:

From: Stefan Monnier <mo= nnier@iro.umontreal.ca> Cc: Daniel Colascione <dancol@<= wbr/>dancol.org>, 78323@debbugs.gnu.= org
Date: Mon, 12 May 2025 10:42:47 -0400

With read-file-name-completion-ignore-case true, commit 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion behavior. Suppose we have file named fooBarQux. Previously, if I'd typed "foobar" and TAB while reading a filename, then the completio= n would be "fooBarQux". Now, it completes as "foobarQux", wh= ich is wrong and breaks, among other things, vc.

Spencer, could you please look into fixing this regression?

What do you think of reverting this change while Spencer finds the cause of the problem?

I wouldn't mind, but then I don't use these features. Let's he= ar Stefan's opinion first.

I'd first like to hear Spencer's opinion on how quickly he might be= able to fix it or if it indeed breaks his assumptions too hard (so we'd need a different approach, in which case we may as well revert the change first)= .

So, Spencer, the eyes of all the world are upon you.

Sorry for the delay, I was away this weekend. Thanks for your patience.

The attached patch should fix the issue; it's what I have installed at my site.

Thanks.

Daniel, Dieter, and Aaron, could you please see whether this fixes your problems as well?

Yes, it works for me now. Thanks!

--=20
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

--db8eee90f32bc1550d8704193521e17cbba9336bac47da7a19f221adbef0-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 14 18:19:21 2025 Received: (at 78323) by debbugs.gnu.org; 14 May 2025 22:19:21 +0000 Received: from localhost ([127.0.0.1]:47042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFKRd-0003bF-3d for submit@debbugs.gnu.org; Wed, 14 May 2025 18:19:21 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:32901) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uFKRY-0003aa-TX for 78323@debbugs.gnu.org; Wed, 14 May 2025 18:19:18 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <86zfffzbhq.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 May 2025 14:18:41 +0300") References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> Date: Wed, 14 May 2025 18:19:11 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1747261151; bh=cMRw8UWrzDLHuBo305/XTg8bf2xoBTEuGKDdhT+BF0Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LesjSurcSOGYNVu5gNHoifF2Yw9g+S1HgYxnZjLaceQHe2hNka72LP+3nU/7NKAEU 4fE7x7WrRF48w9WU0QugqQnFfxnrruJE5dwfPD2j7yJvqcQwghzzykBfm9Z7FAgBXv /vJxoqeNgDKmMT5VLk26zeNTJd9A90+4A3IfxfgwJcEJHdNf0p22yVI9oU9mk9yJYN a8/eXpiZvAJsYScrNSe+NnoxQtZ/R9tBZbaLiP57/33fPp+/oXqSJk+iveunlaHs02 iZPJq7rX70cki/Y/WM0BQ0DzvQAdxD2O8J4/l/EIzoDnTn/aUiUNArx8hJcEeU6b+w jXCAT918mCE3A== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: Dieter Deyke , dancol@dancol.org, 78323@debbugs.gnu.org, monnier@iro.umontreal.ca, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: Stefan Monnier , dancol@dancol.org, >> 78323@debbugs.gnu.org >> Date: Tue, 13 May 2025 12:23:36 -0400 >> >> Eli Zaretskii writes: >> >> >> From: Stefan Monnier >> >> Cc: Daniel Colascione , sbaugh@janestreet.com, >> >> 78323@debbugs.gnu.org >> >> Date: Mon, 12 May 2025 10:42:47 -0400 >> >> >> >> >> >> With read-file-name-completion-ignore-case true, commit >> >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> >> >> >> typed "foobar" and TAB while reading a filename, then the completion >> >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> >> >> >> and breaks, among other things, vc. >> >> >> > Spencer, could you please look into fixing this regression? >> >> >> What do you think of reverting this change while Spencer finds the cause >> >> >> of the problem? >> >> > I wouldn't mind, but then I don't use these features. Let's hear >> >> > Stefan's opinion first. >> >> >> >> I'd first like to hear Spencer's opinion on how quickly he might be able to >> >> fix it or if it indeed breaks his assumptions too hard (so we'd need >> >> a different approach, in which case we may as well revert the change first). >> > >> > So, Spencer, the eyes of all the world are upon you. >> >> Sorry for the delay, I was away this weekend. Thanks for your patience. >> >> The attached patch should fix the issue; it's what I have installed at >> my site. > > Thanks. > > Daniel, Dieter, and Aaron, could you please see whether this fixes > your problems as well? BTW, the patch I posted has the wrong commit message but is otherwise correct. Assuming there's review feedback, I'll correct the commit message in the next version. From debbugs-submit-bounces@debbugs.gnu.org Sat May 17 05:39:51 2025 Received: (at 78323) by debbugs.gnu.org; 17 May 2025 09:39:51 +0000 Received: from localhost ([127.0.0.1]:45841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGE1G-0004Ux-R9 for submit@debbugs.gnu.org; Sat, 17 May 2025 05:39:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35258) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGE1E-0004Ud-EV for 78323@debbugs.gnu.org; Sat, 17 May 2025 05:39:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGE18-0002NB-M3; Sat, 17 May 2025 05:39:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=K71DH7+cj8fe/YSubyK/JF1y4lBCVSWnK1DbkyIKQuM=; b=GERiYRHKciqY V2o8k6ZLwhCsVBZ4F6VVkjs6wi+9GGh3rPQrei8gPv+lco1gf2PzyRjbjq8YYUtm9IodG6mxXh1mw v3nNL0Vh1m4zreSRAHIMwDPGaVMg7vFHaeoUIFARSQWsIU+nBbu7GP/iJxK9JyLM4c9P5vQR9X933 EAtsXuoUkB/fQcbAGcmpuTNReXNRo74g+wdhSc0scVxkAJWuDP8Rn6K0c05ScIdpFIkzn3Y0uFQaW t/60e671//cWFcd+P1AX4uWwCLi7vYbZtBM/1HZGtLzCf+4i7xYRMsisejY3tvR1ppbPGL6StP+Dt qwRqkW3CaTWj9IINM32EmQ==; Date: Sat, 17 May 2025 12:39:39 +0300 Message-Id: <864ixjwp7o.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Wed, 14 May 2025 18:19:11 -0400) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323 Cc: dieter.deyke@gmail.com, dancol@dancol.org, 78323@debbugs.gnu.org, monnier@iro.umontreal.ca, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: dancol@dancol.org, Dieter Deyke , Aaron Jensen > , monnier@iro.umontreal.ca, 78323@debbugs.gnu.org > Date: Wed, 14 May 2025 18:19:11 -0400 > > Eli Zaretskii writes: > >> From: Spencer Baugh > >> Cc: Stefan Monnier , dancol@dancol.org, > >> 78323@debbugs.gnu.org > >> Date: Tue, 13 May 2025 12:23:36 -0400 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Stefan Monnier > >> >> Cc: Daniel Colascione , sbaugh@janestreet.com, > >> >> 78323@debbugs.gnu.org > >> >> Date: Mon, 12 May 2025 10:42:47 -0400 > >> >> > >> >> >> >> With read-file-name-completion-ignore-case true, commit > >> >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion > >> >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd > >> >> >> >> typed "foobar" and TAB while reading a filename, then the completion > >> >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong > >> >> >> >> and breaks, among other things, vc. > >> >> >> > Spencer, could you please look into fixing this regression? > >> >> >> What do you think of reverting this change while Spencer finds the cause > >> >> >> of the problem? > >> >> > I wouldn't mind, but then I don't use these features. Let's hear > >> >> > Stefan's opinion first. > >> >> > >> >> I'd first like to hear Spencer's opinion on how quickly he might be able to > >> >> fix it or if it indeed breaks his assumptions too hard (so we'd need > >> >> a different approach, in which case we may as well revert the change first). > >> > > >> > So, Spencer, the eyes of all the world are upon you. > >> > >> Sorry for the delay, I was away this weekend. Thanks for your patience. > >> > >> The attached patch should fix the issue; it's what I have installed at > >> my site. > > > > Thanks. > > > > Daniel, Dieter, and Aaron, could you please see whether this fixes > > your problems as well? > > BTW, the patch I posted has the wrong commit message but is otherwise > correct. Assuming there's review feedback, I'll correct the commit > message in the next version. Please do submit a correct patch, so we could resolve this regression. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon May 19 10:58:06 2025 Received: (at 78323) by debbugs.gnu.org; 19 May 2025 14:58:06 +0000 Received: from localhost ([127.0.0.1]:42106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uH1wL-00078d-6W for submit@debbugs.gnu.org; Mon, 19 May 2025 10:58:06 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:60154) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uH1wH-00077a-7Z for 78323@debbugs.gnu.org; Mon, 19 May 2025 10:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xC90f6YSkrHi11mXlNfPSiJGrgvVHno/63SL3g58+Ck=; b=OCgVHtumcX2xyEifas9nmoZgwR FYAVoEHEupds2ombR7cGzn0VobsD1pv2DSb4iRf4zLKMcMxExJoSKurcBLz+aw3SUAa6FXUs2kxcT G+g/SeyBbzd+qW+XyDkGj7DIdWBgJ683vtpYIfnqV+GgfBuM0OBOM5Tc+3EkzdP1DDQVHeHyzkmbz v5AzjscIoZi/hM2jW8fDyTeQsDL4qfAGOy6nl+kyWI1fefhJjp18FhuQsSdDzacQUoidn0RVYteFV NXQREhNAhyQQX8XQuOyKl+11GY8eSGSogMdVxVOJzpn0rZRfjbxmJOPBY4SMibNltEnhQId6S0w3p rPSDRZhQ==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1uH1v6-00A2RO-2k; Mon, 19 May 2025 10:56:48 -0400 From: Daniel Colascione To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <864ixjwp7o.fsf@gnu.org> References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> <864ixjwp7o.fsf@gnu.org> User-Agent: mu4e 1.12.10; emacs 31.0.50 Date: Mon, 19 May 2025 10:57:51 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 78323 Cc: Spencer Baugh , dieter.deyke@gmail.com, 78323@debbugs.gnu.org, monnier@iro.umontreal.ca, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: dancol@dancol.org, Dieter Deyke , Aaron Jensen >> , monnier@iro.umontreal.ca, 78323@debbugs.gnu.org >> Date: Wed, 14 May 2025 18:19:11 -0400 >> >> Eli Zaretskii writes: >> >> From: Spencer Baugh >> >> Cc: Stefan Monnier , dancol@dancol.org, >> >> 78323@debbugs.gnu.org >> >> Date: Tue, 13 May 2025 12:23:36 -0400 >> >> >> >> Eli Zaretskii writes: >> >> >> >> >> From: Stefan Monnier >> >> >> Cc: Daniel Colascione , sbaugh@janestreet.com, >> >> >> 78323@debbugs.gnu.org >> >> >> Date: Mon, 12 May 2025 10:42:47 -0400 >> >> >> >> >> >> >> >> With read-file-name-completion-ignore-case true, commit >> >> >> >> >> 509cbe1c35b3dd005a53ac041f9c87ee53b8e115 breaks existing completion >> >> >> >> >> behavior. Suppose we have file named fooBarQux. Previously, if I'd >> >> >> >> >> typed "foobar" and TAB while reading a filename, then the completion >> >> >> >> >> would be "fooBarQux". Now, it completes as "foobarQux", which is wrong >> >> >> >> >> and breaks, among other things, vc. >> >> >> >> > Spencer, could you please look into fixing this regression? >> >> >> >> What do you think of reverting this change while Spencer finds the cause >> >> >> >> of the problem? >> >> >> > I wouldn't mind, but then I don't use these features. Let's hear >> >> >> > Stefan's opinion first. >> >> >> >> >> >> I'd first like to hear Spencer's opinion on how quickly he might be able to >> >> >> fix it or if it indeed breaks his assumptions too hard (so we'd need >> >> >> a different approach, in which case we may as well revert the change first). >> >> > >> >> > So, Spencer, the eyes of all the world are upon you. >> >> >> >> Sorry for the delay, I was away this weekend. Thanks for your patience. >> >> >> >> The attached patch should fix the issue; it's what I have installed at >> >> my site. >> > >> > Thanks. >> > >> > Daniel, Dieter, and Aaron, could you please see whether this fixes >> > your problems as well? >> >> BTW, the patch I posted has the wrong commit message but is otherwise >> correct. Assuming there's review feedback, I'll correct the commit >> message in the next version. > > Please do submit a correct patch, so we could resolve this regression. > > Thanks. Works fine for me too, FWIW. From debbugs-submit-bounces@debbugs.gnu.org Mon May 19 11:47:05 2025 Received: (at 78323) by debbugs.gnu.org; 19 May 2025 15:47:05 +0000 Received: from localhost ([127.0.0.1]:42652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uH2hl-0003e6-5F for submit@debbugs.gnu.org; Mon, 19 May 2025 11:47:05 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:56653) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uH2hi-0003dC-Et for 78323@debbugs.gnu.org; Mon, 19 May 2025 11:47:02 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#78323: Regression in case-insensitive filename completion In-Reply-To: <864ixjwp7o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 May 2025 12:39:39 +0300") References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> <864ixjwp7o.fsf@gnu.org> Date: Mon, 19 May 2025 11:46:57 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1747669617; bh=C4bUU8rIFYe1RRPlKIfDxDd5ChPINYwXzMeRm1JV4K8=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=BOVsfhcsFONHG0da5hcSZdr+yaobSkIfQPQ+Lf+cRl6gdzGGTZkK5k08wItCzCbGO nDnzx1reZ2eH7hGxA71gEpS5ZX3oEVyKi8sd+bbann5XFg7HSR0CVOIGlQmxW3bI4o UUICdxQkxOJTUKKFMLDyy6/DG6PJIV2V7re8t/SWzTSmWUPkWM+15KELHSCG6jxkkp /72m4zrbKfWuFZbZbBzc53TCctWo0QydyuSRNqH1eJVcsSmzHu32lxvmcrwipqGBxA uI0aVawFg36aj9sQPlKR/Sz3jUOlfUNSxSj8vG8LpKyo/+EyStbPwdgHB9ViwjuJ/U 0ZUDPwV+2FsfA== X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 78323 Cc: aaronjensen@gmail.com, dieter.deyke@gmail.com, dancol@dancol.org, monnier@iro.umontreal.ca, 78323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Spencer Baugh >> BTW, the patch I posted has the wrong commit message but is otherwise >> correct. Assuming there's review feedback, I'll correct the commit >> message in the next version. > > Please do submit a correct patch, so we could resolve this regression. > > Thanks. Here is the version with a correct commit message. (I also added some comments in the test) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-completion-ignore-case-with-completion-file-name.patch >From d3d61cfe7699078c3f6405f2dd7a7a5f61d5985a Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Mon, 19 May 2025 11:35:38 -0400 Subject: [PATCH] Fix completion-ignore-case with completion--file-name-table 509cbe1c35b3d "Improve env var handling in read-file-name" caused try-completion and all-completion operations with completion--file-name-table to no longer update the case of text which was already present in the input string. That is, completions would be returned ignoring case, but the completions would have letter-casing which matched the input string rather than matching the actual file names. This was caused by unnecessarily replacing text in the returned file name completions with text from the input string ORIG, which in turn was caused by the desire to preserve text from ORIG even after substitute-in-file-name changed it. Fix this by detecting when ORIG was not substantially changed by substitute-in-file-name; in that case, the returned file name completions also don't need substantial changes. * lisp/minibuffer.el (completion--file-name-table): Use text from the completions, not the input string. (bug#78323) * test/lisp/minibuffer-tests.el (completion-table-test-quoting): Test with completion-ignore-case as well. --- lisp/minibuffer.el | 28 +++++++++++++++++++--------- test/lisp/minibuffer-tests.el | 21 ++++++++++++++++++++- 2 files changed, 39 insertions(+), 10 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 7b2b986aa1d..6f9e6c67541 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3597,6 +3597,16 @@ completion--file-name-table (if (eq (car-safe action) 'boundaries) (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) (let* ((sifned (substitute-in-file-name orig)) + (orig-start (car (completion--sifn-boundaries orig table pred ""))) + (sifned-start (car (completion-boundaries sifned table pred ""))) + (orig-in-bounds (substring orig orig-start)) + (sifned-in-bounds (substring sifned sifned-start)) + (only-need-double-dollars + ;; If true, sifn only un-doubled $s in ORIG, so we can fix a + ;; completion to match ORIG by just doubling $s again. This + ;; preserves more text from the completion, behaving better with + ;; non-nil `completion-ignore-case'. + (string-equal orig-in-bounds (minibuffer--double-dollars sifned-in-bounds))) (result (let ((completion-regexp-list ;; Regexps are matched against the real file names after @@ -3611,21 +3621,21 @@ completion--file-name-table (if (stringp result) ;; Extract the newly added text, quote any dollar signs, and ;; append it to ORIG. - (let ((new-text (substring result (length sifned)))) - (concat orig (minibuffer--double-dollars new-text))) + (if only-need-double-dollars + (concat (substring orig nil orig-start) + (minibuffer--double-dollars (substring result sifned-start))) + (let ((new-text (substring result (length sifned)))) + (concat orig (minibuffer--double-dollars new-text)))) result)) ((eq action t) ; all-completions (mapcar - (let ((orig-prefix - (substring orig (car (completion--sifn-boundaries orig table pred "")))) - (sifned-prefix-length - (- (length sifned) - (car (completion-boundaries sifned table pred ""))))) + (if only-need-double-dollars + #'minibuffer--double-dollars ;; Extract the newly added text, quote any dollar signs, and append ;; it to the part of ORIG inside the completion boundaries. (lambda (compl) - (let ((new-text (substring compl sifned-prefix-length))) - (concat orig-prefix (minibuffer--double-dollars new-text))))) + (let ((new-text (substring compl (length sifned-in-bounds)))) + (concat orig-in-bounds (minibuffer--double-dollars new-text))))) result)) (t result)))))) diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index bed797bdb14..f9a26d17e58 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -108,7 +108,26 @@ completion-table-test-quoting (should (equal (completion-try-completion input #'completion--file-name-table nil (length input)) - (cons output (length output))))))) + (cons output (length output))))) + ;; Everything also works with `completion-ignore-case'. + (let ((completion-ignore-case t)) + (pcase-dolist (`(,input ,output) + '( + ("data/M-CTTQ" "data/minibuffer-test-cttq$$tion") + ("data/M-CTTQ$$t" "data/minibuffer-test-cttq$$tion") + ;; When an env var is in the completion bounds, try-completion + ;; won't change letter case. + ("lisp/c${CTTQ1}E" "lisp/c${CTTQ1}Et/") + ("lisp/ced${CTTQ2}SE-U" "lisp/ced${CTTQ2}SEmantic-utest") + ;; If the env var is before the completion bounds, try-completion + ;; *will* change letter case. + ("lisp/c${CTTQ1}et/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + ("lis/c${CTTQ1}/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + )) + (should (equal (car (completion-try-completion input + #'completion--file-name-table + nil (length input))) + output)))))) (ert-deftest completion--insert-strings-faces () (with-temp-buffer -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 19 13:05:31 2025 Received: (at 78323-done) by debbugs.gnu.org; 19 May 2025 17:05:31 +0000 Received: from localhost ([127.0.0.1]:43565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uH3ve-00036W-TL for submit@debbugs.gnu.org; Mon, 19 May 2025 13:05:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58702) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uH3vc-00035z-RO for 78323-done@debbugs.gnu.org; Mon, 19 May 2025 13:05:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3vW-0000qW-Hg; Mon, 19 May 2025 13:05:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dMbqUCj4hc/KKvmPAwka0OmGcTAC9TjXL4bjaEJ1W7U=; b=KM6UWFosR6vm GmKzbodlIZ8fsL5I4qbadc0ZZ3pHoydGYEZohvrnkTFgoqV+637+4nQaFgkMuJ2NNlSyVIy2Wphay ZkXhXw/249WpepmurdaqdvZKsuT/1iu8xnNUcgdrqv20noqlLuakKl094QkoSu7sMpKFr4Cii/SxP pU3tCHyYdUM6+M721HycU/4b7W/KIrDVvfrU4ufpFRUT6DADtXJ8MNgCsYK61MYcI3HdkiyZvG28A dxMDrGH6sA9A401tD/ZsC7d8lfL6kSNWENFwHJFJ8EGwjNebhOxc6reqFhbIA9TNwEixOywBJQMlb FGt55moSk1yRAIGG3G6M/Q==; Date: Mon, 19 May 2025 20:04:57 +0300 Message-Id: <864ixga5vq.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Mon, 19 May 2025 11:46:57 -0400) Subject: Re: bug#78323: Regression in case-insensitive filename completion References: <86plgicn7l.fsf@gnu.org> <86sela6orh.fsf@gnu.org> <86cycd7u7n.fsf@gnu.org> <86zfffzbhq.fsf@gnu.org> <864ixjwp7o.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78323-done Cc: aaronjensen@gmail.com, dieter.deyke@gmail.com, dancol@dancol.org, monnier@iro.umontreal.ca, 78323-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: dieter.deyke@gmail.com, dancol@dancol.org, 78323@debbugs.gnu.org, > monnier@iro.umontreal.ca, aaronjensen@gmail.com > Date: Mon, 19 May 2025 11:46:57 -0400 > > Eli Zaretskii writes: > >> From: Spencer Baugh > >> BTW, the patch I posted has the wrong commit message but is otherwise > >> correct. Assuming there's review feedback, I'll correct the commit > >> message in the next version. > > > > Please do submit a correct patch, so we could resolve this regression. > > > > Thanks. > > Here is the version with a correct commit message. (I also added some > comments in the test) Thanks, installed on master, and closing the bug.