From unknown Fri Jun 20 07:26:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78316 <78316@debbugs.gnu.org> To: bug#78316 <78316@debbugs.gnu.org> Subject: Status: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. Reply-To: bug#78316 <78316@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:26:08 +0000 retitle 78316 [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4de= v1-0.9338e3e. reassign 78316 guix-patches submitter 78316 Cayetano Santos severity 78316 normal tag 78316 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 08 08:51:07 2025 Received: (at submit) by debbugs.gnu.org; 8 May 2025 12:51:07 +0000 Received: from localhost ([127.0.0.1]:55286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uD0iQ-0001Hy-Ja for submit@debbugs.gnu.org; Thu, 08 May 2025 08:51:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60086) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uD0iM-0001HH-VP for submit@debbugs.gnu.org; Thu, 08 May 2025 08:51:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uD0iH-000773-4j for guix-patches@gnu.org; Thu, 08 May 2025 08:50:57 -0400 Received: from confino.investici.org ([93.190.126.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uD0iE-0005nL-Op for guix-patches@gnu.org; Thu, 08 May 2025 08:50:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1746708651; bh=tmRqOHDvf6CAGHaLV4gkNwj11cThqLnonG5btARb7UQ=; h=From:To:Cc:Subject:Date:From; b=Yzdamj5kmNp8BSXscMo0lDvVT/UiIJf+LzbtILlPmDiNZb0we0IPDN4I5IzdFWEI2 m+eai3iyDx07j301DwKrJN9lOg9BUdcYi1TDpdGNELTxIHp0DkjGESxMan1x1tsolo RERJqSne7HfF/uFzmOwjf9dz587sG0QDkpY2R+do= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4ZtX6z156vz11Dq; Thu, 8 May 2025 12:50:51 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZtX6y72T4z1198; Thu, 8 May 2025 12:50:50 +0000 (UTC) From: Cayetano Santos To: guix-patches@gnu.org Subject: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. Date: Thu, 8 May 2025 14:49:32 +0200 Message-ID: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Gabriel Wicki , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=93.190.126.19; envelope-from=csantosb@inventati.org; helo=confino.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/fpga.scm (python-hdlmake): Update to 3.4dev1-0.9338e3e. Change-Id: Ied124a3ceb22be427c5255b5d139f5f63031e260 --- [source]: Update URL. [homepage]: Update URL. gnu/packages/fpga.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm index 2298dde595..e2a0b19a7d 100644 --- a/gnu/packages/fpga.scm +++ b/gnu/packages/fpga.scm @@ -776,26 +776,26 @@ (define-public openfpgaloader (license license:asl2.0))) (define-public python-hdlmake - (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54") + (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621") (revision "0")) (package (name "python-hdlmake") - (version (git-version "3.3" revision commit)) + (version (git-version "3.4dev1" revision commit)) (source (origin (method git-fetch) (uri (git-reference - (url "https://ohwr.org/project/hdl-make") + (url "https://gitlab.com/ohwr/project/hdl-make/") (commit commit))) (file-name (git-file-name name version)) (sha256 - (base32 "08ivnhxyp44agmifqb4pjbxj23p43qqcg73s2y2z1hqk2six3fdx")))) + (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj")))) (build-system pyproject-build-system) (arguments `(#:tests? #f)) (native-inputs (list python-setuptools python-wheel)) (propagated-inputs (list python-six)) - (home-page "https://ohwr.org/projects/hdl-make") + (home-page "https://gitlab.com/ohwr/project/hdl-make/") (synopsis "Generate multi-purpose makefiles for HDL projects") (description "Hdlmake helps manage and share @acronym{HDL, hardware description base-commit: 4fe484ee7e9d598a9d0a249c375b75a14b95d1b4 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 08:04:43 2025 Received: (at 78316) by debbugs.gnu.org; 12 May 2025 12:04:43 +0000 Received: from localhost ([127.0.0.1]:51000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uERtj-0000IB-3k for submit@debbugs.gnu.org; Mon, 12 May 2025 08:04:43 -0400 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:55597) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uERtf-0000HX-A7 for 78316@debbugs.gnu.org; Mon, 12 May 2025 08:04:40 -0400 Received: from coney (mob-194-230-148-150.cgn.sunrise.net [194.230.148.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA id CD3201FF2B; Mon, 12 May 2025 14:04:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erlikon.ch; s=20250312; t=1747051473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GLYZFtUw2cKqP4iF+vADyemFqkb1uy8JOwGnZ0ZSZcQ=; b=UkhRmN8rbceH8UuthTzQ+YvmrUf/FdygtzFGDRao5waIc+kge/SL5s7XZgUSn8BdAR7+Wg BW2l8f29OicQL23OZEvrrfzHSj3dr5lHeJ/BH6BQ5ragDTOEI9xCdaRSFnQcp6HOOyOOHN t6LG3H7AJUzlxoYWS/wcgwo+bZPwBizR96Uo9bbal+M68rI/yzS+7PSFBzhEgzorlb/BDl q7N51t0Gs9xTJCJ3bIXXPqqjDc9D8TKek6neRHF5+e3eT9+M+9aslDNo2jXU5vS6955MYU 02GfquzE70IaM0GqPHYMOaDEyRPPK7junZFD+4kFKH9S3BB/pVuYM315kFm1JesBzjZuGq JDY8yzfSWrvBGECyexI230OUfcgRK4kNX+30nsROlaZ7Deue4XY2GXMzUpDVO3KdpvctBZ DDMsB79wjIpqmlylslLyGwZTkIl1aK91UDAULUpRfvy5yQR3eaEfM6dsfB28Dt7lQLCIts 3HSFa4jOVSR/V8gg/Fm9Ojamtvdjdv1dphazGKN91LfRpznxfA0s3zV9h1FRtJx+g1yrP9 oG5kYGo6Xiw7jCHpT5GJf/8JyhxB+XcThF5WorpmEey0X4J5kWwfx0ELuRgFmJUilh9bc6 yCbFbgv4ZugbEx7OE084juBDiFkqrwlpaHY0Em6pCz2iCrZ97ipSE= Date: Mon, 12 May 2025 14:04:24 +0200 From: Gabriel Wicki To: Cayetano Santos Subject: Re: [bug#78316] [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. Message-ID: <4tanyfelaogriorgcfs7zz74ct7vrm4iv6upyg5f26blf4z7k3@soc25abt2jmc> References: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78316 Cc: Maxim Cournoyer , Ekaitz Zarraga , 78316@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) LGTM, but: Does the project officially change their home-page? If so, please state that in the commit message. Thanks for your time and effort! gabber From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 08:53:02 2025 Received: (at 78316-done) by debbugs.gnu.org; 12 May 2025 12:53:02 +0000 Received: from localhost ([127.0.0.1]:51286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uESeT-0002zA-7U for submit@debbugs.gnu.org; Mon, 12 May 2025 08:53:01 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:56449) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uESeN-0002yb-OI for 78316-done@debbugs.gnu.org; Mon, 12 May 2025 08:52:57 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-af51596da56so3404143a12.0 for <78316-done@debbugs.gnu.org>; Mon, 12 May 2025 05:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747054369; x=1747659169; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8aBCHt7mHSbW7D2Wuf/vRnZV8w0zYIIkt50Hp7A6maI=; b=Ds2Z23MNnI5MlUv18X7QsevGY6c/2/Ktyfkt1d9Asi/NYJYbpo0j+RQThgwt7elLEA r2bsiUDsQVoB3VKSCk4k/4bvci/FEWn/obBKeoTRp3s+7n9bAwy3sbJvBnZsmQEAgYRO eVyOqUaoaFbXFgJFoagWrqWoOtwVBszZUbfMQlCXRBmUah7taA/hJlSnEHPIxDT9/y/W tQ3hEZtClMtJz/mBN7VSv19WDSRGmVSPXymyhZyzamy7ytNvd3125EIqm9/1RBx9xQy7 pD3IuZmpANrT2ymT574fGwveIlMacp2b6AouduCIMNcjJJIyGfBFltl9v1bRQuS6VM+w Qm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747054369; x=1747659169; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8aBCHt7mHSbW7D2Wuf/vRnZV8w0zYIIkt50Hp7A6maI=; b=o75UB/HLhTQqNheyqyua7XnrocPaTh31By0tpZZuevOl2sqsJIrtX/CDapHba4EFkg C5l5slR5qCqE6V7ncsQcL9MMZVlXCaW1tNBMlClOnujXzFrCOGnY6PCehtO+krBfyFFr LP4RMMQ2smGeINSGTN3BrKAm1teSwqmsfCpdAvI9OWydvql/bFFK5PC+nTXrTR6vqjju 5YSnX2nOwT2hyR82I0KF26C+G9Oe8OhvQgNBgCS8oj//akCV6yugsYZGcBO5f42dPbmK wL+FAURoT/OyA3+gaUVE4lMNlxy/Wniwcp0e/fSv4y/cgKnTl+ISuWd/vYFBbka4OCLH 2XnQ== X-Gm-Message-State: AOJu0YzM3KCe12NiLWGdMAGSaP34ceWdmtJz17ao5S3Namg5xP17OGwg 3Ll8vVay1p2MGf2Eb6l0sixARjNFVL/rGtvt5f4Lv8jXRBgDq9Ad X-Gm-Gg: ASbGncu9LlU3/yjyRAUYpjAZ5qsRhvbZab9vQ3S31rp5qeVH1MUDzyqAPjgZ2M/fcmt cOq/msFrMAj1Ytf7seCRsx5Kx7np8vlU8BtHeYq//Oap02OTr6kYmZSlM057jEe+R9A6Wkg+WaM iNUua0Gugmk123DieJGkskyL/9Ab8Up5A/ylmlmn+Sz49ieSoRgLy2JEA2b3R6zdipJMxUxEX4Y f8UmJ+FpQdVl2hnARxGNifz+6PtIiDhViOxrZiedwbC+hbg2Aa6zu/U9iVTDJSSn/cOfde3F7Ms YbyWhNwCqdBnYE6Ct4rCnjleR0iYM712jlswvv1l3fqle+TRHw== X-Google-Smtp-Source: AGHT+IENdPnGeb2h5auA6yOEyX/7d8zVrmdqAvuC3vSM/pCRwyqYZ3E8gAK8X/7J4vgxsdl14CpbJQ== X-Received: by 2002:a17:903:186:b0:22e:4fe6:24f9 with SMTP id d9443c01a7336-22fc8b3af29mr170467305ad.13.1747054369128; Mon, 12 May 2025 05:52:49 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc7742f3csm61553355ad.99.2025.05.12.05.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 05:52:48 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. In-Reply-To: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> (Cayetano Santos's message of "Thu, 8 May 2025 14:49:32 +0200") References: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> Date: Mon, 12 May 2025 21:52:46 +0900 Message-ID: <874ixqoush.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78316-done Cc: Gabriel Wicki , Ekaitz Zarraga , 78316-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cayetano Santos writes: > * gnu/packages/fpga.scm (python-hdlmake): Update to 3.4dev1-0.9338e3e. > > Change-Id: Ied124a3ceb22be427c5255b5d139f5f63031e260 > --- > > [source]: Update URL. > [homepage]: Update URL. Ah, these should have appeared in the change log (commit message), not in this patch metadata/comment area. I've fixed it locally. > gnu/packages/fpga.scm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm > index 2298dde595..e2a0b19a7d 100644 > --- a/gnu/packages/fpga.scm > +++ b/gnu/packages/fpga.scm > @@ -776,26 +776,26 @@ (define-public openfpgaloader > (license license:asl2.0))) > > (define-public python-hdlmake > - (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54") > + (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621") > (revision "0")) > (package > (name "python-hdlmake") > - (version (git-version "3.3" revision commit)) > + (version (git-version "3.4dev1" revision commit)) The version here is not correct, according to (info "(guix) Version Numbers"). The version string of a git snapshot should be based on the latest upstream version, which is still 3.3. Since we're not bumping the version the revision number needs to go up by one. > (source > (origin > (method git-fetch) > (uri (git-reference > - (url "https://ohwr.org/project/hdl-make") > + (url "https://gitlab.com/ohwr/project/hdl-make/") > (commit commit))) > (file-name (git-file-name name version)) > (sha256 > - (base32 "08ivnhxyp44agmifqb4pjbxj23p43qqcg73s2y2z1hqk2six3fdx")))) > + (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj")))) > (build-system pyproject-build-system) > (arguments > `(#:tests? #f)) > (native-inputs (list python-setuptools python-wheel)) > (propagated-inputs (list python-six)) > - (home-page "https://ohwr.org/projects/hdl-make") > + (home-page "https://gitlab.com/ohwr/project/hdl-make/") LGTM. Applied with the following fix-ups (I also enabled the tests): --8<---------------cut here---------------start------------->8--- 1 file changed, 7 insertions(+), 5 deletions(-) gnu/packages/fpga.scm | 12 +++++++----- modified gnu/packages/fpga.scm @@ -774,10 +774,10 @@ (define-public openfpgaloader (define-public python-hdlmake (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621") - (revision "0")) + (revision "1")) (package (name "python-hdlmake") - (version (git-version "3.4dev1" revision commit)) + (version (git-version "3.3" revision commit)) (source (origin (method git-fetch) @@ -788,9 +788,11 @@ (define-public python-hdlmake (sha256 (base32 "13d0zvpch0k758r2c2vq3vhd9nbydy01jnv2ddfvb6d3xpb4wzrj")))) (build-system pyproject-build-system) - (arguments - `(#:tests? #f)) - (native-inputs (list python-setuptools python-wheel)) + (arguments (list #:phases #~(modify-phases %standard-phases + (add-before 'check 'chdir + (lambda _ + (chdir "testsuite")))))) + (native-inputs (list python-pytest python-setuptools python-wheel)) (propagated-inputs (list python-six)) (home-page "https://gitlab.com/ohwr/project/hdl-make/") (synopsis "Generate multi-purpose makefiles for HDL projects") [back] --8<---------------cut here---------------end--------------->8--- -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 09:17:16 2025 Received: (at 78316-done) by debbugs.gnu.org; 12 May 2025 13:17:16 +0000 Received: from localhost ([127.0.0.1]:51446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uET1v-0004M0-La for submit@debbugs.gnu.org; Mon, 12 May 2025 09:17:15 -0400 Received: from devianza.investici.org ([2c0f:f930:0:4::108]:36713) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uET1s-0004Ll-IN for 78316-done@debbugs.gnu.org; Mon, 12 May 2025 09:17:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1747055830; bh=r1azZ3fkNNCdm9rSaSW/lCMMIHDXU6uW/0XvdfjfYYk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=s1X/W5Jf0IfF+GtFkCax8VraVO0PdeAhGpkSKuTE7S3CUlKve8lCo6Cu8WdNaIONg Q9HSgB4TaCQb8d34VWBBSdPOy7pz0VUdL+1t8OWiIHfjRw265act0RI4Eymf/5IPOu gnwDDxKrMcDfDe1ojIkFMMA3/uylMU1ZIpS6vD98= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Zx0WV344bz6xfW; Mon, 12 May 2025 13:17:10 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Zx0WV0nZCz6xfF; Mon, 12 May 2025 13:17:10 +0000 (UTC) From: Cayetano Santos To: Maxim Cournoyer Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. In-Reply-To: <874ixqoush.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 12 May 2025 21:52:46 +0900") References: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> <874ixqoush.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Mon, 12 May 2025 15:17:08 +0200 Message-ID: <87cyce55pn.fsf@inventati.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78316-done Cc: Gabriel Wicki , Ekaitz Zarraga , 78316-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >lun. 12 mai 2025 at 21:52, Maxim Cournoyer wro= te: >> (define-public python-hdlmake >> - (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54") >> + (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621") >> (revision "0")) >> (package >> (name "python-hdlmake") >> - (version (git-version "3.3" revision commit)) >> + (version (git-version "3.4dev1" revision commit)) > > The version here is not correct, according to (info "(guix) Version > Numbers"). The version string of a git snapshot should be based on the > latest upstream version, which is still 3.3. Since we're not bumping > the version the revision number needs to go up by one. Once built and installed, =E2=80=98hdlmake --version=E2=80=99 returns "3.4d= ev1" as for "hdlmake/_version.py", which is weird when one installs 3.3. C. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaCH01BccY3NhbnRvc2JA aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mglAwAP4zLmb5/9myQjPOKGBqQx25KqsA 4DnTAh1aBR2xq4+rkAD+NIbAPJeslG6oNR2P0AlXurZk+dKbDS8L5k+Iv6PY1g8= =33TA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 21:24:55 2025 Received: (at 78316-done) by debbugs.gnu.org; 13 May 2025 01:24:55 +0000 Received: from localhost ([127.0.0.1]:56127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uEeO6-0006bF-TR for submit@debbugs.gnu.org; Mon, 12 May 2025 21:24:55 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:43008) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uEeO3-0006ay-C8 for 78316-done@debbugs.gnu.org; Mon, 12 May 2025 21:24:53 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-b200047a6a5so3864552a12.0 for <78316-done@debbugs.gnu.org>; Mon, 12 May 2025 18:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747099485; x=1747704285; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zzPFUcNYKhJ5N31yR/iJILpTljsQlYD717syW+OI268=; b=RKrOUDqJXQNzmmD8l4IBdLv/s0lGYqV9D8Tpw7BG/stXM6QjM+lqXnL3ZeHzVeUYtH gClnlQ/bCQQXyiFX4LAW+ZHEcsa4dt7zGYRCB/DmK06NHBLP+ENZLJlj2SQ+vYjELUe0 NH+W9XSW0/mseGww2gRf++eYF6gUADBvydDsIfn/CJPOwH+cK2I9SF2mE49WbMqC+SPJ 6QBXWTwtFROFZrx2ONcUyBqV9evXq8ZsL5c9gBA3nXmO6DJT9mwiv/pu6pPaDwDI6lim MgL6D9lsUS3lLSee7AJE1m1vvd/EcYwExb11n8SxYYFCQXXc9blyXRp5cov2sUWZ7qmH DXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747099485; x=1747704285; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zzPFUcNYKhJ5N31yR/iJILpTljsQlYD717syW+OI268=; b=Czo0EpX4auQCmzOmRPqXbltk2XRx3m8Pdel2Gn83qMW8UdZAnHB6KyBfngIXW7ezi8 J8lufqvBQ+/Fx8DrQUbN6VR2sMAI/L6tZnyDFRd0KaqsHH6HdkopxIKUYYfyEMW666zx 6CtlraPhElc2QiogHKVeGgv1JDGeIklAphKnSyI+mSQrIwlOpyHcx7odfd4jjgUkn3dd wZ9cN3HyAp3uDhjl6L5CeutuL9DLj9ys6wx+3UIqmKPDQYw8PTtaD758C0oZ7nu3Tt8r 1gJL4/Ben25y4kFkP/79LGRaPizr/See7/5TC69QWSERbjeckBc8pHnkgxv0qWQY4Vl9 iEGQ== X-Gm-Message-State: AOJu0YyrC1SuAo+fndyNdBAzFgj5Ok0v2l8Fp1pqMIbHpsiul4SRkatd 8Kq3wl7XwzNtg7ab/8z2r/fG467yX450drG9McOTjCYu1nWtn2jF X-Gm-Gg: ASbGncsxDHrUVLE+AE5elvxD7HPjcXAHBDLA1JMadln5DNT37xabSh1WXf+t38lHnek 0r47dhYNNpYKs5LbTfCd3RBLQioOSjCT7ICHECCsq18sPfmZ9NYld1S30ncuwTbXUEs9HS9Ql1a A/zww3d9rb3bqOljkjXWX8JHZbrawXqsl1obXil/PBYcLwH/rmKThVSxiO/v85YNyBmIJnhIVMZ 4W10I9H5FNmIZxfjOPFbOFAVWg1eLJZDwzD2vHb8VSCCLU4QxO42Rewqt17MxcjuE/VKTvTzHV9 m1yTej4XcOm/Eca9pPlUP3ot1j9KJOILxKOWkSaftx9O++l5Cw== X-Google-Smtp-Source: AGHT+IFsFGW8RqZ+tW6oIzxUhXqWbY7aW4tTX7TR2mnz2nxCd3HoXT0XquSJxTDETbG8IkSU6EAbSA== X-Received: by 2002:a17:903:228e:b0:215:b1e3:c051 with SMTP id d9443c01a7336-2317cb041eemr21737465ad.11.1747099484889; Mon, 12 May 2025 18:24:44 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc8271ad5sm69457425ad.137.2025.05.12.18.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 18:24:44 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e. In-Reply-To: <87cyce55pn.fsf@inventati.org> (Cayetano Santos's message of "Mon, 12 May 2025 15:17:08 +0200") References: <4f7ed71fab3045a19ff031ebfc293ac1aee052a2.1746708572.git.csantosb@inventati.org> <874ixqoush.fsf@gmail.com> <87cyce55pn.fsf@inventati.org> Date: Tue, 13 May 2025 10:24:41 +0900 Message-ID: <871pstnvza.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78316-done Cc: Gabriel Wicki , Ekaitz Zarraga , 78316-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Cayetano, Cayetano Santos writes: >>lun. 12 mai 2025 at 21:52, Maxim Cournoyer wr= ote: > >>> (define-public python-hdlmake >>> - (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54") >>> + (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621") >>> (revision "0")) >>> (package >>> (name "python-hdlmake") >>> - (version (git-version "3.3" revision commit)) >>> + (version (git-version "3.4dev1" revision commit)) >> >> The version here is not correct, according to (info "(guix) Version >> Numbers"). The version string of a git snapshot should be based on the >> latest upstream version, which is still 3.3. Since we're not bumping >> the version the revision number needs to go up by one. > > Once built and installed, =E2=80=98hdlmake --version=E2=80=99 returns "3.= 4dev1" as for > "hdlmake/_version.py", which is weird when one installs 3.3. I see. We could always use 3.4dev1 and add a comment telling the next person updating it where it comes from, e.g. ;; The git snapshot base version is taken from the 'hdlmake/_version.py' ;; source. It's a small thing though. I personally wouldn't bother. --=20 Thanks, Maxim From unknown Fri Jun 20 07:26:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 Jun 2025 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator