Subject: Re: bug#78316: [PATCH electronics-team] gnu: python-hdlmake: Update to 3.4dev1-0.9338e3e.

From: Maxim Cournoyer <[email-masked]>
Date: Tue, 13 May 2025 10:24:41 +0900

Hi Cayetano,

Cayetano Santos <[email-masked]> writes:

>>lun. 12 mai 2025 at 21:52, Maxim Cournoyer <[email-masked]> wrote:
>
>>>  (define-public python-hdlmake
>>> -  (let ((commit "3cb248fdad601c579b59fd7c194402871209bc54")
>>> +  (let ((commit "9338e3e7a8784e63d16496a3fa8234d9e5aa7621")
>>>          (revision "0"))
>>>      (package
>>>        (name "python-hdlmake")
>>> -      (version (git-version "3.3" revision commit))
>>> +      (version (git-version "3.4dev1" revision commit))
>>
>> The version here is not correct, according to (info "(guix) Version
>> Numbers").  The version string of a git snapshot should be based on the
>> latest upstream version, which is still 3.3.  Since we're not bumping
>> the version the revision number needs to go up by one.
>
> Once built and installed, ‘hdlmake --version’ returns "3.4dev1" as for
> "hdlmake/_version.py", which is weird when one installs 3.3.

I see.  We could always use 3.4dev1 and add a comment telling the next
person updating it where it comes from, e.g.

;; The git snapshot base version is taken from the 'hdlmake/_version.py'
;; source.

It's a small thing though.  I personally wouldn't bother.

-- 
Thanks,
Maxim