GNU bug report logs - #78315
[PATCH emacs-team 00/53] More fixes, and a lot of style improvements.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 78315 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [bug#78315] [PATCH 20/53] gnu: emacs-fish-completion: Improve style.
Date: Thu,  8 May 2025 14:50:22 +0200

* gnu/packages/emacs-xyz.scm (emacs-fish-completion):
  [arguments]<phases>: Improve 'configure phase style.
---
 gnu/packages/emacs-xyz.scm | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc272e4fe8..24cb9ecd3a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30301,20 +30301,16 @@ (define-public emacs-fish-completion
         (base32
          "17lqip1i1rrsvxzz4bx9rqf1fvwd3hriwg3sj6qxmfc8pylnp37q"))))
     (build-system emacs-build-system)
-    (inputs (list fish))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'configure
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((fish (assoc-ref inputs "fish")))
-               ;; Specify the absolute file names of the various
-               ;; programs so that everything works out-of-the-box.
-               (make-file-writable "fish-completion.el")
-               (emacs-substitute-variables
-                   "fish-completion.el"
-                 ("fish-completion-command"
-                  (string-append fish "/bin/fish")))))))))
+           (lambda* (#:key inputs #:allow-other-keys)
+             (make-file-writable "fish-completion.el")
+             (emacs-substitute-variables "fish-completion.el"
+               ("fish-completion-command"
+                (search-input-file inputs "bin/fish"))))))))
+    (inputs (list fish))
     (home-page
      "https://gitlab.com/Ambrevar/emacs-fish-completion")
     (synopsis "Fish completion for Emacs pcomplete")
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.