GNU bug report logs - #78315
[PATCH emacs-team 00/53] More fixes, and a lot of style improvements.

Previous Next

Full log

Message #167 received at 78315 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 78315 <at> debbugs.gnu.org
Subject: Re: [bug#78315] [PATCH 13/53] gnu: emacs-org-pandoc-import: Use
 search-input-file.
Date: Sat, 17 May 2025 09:09:36 -0700

Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-pandoc-import):
>   [arguments]<phases>: Improve 'patch-exec-paths phase.
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index a00f66a5bd..2cdc6ccc0e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -13000,10 +13000,10 @@ (define-public emacs-org-pandoc-import
>           (modify-phases %standard-phases
>             (add-after 'unpack 'patch-exec-paths
>               (lambda* (#:key inputs #:allow-other-keys)
> -               (let ((pandoc (assoc-ref inputs "pandoc")))
> -                 (substitute* "org-pandoc-import.el"
> -                   (("\"pandoc\"")
> -                    (string-append "\"" pandoc 
> "/bin/pandoc\"")))))))))
> +               (substitute* "org-pandoc-import.el"
> +                 (("\"pandoc\"")
> +                  (string-append
> +                   "\"" (search-input-file inputs "bin/pandoc") 
> "\""))))))))

I think this should use `emacs-substitute-variables' instead of 
`substitute*'.

 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.