GNU bug report logs - #78308
[PATCH 0/9] VTE integration support / Shell startup files refactor

Previous Next

Full log

Message #71 received at 78308 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Luis Guilherme Coelho" <lgcoelho <at> disroot.org>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, Rutherther <rutherther <at> ditigal.xyz>,
 78308 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#78308] [PATCH v2 2/9] services: Add
 etc-profile-d-service-type.
Date: Wed, 14 May 2025 22:26:28 +0900

Hi Luis,

"Luis Guilherme Coelho" <lgcoelho <at> disroot.org> writes:

>> +@example
>> +(service etc-profile-d-service-type
>> +         (list (plain-file "youppi.sh" HOW_IMPORTANT=very")))
>> +@end example
>> +@end defvar
> I'm not really doing a review or something, but thought it would be
> pertinent do say. There's a missing quote before HOW_IMPORTANT=very.

Thanks.  Maybe I'll get it right in v3.  I probably should have just
copied a snippet used in the system tests to ensure it's been tested and
works ;-).

I also forgot the news entry, which I'll tackle in v3 as well.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.