GNU bug report logs - #78303
31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78303: closed (31.0.50; Allow nil as valid value for
 url-cookie-save-interval per doc and type)
Date: Sat, 17 May 2025 08:29:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 17 May 2025 11:28:09 +0300
with message-id <86h61jwsiu.fsf <at> gnu.org>
and subject line Re: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type
has caused the debbugs.gnu.org bug report #78303,
regarding 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78303: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78303
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Allow nil as valid value for url-cookie-save-interval per
 doc and type
Date: Wed, 7 May 2025 22:59:47 +0200

[Message part 3 (text/plain, inline)]

X-Debbugs-Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>

[ CC to Stefan, who seems to be the original author of that cookie
  handling thingy ... apologies if that does not really concern you ]

Variable `url-cookie-save-interval' can be perfectly well configured to
nil, as one can see in function `url-cookie-setup-save-timer' (which
seems to be the only function referencing that variable):

  (defun url-cookie-setup-save-timer ()
    "Reset the cookie saver timer."
    (interactive)
    (ignore-errors (cancel-timer url-cookie-timer))
    (setq url-cookie-timer nil)
    (if url-cookie-save-interval
        (setq url-cookie-timer (run-at-time url-cookie-save-interval
                                            url-cookie-save-interval
                                            #'url-cookie-write-file))))

However, the docstring and the :type of the defcustom do not
document/allow for nil as a valid value.

The attached patch fixes that, please check.

Thanks!

[0001-Allow-nil-as-valid-value-for-url-cookie-save-interva.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 78303-done <at> debbugs.gnu.org, jschmidt4gnu <at> vodafonemail.de
Subject: Re: bug#78303: 31.0.50; Allow nil as valid value for
 url-cookie-save-interval per doc and type
Date: Sat, 17 May 2025 11:28:09 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>,  78303 <at> debbugs.gnu.org
> Date: Thu, 08 May 2025 09:28:49 -0400
> 
> >> [ CC to Stefan, who seems to be the original author of that cookie
> >>   handling thingy ... apologies if that does not really concern you ]
> 
> [ Hmm... Git indeed claims that I added this file back in 2003, but
>   I have no recollection of doing so.  Apparently that applies to all
>   the URL package, so I guess I was the one who added that package to
>   Emacs, tho I can't remember doing that either.
>   FWIW, that package started its life as part of the W3 browser and was
>   written mostly by W3's author, William Perry.
>   You can see that package's earlier history in the `externals/w3`
>   branch of the `elpa.git `repository where the files were named
>   `lisp/url-*.el`.  ]
> 
> > Thanks, my alternative suggestion is below.  Now Stefan gets to choose ;-)
> 
> I'll let you fight it out.  🙂

I've now installed on the master branch a version that merges both
suggestions, and I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.