From unknown Tue Jun 17 22:27:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 May 2025 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 78303@debbugs.gnu.org Cc: stefan monnier X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: stefan monnier Received: via spool by submit@debbugs.gnu.org id=B.174665162626158 (code B ref -1); Wed, 07 May 2025 21:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 May 2025 21:00:26 +0000 Received: from localhost ([127.0.0.1]:48609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uClsP-0006nq-EX for submit@debbugs.gnu.org; Wed, 07 May 2025 17:00:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37878) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uClsK-0006hg-W4 for submit@debbugs.gnu.org; Wed, 07 May 2025 17:00:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uClsF-0006Kd-1N for bug-gnu-emacs@gnu.org; Wed, 07 May 2025 17:00:15 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCls7-0004ey-Ld for bug-gnu-emacs@gnu.org; Wed, 07 May 2025 17:00:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1746651595; bh=b9eN3Vrm7yqqGULfoey/wvxWvAXiXuiAi79F5hTBMcA=; h=Content-Type:Message-ID:Date:User-Agent:From:Content-Language:To: Subject:From; b=gLXAxj1gt9ryC2TzJ+FeWMEQ2rIgsO7Lcc+thzjkzpKOWquZC11635fe4XUPrDTLJ NnO0JN3FJN3loOxHNKeHA0GiTSypmuxIMobZLRwfEp3Rp2N/9BQ8FhnW2DDYwa8vkG iwI+4wTn7WP1bvZjt9XL0YWNAlJ9/1Wscpx2WH5o= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Zt71l4jGgz2GTX for ; Wed, 7 May 2025 20:59:55 +0000 (UTC) Received: from [192.168.178.41] (port-92-199-212-225.dynamic.as20676.net [92.199.212.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Zt71g1hg8z8sXx for ; Wed, 7 May 2025 20:59:48 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------l1coUjF2zf1C82npKk4vAVnD" Message-ID: Date: Wed, 7 May 2025 22:59:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Schmidt Content-Language: de-DE-frami, en-US X-purgate-server: smtpa04 X-purgate-type: clean X-purgate: clean X-purgate-size: 3991 X-purgate-ID: 155817::1746651591-9E4C0D3F-D2DAD9F3/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------l1coUjF2zf1C82npKk4vAVnD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Debbugs-Cc: Stefan Monnier [ CC to Stefan, who seems to be the original author of that cookie handling thingy ... apologies if that does not really concern you ] Variable `url-cookie-save-interval' can be perfectly well configured to nil, as one can see in function `url-cookie-setup-save-timer' (which seems to be the only function referencing that variable): (defun url-cookie-setup-save-timer () "Reset the cookie saver timer." (interactive) (ignore-errors (cancel-timer url-cookie-timer)) (setq url-cookie-timer nil) (if url-cookie-save-interval (setq url-cookie-timer (run-at-time url-cookie-save-interval url-cookie-save-interval #'url-cookie-write-file)))) However, the docstring and the :type of the defcustom do not document/allow for nil as a valid value. The attached patch fixes that, please check. Thanks! --------------l1coUjF2zf1C82npKk4vAVnD Content-Type: text/x-patch; charset=UTF-8; name="0001-Allow-nil-as-valid-value-for-url-cookie-save-interva.patch" Content-Disposition: attachment; filename*0="0001-Allow-nil-as-valid-value-for-url-cookie-save-interva.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMjZlMGY4ZmNmNWE4ODYwNzljNGYyZjZlYjc0MDMwMzQ5YjQxYWExIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFdlZCwgNyBNYXkgMjAyNSAyMjo0ODo0NSArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIEFsbG93IG5pbCBhcyB2YWxpZCB2YWx1ZSBmb3IgYHVybC1jb29raWUt c2F2ZS1pbnRlcnZhbCcKCiogbGlzcC91cmwvdXJsLWNvb2tpZS5lbCAodXJsLWNvb2tpZS1z YXZlLWludGVydmFsKTogQWxsb3cgbmlsIGFzIHZhbGlkCnZhbHVlIGZvciBgdXJsLWNvb2tp ZS1zYXZlLWludGVydmFsJzogTWVudGlvbiB0aGF0IHZhbHVlIGluIHRoZQpkb2NzdHJpbmcg YW5kIGNoYW5nZSB0aGUgY3VzdG9tIHR5cGUgYWNjb3JkaW5nbHkuICAoQnVnI1hYWFhYKQot LS0KIGxpc3AvdXJsL3VybC1jb29raWUuZWwgfCAxMyArKysrKysrKy0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvdXJsL3VybC1jb29raWUuZWwgYi9saXNwL3VybC91cmwtY29va2llLmVsCmluZGV4 IGJiNzM2NGVmMDZlLi4zMDkyYzVhN2Q3OSAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWNv b2tpZS5lbAorKysgYi9saXNwL3VybC91cmwtY29va2llLmVsCkBAIC0zNDksMTUgKzM0OSwx OCBAQCB1cmwtY29va2llLWhhbmRsZS1zZXQtY29va2llCiAoZGVmdmFyIHVybC1jb29raWUt dGltZXIgbmlsKQogCiAoZGVmY3VzdG9tIHVybC1jb29raWUtc2F2ZS1pbnRlcnZhbCAzNjAw Ci0gICJUaGUgbnVtYmVyIG9mIHNlY29uZHMgYmV0d2VlbiBhdXRvbWF0aWMgc2F2ZXMgb2Yg Y29va2llcy4KLURlZmF1bHQgaXMgMSBob3VyLiAgTm90ZSB0aGF0IGlmIHlvdSBjaGFuZ2Ug dGhpcyB2YXJpYWJsZSBvdXRzaWRlIG9mCi10aGUgYGN1c3RvbWl6ZScgaW50ZXJmYWNlIGFm dGVyIGB1cmwtZG8tc2V0dXAnIGhhcyBiZWVuIHJ1biwgeW91IG5lZWQKLXRvIHJ1biB0aGUg YHVybC1jb29raWUtc2V0dXAtc2F2ZS10aW1lcicgZnVuY3Rpb24gbWFudWFsbHkuIgorICAi SWYgbm9uLW5pbCwgdGhlIG51bWJlciBvZiBzZWNvbmRzIGJldHdlZW4gYXV0b21hdGljIHNh dmVzIG9mIGNvb2tpZXMuCitJZiBuaWwsIGRvbid0IGF1dG9tYXRpY2FsbHkgc2F2ZSBjb29r aWVzLgorRGVmYXVsdCBzYXZlIGludGVydmFsIGlzIDEgaG91ci4KK05vdGUgdGhhdCBpZiB5 b3UgY2hhbmdlIHRoaXMgdmFyaWFibGUgb3V0c2lkZSBvZiB0aGUgYGN1c3RvbWl6ZScgaW50 ZXJmYWNlCithZnRlciBgdXJsLWRvLXNldHVwJyBoYXMgYmVlbiBydW4sIHlvdSBuZWVkIHRv IHJ1biB0aGUKK2B1cmwtY29va2llLXNldHVwLXNhdmUtdGltZXInIGZ1bmN0aW9uIG1hbnVh bGx5LiIKICAgOnNldCAobGFtYmRhICh2YXIgdmFsKQogICAgICAgICAgKHNldC1kZWZhdWx0 IHZhciB2YWwpCiAgICAgICAgICAoaWYgKGJvdW5kLWFuZC10cnVlLXAgdXJsLXNldHVwLWRv bmUpCiAgICAgICAgICAgICAgKHVybC1jb29raWUtc2V0dXAtc2F2ZS10aW1lcikpKQotICA6 dHlwZSAnbmF0bnVtKQorICA6dHlwZSAnKGNob2ljZSAobmF0bnVtIDp0YWcgIk51bWJlciBv ZiBzZWNvbmRzIikKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIkRvbid0IGF1dG9t YXRpY2FsbHkgc2F2ZSBjb29raWVzIiBuaWwpKSkKIAogKGRlZnVuIHVybC1jb29raWUtc2V0 dXAtc2F2ZS10aW1lciAoKQogICAiUmVzZXQgdGhlIGNvb2tpZSBzYXZlciB0aW1lci4iCi0t IAoyLjM5LjUKCg== --------------l1coUjF2zf1C82npKk4vAVnD-- From unknown Tue Jun 17 22:27:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 May 2025 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jens Schmidt Cc: 78303@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 78303-submit@debbugs.gnu.org id=B78303.174669726014685 (code B ref 78303); Thu, 08 May 2025 09:41:01 +0000 Received: (at 78303) by debbugs.gnu.org; 8 May 2025 09:41:00 +0000 Received: from localhost ([127.0.0.1]:54263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uCxkS-0003on-ES for submit@debbugs.gnu.org; Thu, 08 May 2025 05:41:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39036) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uCxkP-0003oK-Cy for 78303@debbugs.gnu.org; Thu, 08 May 2025 05:40:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCxkJ-0008RP-2b; Thu, 08 May 2025 05:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ge8B+4IG/X4ILN8/0odveUvaYaKArDxF13KMzHSZwqc=; b=hUh/QI9IZ2no TAnzPqRH8xRcuYUbdkg38WI2OtvOtDgeRCtj9x7T5P7IoBr0ikuRwiqUdP1uRMuZtu6JFfWctAqGL uoAnrXk4WYFZhszu1i18Qz1RV5VHueKvMprB3fyeUnf9j0sAfBX/okRF3RAirKHWsswLHP+NoBTzU 77Xz6H2rsCgEOUAEYXhAxKjfRLYZc64HlqBUOhyRNWCeaA5XaHjhLswDMA7CbxY7HLvOYVuWTIxyo T2OA8IgzFpCFVqW26bpxqIh9Ld0iVFQAgCASFs2FNt86fv73udFXkyP3eSTCQGb/sRT8p6fSxvOsU ZfgKRbFOAFHax9Qurq+O9w==; Date: Thu, 08 May 2025 12:40:48 +0300 Message-Id: <86msbne8yn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: stefan monnier > Date: Wed, 7 May 2025 22:59:47 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > [ CC to Stefan, who seems to be the original author of that cookie > handling thingy ... apologies if that does not really concern you ] > > Variable `url-cookie-save-interval' can be perfectly well configured to > nil, as one can see in function `url-cookie-setup-save-timer' (which > seems to be the only function referencing that variable): > > (defun url-cookie-setup-save-timer () > "Reset the cookie saver timer." > (interactive) > (ignore-errors (cancel-timer url-cookie-timer)) > (setq url-cookie-timer nil) > (if url-cookie-save-interval > (setq url-cookie-timer (run-at-time url-cookie-save-interval > url-cookie-save-interval > #'url-cookie-write-file)))) > > However, the docstring and the :type of the defcustom do not > document/allow for nil as a valid value. > > The attached patch fixes that, please check. Thanks, my alternative suggestion is below. Now Stefan gets to choose ;-) diff --git a/lisp/url/url-cookie.el b/lisp/url/url-cookie.el index bb7364e..7ec90fd 100644 --- a/lisp/url/url-cookie.el +++ b/lisp/url/url-cookie.el @@ -350,21 +350,23 @@ url-cookie-timer (defcustom url-cookie-save-interval 3600 "The number of seconds between automatic saves of cookies. -Default is 1 hour. Note that if you change this variable outside of +Default is 1 hour; set to nil to disable automatic saving. +Note that if you change this variable outside of the `customize' interface after `url-do-setup' has been run, you need to run the `url-cookie-setup-save-timer' function manually." :set (lambda (var val) (set-default var val) (if (bound-and-true-p url-setup-done) (url-cookie-setup-save-timer))) - :type 'natnum) + :type '(choice (const :tag "Disable automatic saving" :value nil) + (natnum :tag "Auto-save interval in seconds"))) (defun url-cookie-setup-save-timer () "Reset the cookie saver timer." (interactive) (ignore-errors (cancel-timer url-cookie-timer)) (setq url-cookie-timer nil) - (if url-cookie-save-interval + (if (natnump url-cookie-save-interval) (setq url-cookie-timer (run-at-time url-cookie-save-interval url-cookie-save-interval #'url-cookie-write-file)))) From unknown Tue Jun 17 22:27:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 May 2025 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 78303@debbugs.gnu.org, Jens Schmidt Received: via spool by 78303-submit@debbugs.gnu.org id=B78303.174671094015753 (code B ref 78303); Thu, 08 May 2025 13:29:02 +0000 Received: (at 78303) by debbugs.gnu.org; 8 May 2025 13:29:00 +0000 Received: from localhost ([127.0.0.1]:55826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uD1J5-00045z-P5 for submit@debbugs.gnu.org; Thu, 08 May 2025 09:29:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63389) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uD1J2-00045f-SC for 78303@debbugs.gnu.org; Thu, 08 May 2025 09:28:57 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 83EEC1002EC; Thu, 8 May 2025 09:28:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1746710930; bh=JkhbSE/ald7iBtPQCx8elsWeLOCmkLA3AcOfgSx+Azg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NBWSjEP1ZVXtpClb1kJdJPkPGO7ELCWBiSgzRuk9Tvl2dpnjPo1D4v4fsk+kOtJRj wP9WY2DMPND9PruQQF9Wh3mDBS6roi9ZsSE/lat9q75M+SvR2szzWUfVund5z6d53f IjDsJzMDGxMogRToGu+AETlyJRxjZGpkgL3umQSYu8P9MJWp3BWwTYxV69gy1L0Izj FTQo2JjCUtMwNn7WHvKP3Q4y3Bu1Enlglma27FhHwicKvwuhI9dAUbaIkAJOP1/cSy gjMTrRMXuWsm5YEgfveBXe0X+Zhx8X1YIy3NOsGe+ZdFUnArrooyRcp15TF0PoUgFB J1jU9dn0Sr6Kg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8820F100034; Thu, 8 May 2025 09:28:50 -0400 (EDT) Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5AF5412045A; Thu, 8 May 2025 09:28:50 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86msbne8yn.fsf@gnu.org> Message-ID: References: <86msbne8yn.fsf@gnu.org> Date: Thu, 08 May 2025 09:28:49 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.219 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> [ CC to Stefan, who seems to be the original author of that cookie >> handling thingy ... apologies if that does not really concern you ] [ Hmm... Git indeed claims that I added this file back in 2003, but I have no recollection of doing so. Apparently that applies to all the URL package, so I guess I was the one who added that package to Emacs, tho I can't remember doing that either. FWIW, that package started its life as part of the W3 browser and was written mostly by W3's author, William Perry. You can see that package's earlier history in the `externals/w3` branch of the `elpa.git `repository where the files were named `lisp/url-*.el`. ] > Thanks, my alternative suggestion is below. Now Stefan gets to choose ;-) I'll let you fight it out. =F0=9F=99=82 Stefan From unknown Tue Jun 17 22:27:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 May 2025 17:51:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Eli Zaretskii Cc: 78303@debbugs.gnu.org Received: via spool by 78303-submit@debbugs.gnu.org id=B78303.174672664429470 (code B ref 78303); Thu, 08 May 2025 17:51:04 +0000 Received: (at 78303) by debbugs.gnu.org; 8 May 2025 17:50:44 +0000 Received: from localhost ([127.0.0.1]:59724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uD5OO-0007fG-IK for submit@debbugs.gnu.org; Thu, 08 May 2025 13:50:44 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:44078) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uD5OM-0007eh-MM for 78303@debbugs.gnu.org; Thu, 08 May 2025 13:50:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1746726636; bh=A7Bc5UHuSBWx+4mdhUoNG2vbNXWrDKb+RtezlIkwSUw=; h=Message-ID:Date:User-Agent:Subject:To:References:From: Content-Language:In-Reply-To:Content-Type:From; b=hD3xJ855cueOJyGLI8iQKDpSNHUbkTZw4JRElWx3i4C7fngdDz1DpGCFAVgHkShzZ DQ18xt8xmmvQwIDoZfrO0MXQIjfEigBLWB3r1bzrXolTtkJCEn6KoXbVK0qbG9JvDV LnWfLDglhEiy4m8S6iDwBCMqiLQyH/kPVfWDPCCg= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4Ztfmr6l1Xz1y0r; Thu, 8 May 2025 17:50:36 +0000 (UTC) Received: from [192.168.178.41] (port-83-236-2-65.dynamic.as20676.net [83.236.2.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Ztfmf3By6z8sXM; Thu, 8 May 2025 17:50:23 +0000 (UTC) Message-ID: <07d54dfe-28c1-41dd-b564-df20f76595bb@vodafonemail.de> Date: Thu, 8 May 2025 19:50:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <86msbne8yn.fsf@gnu.org> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-server: smtpa08 X-purgate-type: clean X-purgate: clean X-purgate-size: 299 X-purgate-ID: 155817::1746726632-B5C8F355-01B333F0/0/0 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2025-05-08 15:28, Stefan Monnier wrote: >> Thanks, my alternative suggestion is below. Now Stefan gets to choose ;-) > > I'll let you fight it out. 🙂 Never mess with Eli when it comes to documentation or UI. I quit. Read as: Please install your alternative, Eli. Thanks. From unknown Tue Jun 17 22:27:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jens Schmidt Subject: bug#78303: closed (Re: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type) Message-ID: References: <86h61jwsiu.fsf@gnu.org> X-Gnu-PR-Message: they-closed 78303 X-Gnu-PR-Package: emacs Reply-To: 78303@debbugs.gnu.org Date: Sat, 17 May 2025 08:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1747470542-32358-1" This is a multi-part message in MIME format... ------------=_1747470542-32358-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per = doc and type which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78303@debbugs.gnu.org. --=20 78303: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78303 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1747470542-32358-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78303-done) by debbugs.gnu.org; 17 May 2025 08:28:21 +0000 Received: from localhost ([127.0.0.1]:45366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGCu4-0008Ok-Hy for submit@debbugs.gnu.org; Sat, 17 May 2025 04:28:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52656) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGCu2-0008OT-Cl for 78303-done@debbugs.gnu.org; Sat, 17 May 2025 04:28:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGCtw-0002xZ-QL; Sat, 17 May 2025 04:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ql6ETQUn9SC3YhDk6kA+rANIMmKh6bc6LhTnWi0vnQg=; b=YmkoJls3hSAoq8hGLij0 7b4TuC+Kpglwl7CZEDWJV0sGch22gwiTimJI/RTTAH4mBgheTXP08w8XHYRtmDTM45ccYF/bp8BUl 6Xm79pu+VDL02TzKLry+bSwhSiAarevYlK7hQCnXXOEVBvnGpa7e/qNUm18RA+cp0uqo3xoWnDs6W qMDnbi8F+v0V/TLkNG95tIoSeEF0kgftjZuJ9hq+eWgd53wHRYDlfrhYaT4e4TNMFfOedTZMMgl+S 3UiDKBP+8bNEUv8Bp0DvIkc3WZJJ07ClQHpZy1193aRm2Q/9NmTagJ49y5RKb4IaAEMQcLJKYicGW wWkmuomeOYQ54w==; Date: Sat, 17 May 2025 11:28:09 +0300 Message-Id: <86h61jwsiu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 08 May 2025 09:28:49 -0400) Subject: Re: bug#78303: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type References: <86msbne8yn.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78303-done Cc: 78303-done@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Jens Schmidt , 78303@debbugs.gnu.org > Date: Thu, 08 May 2025 09:28:49 -0400 > > >> [ CC to Stefan, who seems to be the original author of that cookie > >> handling thingy ... apologies if that does not really concern you ] > > [ Hmm... Git indeed claims that I added this file back in 2003, but > I have no recollection of doing so. Apparently that applies to all > the URL package, so I guess I was the one who added that package to > Emacs, tho I can't remember doing that either. > FWIW, that package started its life as part of the W3 browser and was > written mostly by W3's author, William Perry. > You can see that package's earlier history in the `externals/w3` > branch of the `elpa.git `repository where the files were named > `lisp/url-*.el`. ] > > > Thanks, my alternative suggestion is below. Now Stefan gets to choose ;-) > > I'll let you fight it out. 🙂 I've now installed on the master branch a version that merges both suggestions, and I'm therefore closing this bug. ------------=_1747470542-32358-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 May 2025 21:00:26 +0000 Received: from localhost ([127.0.0.1]:48609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uClsP-0006nq-EX for submit@debbugs.gnu.org; Wed, 07 May 2025 17:00:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37878) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uClsK-0006hg-W4 for submit@debbugs.gnu.org; Wed, 07 May 2025 17:00:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uClsF-0006Kd-1N for bug-gnu-emacs@gnu.org; Wed, 07 May 2025 17:00:15 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCls7-0004ey-Ld for bug-gnu-emacs@gnu.org; Wed, 07 May 2025 17:00:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1746651595; bh=b9eN3Vrm7yqqGULfoey/wvxWvAXiXuiAi79F5hTBMcA=; h=Content-Type:Message-ID:Date:User-Agent:From:Content-Language:To: Subject:From; b=gLXAxj1gt9ryC2TzJ+FeWMEQ2rIgsO7Lcc+thzjkzpKOWquZC11635fe4XUPrDTLJ NnO0JN3FJN3loOxHNKeHA0GiTSypmuxIMobZLRwfEp3Rp2N/9BQ8FhnW2DDYwa8vkG iwI+4wTn7WP1bvZjt9XL0YWNAlJ9/1Wscpx2WH5o= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Zt71l4jGgz2GTX for ; Wed, 7 May 2025 20:59:55 +0000 (UTC) Received: from [192.168.178.41] (port-92-199-212-225.dynamic.as20676.net [92.199.212.225]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Zt71g1hg8z8sXx for ; Wed, 7 May 2025 20:59:48 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------l1coUjF2zf1C82npKk4vAVnD" Message-ID: Date: Wed, 7 May 2025 22:59:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Schmidt Content-Language: de-DE-frami, en-US To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Allow nil as valid value for url-cookie-save-interval per doc and type X-purgate-server: smtpa04 X-purgate-type: clean X-purgate: clean X-purgate-size: 3991 X-purgate-ID: 155817::1746651591-9E4C0D3F-D2DAD9F3/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------l1coUjF2zf1C82npKk4vAVnD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Debbugs-Cc: Stefan Monnier [ CC to Stefan, who seems to be the original author of that cookie handling thingy ... apologies if that does not really concern you ] Variable `url-cookie-save-interval' can be perfectly well configured to nil, as one can see in function `url-cookie-setup-save-timer' (which seems to be the only function referencing that variable): (defun url-cookie-setup-save-timer () "Reset the cookie saver timer." (interactive) (ignore-errors (cancel-timer url-cookie-timer)) (setq url-cookie-timer nil) (if url-cookie-save-interval (setq url-cookie-timer (run-at-time url-cookie-save-interval url-cookie-save-interval #'url-cookie-write-file)))) However, the docstring and the :type of the defcustom do not document/allow for nil as a valid value. The attached patch fixes that, please check. Thanks! --------------l1coUjF2zf1C82npKk4vAVnD Content-Type: text/x-patch; charset=UTF-8; name="0001-Allow-nil-as-valid-value-for-url-cookie-save-interva.patch" Content-Disposition: attachment; filename*0="0001-Allow-nil-as-valid-value-for-url-cookie-save-interva.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMjZlMGY4ZmNmNWE4ODYwNzljNGYyZjZlYjc0MDMwMzQ5YjQxYWExIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFdlZCwgNyBNYXkgMjAyNSAyMjo0ODo0NSArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIEFsbG93IG5pbCBhcyB2YWxpZCB2YWx1ZSBmb3IgYHVybC1jb29raWUt c2F2ZS1pbnRlcnZhbCcKCiogbGlzcC91cmwvdXJsLWNvb2tpZS5lbCAodXJsLWNvb2tpZS1z YXZlLWludGVydmFsKTogQWxsb3cgbmlsIGFzIHZhbGlkCnZhbHVlIGZvciBgdXJsLWNvb2tp ZS1zYXZlLWludGVydmFsJzogTWVudGlvbiB0aGF0IHZhbHVlIGluIHRoZQpkb2NzdHJpbmcg YW5kIGNoYW5nZSB0aGUgY3VzdG9tIHR5cGUgYWNjb3JkaW5nbHkuICAoQnVnI1hYWFhYKQot LS0KIGxpc3AvdXJsL3VybC1jb29raWUuZWwgfCAxMyArKysrKysrKy0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvdXJsL3VybC1jb29raWUuZWwgYi9saXNwL3VybC91cmwtY29va2llLmVsCmluZGV4 IGJiNzM2NGVmMDZlLi4zMDkyYzVhN2Q3OSAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWNv b2tpZS5lbAorKysgYi9saXNwL3VybC91cmwtY29va2llLmVsCkBAIC0zNDksMTUgKzM0OSwx OCBAQCB1cmwtY29va2llLWhhbmRsZS1zZXQtY29va2llCiAoZGVmdmFyIHVybC1jb29raWUt dGltZXIgbmlsKQogCiAoZGVmY3VzdG9tIHVybC1jb29raWUtc2F2ZS1pbnRlcnZhbCAzNjAw Ci0gICJUaGUgbnVtYmVyIG9mIHNlY29uZHMgYmV0d2VlbiBhdXRvbWF0aWMgc2F2ZXMgb2Yg Y29va2llcy4KLURlZmF1bHQgaXMgMSBob3VyLiAgTm90ZSB0aGF0IGlmIHlvdSBjaGFuZ2Ug dGhpcyB2YXJpYWJsZSBvdXRzaWRlIG9mCi10aGUgYGN1c3RvbWl6ZScgaW50ZXJmYWNlIGFm dGVyIGB1cmwtZG8tc2V0dXAnIGhhcyBiZWVuIHJ1biwgeW91IG5lZWQKLXRvIHJ1biB0aGUg YHVybC1jb29raWUtc2V0dXAtc2F2ZS10aW1lcicgZnVuY3Rpb24gbWFudWFsbHkuIgorICAi SWYgbm9uLW5pbCwgdGhlIG51bWJlciBvZiBzZWNvbmRzIGJldHdlZW4gYXV0b21hdGljIHNh dmVzIG9mIGNvb2tpZXMuCitJZiBuaWwsIGRvbid0IGF1dG9tYXRpY2FsbHkgc2F2ZSBjb29r aWVzLgorRGVmYXVsdCBzYXZlIGludGVydmFsIGlzIDEgaG91ci4KK05vdGUgdGhhdCBpZiB5 b3UgY2hhbmdlIHRoaXMgdmFyaWFibGUgb3V0c2lkZSBvZiB0aGUgYGN1c3RvbWl6ZScgaW50 ZXJmYWNlCithZnRlciBgdXJsLWRvLXNldHVwJyBoYXMgYmVlbiBydW4sIHlvdSBuZWVkIHRv IHJ1biB0aGUKK2B1cmwtY29va2llLXNldHVwLXNhdmUtdGltZXInIGZ1bmN0aW9uIG1hbnVh bGx5LiIKICAgOnNldCAobGFtYmRhICh2YXIgdmFsKQogICAgICAgICAgKHNldC1kZWZhdWx0 IHZhciB2YWwpCiAgICAgICAgICAoaWYgKGJvdW5kLWFuZC10cnVlLXAgdXJsLXNldHVwLWRv bmUpCiAgICAgICAgICAgICAgKHVybC1jb29raWUtc2V0dXAtc2F2ZS10aW1lcikpKQotICA6 dHlwZSAnbmF0bnVtKQorICA6dHlwZSAnKGNob2ljZSAobmF0bnVtIDp0YWcgIk51bWJlciBv ZiBzZWNvbmRzIikKKyAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIkRvbid0IGF1dG9t YXRpY2FsbHkgc2F2ZSBjb29raWVzIiBuaWwpKSkKIAogKGRlZnVuIHVybC1jb29raWUtc2V0 dXAtc2F2ZS10aW1lciAoKQogICAiUmVzZXQgdGhlIGNvb2tpZSBzYXZlciB0aW1lci4iCi0t IAoyLjM5LjUKCg== --------------l1coUjF2zf1C82npKk4vAVnD-- ------------=_1747470542-32358-1--