GNU bug report logs - #78298
[PATCH] Scroll with mouse wheel in calendar

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>, Po Lu <luangruo <at> yahoo.com>
Cc: 78298 <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr, juri <at> linkov.net
Subject: bug#78298: [PATCH] Scroll with mouse wheel in calendar
Date: Tue, 03 Jun 2025 13:57:36 +0300

> From: Michael Heerdegen <michael_heerdegen <at> web.de>
> Cc: Manuel Giraud <manuel <at> ledu-giraud.fr>,  78298 <at> debbugs.gnu.org,
>   juri <at> linkov.net
> Date: Sun, 01 Jun 2025 03:22:48 +0200
> 
> Hello Eli, Manuel and Juri,
> 
> > > >>> Could this be put on master and this report closed?  If possible, I'd
> > > >>> like to deal with the issue highlighted by Juri in another bug report.
> > > >>
> > > >> I was waiting for Juri and others to say the patch is okay.  I didn't
> > > >> see their response yet.
> > > >
> > > > I don't know if the patch is ready to be installed
> > > > when it doesn't fix the problem reported by Michael.
> > > 
> > > I think that my last patch fixes this problem… but you're right we need
> > > a confirmation from Michael.
> >
> > Michael?
> 
> Thanks for the reminder.  Yes, my problem is fixed indeed, we can
> install the patch.
> 
> And I can reproduce the issue found by Juri.
> 
> AFAICT, this point positioning problem happens only because we don't
> (temporarily) select the window, we only make the buffer current.  When
> I change `calendar-scroll-left' to use `with-selected-window' this
> problem is gone.  It's the old window point vs. point in the buffer
> thing I guess.
> 
> In the commit history you find that the code once worked like that, then
> in 2023 had been changed to fix some other invocation case:
> 
> | b556c180f65 "Also fix calendar-scroll-left" (Po Lu <luangruo <at> yahoo.com> 2023-08-10)
> | * lisp/calendar/cal-move.el (calendar-scroll-left): Use
> | `calendar-event-buffer' instead of assuming that EVENT's
> | posn-window is always a window.
> 
> So I guess we should restore the old version but just check whether
> posn-window returns a live window, and only if not select the buffer
> directly.  But I did not yet look at what exactly had been broken before
> that had been changed.

Po Lu, any comments?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.